[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki updated this revision to Diff 372406. linjamaki added a comment. Add -verify and expected-no-diagnostics to a SPIR-V test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 Files:

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

haonanya created this revision. haonanya added reviewers: svenvh, Anastasia. haonanya added a project: clang. Herald added subscribers: ldrumm, yaxunl. haonanya requested review of this revision. Herald added a subscriber: cfe-commits. Add atomic_half types and builtins operating on the types

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei updated this revision to Diff 372400. pengfei added a comment. Allow MI operands of complex FMA to be commutable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109658/new/ https://reviews.llvm.org/D109658 Files:

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 372398. modimo added a comment. Add mayThrow flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.llvm.org/D36850 Files: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll

[clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

Author: David Blaikie Date: 2021-09-13T19:17:05-07:00 New Revision: 2bd84938470bf2e337801faafb8a67710f46429d URL: https://github.com/llvm/llvm-project/commit/2bd84938470bf2e337801faafb8a67710f46429d DIFF: https://github.com/llvm/llvm-project/commit/2bd84938470bf2e337801faafb8a67710f46429d.diff

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372383. waltl added a comment. Mark new option as NoDriverOption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, svenvh. I am ok with the patch. Thanks very much. I'd appreciate it if you help review https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/1116 as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

amyk added a comment. `builtins-ppc-p10vector.c` looks like it needs to be updated from the failing test case. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1373 vector signed int test_vec_vec_splati_ins_si(void) { + // CHECK-BE: [[T0:%.+]]] = and %{{.+}}, i32 1

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

phosek added a comment. In D109624#2998774 , @saghir wrote: > In D109624#2998665 , @thakis wrote: > >> In D109624#2998550 , @saghir wrote: >> >>> Hi, this change also

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

saghir added a comment. In D109624#2998665 , @thakis wrote: > In D109624#2998550 , @saghir wrote: > >> Hi, this change also breaks Power PC bots: >> >> 1. >>

[PATCH] D109681: [RISCV] add Half-precision test for vle/vse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f25d0046fc: [RISCV] add Half-precision test for vle/vse (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo

[clang] d4f25d0 - [RISCV] add Half-precision test for vle/vse

Author: Shao-Ce Sun Date: 2021-09-14T08:55:22+08:00 New Revision: d4f25d0046fc9d1a42d9974e75cfba14ff3d535e URL: https://github.com/llvm/llvm-project/commit/d4f25d0046fc9d1a42d9974e75cfba14ff3d535e DIFF: https://github.com/llvm/llvm-project/commit/d4f25d0046fc9d1a42d9974e75cfba14ff3d535e.diff

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. In D109703#2998350 , @krisb wrote: > In D109703#2998155 , @ellis wrote: > >> I've added this to the added test case. >> >> !18 = !DIImportedEntity(tag: DW_TAG_imported_declaration, scope:

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

LuoYuanke added a comment. It seems in this patch the builtins interface is aligned to intrinsics interface. Since AVX512FP16 is pretty new, I assume nobody is using the GCC builtin. Can we ask GCC guys change their builtin interface? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern added a comment. In D109557#2998213 , @HazardyKnusperkeks wrote: > With context he meant the diff context. > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Ah sorry about that. Done. In D109557#2998226

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern updated this revision to Diff 372364. csmulhern added a comment. Adds more context to the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D109714: Reduce maximum width of _ExtInt from 2^24-1 to 2^23 to workaround SelectionDAG issue.

craig.topper abandoned this revision. craig.topper added a comment. Abandoning in favor of D109721 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109714/new/ https://reviews.llvm.org/D109714

[PATCH] D109721: [IR] Reduce max supported integer from 2^24-1 to 2^23.

craig.topper updated this revision to Diff 372362. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109721/new/

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

amyk added a comment. A question I have is, I noticed there are some test case changes involving `xxspltidp` and `xxsplti32dx`, but are additional tests needed for `xxspltiw`? Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1887 // XXSPLI32DX needs extra flags to

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

MaskRay added a comment. I uploaded D109727 to clean up suse related `*Triples` elements in `CollectLibDirsAndTriples`. The long-term plan is to remove the `*Triples` variables entirely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

jyknight accepted this revision. jyknight added inline comments. Comment at: clang/include/clang/Driver/Options.td:2380 + NegFlag, + BothFlags<[CC1Option], " to avoid heapifying local blocks">>; Needs to be marked `[CC1Option, NoDriverOption]` Repository:

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2488 +addTrait(Property); + } } Nit: no braces. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2052 +/* CurrentFunctionDecl */ nullptr, +/*

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

thakis added a comment. In D109624#2998550 , @saghir wrote: > Hi, this change also breaks Power PC bots: > > 1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio > 2.

[clang] b7bac5a - [clang] Revert gcc-driver part of 648feabc65d8

Author: Nico Weber Date: 2021-09-13T19:04:29-04:00 New Revision: b7bac5a172e51ed065b3b4dc64cc2d8831e8081c URL: https://github.com/llvm/llvm-project/commit/b7bac5a172e51ed065b3b4dc64cc2d8831e8081c DIFF: https://github.com/llvm/llvm-project/commit/b7bac5a172e51ed065b3b4dc64cc2d8831e8081c.diff

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

thakis added a comment. In D109624#2998555 , @phosek wrote: > In D109624#2998419 , @thakis wrote: > >> Does it fail consistently? Or was it a one-time flake? > > It's been failing consistently. It might be

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

thakis added a comment. In D109624#2998550 , @saghir wrote: > Hi, this change also breaks Power PC bots: > > 1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio > 2.

[PATCH] D63497: Add support for openSUSE RISC-V triple

MaskRay added a comment. I created D109727 to clean up the `*Triples` variables. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63497/new/ https://reviews.llvm.org/D63497 ___

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

MaskRay created this revision. MaskRay added reviewers: asb, schwab, tstellar. Herald added subscribers: StephenFan, dexonsmith, luismarques, steven.zhang, s.egerton, PkmX, simoncook, hiraditya, kristof.beyls. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. > Btw, is the intent for this functionality to replace what's in > SarifDiagnostics.cpp > (https://github.com/llvm/llvm-project/blob/main/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp) > fairly immediately? Or are we going to carry both implementations? This

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

phosek added a comment. In D109624#2998419 , @thakis wrote: > Does it fail consistently? Or was it a one-time flake? It's been failing consistently. It might be related to our toolchain setting lld as the default linker:

Re: [clang] bdce8d4 - Revert "[X86] Adjust Keylocker handle mem size"

When reverting patches, please include the reason in the commit message. ~Craig On Mon, Sep 13, 2021 at 3:01 AM Xiang1 Zhang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Xiang1 Zhang > Date: 2021-09-13T18:00:46+08:00 > New Revision: bdce8d40c6da56f1c95a8d7bfeac12b1ffce79cf

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

saghir added a comment. Hi, this change also breaks Power PC bots: 1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio 2. https://lab.llvm.org/buildbot/#/builders/18/builds/2443/steps/23/logs/stdio It fails consistently on our bots. Can you please take a look?

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372347. cchen added a comment. Rebase and fix based on suggestions Haven't ConstructTrait to IRBuilder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files:

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:704 +C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) { + Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling(); + return; I think

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:737 + } + void eraseConstructTrait() { ConstructTraits.clear(); } + cchen wrote: > jdoerfert wrote: > > Modification was made to make it clear what happens but now I think this is > > not

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

thakis added a comment. Does it fail consistently? Or was it a one-time flake? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109624/new/ https://reviews.llvm.org/D109624 ___ cfe-commits mailing list

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. the modf test still doesn't work. The issue was from unbundle. case 1 works. clang++ -fopenmp -fopenmp-targets=nvptx64 modf.cpp -c clang++ -fopenmp -fopenmp-targets=nvptx64 modf.o case 2 clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64

[clang] 0867c01 - [ClangScanDeps][test] Add -fmodules-cache-path=DIR/cache to make diagnostics.c hermetic

Author: Fangrui Song Date: 2021-09-13T13:17:55-07:00 New Revision: 0867c017e55e3a3d457f26bb778a2cd80d86e1f4 URL: https://github.com/llvm/llvm-project/commit/0867c017e55e3a3d457f26bb778a2cd80d86e1f4 DIFF: https://github.com/llvm/llvm-project/commit/0867c017e55e3a3d457f26bb778a2cd80d86e1f4.diff

[PATCH] D109681: [RISCV] add Half-precision test for vle/vse

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109681/new/ https://reviews.llvm.org/D109681

[PATCH] D109686: Check supported architectures in sseXYZ/avxXYZ headers

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109686/new/ https://reviews.llvm.org/D109686

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-container-data-pointer.cpp:104 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb added a comment. In D109703#2998155 , @ellis wrote: > I've added this to the added test case. > > !18 = !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !4, > entity: !19, line: 122) > !19 = !DIGlobalVariable(name:

[PATCH] D109714: Reduce maximum width of _ExtInt from 2^24-1 to 2^23 to workaround SelectionDAG issue.

craig.topper updated this revision to Diff 372331. craig.topper added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109714/new/ https://reviews.llvm.org/D109714 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: guansong. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Diagnose -fopenmp-targets for HIP programs since dual HIP and OpenMP offloading in

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 372329. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files:

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added a comment. > One thing I wanted to do though is keep track of the constructs in the > OpenMPIRBuilder instead. So move the > > /// Vector of declare variant construct traits. > SmallVector ConstructTraits; > > into OpenMPIRBuilder and add/delete the things there. It's not a

[PATCH] D109714: Reduce maximum width of _ExtInt from 2^24-1 to 2^23 to workaround SelectionDAG issue.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM modulo a request for some comments in the code. It makes me sad that we have a max number of bits specified by LLVM that's kinda useless. "You can store this many bits into this integer value, but if you attempt to add 0

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. > Even if `INSTR_PROF_RAW_VERSION` is bumped, I think it is very likely your > Rust downstream will observe an `if (GET_VERSION(Version) != > RawInstrProf::Version)` error in llvm-profdata, > because from your description it seems you are likely mixing raw profile

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 marked an inline comment as done. gandhi21299 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5069 // where aliases aren't supported. - if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isAMDGPU())

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2998159 , @catenacyber wrote: >> .profraw are files with the raw profile format. The compiler-rt/lib/profile >> runtime and llvm-profdata only support one version at any commit. > > Ok. > >> Mixing .profraw files

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. > .profraw are files with the raw profile format. The compiler-rt/lib/profile > runtime and llvm-profdata only support one version at any commit. Ok. > Mixing .profraw files produced by different compiler-rt/lib/profile runtimes > is unsupported. I do not think I

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks a lot!! This seems to take care of my issues. Can you also include the following test case somewhere into, say, `test/Analysis/blocks-nrvo.c`? It crashes without this patch. // RUN:

[PATCH] D109714: Reduce maximum width of _ExtInt from 2^24-1 to 2^23 to workaround SelectionDAG issue.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Changes to the tests are less intense than I would have thought! In general I'm Ok with this, I don't think anyone would really notice/mind this all that much, and since we can't

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. You state in the documentation that it is also for angle brackets and more, but there are no test cases for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109714: Reduce maximum width of _ExtInt from 2^24-1 to 2^23 to workaround SelectionDAG issue.

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, erichkeane. craig.topper requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. SelectionDAG type legalization requires a power of 2 type with at least as many bits

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2997899 , @csmulhern wrote: > I've added more information to my original message. Please let me know if > further context is desired. With context he meant the diff context.

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2997272 , @ye-luo wrote: > @saiislam did you turn on offload? > https://github.com/ye-luo/openmp-target/wiki/OpenMP-offload-compilers#llvm-clang > On NVIDIA, it fails at CMake step. On AMD, make step stops because of

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added a comment. In D109707#2998095 , @aeubanks wrote: > should the `amdgpu-early-inline-all` flag be deleted? No. It is still used by HIP. We will deprecate it in the feature, but it is not ready yet. Repository: rG LLVM Github Monorepo

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2998137 , @catenacyber wrote: >> Bump the raw profile format version to 6. (Last bump happened in 2019-10.) > > This does not seem to be in the patch, ie no change of > `INSTR_PROF_RAW_VERSION` in

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. Thanks for working on this! `getOrCreateGlobalVariableDIE()` is also called in `constructImportedEntityDIE()` which means that there could be some globals without DIE parents. In D108492 I've added this to the added test case. !18 =

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 372307. saiislam added a comment. Fix for file types in fat archive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files:

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. > Bump the raw profile format version to 6. (Last bump happened in 2019-10.) This does not seem to be in the patch, ie no change of `INSTR_PROF_RAW_VERSION` in compiler-rt/include/profile/InstrProfData.inc Is that missing ? Repository: rG LLVM Github Monorepo

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl added a comment. In D108243#2998077 , @ahatanak wrote: > I was just asking for test cases as I thought it was already a driver option, > but it turns out it wasn't. I agree that this shouldn't be a driver option. > > Sorry @waltl, please revert

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372306. waltl added a comment. Remove driver flags and corresponding tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files:

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2998091 , @catenacyber wrote: > Thanks for the quick reply > >> I don't think this change is responsible. This has been tested by many C++ >> downstream groups. > > What did I do wrong ? > Adding this only commit

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

aeubanks added a comment. should the `amdgpu-early-inline-all` flag be deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing list

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added a comment. We cannot disable early inline all since this will cause performance regressions. Instead, the early inline all pass should be fixed so it does not remove aliases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. Thanks for the quick reply > I don't think this change is responsible. This has been tested by many C++ > downstream groups. What did I do wrong ? Adding this only commit makes the scenario fail. > Rust should use upgrade its lib/ProfileData and

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8448 + +class AttrImporter { + Error Err = Error::success(); shafik wrote: > @martong the `ASTImporter` file is quite large as it is and I think it makes > sense to have `AttrImporter`

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

ahatanak added a comment. I was just asking for test cases as I thought it was already a driver option, but it turns out it wasn't. I agree that this shouldn't be a driver option. Sorry @waltl, please revert the changes that made it a driver option in the last patch. Repository: rG LLVM

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5069 // where aliases aren't supported. - if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); This

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added a comment. While I think the early inliner is largely obsolete, it should still handle aliases correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 created this revision. gandhi21299 added reviewers: yaxunl, aeubanks. Herald added subscribers: foad, kerbowa, hiraditya, tpr, nhaehnle, jvesely, arsenm. gandhi21299 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins and changes the signature of a

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

thakis added a comment. Hm, it passes on my win box and on the one running the presubmit test. Do you know if there's anything special about your bot? Any idea how I could reproduce this? The output is `error: command failed with exit status: True`. Repository: rG LLVM Github Monorepo

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman accepted this revision. aaron.ballman added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:63 +hasType(Container), +

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

aaron.ballman added a comment. In D69764#2997910 , @MyDeveloperDay wrote: > I think the relevance of Left/Right East/West as a setting is less > important, as its more about an ordering, allowing some tokens to go to the > Left and some to the Right

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 372292. MyDeveloperDay added a comment. QualifierAlignmentFixer need to process all the Left/Right passes internally before return the fixes on the original code. So now QualifierAlignmentFixer has its own inner set of passes which will be processed,

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman edited reviewers, added: aaron.ballman; removed: rsmith. aaron.ballman added a subscriber: lattner. aaron.ballman added a comment. In D109701#2997892 , @lattner wrote: > I'm not sure who the best person is to review this, but it isn't me

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

jyknight added a comment. In D108243#2995898 , @waltl wrote: > Added driver flags, and tests for them @ahatanak did you intend to ask Walt to add a driver flag for this? I think we should not have one, since this isn't something we should be telling

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. I think the relevance of Left/Right East/West as a setting is less important, as its more about an ordering, allowing some tokens to go to the Left and some to the Right of the "type" QualifierAlignment: Custom QualifierOrder: [ inline, static, type, const,

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern added a comment. I've added more information to my original message. Please let me know if further context is desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

lattner resigned from this revision. lattner edited reviewers, added: rsmith; removed: lattner. lattner added a comment. I'm not sure who the best person is to review this, but it isn't me anymore sadly. Richard, can you recommend someone? Comment at:

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:69 +/// Reference: +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317427;>artifactLocation object +/// 2. \ref SarifArtifact I'm not sure how to

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372289. vaibhav.y added a comment. [clangBasic] Fixup header guard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith updated this revision to Diff 372287. keith added a comment. Revert unrelated formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D109557: Adds an AlignCloseBracket option

MyDeveloperDay added a comment. Please resubmit the patch with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 372285. compnerd added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 Files:

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith updated this revision to Diff 372286. keith marked an inline comment as done. keith added a comment. Fix formatting and comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D109461 Files:

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd marked 7 inline comments as done. compnerd added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:63 +hasType(Container), +

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

phosek added a comment. `Clang :: Driver/cl.c` started failing on our Windows bots after this change landed. Here

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:711 + +/*template +friend struct AttrArgImporter; Looks like left over unused code? Comment at: clang/lib/AST/ASTImporter.cpp:8448 + +class AttrImporter { + Error

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb created this revision. krisb added reviewers: dblaikie, probinson. Herald added a subscriber: hiraditya. krisb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=44695

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. In D109128#2997588 , @JDevlieghere wrote: > If I understand correctly, this patch does that, but swaps 2 and 3. What's > the motivation for trying the non-canonical path first? If we treat the > current working directory as a

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y created this revision. vaibhav.y added a reviewer: lattner. Herald added subscribers: dexonsmith, wenlei, mgorny. vaibhav.y edited the summary of this revision. vaibhav.y added a project: clang. vaibhav.y added subscribers: aaron.ballman, lebedev.ri. vaibhav.y added a comment. vaibhav.y

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

MaskRay added a comment. Haven't looked closely at this particular commit, but I think hard coding the detected triples is almost always a bad idea. See https://reviews.llvm.org/D63497#2993662 for a longer comment. The proper way is (1) making sure CMake `LLVM_DEFAULT_TARGET_TRIPLE` is correct

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2997674 , @catenacyber wrote: > This commit has broken oss-fuzz workflow for rust projects. > I do not know if the fix is > https://reviews.llvm.org/rG66e2772e4285588ccc3bcdb5f392c8326debbd7d > > Scenario is > >

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt:42 DynamicTypeChecker.cpp + cert/InvalidPtrChecker.cpp EnumCastOutOfRangeChecker.cpp Please, insert this in its sorted place. CHANGES SINCE LAST ACTION

  1   2   >