[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

ahatanak added a reviewer: rjmccall. ahatanak added a comment. I'm not sure why `ObjCObjectPointerType` was originally a specifier, but this patch looks safe to me. `ObjCObjectPointerType` is never passed to `TypePrinter::printBefore` and `QualType GetBaseType`, which are the two functions

[PATCH] D110336: [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d6889964ab5: [X86][FP16] Add more builtins to avoid multi evaluation problems add 2 missed… (authored by pengfei). Changed prior to commit:

[clang] 7d68899 - [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics

Author: Wang, Pengfei Date: 2021-09-27T09:27:04+08:00 New Revision: 7d6889964ab534164698ef134de9cf11cd87a09d URL: https://github.com/llvm/llvm-project/commit/7d6889964ab534164698ef134de9cf11cd87a09d DIFF: https://github.com/llvm/llvm-project/commit/7d6889964ab534164698ef134de9cf11cd87a09d.diff

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" HazardyKnusperkeks wrote: > feg208 wrote: > > HazardyKnusperkeks

[PATCH] D110336: [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110336/new/ https://reviews.llvm.org/D110336

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" feg208 wrote: > HazardyKnusperkeks wrote: > > Here is

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tambre added a comment. This unfortunately breaks using Debian distribution CUDA. The Debian/Ubuntu special case

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. Maybe we should emit note like “cast one or both operands to int to silence this warning” (any idea for better note text?)? I think it could be useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 375118. xbolva00 edited the summary of this revision. xbolva00 added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

Quuxplusone added a comment. LGTM % comments, FWIW. Comment at: clang/test/Sema/warn-bitwise-and-bool.c:26 + b = foo() & a; + b = (p != 0) & (*p == 42); + b = foo() & (*q == 42); // expected-warning {{use of bitwise '&' with boolean operands}} Perhaps add

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. Looks OK now? or something more to be done? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 375115. xbolva00 added a comment. Introduced -Wbitwise-instead-of-logical flag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune marked an inline comment as done. aqjune added inline comments. Comment at: clang/test/CodeGen/X86/avx-builtins.c:182 // CHECK-LABEL: test_mm256_castsi128_si256 - // CHECK: shufflevector <2 x i64> %{{.*}}, <2 x i64> %{{.*}}, <4 x i32> + // CHECK: shufflevector <2 x

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune updated this revision to Diff 375095. aqjune added a comment. Resurrect mistakenly removed test statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103874/new/ https://reviews.llvm.org/D103874 Files:

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune updated this revision to Diff 375094. aqjune added a comment. Herald added a subscriber: arphaman. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103874/new/ https://reviews.llvm.org/D103874 Files:

[PATCH] D110213: [PowerPC] Define XL-compatible macros only for AIX and Linux

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. FWIW I think this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110213/new/ https://reviews.llvm.org/D110213

[PATCH] D110493: [clang-tidy] Fix bug 51790 in readability-uppercase-literal-suffix

carlosgalvezp added a comment. I personally think this fix should happen when doing the match, not when analyzing the matches. This is my first patch to LLVM and I'm not knowledgeable in AST so I don't really know how to go about that :) Please come with suggestions if there's a better way to

[PATCH] D110493: [clang-tidy] Fix bug 51790 in readability-uppercase-literal-suffix

carlosgalvezp created this revision. carlosgalvezp added reviewers: llvm-commits, cfe-commits, steveire, lebedev.ri, alexfh, alexfh_. carlosgalvezp added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. carlosgalvezp requested review of this revision. A bisect determined that