[PATCH] D111037: [X86] Check if struct is blank before getting the inner types

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-abi.c:207 +} pr52011() { + // CHECK-C: define{{.*}} { float, double } @pr52011 +} Why not test CPP as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378094. hsmhsm added a comment. Move OpenMP GPU offloading codegen related changes from here to https://reviews.llvm.org/D111324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378093. hsmhsm added a comment. Move OpenMP GPU offloading codegen related changes from https://reviews.llvm.org/D111324 to here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316/new/

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378092. hsmhsm added a comment. Add lit test - CodeGenObjC/static-alloc-init.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111293/new/ https://reviews.llvm.org/D111293 Files:

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

MaskRay added a comment. In D111367#3050061 , @tstellar wrote: > In D111367#3049772 , @MaskRay wrote: > >> In D111367#3049700 , @hvdijk wrote: >> >>> Does Red Hat

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

tstellar added a comment. In D111367#3049772 , @MaskRay wrote: > In D111367#3049700 , @hvdijk wrote: > >> Does Red Hat actually use `x86_64-redhat-linux` with LLVM (other than for >> finding the GCC

[PATCH] D111382: Support _Float128 and F128 literal in C mode

MaskRay created this revision. MaskRay added reviewers: bkramer, hubert.reinterpretcast, mibintc, nsz. Herald added subscribers: dexonsmith, kbarton, nemanjai, dschuff. MaskRay requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This

[PATCH] D111037: [X86] Check if struct is blank before getting the inner types

pengfei updated this revision to Diff 378082. pengfei marked an inline comment as done. pengfei added a comment. Add more tests. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111037/new/ https://reviews.llvm.org/D111037 Files:

[PATCH] D111336: [AIX] Disable tests failing due to missing DWARF sections

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111336/new/ https://reviews.llvm.org/D111336

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

shchenz added a comment. In D69#3048311 , @Jake-Egan wrote: > In D69#3047761 , @shchenz wrote: > >> Thanks for working on this. >> >> Could you please help to rerun the affected cases after applying

[PATCH] D111037: [X86] Check if struct is blank before getting the inner types

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-abi.c:203 +struct { + float a; + struct {}; Add more cases for the struct composed of _Float16, float, double, struct {}? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111348: [OpenMP] Introduce new flags to assert thread and team usage in the runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG9efdca87c782: [OpenMP] Introduce new flags to assert thread and team usage in the runtime (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D111348?vs=377973=378066#toc

[clang] 9efdca8 - [OpenMP] Introduce new flags to assert thread and team usage in the runtime

Author: Joseph Huber Date: 2021-10-07T22:23:09-04:00 New Revision: 9efdca87c78256bb00ed51521272dec2deed7f23 URL: https://github.com/llvm/llvm-project/commit/9efdca87c78256bb00ed51521272dec2deed7f23 DIFF: https://github.com/llvm/llvm-project/commit/9efdca87c78256bb00ed51521272dec2deed7f23.diff

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

phosek added inline comments. Comment at: llvm/lib/Support/Caching.cpp:137 + sys::path::append(TempFilenameModel, CacheDirectoryPath, +"Caching-%%.tmp.o"); Expected Temp = sys::fs::TempFile::create( I would make this

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe updated this revision to Diff 378065. FreddyYe added a comment. add {{$}}. add comments at first line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798 Files:

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe marked an inline comment as done. FreddyYe added a comment. Sorry for late response. Thanks for your comments, @DavidSpickett ! Comment at: clang/test/Misc/target-invalid-cpu-note.c:27 // TUNE_X86_64: error: unknown target CPU 'not-a-cpu' -// TUNE_X86_64: note: valid

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu added a comment. @MaskRay Thank you for pointing this out. I just added this! The use case is a Debuginfod client implementation. The `AssetCache` in the debuginfod client revision will be replaced by the localCache that was implemented for ThinLTO,

[PATCH] D111348: [OpenMP] Introduce new flags to assert thread and team usage in the runtime

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit wrt. spelling Comment at: clang/include/clang/Basic/LangOptions.def:247-248 LANGOPT(OpenMPOptimisticCollapse , 1, 0, "Use at most 32 bits to represent

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. Thank you! In the meantime, I will rebase this patch and resolve conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.org/D105169 ___

[PATCH] D110286: [WIP][Clang][OpenMP] Add new clang argument `-fopenmp-target-simd`

tianshilei1992 added a comment. In D110286#3047943 , @JonChesterfield wrote: > I'm excited about the thread to warp mapping but unclear why this needs to be > a compile time flag. Can we use this mapping when pragma simd is present and > otherwise

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. Thank you! I'll send a mail to cfe-dev + llvm-dev to notify the change (and gather any possible concern if exists). If there is no objection in a week, let's land these patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

MaskRay added a comment. In D111367#3049700 , @hvdijk wrote: > Does Red Hat actually use `x86_64-redhat-linux` with LLVM (other than for > finding the GCC installation)? I didn't see this on Fedora, I think they use > the config.guess-determined target

[PATCH] D111283: [clang] WIP: template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378054. mizvekov added a comment. - Handle almost all type classes in getCommonSugar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files:

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

MaskRay added a comment. Can you state your intended use case (make that patch a dependent of this one by clicking `Edit Related Revisions` if you have such a patch) so that others can analyze whether code sharing is justified? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei added a comment. I added unit test for macros. I am still working on adding error checks on `--ffuchsia-api-level` flags but the rest is pretty much done. Comment at: clang/test/Frontend/attr-availability-fuchsia.c:4 +// +// It should also be exposed to non-fuchsia

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378052. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu created this revision. Herald added subscribers: ormris, dexonsmith, steven_wu, hiraditya, arichardson, inglorion, sbc100, mgorny, emaste. Herald added a reviewer: MaskRay. Herald added a reviewer: gkm. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. noajshu

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. In D110089#3049656 , @kgk wrote: > Very cool! I am selfishly curious if support for surface operations is > something you plan to add. I had a go at implementing it myself today based > on this patch, and found it a bit harder than

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fad9de5c003: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method. (authored by vsapsai). Repository: rG LLVM Github Monorepo

[clang] 9fad9de - [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

Author: Volodymyr Sapsai Date: 2021-10-07T17:09:31-07:00 New Revision: 9fad9de5c0032898a481e06bf5f696ca50c804c1 URL: https://github.com/llvm/llvm-project/commit/9fad9de5c0032898a481e06bf5f696ca50c804c1 DIFF:

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai added a comment. Thanks for the review! And thanks for the insightful questions about inlined functions. Good to know `static inline` also should trigger the early inline and not only `always_inline`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

hvdijk added a comment. Does Red Hat actually use `x86_64-redhat-linux` with LLVM (other than for finding the GCC installation)? I didn't see this on Fedora, I think they use the config.guess-determined target name, and I think that's the right thing for them to do. That only affects whether

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

MaskRay created this revision. MaskRay added reviewers: hvdijk, phosek, sylvestre.ledru, tstellar. Herald added subscribers: abrachet, pengfei. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. MaskRay requested review of this revision. Herald added a project: clang. Herald

[PATCH] D111366: [CMake] Include llvm-libtool-darwin in Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebcfd3ae8cc5: [CMake] Include llvm-libtool-darwin in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ebcfd3a - [CMake] Include llvm-libtool-darwin in Fuchsia toolchain

Author: Petr Hosek Date: 2021-10-07T16:44:40-07:00 New Revision: ebcfd3ae8cc506e5f6056517dc295b74a3463d24 URL: https://github.com/llvm/llvm-project/commit/ebcfd3ae8cc506e5f6056517dc295b74a3463d24 DIFF: https://github.com/llvm/llvm-project/commit/ebcfd3ae8cc506e5f6056517dc295b74a3463d24.diff

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

rjmccall added a comment. In D111293#3049633 , @jdoerfert wrote: >> CodeGenFunction::InitTempAlloca() inits the static alloca within the entry >> block which may *not* necessarily be correct always. > > FWIW, for all uses this was correct. The point of

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay updated this revision to Diff 378040. MaskRay added a comment. Herald added a subscriber: abrachet. Hard-code Fuchsia to use normalized triple fuchsia.c uses --target=x86_64-fuchsia but expects to find x86_64-unknown-fuchsia path. Linux should respect --target= and do no normalization.

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

kgk added a comment. In D110089#3048460 , @tra wrote: > In D110089#3047161 , @kgk wrote: > >> Will the new macros in this patch also be useful for supporting the >> surface-related methods that also use

[PATCH] D111366: [CMake] Include llvm-libtool-darwin in Fuchsia toolchain

phosek created this revision. phosek added reviewers: leonardchan, haowei, gulfem. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to use this tool in our build. Repository: rG

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

jcking1034 added inline comments. Comment at: clang/docs/tools/dump_ast_matchers.py:13 +CLASS_INDEX_PAGE = urlopen("https://clang.llvm.org/doxygen/classes.html;).read() + aaron.ballman wrote: > Do we need to handle an exception here if there are network

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

jdoerfert added a comment. > CodeGenFunction::InitTempAlloca() inits the static alloca within the entry > block which may *not* necessarily be correct always. FWIW, for all uses this was correct. The point of the function was exactly to do what you state here as "potentially incorrect". The

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

jcking1034 updated this revision to Diff 378037. jcking1034 added a comment. Catch and reraise exceptions with an appropriate message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111332/new/ https://reviews.llvm.org/D111332 Files:

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6406-6414 +/// Matches reference `TypeLoc`s. +/// +/// Given +/// \code +/// int x = 3; +/// int& xx = x; +/// \endcode jcking1034 wrote: > aaron.ballman wrote: > >

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

Conanap updated this revision to Diff 378015. Conanap marked 2 inline comments as done. Conanap added a comment. Added mordern assembler check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111258/new/ https://reviews.llvm.org/D111258 Files:

[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2351 - // FIXME: Do this when the target isn't aarch64. + llvm::Triple::ArchType Arch = CGF.CGM.getTriple().getArch(); + Please leave a comment saying that we should do this on all

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

rjmccall added a comment. Can you just do one patch for all the OpenMP changes, and then put the final removal in a separate patch? Thanks for taking this on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

rjmccall added a comment. We should take the opportunity to add a test here for the ObjC case. It should be testable with something like this, where you should see the store inside of the loop instead of once in the prologue: // RUN: %clang_cc1 -triple x86_64-unknown-freebsd -S -emit-llvm

[clang] 976aa4d - Reland "[clang][Fuchsia] Re-enable compiler-rt tests in runtimes build"

Author: Leonard Chan Date: 2021-10-07T14:19:29-07:00 New Revision: 976aa4d759c7c85786a23de5d09ad771f1e890e0 URL: https://github.com/llvm/llvm-project/commit/976aa4d759c7c85786a23de5d09ad771f1e890e0 DIFF: https://github.com/llvm/llvm-project/commit/976aa4d759c7c85786a23de5d09ad771f1e890e0.diff

[PATCH] D106191: [clang] Option control afn flag

erichkeane added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. masoud.ataei wrote: > erichkeane wrote: > > This seems pretty incomplete to

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 378005. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst clang/include/clang/Driver/Options.td

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f3e52538d77: [NFC][sanitizer] Remove global PersistentAllocator (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111344: [HWASan] Use tagged-globals feature on x86.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111344/new/ https://reviews.llvm.org/D111344

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: > This seems pretty incomplete to me, I have no idea what

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed an absolute path to clang, where only part of the path to the file was remapped, it would result in the file's DIFile being stored

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 377983. keith added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-dsymutil.c

[PATCH] D111267: [clang] Fix darwin REQUIRES test annotation (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9f9ed7a81ab8: [clang] Fix darwin REQUIRES test annotation (NFC) (authored by keith). Repository: rG LLVM Github

[clang] 9f9ed7a - [clang] Fix darwin REQUIRES test annotation (NFC)

Author: Keith Smiley Date: 2021-10-07T12:58:49-07:00 New Revision: 9f9ed7a81ab8ad6af46c7c5ba9109a7ef29fc7a7 URL: https://github.com/llvm/llvm-project/commit/9f9ed7a81ab8ad6af46c7c5ba9109a7ef29fc7a7 DIFF: https://github.com/llvm/llvm-project/commit/9f9ed7a81ab8ad6af46c7c5ba9109a7ef29fc7a7.diff

[PATCH] D111348: [OpenMP] Introduce new flags to assert thread and team usage in the runtime

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: dexonsmith, dang, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp added a comment. Anything else I should address? Otherwise I'd need some help committing since I don't think I have access for that. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110614/new/ https://reviews.llvm.org/D110614

[PATCH] D111344: [HWASan] Use tagged-globals feature on x86.

morehouse created this revision. morehouse added reviewers: pcc, eugenis, vitalybuka. morehouse requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Allows us to use the small code model when we disable relocation

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:32 const char *LinkingOutput) const { const Driver = getToolChain().getDriver(); Since you're doing it for the other method, maybe it'd

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#3048763 , @JonasToth wrote: > ping Hi Jonas, Using patch32 in production (on top of "release/13.x" branch) ever since it was made available. No crashes. Only one false positive reported, which I'm not sure even

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

aaron.ballman added inline comments. Comment at: clang/docs/tools/dump_ast_matchers.py:13 +CLASS_INDEX_PAGE = urlopen("https://clang.llvm.org/doxygen/classes.html;).read() + Do we need to handle an exception here if there are network issues? Repository:

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

eugenis added a comment. @hyeongyukim, thank you for the summary. This looks like a great change, and a net positive to me. The test churn in the other patch is unfortunate, but IMHO unavoidable. If no one has any further objections, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

fcambus created this revision. fcambus added reviewers: krytarowski, mgorny. fcambus requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D111242: Add `TypeLoc`-related matchers.

aaron.ballman added a comment. Aside from the question about member function references and whether those should or should not be matched, I think this LGTM. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6361-6362 +/// \endcode +///

[PATCH] D111336: [AIX] Disable tests failing due to missing DWARF sections

Jake-Egan created this revision. Herald added a subscriber: arphaman. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111336 Files:

[PATCH] D111332: [AST Matchers] Update dump_ast_matchers.py to query only class index page.

ymandel added a comment. Aaron -- I'm not the right reviewer for this. I've put you as the reviewer, but feel free to re-route if there's someone better. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111332/new/

[PATCH] D111332: Update dump_ast_matchers.py to query only class index page.

jcking1034 created this revision. jcking1034 added a reviewer: ymandel. Herald added a subscriber: arphaman. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It may be possible to avoid relying on accessing many individual class

[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: pengfei, kristof.beyls. ahatanak requested review of this revision. https://reviews.llvm.org/D92808 made clang use the operand bundle instead of emitting

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + cor3ntin wrote: > erichkeane wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > >

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 marked an inline comment as not done. jcking1034 added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:636

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Is there any way to have

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya updated this revision to Diff 377934. hiraditya added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 Files: clang/include/clang/Basic/Attr.td clang/test/CodeGen/instrument-objc-method.m

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 updated this revision to Diff 377933. jcking1034 marked 2 inline comments as done. jcking1034 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 Files:

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29e00b29f76a: [CUDA] Make sure string.h is included with original __THROW defined. (authored by tra). Repository: rG LLVM Github Monorepo

[clang] 29e00b2 - [CUDA] Make sure is included with original __THROW defined.

Author: Artem Belevich Date: 2021-10-07T11:43:56-07:00 New Revision: 29e00b29f76adb15a51c1ccd6c1fdb6fce5f4d7b URL: https://github.com/llvm/llvm-project/commit/29e00b29f76adb15a51c1ccd6c1fdb6fce5f4d7b DIFF:

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + aaron.ballman wrote: > erichkeane wrote: > > Is there any way to have this elaborate more?

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377930. cor3ntin added a comment. Fix version in diagnostics in the right direction (23 => 2b) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files:

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377929. cor3ntin added a comment. fix diagnostic, nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files: clang/docs/ReleaseNotes.rst

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

aaron.ballman added a comment. Just nits from me, but otherwise LGTM! Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:556 +def warn_cxx20_alias_in_init_statement : Warning< + "alias declaration in this context is incompatible with C++ standards before C++23">,

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + Is there any way to have this elaborate more? The 'expected 'TOKEN'' is my least favorite

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377921. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Add C++20 compat warning, fix style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks updated this revision to Diff 377915. aeubanks added a comment. add more codegen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.llvm.org/D111250 Files: clang/include/clang/Sema/Sema.h

[PATCH] D106191: [clang] Option control afn flag

erichkeane added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. This seems pretty incomplete to me, I have no idea what it does from this

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu added a comment. In D111273#3047759 , @hans wrote: > Are there no tests for clang-format-diff.py? That seems unfortunate. No test for clang-format-diff.py. > Will this handle more nested cases, for example if the first line here is > deleted,

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. `id` is a typedef and `@class` is an `ObjCInterface` now, so it looks like it's safe to remove `ObjCObjectPointer` case then. CHANGES SINCE LAST ACTION

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377909. masoud.ataei added a comment. Update the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst

[PATCH] D111315: Workaround build error for mingw-g++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6283d468e28b: Workaround build error for mingw-g++ (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6283d46 - Workaround build error for mingw-g++

Author: Luke Drummond Date: 2021-10-07T18:34:16+01:00 New Revision: 6283d468e28b35e2731dda1a9e0efcb3d9acf557 URL: https://github.com/llvm/llvm-project/commit/6283d468e28b35e2731dda1a9e0efcb3d9acf557 DIFF: https://github.com/llvm/llvm-project/commit/6283d468e28b35e2731dda1a9e0efcb3d9acf557.diff

[PATCH] D111315: Workaround build error for mingw-g++

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 ___

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377904. masoud.ataei added a comment. Description and driver test are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files:

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm updated this revision to Diff 377905. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 Files: clang/lib/Interpreter/Interpreter.cpp Index: clang/lib/Interpreter/Interpreter.cpp

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm added a comment. In D111315#3048459 , @v.g.vassilev wrote: > Can you map `state_not_recoverable` to `not_supported`? Sure. I wasn't really sure that the io_error and not_enough_memory were appropriate. Thanks for the confirmation CHANGES

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377903. vitalybuka added a comment. fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files:

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377900. vitalybuka marked an inline comment as done. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files:

[PATCH] D111187: [Clang] Add information about partially implemented features

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in d456fed1a9feaa441847038d6adbb93ff3bf8f66 , thanks for the improvement! Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   >