[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

dblaikie added a comment. Plan is still to address the "this only works with disable free" issue? (I've some preference that be addressed before this feature is turned on by default) & is there a flag to pass to turn this off if someone had trouble with it? (doesn't necessarily have to be, but

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 379284. carlosgalvezp added a comment. Expand documentation to make it clear that globbing is supported for NOLINT, NOLINTNEXTLINE as well as NOLINTBEGIN/END. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. Yes, I think it would be fine to fork off a conversation about what the ABI should be; I didn't meant to completely derail this patch. To be frank, my expectation was that more of this was already settled and documented, so we just needed to add that documentation and

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

craig.topper updated this revision to Diff 379279. craig.topper added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110669/new/ https://reviews.llvm.org/D110669 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Driver/

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

lkail added a comment. I would like to see more aix triple added to existing tests involving ABI in `llvm/test/CodeGen/PowerPC`(such as ppc64-i128-abi.ll), since AIX has independent calling convention lowering and is different from linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aeubanks created this revision. aeubanks updated this revision to Diff 378327. aeubanks added a comment. aeubanks edited the summary of this revision. aeubanks retitled this revision from "[clang] Always pass -clear-ast-before-backend" to "[clang] Pass -clear-ast-before-backend". aeubanks edited t

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

achieveartificialintelligence added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:63-65 + if (Ext == "zbe" || Ext == "zbf" || Ext == "zbm" || Ext == "zbp" || Ext == "zbr" || + Ext == "zbt") Need format here? Repository:

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

craig.topper updated this revision to Diff 379278. craig.topper added a comment. Add back dropped changes to RISCV.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110669/new/ https://reviews.llvm.org/D110669 Files: clang/lib/Basic/Targets/RISCV

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

craig.topper updated this revision to Diff 379276. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110669/new/ https://reviews.llvm.org/D11066

[PATCH] D111692: [RISCV] Remove Zvamo C intrinsics and builtins.

craig.topper created this revision. craig.topper added reviewers: kito-cheng, HsiangKai, khchen, rogfer01, frasercrmck, arcbbb. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, t

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 379272. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Add arch info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added a comment. As discussed in D110684 , developers complain not only compile time, but also binary size & memory usage caused by RVV intrinsics. We need to consider binary size, too. Is there other way to handle it? Or we should go back to think ab

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added a comment. Although it reduces the header size, this patch will increase the binary size of clang. Debug build: Before this patch: textdatabss dec hex filename 263892591 10838284500232 275231

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

HsiangKai added a comment. We are working on a patch, D111617 , to reduce the large header size caused by abundant RISC-V vector intrinsics. From the measurement depicted in D103228 , it should be helpful for compile time. Rep

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma added a comment. go for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Mon, Oct 11, 2021 at 2:46 PM Richard Smith wrote: > On Wed, 15 Sept 2021 at 13:52, David Blaikie wrote: > >> On Tue, Sep 14, 2021 at 10:04 AM Richard Smith >> wrote: >> >>> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> Aut

[clang] 3909327 - Improve printing of const variable sized arrays

Author: David Blaikie Date: 2021-10-12T19:04:53-07:00 New Revision: 39093279f2ede4af9048b89d048d7fe9182a50f8 URL: https://github.com/llvm/llvm-project/commit/39093279f2ede4af9048b89d048d7fe9182a50f8 DIFF: https://github.com/llvm/llvm-project/commit/39093279f2ede4af9048b89d048d7fe9182a50f8.diff

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:923 + + const RVVIntrinsicInfo *Intrinsic = std::find_if( + std::begin(RVVIntrinsicInfos), std::end(RVVIntrinsicInfos), kito-cheng wrote: > rogfer01 wrote: > > Not for this patch: I

[PATCH] D107944: [hmaptool] Port to python3

bruno added a comment. Overall looks great but there are some test failures, looks like you also need to update line 223? -- Traceback (most recent call last): File "/var/lib/buildkite-agent/builds/llvm-project/build/bin/hmaptool", line 296, in main() File "/var/lib/buildkite

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

MaskRay added a comment. This has been the first time RISC-V added something and caused performance/memory/test execution regression for other users. The problem should be considered seriously (I don't even mind reverting the patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D106755: Extended format string checking to wprintf/wscanf

floam added a comment. still working on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106755/new/ https://reviews.llvm.org/D106755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D111665: [CUDA] Provide address space conversion builtins.

tra added a comment. In D111665#3059989 , @jdoerfert wrote: > Except when it doesn't get instcombined away: https://godbolt.org/z/YE4EfEPde Well, it does get translated into sensible PTX, so, while not ideal, it's not too big of a deal. Using an integer

[PATCH] D111517: [X86] Remove little support we had for MPX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2d4fe51bb4f: [X86] Remove little support we had for MPX (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] c2d4fe5 - [X86] Remove little support we had for MPX

Author: Fangrui Song Date: 2021-10-12T16:18:51-07:00 New Revision: c2d4fe51bb4f98870a2358a32809f849b0751d7c URL: https://github.com/llvm/llvm-project/commit/c2d4fe51bb4f98870a2358a32809f849b0751d7c DIFF: https://github.com/llvm/llvm-project/commit/c2d4fe51bb4f98870a2358a32809f849b0751d7c.diff

[PATCH] D111665: [CUDA] Provide address space conversion builtins.

jdoerfert added a comment. In D111665#3059690 , @tra wrote: > In D111665#3059427 , @jdoerfert > wrote: > >> Not loving the magic constants here but I don't think we have a enum or >> similar right now. > > Yup.

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov marked 3 inline comments as done. mizvekov added inline comments. Comment at: clang/test/SemaCXX/sugared-auto.cpp:146 +return a; + return N(); // expected-error {{but deduced as 'SARS (*)() throw(Man, Vibrio)' (aka 'void (*)() throw(Man, Vibrio)')}} +}

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov created this revision. mizvekov retitled this revision from "[clang] WIP: Use getCommonSugar in an assortment of places" to "[clang] WIP: use getCommonSugar in an assortment of places". mizvekov updated this revision to Diff 378694. mizvekov added a comment. mizvekov updated this revisio

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a8c695542b: [NFC] Rename EmitAssemblyHelper new/legacy PM methods (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] b6a8c69 - [NFC] Rename EmitAssemblyHelper new/legacy PM methods

Author: Arthur Eubanks Date: 2021-10-12T15:41:44-07:00 New Revision: b6a8c695542b2987eb9a203d5663a0740cb4725f URL: https://github.com/llvm/llvm-project/commit/b6a8c695542b2987eb9a203d5663a0740cb4725f DIFF: https://github.com/llvm/llvm-project/commit/b6a8c695542b2987eb9a203d5663a0740cb4725f.diff

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

aeubanks updated this revision to Diff 379208. aeubanks added a comment. add comment I'd rather switch everything to lowerCamel at once rather than just a few methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111680/new/ https://reviews.llvm.o

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

amyk accepted this revision as: amyk. amyk added a comment. Aside from the comment made by Victor, also LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.org/D111229 __

[PATCH] D111665: [CUDA] Provide address space conversion builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf526ee5b8517: [CUDA] Provide address space conversion builtins. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111665/new/ https://reviews

[clang] f526ee5 - [CUDA] Provide address space conversion builtins.

Author: Artem Belevich Date: 2021-10-12T14:56:39-07:00 New Revision: f526ee5b8517b60620cd03bb3e5945ed69d6bfaa URL: https://github.com/llvm/llvm-project/commit/f526ee5b8517b60620cd03bb3e5945ed69d6bfaa DIFF: https://github.com/llvm/llvm-project/commit/f526ee5b8517b60620cd03bb3e5945ed69d6bfaa.diff

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

craig.topper added a comment. I think this looks good other than the whitespace in fixed-vectors-mask-logic.ll that Jessica commented on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111062/new/ https://reviews.llvm.org/D111062 _

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

craig.topper added a comment. In D110684#3059698 , @aeubanks wrote: > In D110684#3057498 , @nikic wrote: > >> I noticed this a few time in the past already, but this is the worst one yet: >> >> Compile-time: >> h

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

MaskRay added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:175 + void EmitAssemblyWithLegacyPassManager(BackendAction Action, + std::unique_ptr OS); Perhaps add a comment to bring awareness to possible

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Consider switching to `functionName` while updating the function names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111680/new/ https://revi

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong updated this revision to Diff 379189. martong marked 3 inline comments as done. martong added a comment. - Fix logic error - Add more test cases - Use SymbolRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110357/new/ https://reviews.llvm.

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong marked 5 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1619 + return true; +const SymExpr *LHS = Sym->getLHS(); +const llvm::APSInt &Zero = ASDenysPetrov wrote: >

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

aeubanks created this revision. aeubanks added a reviewer: MaskRay. Herald added a subscriber: ormris. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. aeubanks requested review of this revision. Herald added a project: clang. Herald added a s

[PATCH] D111582: [clang] Teardown new PM data structures before running codegen pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cadef6537b3: [clang] Teardown new PM data structures before running codegen pipeline (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] 2cadef6 - [clang] Teardown new PM data structures before running codegen pipeline

Author: Arthur Eubanks Date: 2021-10-12T14:17:11-07:00 New Revision: 2cadef6537b351cc696e2de1f5c8e9fbe6055980 URL: https://github.com/llvm/llvm-project/commit/2cadef6537b351cc696e2de1f5c8e9fbe6055980 DIFF: https://github.com/llvm/llvm-project/commit/2cadef6537b351cc696e2de1f5c8e9fbe6055980.diff

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 379179. mizvekov added a comment. - Introduce TDK_ALreadyDiagnosed. Addresses rsmith's review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: cla

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

aeubanks added a comment. In D110684#3057498 , @nikic wrote: > I noticed this a few time in the past already, but this is the worst one yet: > > Compile-time: > https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d3884

[PATCH] D111665: [CUDA] Provide address space conversion builtins.

tra added a comment. In D111665#3059427 , @jdoerfert wrote: > Not loving the magic constants here but I don't think we have a enum or > similar right now. Yup. > I also have to question the people that choose `size_t` here... we will end > up with int

[PATCH] D111582: [clang] Teardown new PM data structures before running codegen pipeline

aeubanks updated this revision to Diff 379175. aeubanks added a comment. add back a (similar) comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111582/new/ https://reviews.llvm.org/D111582 Files: clang/lib/CodeGen/BackendUtil.cpp Index: cla

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b9f9b4b3cf: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith added a comment. In D102923#3059592 , @teemperor wrote: > This seems to have broken compiling some versions of Foundation/Dispatch with > -fmodules enabled (which breaks the LLDB test suite when it tries to compile > any Objective-C tests). C

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/inline-calls.ll:3 ; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck %s -; RUN: llc -march=r600 -mcpu=redwood -verify-machineinstrs < %s | FileCheck %s @tstellar

[PATCH] D102923: [clang][lex] Remark on search path usage

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. This seems to have broken compiling some versions of Foundation/Dispatch with -fmodules enabled (which breaks the LLDB test suite when it tries to compile any Objective-C tests). Can you

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. Thanks. LGTM. One minor can be addressed when commit it. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c:71 + + /*shift = 31, mask = 0x1FF = 511*

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1619 + return true; +const SymExpr *LHS = Sym->getLHS(); +const llvm::APSInt &Zero = steakhal wrote: > Since `SymbolRef` actually is already `c

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

kamaub updated this revision to Diff 379149. kamaub added a comment. Adding shift variable test case to `builtins-ppc-xlcompat-rotate.c` as per review comment request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.o

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

steakhal added a comment. The coverage report of the test shows that L2124 is uncovered. Please add a test demonstrating that path as well. I'm gonna come back to this tomorrow. Comment at: clang/test/Analysis/solver-sym-simplification-adjustment.c:36 + clang_analyzer_warnIfR

[PATCH] D111665: [CUDA] Provide address space conversion builtins.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Not loving the magic constants here but I don't think we have a enum or similar right now. I also have to question the people that choose `size_t` here... we will end up with int2ptr(ptr

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman added a comment. In D111041#3059245 , @carlosgalvezp wrote: >> Eh, I personally don't care all that much one way or the other (so sure, I >> can do that!), but I recall there being a push to keep the "title" line >> under something very s

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal added a comment. BWT the following lines are uncovered by tests: L1627, L1651, L1758 Please adjust your tests accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110357/new/ https://reviews.llvm.org/D110357

[PATCH] D111582: [clang] Teardown new PM data structures before running codegen pipeline

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks great! Comment at: clang/lib/CodeGen/BackendUtil.cpp:1441-1442 - - // FIXME: We still use the legacy pass manager to do code generation. We - // create that pass

[PATCH] D111669: No longer crash when a consteval function returns a structure

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. I don't think the aggregate emitter needs to emit anything when handling a constant expression which has an unused resu

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

NeHuang added a comment. Please check and add a test in `clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c` with `shift` as a variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.org/D111229 __

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu added a comment. @tejohnson Thanks for your comments! From my perspective this patch is done. Please let me know if you have any further changes to suggest before accepting. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/

[PATCH] D111665: [CUDA] Provide address space conversion builtins.

tra added a comment. Tested by verifying that generated code (both PTX and SASS) matches that of NVCC: https://godbolt.org/z/rWYYx63bT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111665/new/ https://reviews.llvm.org/D111665

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf marked an inline comment as done. 0x1eaf added a comment. I don't have commit access, so would appreciate if you commit it, thanks! Forgot to mention on Friday: I've instrumented preamble building, but haven't instrumented background indexing which is outside of `TUScheduler.cpp` and wou

[PATCH] D111655: [analyzer] non-obvious analyzer warning: Use of zero-allocated memory

NoQ added a comment. Yuck I forgot to forge commit author. Sorry!! Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2474-2475 auto R = std::make_unique( -*BT_UseZerroAllocated[*CheckKind], "Use of zero-allocated memory", N); +*BT_UseZerroAllo

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 379124. 0x1eaf added a comment. Updated the AST worker crash handler to avoid `std::string` copy: used a char pointer instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/

[PATCH] D111665: [CUDA] Provide address space conversion builtins.

tra created this revision. tra added a reviewer: jdoerfert. Herald added subscribers: bixia, yaxunl. tra requested review of this revision. Herald added a project: clang. CUDA-11 headers rely on these NVCC builtins. Despite having `__nv` previx, those are *not* provided by libdevice. Repository:

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. > Eh, I personally don't care all that much one way or the other (so sure, I > can do that!), but I recall there being a push to keep the "title" line under > something very small (50 chars?) because of the way tools sometimes display > this information to users,

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

wolfgangp added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109981/new/ https://reviews.llvm.org/D109981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

steakhal added a comment. I still need to chew through the code but on a high level, I think it looks correct. PS: the test coverage is outstanding! F19575968: unite-patch-line-coverage.zip Comment at: clang/lib/StaticAnalyzer/Core/RangeCo

[PATCH] D111582: [clang] Clear IR analyses before codegen pipeline

aeubanks updated this revision to Diff 379111. aeubanks added a comment. refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111582/new/ https://reviews.llvm.org/D111582 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib/CodeGen/Backe

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur added a comment. Thanks, this fixed the errors introduced in D105191 : http://meinersbur.de:8011/#/builders/1/builds/1594 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/ https://reviews.llvm.

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman added a comment. In D111041#3059054 , @carlosgalvezp wrote: > Thanks a lot for the review and the help! > > By the way, should we keep the [clang-tidy] header for the next commits? > Glancing at the commit history, I think it's much easier

[PATCH] D111655: [analyzer] non-obvious analyzer warning: Use of zero-allocated memory

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ec9d8501c9: [analyzer] Fix non-obvious analyzer warning: Use of zero-allocated memory. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] f3ec9d8 - [analyzer] Fix non-obvious analyzer warning: Use of zero-allocated memory.

Author: Artem Dergachev Date: 2021-10-12T10:41:00-07:00 New Revision: f3ec9d8501c91c22c1578470e638c74120f60667 URL: https://github.com/llvm/llvm-project/commit/f3ec9d8501c91c22c1578470e638c74120f60667 DIFF: https://github.com/llvm/llvm-project/commit/f3ec9d8501c91c22c1578470e638c74120f60667.dif

[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. It'd be nice to split out the move of `ReadModuleNames` into an NFC prep patch for a cleaner commit history before pushing, but up to you. Repository: rG LLVM Github Monorepo

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 379104. noajshu added a comment. Make cache dir parameter a Twine and avoid unnecessary copy in conversion to SmallString. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D11

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

kamaub updated this revision to Diff 379103. kamaub added a comment. Addressing review request to remove unnecessary testing line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.org/D111229 Files: clang/include/cl

[PATCH] D111570: [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cc42758a9d8: [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList (authored by thakis). Herald added a project: clang. Repository:

[clang] 2cc4275 - [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

Author: Nico Weber Date: 2021-10-12T13:29:19-04:00 New Revision: 2cc42758a9d89da7c726b78232dfba02314957a9 URL: https://github.com/llvm/llvm-project/commit/2cc42758a9d89da7c726b78232dfba02314957a9 DIFF: https://github.com/llvm/llvm-project/commit/2cc42758a9d89da7c726b78232dfba02314957a9.diff LO

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. I wonder if it would be more clear going forward to name this additional cache by its purpose, so it doesn't sound more general than it really is. As currently named, it might look lik

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

steakhal added inline comments. Comment at: clang/test/Analysis/initialization.c:101-102 + +const int glob_arr3[]; // Incomplete array declaration +const int glob_arr3[4] = {1, 2, 3}; // Incomplete Array redeclaration +void foo() { ASDenysPetrov wrot

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1619 + return true; +const SymExpr *LHS = Sym->getLHS(); +const llvm::APSInt &Zero = Comment at: clang/lib/StaticAnalyzer/Core/Ra

[PATCH] D111655: [analyzer] non-obvious analyzer warning: Use of zero-allocated memory

Quuxplusone added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2474-2475 auto R = std::make_unique( -*BT_UseZerroAllocated[*CheckKind], "Use of zero-allocated memory", N); +*BT_UseZerroAllocated[*CheckKind], +"Use o

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349 + // Allow specifying a few checks with a glob expression. + GlobList Globs(ChecksStr); + if (!Globs.contains(CheckName)) salman-javed

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 379097. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Addressed @salman-javed-nz comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/D111208 Files: clang-tools-extra/c

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 379095. noajshu added a comment. rebase against main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp l

[PATCH] D111655: [analyzer] non-obvious analyzer warning: Use of zero-allocated memory

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Can confirm, people were confused. I'll commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111655/new/ https://reviews.llvm.org/D111655 ___

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. Thanks a lot for the review and the help! By the way, should we keep the [clang-tidy] header for the next commits? Glancing at the commit history, I think it's much easier to see what the commit is updating, and probably can setup email filters to only receive not

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1661-1663 // Check if the containing array has an initialized value that we can trust. // We can trust a const value or a value of a global initializer in main(). +const

[PATCH] D111582: [clang] Clear IR analyses before codegen pipeline

dblaikie added a comment. Any chance of refactoring this code so naturally these objects are lexically scoped to their necessary lifetime, and just cease to exist before the code gen passes are run? (looks like this function is pretty long and might benefit from being broken up into pieces anyw

[clang] 57b40b5 - [AST, CodeGen, Driver] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2021-10-12T09:19:49-07:00 New Revision: 57b40b5f34383634949d1639e64a5c2acd0dc5f6 URL: https://github.com/llvm/llvm-project/commit/57b40b5f34383634949d1639e64a5c2acd0dc5f6 DIFF: https://github.com/llvm/llvm-project/commit/57b40b5f34383634949d1639e64a5c2acd0dc5f6.diff L

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:617 + // Find nvlink and pass it as "--nvlink-command=" argument of clang-nvlink-wrapper. + auto NvlinkBin = getToolChain().GetProgramPath("nvlink"); + const char *NvlinkPath = M

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGf56548829c4c: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/

[clang] f565488 - [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Author: Saiyedul Islam Date: 2021-10-12T16:15:52Z New Revision: f56548829c4c696d798c252bf097b71538bd45d7 URL: https://github.com/llvm/llvm-project/commit/f56548829c4c696d798c252bf097b71538bd45d7 DIFF: https://github.com/llvm/llvm-project/commit/f56548829c4c696d798c252bf097b71538bd45d7.diff LOG

[PATCH] D111655: [analyzer] non-obvious analyzer warning: Use of zero-allocated memory

chrisdangelo created this revision. chrisdangelo added a reviewer: NoQ. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. chrisdangelo requested review of this revision. Herald added

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, aaron.ballman, steakhal, martong, vsavchenko. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested review of thi

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1145 + CodeCompletionTUInfo CCTUInfo; + std::vector &ParamNames; + // For de-duplication only. StringRefs based on strings in ParamNames. kadircet wrote: > nit: Why not directl

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 379070. adamcz marked 3 inline comments as done. adamcz added a comment. next round of review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823 Files: clang-t

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1663 // We can trust a const value or a value of a global initializer in main(). -const VarDecl *VD = VR->getDecl(); +const VarDecl *VD = VR->getDecl()->getMostRecentDecl();

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:1378 +def : InstAlias<"vmornot.mm $vd, $vs2, $vs1", +(VMORN_MM VR:$vd, VR:$vs2, VR:$vs1), 0>; + Ugh, spec mandating aliases for the pre-ratified names... this is ju

  1   2   >