[PATCH] D112398: [RISCV] Add ABI testing for Float16.

rogfer01 added a comment. I'm curious about how we handle `_Float16` here. My understanding from the psabi and the Zfh draft

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 382932. linjamaki added a comment. Update for changes in D112404 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki updated this revision to Diff 382931. linjamaki marked an inline comment as done. linjamaki added a comment. Remove `--spirv-ext` and `--spirv-max-version`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.or

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

linjamaki added a comment. > Do I read it correctly that you would have no objections for others to rework > this patch if needed? :) Yes, anyone can work on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/ https://reviews.ll

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki marked an inline comment as done. linjamaki added inline comments. Comment at: clang/include/clang/Driver/Options.td:1534 +HelpText<"Specify maximum SPIR-V version which can be emitted">; +def spirv_ext_EQ : CommaJoined<["--"], "spirv-ext">, +HelpText<"Specify c

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit rG73453e7adecb: [clangd] Avoid expensive checks of buffer names in IncludeCleaner (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112652

[clang-tools-extra] 73453e7 - [clangd] Avoid expensive checks of buffer names in IncludeCleaner

Author: Sam McCall Date: 2021-10-28T08:00:57+02:00 New Revision: 73453e7adecbcc7208ceb70d5e55086ffbd1de3a URL: https://github.com/llvm/llvm-project/commit/73453e7adecbcc7208ceb70d5e55086ffbd1de3a DIFF: https://github.com/llvm/llvm-project/commit/73453e7adecbcc7208ceb70d5e55086ffbd1de3a.diff LO

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. Lambda capture semantics mean that extensions or inconsistencies in constexpr evaluation result in binary-compatibility issues. struct NonLit { NonLit(); }; template constexpr int foo() { return 42; T t; } extern int g(void *); i

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

weiwang added a comment. This issue has been blocking our internal module re-enablement for some time now, and we really appreciate any feedback. We also wonder if only `DeducedTemplateSpecializationType` is affected or it could also happen to other types. Repository: rG LLVM Github Monorep

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112652/new/ https://reviews.llvm.org/D112652 __

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15e3d39110fa: [clang] Fortify warning for scanf calls with field width too big. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833

[clang] 15e3d39 - [clang] Fortify warning for scanf calls with field width too big.

Author: Michael Benfield Date: 2021-10-28T02:52:03Z New Revision: 15e3d39110fa4449be4f56196af3bc81b623f3ab URL: https://github.com/llvm/llvm-project/commit/15e3d39110fa4449be4f56196af3bc81b623f3ab DIFF: https://github.com/llvm/llvm-project/commit/15e3d39110fa4449be4f56196af3bc81b623f3ab.diff L

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea2431d3f10: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support… (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 6ea2431 - [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

Author: Kai Luo Date: 2021-10-28T02:18:43Z New Revision: 6ea2431d3f109aefa31cd4d520cc234a5aa5484a URL: https://github.com/llvm/llvm-project/commit/6ea2431d3f109aefa31cd4d520cc234a5aa5484a DIFF: https://github.com/llvm/llvm-project/commit/6ea2431d3f109aefa31cd4d520cc234a5aa5484a.diff LOG: [clan

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel updated this revision to Diff 382884. housel added a comment. Added additional comments to `CFI_Parser::decodeFDE`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111863/new/ https://reviews.llvm.org/D111863 Files: libunwind/src/DwarfParse

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf6fa6ef1c2: [OpenMP] Declare variants for templates need to match # template args (authored by jdoerfert). Repository: rG LLVM Github Monorepo

[clang] 6cf6fa6 - [OpenMP] Declare variants for templates need to match # template args

Author: Johannes Doerfert Date: 2021-10-27T21:04:32-05:00 New Revision: 6cf6fa6ef1c28de0d553a38defa719342774f104 URL: https://github.com/llvm/llvm-project/commit/6cf6fa6ef1c28de0d553a38defa719342774f104 DIFF: https://github.com/llvm/llvm-project/commit/6cf6fa6ef1c28de0d553a38defa719342774f104.d

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:112 return 0; - assert(RVVVectorBitsMax >= 128 && RVVVectorBitsMax <= 65536 && + assert(RVVVectorBitsMax >= 32 && RVVVectorBitsMax <= 65536 && isPowerOf2_32(RVVVectorBitsMax) && ---

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382880. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382879. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D112682: [openmp][nfc] Subset of D112680

JonChesterfield added a comment. Change takes the bulk of EmitNVPTXDevicePrintfCallExpr into a helper function, and adjusts it to also return the size of the alloca for use in D112680 . NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D112682: [openmp][nfc] Subset of D112680, landing would clean up diff

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992, jhuber6, ye-luo, ronlieb, pdhaliwal. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a pro

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. New runtime failing CI suggests it may take some iteration to land, so reworked this to make sense with or without it. Doesn't make much difference to nvptx - printf still ultimately resolves to the same vprintf function as before - but a lot of tests that were

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 382873. JonChesterfield added a comment. - rebase to not require new runtime, stubs now return error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files:

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a reviewer: ronlieb. JonChesterfield added a comment. Tagging Ron as this is current stuck on the mystery of passing locally and failing CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D1

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Makes more sense with D112227 landed, but probably worthwhile just for the old runtime as it removes the link failure from all the tests that use printf. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:94 +std

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992, jhuber6, ye-luo, ronlieb, pdhaliwal. Herald added subscribers: asavonic, kerbowa, guansong, tpr, yaxunl, mgorny, nhaehnle, jvesely. JonChesterfield requested review of this revision. Herald added su

Maintenance works at llvm lab today

Hello everyone, LLVM lab and build bot will be unavailable for about 3 hours starting from 6:00 PM PST today for lab maintenance work. Thank you for understanding. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382866. JonChesterfield added a comment. - fix new+old test enabling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDG

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382864. JonChesterfield added a comment. - Reintroduce syncThreadsAligned, dropped in git merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:196 -void syncThreadsAligned() { syncThreads(); } - -void fenceTeam(int Ordering) { __builtin_amdgcn_fence(Ordering, "workgroup"); } - -void fenceKernel(int Ordering) { __bu

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

eugenis added inline comments. Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93 + bool invalidate(Module &, const PreservedAnalyses &, + ModuleAnalysisManager::Invalidator &) { +return false; vitalybuka wrote: > vitalybuka wro

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/APValue.cpp:133 +void APValue::LValueBase::setNoCFIValue(bool NoCFI) { + if (is()) { +Local.NoCFIValue = NoCFI; Remove braces

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield reopened this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Didn't fare very well under CI, investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.

[clang] 6c7b203 - Revert "[libomptarget] Build DeviceRTL for amdgpu"

Author: Jon Chesterfield Date: 2021-10-28T01:01:53+01:00 New Revision: 6c7b203d1d7000269215ab5b3d329ab03dc85e42 URL: https://github.com/llvm/llvm-project/commit/6c7b203d1d7000269215ab5b3d329ab03dc85e42 DIFF: https://github.com/llvm/llvm-project/commit/6c7b203d1d7000269215ab5b3d329ab03dc85e42.di

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7e089f2d6a5: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed (authored by ardb, committed by nickdesaulniers). Repository:

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG33427fdb7b52: [libomptarget] Build DeviceRTL for amdgpu (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D112227?vs=382446&id=382853#toc Repository: rG LLVM Github Mon

[clang] 33427fd - [libomptarget] Build DeviceRTL for amdgpu

Author: Jon Chesterfield Date: 2021-10-28T00:41:45+01:00 New Revision: 33427fdb7b52b79ce5e25b7e14e0f1a44d876bd2 URL: https://github.com/llvm/llvm-project/commit/33427fdb7b52b79ce5e25b7e14e0f1a44d876bd2 DIFF: https://github.com/llvm/llvm-project/commit/33427fdb7b52b79ce5e25b7e14e0f1a44d876bd2.di

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

nickdesaulniers added a comment. In D112600#3091959 , @ardb wrote: > Thanks all. Could someone with commit access please merge this? Thanks. Sure thing; I'll pick it up. Thanks again for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

ardb added a comment. Thanks all. Could someone with commit access please merge this? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112600/new/ https://reviews.llvm.org/D112600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. A different "ouch" (and, yes, this is a regression from this patch): auto f = [](bool b) { if (b) return 42; static int x = 0; return x; }; constexpr int x = f(true); const int *p = &x; Generates no diagnostics with this patch even with

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield updated this revision to Diff 382845. mbenfield added a comment. const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833/new/ https://reviews.llvm.org/D111833 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 382823. ASDenysPetrov added a comment. Added doc comment to `getSValFromStringLiteral` function. Fixed minor code defects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 Files: clang/lib/StaticAna

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield updated this revision to Diff 382840. mbenfield added a comment. fix function_ref use-after-free Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833/new/ https://reviews.llvm.org/D111833 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

ardb updated this revision to Diff 382839. ardb added a comment. Add another test suggested by Nick. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112600/new/ https://reviews.llvm.org/D112600 Files: llvm/lib/Target/ARM/ARMInstrThumb.td llvm/lib/Target/ARM/ARMInstrThumb2.td llvm/t

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/MinGW.h:63 + static void FixTripleArch(const Driver &D, llvm::Triple &Triple, +const llvm::opt::ArgList &Args); Use `functionName` for newer functions. (It's unf

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:96 +static cl::opt SkipRaxSetup( +"x86-skip-rax-setup", cl::init(false), MaskRay wrote: > nickdesaulniers wrote: > > If it's a command line option rather than encoded

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Cool, if you wouldn't mind additional extending this patch to cover the intrinsic that the front end also generates, this LGTM: diff --git a/llvm/test/CodeGen/ARM/thread_po

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. Agreed. If after semantic analysis for a declaration we can check declaration's typeloc chain again, we might be able to give proper warnings. I am happy to implement this as a followup as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format))

This revision was automatically updated to reflect the committed changes. Closed by commit rGd378a0febc7e: [Sema] Recognize format argument indicated by format attribute inside blocks (authored by fcloutier). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] d378a0f - [Sema] Recognize format argument indicated by format attribute inside blocks

Author: Félix Cloutier Date: 2021-10-27T15:48:35-07:00 New Revision: d378a0febc7e13aae7853b2e8733626f61140e55 URL: https://github.com/llvm/llvm-project/commit/d378a0febc7e13aae7853b2e8733626f61140e55 DIFF: https://github.com/llvm/llvm-project/commit/d378a0febc7e13aae7853b2e8733626f61140e55.diff

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

ardb updated this revision to Diff 382826. ardb added a comment. Drop new Clang CodeGen test, and add the Thumb2 check to an existing backend test instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112600/new/ https://reviews.llvm.org/D112600 Files: llvm/lib/Target/ARM/ARMInstrT

[PATCH] D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface

fcloutier created this revision. fcloutier added reviewers: doug.gregor, dcoughlin, rsmith, NoQ, ahatanak. fcloutier added a project: clang. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. It has come to my attention that

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

cycheng updated this revision to Diff 382816. cycheng added a comment. previous update was using wrong file, sorry!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112110/new/ https://reviews.llvm.org/D112110 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaOpenCL/invalid-types.cl

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

cycheng updated this revision to Diff 382813. cycheng marked 2 inline comments as done. cycheng added a comment. - Remove OpenCL 2.0 description - Merge test files into single test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112110/new/ https://reviews.llvm.org/D112110 Files:

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

craig.topper added a comment. I think the concept seems good to me. I'd like @aaron.ballman to review the attribute code. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610 unsigned NF = 1; constexpr unsigned TAIL_UNDISTURBED = 0; + constexpr unsigned TAIL_AGNOSTIC = 0b0

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/arm-tphard.c:10 +} + ardb wrote: > nickdesaulniers wrote: > > Let's make this a test under llvm/test/CodeGen/, using IR: > > ``` > > ; RUN: llc --mtriple=armv7-linux-gnueabihf -o - %s | FileChe

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:3193 +def mskip_rax_setup : Flag<["-"], "mskip-rax-setup">, Group, Flags<[NoXarchOption]>, + HelpText<"Skip setting up RAX register when passing variable arguments (x86 only)">; def mstackrealign

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

rsmith added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:70 llvm::Expected - getSymbolAddress(llvm::StringRef UnmangledName) const; + getSymbolAddress(llvm::StringRef Name, bool IsMangled = false) const; }; I find this flag na

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/ https://reviews.llvm.org/D112349 __

[libunwind] 3e39bbf - [libunwind] Simplify the executor used in the tests

Author: Louis Dionne Date: 2021-10-27T17:30:07-04:00 New Revision: 3e39bbf5f9614327bb09d6527db8b40fc472fedf URL: https://github.com/llvm/llvm-project/commit/3e39bbf5f9614327bb09d6527db8b40fc472fedf DIFF: https://github.com/llvm/llvm-project/commit/3e39bbf5f9614327bb09d6527db8b40fc472fedf.diff

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

ardb added inline comments. Comment at: clang/test/CodeGen/arm-tphard.c:10 +} + nickdesaulniers wrote: > Let's make this a test under llvm/test/CodeGen/, using IR: > ``` > ; RUN: llc --mtriple=armv7-linux-gnueabihf -o - %s | FileCheck %s > ; RUN: llc --mtriple=th

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

Wirena created this revision. Wirena added a reviewer: HazardyKnusperkeks. Wirena requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112664 Files: clang/docs/ClangFormatStyleO

[PATCH] D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format))

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112569/new/ https://reviews.llvm.org/D112569 ___

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield updated this revision to Diff 382802. mbenfield added a comment. rebase and rerun tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833/new/ https://reviews.llvm.org/D111833 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

mstorsjo updated this revision to Diff 382801. mstorsjo added a comment. Rebased after renaming `SysrootName` to `SubdirName`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111952/new/ https://reviews.llvm.org/D111952 Files: clang/lib/Driver/Dri

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

mstorsjo updated this revision to Diff 382798. mstorsjo added a comment. Renamed the variable to `SubdirName`. Will push tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112387/new/ https://reviews.llvm.org/D112387 Files: clang/lib/Driver

[PATCH] D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format))

fcloutier updated this revision to Diff 382788. fcloutier added a reviewer: ahatanak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112569/new/ https://reviews.llvm.org/D112569 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/format-string

[PATCH] D112659: Add a limit to __make_integer_seq builtin.

rsmith added a comment. I wonder if more generally we should have a limit on either the size of a pack or the number of template arguments in a template specialization, rather than limiting only `__make_integer_seq`? I think a hand-rolled `make_integer_sequence` implementation should also be li

[PATCH] D110210: [clang] NFC: include non friendly types and missing sugar in test expectations

This revision was automatically updated to reflect the committed changes. Closed by commit rG086e111216bc: [clang] NFC: include non friendly types and missing sugar in test expectations (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 086e111 - [clang] NFC: include non friendly types and missing sugar in test expectations

Author: Matheus Izvekov Date: 2021-10-27T23:03:29+02:00 New Revision: 086e111216bc4fb8065aa7ef4bc226380d1c237e URL: https://github.com/llvm/llvm-project/commit/086e111216bc4fb8065aa7ef4bc226380d1c237e DIFF: https://github.com/llvm/llvm-project/commit/086e111216bc4fb8065aa7ef4bc226380d1c237e.dif

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, sgraenitz, lhames, thakis. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. Repository: rC Clang https://reviews.llvm.org/D112663 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

sammccall updated this revision to Diff 382779. sammccall added a comment. Add more docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112652/new/ https://reviews.llvm.org/D112652 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d7fba5f95f0: [clang] deprecate frelaxed-template-template-args, make it on by default (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 2d7fba5 - [clang] deprecate frelaxed-template-template-args, make it on by default

Author: Matheus Izvekov Date: 2021-10-27T22:48:27+02:00 New Revision: 2d7fba5f95f0614f6f2c4a4ed966b307d617898b URL: https://github.com/llvm/llvm-project/commit/2d7fba5f95f0614f6f2c4a4ed966b307d617898b DIFF: https://github.com/llvm/llvm-project/commit/2d7fba5f95f0614f6f2c4a4ed966b307d617898b.dif

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

rsmith added inline comments. Herald added a subscriber: carlosgalvezp. Comment at: clang/include/clang/AST/Type.h:4968 QualType getDeducedType() const { -return !isCanonicalUnqualified() ? getCanonicalTypeInternal() : QualType(); +return DeducedAsType.isNull() ? QualT

[PATCH] D112633: [AST] fail rather than crash when const evaluating invalid c++ foreach

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGde7494a33a5c: [AST] fail rather than crash when const evaluating invalid c++ foreach (authored by sammccall). Changed prior to commit: https://reviews.llvm.or

[clang] de7494a - [AST] fail rather than crash when const evaluating invalid c++ foreach

Author: Sam McCall Date: 2021-10-27T22:45:32+02:00 New Revision: de7494a33a5c3152dd0ed24ea1c8b2760255f2f7 URL: https://github.com/llvm/llvm-project/commit/de7494a33a5c3152dd0ed24ea1c8b2760255f2f7 DIFF: https://github.com/llvm/llvm-project/commit/de7494a33a5c3152dd0ed24ea1c8b2760255f2f7.diff LO

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:261 +if (!FE) { + assert(isSpecialBuffer(FID, SM)); + continue; kbobyrev wrote: > kbobyrev wrote: > > Implementation-wise, this seems like the right place to dr

[PATCH] D112659: Add a limit to __make_integer_seq builtin.

erichkeane added a subscriber: ldionne. erichkeane added a comment. Some additional data on a release build (on my quite recent Xeon 8260M): 2^24: 27 sec, ~3.3GB 2^25: 49 sec, ~6.4GB It follows a pretty linear pattern from there. I'm open to choosing a different limit if we find one more reaso

[PATCH] D112661: [clangd] reuse preambles from other files when possible

qchateau added a comment. This is a revisit of D97417 which is a bit out of date and fell into oblivion. I've been using a forked version of clangd including this change for months on my day-to-day work and it does significantly improve my experience. Some numbe

[PATCH] D112661: [clangd] reuse preambles from other files when possible

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Keep a s

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. @joerg Any further thoughts on this? I'm happy for it to go in as-is -- we can always make the implementation of `__unw_add_dynamic_eh_frame_section` / `__unw_remove_dynamic_eh_frame_section` later, but the API looks good to me, and I think this is a strict improvement

[PATCH] D112659: Add a limit to __make_integer_seq builtin.

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, majnemer, EricWF. Herald added subscribers: dexonsmith, dang. erichkeane requested review of this revision. As brought up in PR48246, passing a large value to `__make_integer_seq` results in the compiler getting stuck in

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

kbobyrev added a comment. Thank you for taking care of this! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:261 +if (!FE) { + assert(isSpecialBuffer(FID, SM)); + continue; Implementation-wise, this seems like the right place to drop nonex

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov updated this revision to Diff 382762. mizvekov added a comment. rebase, one last CI run. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109496/new/ https://reviews.llvm.org/D109496 Files: clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D111986: [Clang] Add elementwise abs builtin.

This revision was automatically updated to reflect the committed changes. Closed by commit rG01870d51b848: [Clang] Add elementwise abs builtin. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111986/new/ https://reviews.llvm.org/D

[clang] 01870d5 - [Clang] Add elementwise abs builtin.

Author: Florian Hahn Date: 2021-10-27T21:01:44+01:00 New Revision: 01870d51b848166eee59ed2e77be0199a561cf59 URL: https://github.com/llvm/llvm-project/commit/01870d51b848166eee59ed2e77be0199a561cf59 DIFF: https://github.com/llvm/llvm-project/commit/01870d51b848166eee59ed2e77be0199a561cf59.diff

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

ymandel added a comment. I'm not really familiar w/ this code. But, if njames93 doesn't respond, then I'll give it a go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112647/new/ https://reviews.llvm.org/D112647 __

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

avogelsgesang added a reviewer: alexfh. avogelsgesang added a subscriber: alexfh. avogelsgesang added a comment. not sure whom to add as a reviewer. According to `git log` this check wasn't changed for a while... Adding @alexfh based on `CODE_OWNERS.TXT` Repository: rG LLVM Github Monorepo

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added a comment. I'm gonna add docs to `getSValFromStringLiteral` and update the patch. And of course will fix your nits. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + //

[clang] 101aaf6 - Revert "[NFC] `IRBuilderBase::CreateAdd()`: place constant onto RHS"

Author: Roman Lebedev Date: 2021-10-27T22:21:37+03:00 New Revision: 101aaf62efef1ee55e0bc9fa78a83d8a4c6fcee6 URL: https://github.com/llvm/llvm-project/commit/101aaf62efef1ee55e0bc9fa78a83d8a4c6fcee6 DIFF: https://github.com/llvm/llvm-project/commit/101aaf62efef1ee55e0bc9fa78a83d8a4c6fcee6.diff

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This changes the ha

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang added reviewers: ymandel, njames93. avogelsgesang added a comment. Adding reviewers based on `git log` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112647/new/ https://reviews.llvm.org/D112647 ___

[PATCH] D112504: [OpenMP] Wrap (v)printf in the new RT and use same handling for AMD

JonChesterfield updated this revision to Diff 382747. JonChesterfield added a comment. -rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112504/new/ https://reviews.llvm.org/D112504 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

avogelsgesang created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. avogelsgesang requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This commit improves the fix-its of `modernize-pass-by-value` in two ways: 1

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

igor.kirillov added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5370 if (CGM.getCodeGenOpts().OptimizationLevel != 0) Fn->addFnAttr(llvm::Attribute::AlwaysInline); return Fn; I noticed that here we set this attribute on the same fun

[PATCH] D112633: [AST] fail rather than crash when const evaluating invalid c++ foreach

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/constexpr-function-recovery-crash.cpp:73 + +struct X { int a; } array[] = {{undef()}}; // expected-error {{use of undeclared identifier 'u

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang updated this revision to Diff 382741. avogelsgesang added a comment. Remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112647/new/ https://reviews.llvm.org/D112647 Files: clang-tools-extra/clang-apply-replaceme

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang created this revision. Herald added a subscriber: carlosgalvezp. avogelsgesang requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The fixes from the YAML file can refer to relative paths. Those relative paths are mean

  1   2   3   >