rjmccall added a comment.
Seems like a good idea to me. Minor request; otherwise, feel free to commit.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1438
+// Add it here so that it runs prior to the BC/LL emission pass
+MPM.addPass(VerifierPass());
+
T
dblaikie added a comment.
I guess CodeGenOpts::VerifyModule is on by default, but I'll admit that
surprises me - for API-built modules, I figured it was expected they were valid
by construction (ie: like an assertion - it's a bug in clang if the resulting
module isn't valid - so we wouldn't wan
brad created this revision.
brad added reviewers: dcederman, LemonBoy, jyknight.
brad added a project: clang.
Herald added subscribers: jrtc27, fedor.sergeev.
brad requested review of this revision.
Disable SjLj lowering.
The builtin SjLj support has been removed.
https://reviews.llvm.org/rG0c05
atmnpatel created this revision.
atmnpatel added reviewers: jdoerfert, tianshilei1992, JonChesterfield.
Herald added subscribers: ormris, dexonsmith, pengfei, hiraditya, mgorny.
atmnpatel requested review of this revision.
Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan
Author: Yonghong Song
Date: 2021-11-06T18:19:00-07:00
New Revision: bbab17c6c987d7a6612855c02a4e8988dac0dc17
URL:
https://github.com/llvm/llvm-project/commit/bbab17c6c987d7a6612855c02a4e8988dac0dc17
DIFF:
https://github.com/llvm/llvm-project/commit/bbab17c6c987d7a6612855c02a4e8988dac0dc17.diff
On 11/6/21 4:36 PM, Nathan Chancellor via Phabricator wrote:
nathanchance added a comment.
I bisected a crash in the Linux kernel down to the reland commit (and it is not
fixed as of
https://github.com/llvm/llvm-project/commit/2249ecee8d9a6237f51485bd39f01ba031575987):
$ git bisect log
nathanchance added a comment.
I bisected a crash in the Linux kernel down to the reland commit (and it is not
fixed as of
https://github.com/llvm/llvm-project/commit/2249ecee8d9a6237f51485bd39f01ba031575987):
$ git bisect log
# bad: [bdaa181007a46d317a1665acb8234eddeee82815] [TwoAddressInst
ibookstein updated this revision to Diff 385298.
ibookstein added a comment.
clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113352/new/
https://reviews.llvm.org/D113352
Files:
clang/lib/CodeGen/BackendUtil.cpp
Index: clang/lib/Code
ibookstein created this revision.
ibookstein added reviewers: dblaikie, rjmccall.
Herald added a subscriber: ormris.
ibookstein requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Previously, the Backend_Emit{Nothing,BC,LL} modes did
not run th
carlosgalvezp updated this revision to Diff 385286.
carlosgalvezp added a comment.
Update release notes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113249/new/
https://reviews.llvm.org/D113249
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/include/clang/Basic/Cuda.h
c
carlosgalvezp added a comment.
> - The driver needs to enable ptx75 when it constructs cc1 command line in
> clang/lib/Driver/ToolChains/Cuda.cpp
@tra Haven't I already done it in line 712? Or where should I enable it?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113249/new/
https://
carlosgalvezp updated this revision to Diff 385284.
carlosgalvezp added a comment.
Updated BuilintsNVPTX.def
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113249/new/
https://reviews.llvm.org/D113249
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/include/clang/Basic/Cuda.
NeHuang updated this revision to Diff 385282.
NeHuang marked 3 inline comments as done.
NeHuang added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111434/new/
https://reviews.llvm.org/D111434
Files:
llvm/lib/T
RKSimon added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14563
-if (isa(Order)) {
- int ord = cast(Order)->getZExtValue();
+switch (BuiltinID) {
+case AMDGPU::BI__builtin_amdgcn_atomic_inc32:
@saiislam @arsenm Coverity is warn
asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
This seems to match the emerging consensus in the various RISC-V GitHub issue
threads and as you point out, is needed to support extensions in the 1.0 V
spec. Looks good to me - thanks!
=
eopXD marked an inline comment as done.
eopXD added inline comments.
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c:3
// REQUIRES: riscv-registered-target
-// RUN: %clang_cc1 -triple riscv64 -target-feature +experimental-v
-disable-O0-optnone -emit-llvm
eopXD updated this revision to Diff 385278.
eopXD added a comment.
Update code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112613/new/
https://reviews.llvm.org/D112613
Files:
clang/utils/TableGen/RISCVVEmitter.cpp
Index: clang/utils/TableGe
eopXD updated this revision to Diff 385277.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113336/new/
https://reviews.llvm.org/D113336
Files:
clang/lib/Basic/Targets/RISCV.cpp
llvm/include/llvm/Support/RISCVISAIn
eopXD updated this revision to Diff 385276.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112613/new/
https://reviews.llvm.org/D112613
Files:
clang/lib/Basic/Targets/RISCV.cpp
clang/utils/TableGen/RISCVVEmitter.c
eopXD updated this revision to Diff 385275.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113336/new/
https://reviews.llvm.org/D113336
Files:
clang/lib/Basic/Targets/RISCV.cpp
llvm/include/llvm/Support/RISCVISAIn
Author: hyeongyu kim
Date: 2021-11-06T19:58:34+09:00
New Revision: 63fff0f5bffe20fa2c84a45a41161afa0043cb34
URL:
https://github.com/llvm/llvm-project/commit/63fff0f5bffe20fa2c84a45a41161afa0043cb34
DIFF:
https://github.com/llvm/llvm-project/commit/63fff0f5bffe20fa2c84a45a41161afa0043cb34.diff
eopXD updated this revision to Diff 385258.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113336/new/
https://reviews.llvm.org/D113336
Files:
clang/lib/Basic/Targets/RISCV.cpp
llvm/include/llvm/Support/RISCVISAIn
eopXD updated this revision to Diff 385256.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113336/new/
https://reviews.llvm.org/D113336
Files:
clang/lib/Basic/Targets/RISCV.cpp
llvm/include/llvm/Support/RISCVISAIn
HazardyKnusperkeks updated this revision to Diff 385248.
HazardyKnusperkeks marked an inline comment as done.
HazardyKnusperkeks added a reviewer: owenpan.
HazardyKnusperkeks added a comment.
Dropped braces.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
eopXD added inline comments.
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c:3
// REQUIRES: riscv-registered-target
-// RUN: %clang_cc1 -triple riscv64 -target-feature +experimental-v
-disable-O0-optnone -emit-llvm %s -o - | opt -S -mem2reg | FileCheck
-
eopXD created this revision.
eopXD added a reviewer: craig.topper.
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence,
vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton,
Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb5aef90d4656: [Clang] Fix instantiation of OpaqueValueExprs
(Bug #45964) (authored by ricejasonf, committed by tambre).
R
Author: Jason Rice
Date: 2021-11-06T10:06:38+02:00
New Revision: b5aef90d4656c5188759d03e2c5c3dc3d8bb398b
URL:
https://github.com/llvm/llvm-project/commit/b5aef90d4656c5188759d03e2c5c3dc3d8bb398b
DIFF:
https://github.com/llvm/llvm-project/commit/b5aef90d4656c5188759d03e2c5c3dc3d8bb398b.diff
LO
28 matches
Mail list logo
