[PATCH] D112626: Convert float to double on __builtin_dump_struct

rafaelfranco created this revision. rafaelfranco published this revision for review. rafaelfranco added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This seems to fix the problem. Feedback etc. more than welcome :) Variadic arguments of float type are automat

[PATCH] D112626: Convert float to double on __builtin_dump_struct

rafaelfranco added a comment. I have added John McCall to the reviewers as the CODE_OWNERS.txt file says he's responsible for LLVM IR generation. Also Aaron Ballman, as he wrote the function per git-blame output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

MyDeveloperDay updated this revision to Diff 388696. MyDeveloperDay added a comment. Upodate to include all comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114142/new/ https://reviews.llvm.org/D114142 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTe

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

salman-javed-nz updated this revision to Diff 388699. salman-javed-nz edited the summary of this revision. salman-javed-nz added a comment. Back out the "replace invalid characters in an identifier with underscores" feature. Making this feature work with Unicode characters on different operating

[PATCH] D114149: [clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"

salman-javed-nz marked 4 inline comments as done. salman-javed-nz added a comment. I reverted my changes to do with the invalid character substitution. Doing something akin to `isAllowedInitiallyIDChar()` and `isAllowedIDChar()` in Lexer.cpp will require converting from `char*` to `UTF32*`. Wind

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp created this revision. carlosgalvezp added a reviewer: aaron.ballman. Herald added subscribers: jeroen.dobbelaere, kbarton, xazax.hun, nemanjai. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Find "p

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3143534 , @danalbert wrote: > Nice, that's a lot of code cleaned up! LGTM, but probably should wait for > someone from Apple to weigh in. I think the new formatting for those error > messages is better for them t

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added inline comments. Comment at: clang/test/Sema/attr-availability-android.c:8 #ifdef WARN_PARTIAL -// expected-note-re@+2 {{'f3' has been marked as being introduced in Android 19 here, but the deployment target is Android 16.0.0{{$ +// expected-note-re@+2 {{

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

collares added a comment. In https://bugzilla.mozilla.org/show_bug.cgi?id=1741454, oxalica discovered this breaks jemalloc-using code, since jemalloc does not guarantee 16-byte alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna created this revision. jessesna added a reviewer: klimek. jessesna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend AllowShortBlocksOnASingleLine for else blocks. See https://bugs.llvm.org/show_bug.cgi?id=49722 Repository:

[PATCH] D114212: [clang-tidy] performance-unnecessary-copy-initialization: Correctly match the type name of the thisPointertype.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfefe20b99313: [clang-tidy] performance-unnecessary-copy-initialization: Correctly match the… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang-tools-extra] fefe20b - [clang-tidy] performance-unnecessary-copy-initialization: Correctly match the type name of the thisPointertype.

Author: Felix Berger Date: 2021-11-20T15:13:41-05:00 New Revision: fefe20b99313d6b0738806d1504652c3b7edb9e0 URL: https://github.com/llvm/llvm-project/commit/fefe20b99313d6b0738806d1504652c3b7edb9e0 DIFF: https://github.com/llvm/llvm-project/commit/fefe20b99313d6b0738806d1504652c3b7edb9e0.diff

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 added a comment. In D100879#3144751 , @collares wrote: > In https://bugzilla.mozilla.org/show_bug.cgi?id=1741454, oxalica discovered > this breaks jemalloc-using code, since jemalloc does not guarantee 16-byte > alignment. Not sure if jemalloc

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

adamdb5 created this revision. Herald added a subscriber: pengfei. adamdb5 retitled this revision from "Whilst working on a project which uses the x86 CPUID instruction, I noticed the header provided by clang (cpuid.h), is missing some bit masks for the feature registers." to "Add missing CPUID b

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca created this revision. mojca added a reviewer: carlosgalvezp. mojca added a project: clang. Herald added subscribers: usaxena95, kadircet, yaxunl. mojca requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. I've been trying to address the following issue in

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

owenpan accepted this revision. owenpan added a comment. LGTM, though I'd like to see a test case for `* //`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114142/new/ https://reviews.llvm.org/D114142 ___ cfe-commits mailing list cfe-commits@

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

collares added a comment. Reproducing oxalica's comment at https://github.com/NixOS/nixpkgs/pull/146817, to make sure it is not missed: "The divergence here is about how to understand the sentence from C17, 7.22.3. There is already an proposal rephrasing it and making it clear that 8-byte allo

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

pcc added a comment. Agreed that this should probably be done in the mangler, I'll try to take a look next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 __

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. Great, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 added a comment. Just curious, did you try firefox with malloc? (If you care about the best performance). “ It also mentions that forcing jemalloc to have 16-byte alignment will significantly slow down its performance.” It would be interesting to see real world data, like firefox benc

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

craig.topper added inline comments. Comment at: clang/lib/Headers/cpuid.h:76 /* Features in %ecx for leaf 1 */ -#define bit_SSE30x0001 -#define bit_PCLMULQDQ 0x0002 -#define bit_PCLMUL bit_PCLMULQDQ /* for gcc compat */ -#define bit_DTES64 0x000