[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e8658b19c05: [clang][AST] Check context of record in structural equivalence. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/ne

[clang] 8e8658b - [clang][AST] Check context of record in structural equivalence.

Author: Balázs Kéri Date: 2021-11-26T08:54:34+01:00 New Revision: 8e8658b19c057a48264514483f188bf7b6c2db7d URL: https://github.com/llvm/llvm-project/commit/8e8658b19c057a48264514483f188bf7b6c2db7d DIFF: https://github.com/llvm/llvm-project/commit/8e8658b19c057a48264514483f188bf7b6c2db7d.diff L

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389924. lh123 added a comment. rename `TTP` to `TAT`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cl

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389921. lh123 added a comment. handle `TypeAliasTemplateDecl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 389922. void added a comment. WIP: Implement zeroing out registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/in

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. Ping. I'm a bit stuck with this submission, any help or pointers on how to proceed (i.e. how to fix the pre-merge tests) would be much appreciated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 __

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389915. lh123 retitled this revision from "[clangd] Add canonical type to hover" to "[clangd] Add desugared type to hover". lh123 edited the summary of this revision. lh123 added a comment. 1. rename `CanType` to `DesugaredTy`. 2. fix some bug in compare `Print

[PATCH] D114162: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:385 - if (!HasX87) { -if (LongDoubleFormat == &llvm::APFloat::x87DoubleExtended()) - HasLongDouble = false; -if (getTriple().getArch() == llvm::Triple::x86) - HasFPReturn = false; - }

[PATCH] D114162: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits

pengfei updated this revision to Diff 389914. pengfei added a comment. Emit diagnostic for long double for i386 target too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114162/new/ https://reviews.llvm.org/D114162 Files: clang/lib/Basic/Targets

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389911. lh123 added a comment. fix some bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hove

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389909. lh123 added a comment. Herald added a project: clang. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.c

[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

vsapsai abandoned this revision. vsapsai added a comment. After more investigation and comparing different entities (like structs, enums) this approach seems to be too involved and probably wrong. A better choice seems to be following the same direction as in ⦗Modules⦘ Implement ODR-like semant

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 389890. lichray added a comment. Ping. Please review. - Reformat code after clang-format lands D114519 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://revi

[PATCH] D114615: Increase the number of driver diagnostics

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're close to hitting the limited number of driver diagnostics, increase `DIAG_SIZE_DRIVER` to accommodate more. Repository: rG LLVM Github Monor

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks, it looks good to me. Most of my comments are just brainstorming, exploring alternative ideas. Feel free to ignore some/all of them. Comment at: clang/include/c

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. @tstellar I totally missed your fast reply, sorry about that! I have just forwarded the mail chain to the indicated address. Let me know if there's anything else I can do to help. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

mstorsjo added a comment. Looks reasonable I think. Is this a deficiency in the EHABI implementation only, i.e. this aspect works as it should in the regular dwarf implementation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109856/new/ https://reviews.llvm.org/D109856 __

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

ldionne added a comment. Please rebase onto `main` and re-upload before submitting, so that the CI runs. There was a flaky failure previously, but I'd like to see it run before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ htt

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. I guess this is ok then. I can't say I've followed every bit in detail, but it looks sensible overall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5162b558d8c0: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES

[clang] 5162b55 - [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

Author: Zarko Todorovski Date: 2021-11-25T16:21:06-05:00 New Revision: 5162b558d8c0b542e752b037e72a69d5fd51eb1e URL: https://github.com/llvm/llvm-project/commit/5162b558d8c0b542e752b037e72a69d5fd51eb1e DIFF: https://github.com/llvm/llvm-project/commit/5162b558d8c0b542e752b037e72a69d5fd51eb1e.di

[PATCH] D114090: [NFC] Inclusive language: rename master flag to main flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGb11c66accfb1: [NFC] Inclusive language: rename master flag to main flag (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114090/new/ http

[clang] b11c66a - [NFC] Inclusive language: rename master flag to main flag

Author: Quinn Pham Date: 2021-11-25T15:16:11-06:00 New Revision: b11c66accfb1d78324278072ed0069d3bbe835cd URL: https://github.com/llvm/llvm-project/commit/b11c66accfb1d78324278072ed0069d3bbe835cd DIFF: https://github.com/llvm/llvm-project/commit/b11c66accfb1d78324278072ed0069d3bbe835cd.diff LO

[PATCH] D114583: [clang-format] Adjust braced list detection

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. That will be a pain in the ass to merge with my current changes, but looks good. In D114583#3153780 , @curdeius wrote

[libunwind] ebfeeec - [libunwind] Fix testing with sanitizers enabled

Author: Louis Dionne Date: 2021-11-25T15:28:17-05:00 New Revision: ebfeeec4c4bcc4373e5d5dfaff7ee75959a7c931 URL: https://github.com/llvm/llvm-project/commit/ebfeeec4c4bcc4373e5d5dfaff7ee75959a7c931 DIFF: https://github.com/llvm/llvm-project/commit/ebfeeec4c4bcc4373e5d5dfaff7ee75959a7c931.diff

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

quinnp accepted this revision. quinnp added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114029/new/ https://reviews.llvm.org/D114029 ___

[PATCH] D114381: [AIX] Disable unsupported offloading gpu tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG0796869e4e1e: [AIX] Disable unsupported offloading gpu tests (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114381/new/ https://revi

[clang] 0796869 - [AIX] Disable unsupported offloading gpu tests

Author: Jake Egan Date: 2021-11-25T15:10:51-05:00 New Revision: 0796869e4e1e517a0f77f8e84d94e1e3525b1061 URL: https://github.com/llvm/llvm-project/commit/0796869e4e1e517a0f77f8e84d94e1e3525b1061 DIFF: https://github.com/llvm/llvm-project/commit/0796869e4e1e517a0f77f8e84d94e1e3525b1061.diff LOG

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. Thanks a lot for your time and help @MyDeveloperDay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___ cfe-commits mailing list cfe-c

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG813d486cbc99: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks (authored by jessesna, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 813d486 - [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

Author: Jesses Gott Date: 2021-11-25T19:45:07Z New Revision: 813d486cbc99836ea4e75996e2667cb38f7113a8 URL: https://github.com/llvm/llvm-project/commit/813d486cbc99836ea4e75996e2667cb38f7113a8 DIFF: https://github.com/llvm/llvm-project/commit/813d486cbc99836ea4e75996e2667cb38f7113a8.diff LOG: [

[PATCH] D114609: [clang] Fix crash on broken parameter declarators

kadircet created this revision. kadircet added reviewers: sammccall, hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114609 Files: clang/lib/Parse/ParseDec

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389849. Jake-Egan added a comment. Removed some tests already disabled by D114481 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D11304

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir jsji wrote: > there is no `fmodule-format=obj` here, why are we failing here? > They have the same erro

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 added a comment. Passed internal CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 389834. gandhi21299 added a comment. - applied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553 Files: clang/include/clang/AST/Expr.h clang/includ

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 389833. gandhi21299 added a comment. - added order argument in the builtins and changed the tests accordingly - adding Sema test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llv

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. Great. Thanks a lot. It's Jesses Gott and jesses.gott.na+l...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___ cfe-commit

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. one of us can commit it for you but we need to do the following to attribute it to you commit --amend --author="John Doe " So I need your name and email address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I ran the examples from https://bugs.llvm.org/show_bug.cgi?id=38314 and its so much better than the previous state! Thanks for this patch, LGTM namespace n { void foo() {

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei marked 2 inline comments as done. masoud.ataei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2760 case options::OPT_fno_honor_nans: HonorNaNs = false;break; case options::OPT_fapprox_func: ApproxFunc = true;

[PATCH] D114583: [clang-format] Adjust braced list detection

cpplearner updated this revision to Diff 389822. cpplearner added a comment. Fixed tests. Since in JavaScript, the thing after `extends` must be an expression, and the thing after `implements` must be an object type, I decided to parse both as braced lists without going through `tryToParseBrace

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei updated this revision to Diff 389820. masoud.ataei edited the summary of this revision. masoud.ataei added a comment. Updated the test combining -ffast-math and -fno-approx-func options. @andrew.w.kaylor I hope you don't mind that I put those tests on `clang/test/Driver/fast-math.c`

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

jrtc27 added a comment. In D114533#3154225 , @arsenm wrote: > In D114533#3153924 , @jrtc27 wrote: > >> This seems like it should not apply to non-integral address spaces? > > No, it shouldn’t care about the indivi

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. Somewhat off-topic from a discussion earlier in the thread. What's the purpose of the following code then if users are supposed to explicitly specify the `-L` flag anyway? c++ if (HostTriple.isArch64Bit() && FS.exists(InstallPath + "/lib64")) LibPath = Inst

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. In D114533#3153924 , @jrtc27 wrote: > This seems like it should not apply to non-integral address spaces? No, it shouldn’t care about the individual address spaces. It’s a reinterpret of the bits, the type meanings don’t matter

[PATCH] D114602: [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC]

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:31 + + + Two excessive newlines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language: replace master with main (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11410

[clang-tools-extra] c3dc6b0 - [NFC][clang-tools-extra] Inclusive language: replace master with main

Author: Quinn Pham Date: 2021-11-25T11:01:16-06:00 New Revision: c3dc6b081da6ba503e67d260033f81f61eb38ea3 URL: https://github.com/llvm/llvm-project/commit/c3dc6b081da6ba503e67d260033f81f61eb38ea3 DIFF: https://github.com/llvm/llvm-project/commit/c3dc6b081da6ba503e67d260033f81f61eb38ea3.diff LO

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:6377 + +static const char *SignReturnAddrStr[] = {"none", "non-leaf", "all"}; +Fn->addFnAttr("sign-return-address", vhscampos wrote: > I reckon selecting the string using a

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. For your test I think its your test that is wrong, looking at the simpler versions (using clang-format-12) void foo() { { { int a; } } } void foo() { { int a; } } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

vhscampos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2979 +def warn_unsupported_branch_protection_spec : Warning< + "unsupported branch protection specification '%0'">, InGroup; + Still need to remove extraneous whitesp

[PATCH] D114602: [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC]

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389811. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added a comment. I can't remember how we discussed this offline, but my plan was to land this and address the limitations as followups rather than extend the scope of this patch. So I think this is ready for review, though certainly not urgent. Repository: rG LLVM Github Monorepo

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

sammccall added a comment. Thanks, this mostly LG now. I'd consider splitting out the new infra change (IncludeStructure) from the feature change (include-cleaner treatment). In case the latter causes some problems... Comment at: clang-tools-extra/clangd/Headers.cpp:92

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:138 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( - D.SysRoot + "/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v" + -

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. I opened https://reviews.llvm.org/D114601. I wasn't sure if that's something that should have been combined with this ticket or not because it can be merged or rejected independently. I also opened a ticket for Microsoft STL on https://github.com/microsoft/STL/issues/235

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: xazax.hun wrote: > Does the `Dy

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca created this revision. mojca added reviewers: tra, carlosgalvezp, Hahnfeld. mojca added a project: clang. Herald added a subscriber: yaxunl. mojca requested review of this revision. Herald added a subscriber: cfe-commits. This is heavily related to https://reviews.llvm.org/D114326 and uses a

[PATCH] D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah this change definitely looks safe: - we've moving it across BeginSourceFile only, which doesn't seem to do anything for the usual parse that we'd use when building preambles. - Befo

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. The other failure is -class C extends {} {} +class C extends {} +{} I'm slightly struggling to work out in both cases if its the test that is wrong @cpplearner what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. FormatsBracedListsInColumnLayout is actually failing in its own test... it now produces void foo() { { // asdf { int a; } } { { int b; } } } rather than previously void foo() { {// asdf {int a; } } { { int b;

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, LG! (I'm not very familiar with clang-modularize, but this seems to be the only place the term is used) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. The reason I have picked this us was because of: https://twitter.com/bruxisma/status/1462987809879257101 This slightly annoys me because : a) What they were talking about was in my view is disrespectful and inaccurate. b) I thought we'd already landed this (which

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3274 + llvm::SmallVector FilesToLookFor; + // User provided clang-format file using -style=file:/path/to/format/file + // Check for explicit config filename MyDeveloperDay wrote:

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

jrtc27 added a comment. This seems like it should not apply to non-integral address spaces? Comment at: llvm/docs/LangRef.rst:10999 +with this instruction. Conversion of pointers to different address spaces +are legal, but may result in undefined behaviour where such a reinter

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. In D114320#3153795 , @MyDeveloperDay wrote: > Thank you for the patch, Do you need help committing this? if so we need your > name and email address to do so > > https://llvm.org/docs/DeveloperPolicy.html#commit-messages Thank

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6082-6085 + // "from" context. Because these DeclContext values look already not stable + // and unimportant this change looks acceptable. + // For these reasons the old DeclContext must be saved to chan

[PATCH] D40319: [libcxx] Support getentropy as a source of randomness for std::random_device

jwakely added inline comments. Comment at: libcxx/trunk/src/random.cpp:29 +#if defined(_LIBCPP_USING_GETENTROPY) +#include +#elif defined(_LIBCPP_USING_DEV_RANDOM) jwakely wrote: > musl only declares `getentropy` in `` not ``. Glibc > declares it in both. Shoul

[PATCH] D114540: Big-endian version of vpermxor

tislam updated this revision to Diff 389775. tislam edited the summary of this revision. tislam added a comment. - Added test for `vpermxor_be` in `clang/test/CodeGen/builtins-ppc-crypto.c`. - Placed `vpermxor_be` under `[HasVSX, HasP8Altivec]` in `llvm/lib/Target/PowerPC/PPCInstrVSX.td`. - Updat

[PATCH] D40319: [libcxx] Support getentropy as a source of randomness for std::random_device

jwakely added inline comments. Herald added a subscriber: abrachet. Comment at: libcxx/trunk/src/random.cpp:29 +#if defined(_LIBCPP_USING_GETENTROPY) +#include +#elif defined(_LIBCPP_USING_DEV_RANDOM) musl only declares `getentropy` in `` not ``. Glibc declares

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389774. sgatev added a comment. Rename Environment.h to DataflowEnvironment.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis/Fl

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389773. sgatev added a comment. Put typed and type-erased interfaces in separate files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/An

[PATCH] D114522: [clangd] Add canonical type to hover

sammccall added a comment. I agree we often show the wrong amount of sugar, and with the thrust of this patch. Some pareto-improments are possible with a single type, but we can't solve this problem satisfactorily: - the right amount of sugar can vary for the same code pattern (`vector::itera

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Thank you for the patch, Do you need help committing this? if so we need your name and email address to do so https://llvm.org/docs/DeveloperPolicy.html#commit-messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6082-6085 + // "from" context. Because these DeclContext values look already not stable + // and unimportant this change looks acceptable. + // For these reasons the old DeclContext must be saved to chang

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36cb7477d1d4: [clang][OpenMP][DebugInfo] Debug support for private variables inside an OpenMP… (authored by alok). Repository: rG LLVM Github Mono

[clang] 36cb747 - [clang][OpenMP][DebugInfo] Debug support for private variables inside an OpenMP task construct

Author: Alok Kumar Sharma Date: 2021-11-25T19:55:22+05:30 New Revision: 36cb7477d1d43de1d97a4c2b4ba0eb5ae29cbafd URL: https://github.com/llvm/llvm-project/commit/36cb7477d1d43de1d97a4c2b4ba0eb5ae29cbafd DIFF: https://github.com/llvm/llvm-project/commit/36cb7477d1d43de1d97a4c2b4ba0eb5ae29cbafd.d

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6082-6085 + // "from" context. Because these DeclContext values look already not stable + // and unimportant this change looks acceptable. + // For these reasons the old DeclContext must be saved to chan

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114256/new/ https://reviews.llvm.org/D114256 __

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

martong added a comment. > Probably this is a bug in the AST creation but currently it works this way. I don't think this is a bug, deduction guides have a convoluted implementation. See the related DeclContext issue with them when local typdefs are involved: https://reviews.llvm.org/D92209 =

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

courbet accepted this revision. courbet added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-bitfields.cpp:62 +void take(T); +void test_parameter_passing(NoBitfield x) { + take(x.id); [nit] newlin

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA updated this revision to Diff 389737. ZarkoCA added a comment. - Fix description - Remove `three` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114562/new/ https://reviews.llvm.org/D114562 Files: clang/docs/ThreadSafetyAnalysis.rst Ind

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall thanks for having a look, I will clarify the comments with your suggestions. In D114025#3152900 , @tstellar wrote: > @ZarkoCA If you are planning to do a lot of this, it might be good to write a > script (or a clang-t

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] 59e4a67 - [clangd] Move IncludeCleaner tracer to the actual computation

Author: Kirill Bobyrev Date: 2021-11-25T13:19:01+01:00 New Revision: 59e4a6708152b42a55653bd8a44a6e0781fd4caf URL: https://github.com/llvm/llvm-project/commit/59e4a6708152b42a55653bd8a44a6e0781fd4caf DIFF: https://github.com/llvm/llvm-project/commit/59e4a6708152b42a55653bd8a44a6e0781fd4caf.diff

[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

zero9178 created this revision. zero9178 added reviewers: MaskRay, aaron.ballman, lebedev.ri, JonasToth, hokein. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. zero9178 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2fe2b5a63bb: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] c2fe2b5 - [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

Author: mydeveloperday Date: 2021-11-25T11:51:21Z New Revision: c2fe2b5a63bb7ec82d0a221bd144f6ce04661f90 URL: https://github.com/llvm/llvm-project/commit/c2fe2b5a63bb7ec82d0a221bd144f6ce04661f90 DIFF: https://github.com/llvm/llvm-project/commit/c2fe2b5a63bb7ec82d0a221bd144f6ce04661f90.diff LOG

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 added a comment. Seems like this is causing failures in a test for clang-tidy if the triple used is an MSVC one. Let me see what I can do about it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/ https://reviews.llvm.org/D114576 __

[clang] d44f2a6 - [clang-format]NFC improve the comment to match the code

Author: mydeveloperday Date: 2021-11-25T11:11:30Z New Revision: d44f2a6db2c71be04a588431a8ffb80d2d9e76f1 URL: https://github.com/llvm/llvm-project/commit/d44f2a6db2c71be04a588431a8ffb80d2d9e76f1 DIFF: https://github.com/llvm/llvm-project/commit/d44f2a6db2c71be04a588431a8ffb80d2d9e76f1.diff LOG

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

This revision was automatically updated to reflect the committed changes. Closed by commit rGc94667a810e4: [clang-format] [PR52595] clang-format does not recognize rvalue references to… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-bitfields.cpp:1 +// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \ +// RUN: -std=c++17 -- -target x86_64-unknown-linux ---

[clang] c94667a - [clang-format] [PR52595] clang-format does not recognize rvalue references to array

Author: mydeveloperday Date: 2021-11-25T11:05:46Z New Revision: c94667a810e44c44fd355f9f014ffe161d75d761 URL: https://github.com/llvm/llvm-project/commit/c94667a810e44c44fd355f9f014ffe161d75d761 DIFF: https://github.com/llvm/llvm-project/commit/c94667a810e44c44fd355f9f014ffe161d75d761.diff LOG

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal updated this revision to Diff 389711. steakhal marked an inline comment as done. steakhal added a comment. Added the `test_parameter_passing()` tests, demonstrating the implicit conversion triggered by parameter passing. It turns out my previous revision suppressed a useful report. Now,

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

CaseyCarter accepted this revision. CaseyCarter added a comment. LGTM - thanks for the quick response! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/ https://reviews.llvm.org/D114576 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske updated this revision to Diff 389709. balazske added a comment. Using correct AST match in the tests to fix failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.llvm.org/D113118 Files: clang/lib

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske reopened this revision. balazske added a comment. This revision is now accepted and ready to land. Windows test failures occurred because wrong AST matchers in the tests. Tests will be updated to use named match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

  1   2   >