[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D114425: [clang] Add __builtin_bswap128

xbolva00 added a comment. Please update Release Notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 395316. philnik added a comment. Is that enough or do you want something more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst

[PATCH] D114425: [clang] Add __builtin_bswap128

RKSimon added a comment. please can you add a constexpr test? Existing bswap tests are in clang/test/Sema/constant-builtins-2.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___

[PATCH] D115959: [clangd] Fix undefined behavior when generating error message at rename with an invalid name

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yikes, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115959/new/ https://reviews.llvm.org/D115959

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 395319. philnik added a comment. Added constexpr test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

spatel added subscribers: kpn, sepavloff, andrew.w.kaylor. spatel added a comment. In D115804#3201044 , @craig.topper wrote: > What's the plan for constrained intrinsics versions of these intrinsics? The > IRBuilder calls for CreateFPToSI and CreateFPTo

[PATCH] D114425: [clang] Add __builtin_bswap128

xbolva00 added a comment. Looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D116000: Revert "[clang-format] Adjust braced list detection"

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It appears that this regressed the formatting of initializer lists in some cases, see comments on https://reviews.llvm.org/D114583. I'll follow-up by a

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire updated this revision to Diff 395322. junaire added a comment. Add a helper function to resue code. I'm not good at naming functions, so I just oveloaded `emitUnaryBuiltin`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115429/new/ https://

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire updated this revision to Diff 395323. junaire added a comment. Format the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115429/new/ https://reviews.llvm.org/D115429 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire added a comment. Hi, @aaron.ballman I'm sorry for not updating the patch in time because I'm preparing for my school final exam :-( One thing I want to mention is that `__builtin_elementwise_roundeven` is actually been added in the RFC during the code review. You can find it in D111529

[PATCH] D116001: [clang-format] add regression tests for braced lists

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on https://reviews.llvm.org/D116000. Added test cases from the comments on https://reviews.llvm.org/D114583. Repository: rG LLVM Github Mo

[PATCH] D116001: [clang-format] add regression tests for braced lists

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116001/new/ https://reviews.llvm.org/D116001 ___

[PATCH] D116001: [clang-format] add regression tests for braced lists

MyDeveloperDay added a comment. thanks for picking this one up (and finding it in the first place) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116001/new/ https://reviews.llvm.org/D116001 ___ cfe-commi

[PATCH] D116000: Revert "[clang-format] Adjust braced list detection"

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think we have to do this as the fix broke more than it fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116000/new/ https:

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay updated this revision to Diff 395329. MyDeveloperDay added a comment. clang-format the file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115990/new/ https://reviews.llvm.org/D115990 Files: clang/include/clang/Format/Format.h clang/lib/Format/TokenAnnotator.cpp cla

[clang] d96bf6e - Revert "[clang-format] Adjust braced list detection"

Author: Krasimir Georgiev Date: 2021-12-19T16:04:42+01:00 New Revision: d96bf6ea461810f7def54541dbcb7ceaecd2d065 URL: https://github.com/llvm/llvm-project/commit/d96bf6ea461810f7def54541dbcb7ceaecd2d065 DIFF: https://github.com/llvm/llvm-project/commit/d96bf6ea461810f7def54541dbcb7ceaecd2d065.d

[PATCH] D116000: Revert "[clang-format] Adjust braced list detection"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd96bf6ea4618: Revert "[clang-format] Adjust braced list detection" (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3a3fcd6 - [clang-format] add regression tests for braced lists

Author: Krasimir Georgiev Date: 2021-12-19T16:07:07+01:00 New Revision: 3a3fcd6a23ad2c0f420a2f6bfde7541233790a30 URL: https://github.com/llvm/llvm-project/commit/3a3fcd6a23ad2c0f420a2f6bfde7541233790a30 DIFF: https://github.com/llvm/llvm-project/commit/3a3fcd6a23ad2c0f420a2f6bfde7541233790a30.d

[PATCH] D116001: [clang-format] add regression tests for braced lists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a3fcd6a23ad: [clang-format] add regression tests for braced lists (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114425: [clang] Add __builtin_bswap128

RKSimon added inline comments. Comment at: clang/test/Sema/constant-builtins-2.c:219 int h5 = __builtin_bswap64(0x1234) == 0x3412 ? 1 : f(); +int h6 = __builtin_bswap128(0x1234) == (((__int128)0x3412) << 112) ? 1 : f(); extern long int bi0; ``` #if

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 395338. philnik added a comment. Guarding test now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Bu

[clang] 1965cc4 - [CodeGen] remove creation of FP cast function attribute

Author: Sanjay Patel Date: 2021-12-19T11:55:00-05:00 New Revision: 1965cc469539979d66c6a7f9d1c73000a795f8f0 URL: https://github.com/llvm/llvm-project/commit/1965cc469539979d66c6a7f9d1c73000a795f8f0 DIFF: https://github.com/llvm/llvm-project/commit/1965cc469539979d66c6a7f9d1c73000a795f8f0.diff

[PATCH] D115886: [CodeGen] remove creation of FP cast function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1965cc469539: [CodeGen] remove creation of FP cast function attribute (authored by spatel). Herald added a project: clang. Herald added a subscriber:

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

qiucf created this revision. qiucf added reviewers: tejohnson, MaskRay, lkail, nickdesaulniers. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The run line of `stack-protector-guard.c` doesn't specify the triple, which means it depe

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Optional nit comment. Comment at: clang/lib/Format/TokenAnnotator.cpp:1875 +// const a = in JavaScript. +if (Style.isJavaScript() && PreviousNotConst->is(to

[PATCH] D115998: [Clang] Add helper text to fopenmp_version_EQ to make it show in help menu

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115998/new/ https://reviews.llvm.org/D115998 ___

[clang-tools-extra] 555eacf - [clangd] Fix undefined behavior when generating error message at rename with an invalid name

Author: Aleksandr Platonov Date: 2021-12-19T22:28:26+03:00 New Revision: 555eacf75f21cd1dfc6363d73ad187b730349543 URL: https://github.com/llvm/llvm-project/commit/555eacf75f21cd1dfc6363d73ad187b730349543 DIFF: https://github.com/llvm/llvm-project/commit/555eacf75f21cd1dfc6363d73ad187b730349543.

[PATCH] D115959: [clangd] Fix undefined behavior when generating error message at rename with an invalid name

This revision was automatically updated to reflect the committed changes. Closed by commit rG555eacf75f21: [clangd] Fix undefined behavior when generating error message at rename with an… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

curdeius added a comment. Please review the descriptions. Looks good, but I'm wondering if there are better names for these options. E.g. when `AlignConsecutiveMacrosIgnoreMax` is true, then `AlignConsecutiveMacrosMinWidth` is not minimum width, but required/fixed width except for long macro nam

[PATCH] D116007: [clang-format] Fix BreakBeforeBraces: Attach ignored with trailing requires-expression of function.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/48312. Repository: rG LLVM

[PATCH] D116008: [clang-format] Fix wrong indentation of namespace identifiers after a concept declaration.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, the code: template concept a_concept = X<>; namespace

[PATCH] D116008: [clang-format] Fix wrong indentation of namespace identifiers after a concept declaration.

curdeius updated this revision to Diff 395355. curdeius added a comment. Undo unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116008/new/ https://reviews.llvm.org/D116008 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/u

[PATCH] D116008: [clang-format] Fix wrong indentation of namespace identifiers after a concept declaration.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116008/new/ https://reviews.llvm.org/D116008 ___

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea created this revision. aganea added reviewers: hans, aheejin, jansvoboda11. Herald added a subscriber: dexonsmith. aganea requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. As reported in PR52704: https://github.com/ll

[PATCH] D115709: [RISCV] Remove Zvamo Extention

achieveartificialintelligence added a comment. In D115709#3200212 , @craig.topper wrote: > LGTM Should I land it now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D1

[PATCH] D115709: [RISCV] Remove Zvamo Extention

arcbbb accepted this revision. arcbbb added a comment. This revision is now accepted and ready to land. LGTM too. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D115709 __

[PATCH] D115709: [RISCV] Remove Zvamo Extention

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68bc6d7cae6d: [RISCV] Remove Zvamo Extention (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 18f087c - [DebugInfo][Clang] record the access flag for class/struct/union types.

Author: Esme-Yi Date: 2021-12-20T02:40:42Z New Revision: 18f087c21cdb08fec77adff47a528a5a335807d9 URL: https://github.com/llvm/llvm-project/commit/18f087c21cdb08fec77adff47a528a5a335807d9 DIFF: https://github.com/llvm/llvm-project/commit/18f087c21cdb08fec77adff47a528a5a335807d9.diff LOG: [Debu

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18f087c21cdb: [DebugInfo][Clang] record the access flag for class/struct/union types. (authored by Esme). Repository: rG LLVM Github Monorepo CHA

[clang] 0060060 - [Clang] Add helper text to fopenmp_version_EQ to make it show in help menu

Author: Shilei Tian Date: 2021-12-19T22:07:24-05:00 New Revision: 0060060fef5da582799a706b6ba8c6ec9fcda2a2 URL: https://github.com/llvm/llvm-project/commit/0060060fef5da582799a706b6ba8c6ec9fcda2a2 DIFF: https://github.com/llvm/llvm-project/commit/0060060fef5da582799a706b6ba8c6ec9fcda2a2.diff L

[PATCH] D115998: [Clang] Add helper text to fopenmp_version_EQ to make it show in help menu

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0060060fef5d: [Clang] Add helper text to fopenmp_version_EQ to make it show in help menu (authored by tianshilei1992). Repository: rG LLVM Github

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

Luhaocong added a comment. ping. Hi everyone, can you please help me review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115430/new/ https://reviews.llvm.org/D115430 ___ cfe-commits mailing list cfe-co

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang

ChuanqiXu added a comment. In D115790#3199905 , @ezhulenev wrote: > There are two places where in MLIR you can put an attribute to coroutine > functions: > > 1. > https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Async/Transforms/AsyncToAs

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai updated this revision to Diff 395365. HsiangKai added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. In riscv-insert-vsetvli, use the policy argument. No use implicit-def maskedoff to adjust the setting. Repository: rG LLVM Github Monorep

[PATCH] D116014: Remove the signed version of createExpression

achieveartificialintelligence created this revision. achieveartificialintelligence added a reviewer: dexonsmith. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. achieveartificialintelligence requested review of this revision. Herald added projects: clang, LLVM. Herald adde

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115430/new/ https://reviews.llvm.org/D115430

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf created this revision. qiucf added reviewers: rzurob, jsji, nemanjai, shchenz, PowerPC. Herald added subscribers: kbarton, hiraditya. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently in Clang, we have

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, shchenz, PowerPC, uweigand, MaskRay. Herald added subscribers: steven.zhang, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a proj

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

MaskRay added a comment. > This is part of the efforts adding .gnu_attribute support for PowerPC. In > Clang, an extra metadata field will be added as float-abi to show current > long double format. So backend can emit .gnu_attribute section data from this > metadata. How does .gnu_attribute w

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf added a comment. In D116016#3202148 , @MaskRay wrote: >> This is part of the efforts adding .gnu_attribute support for PowerPC. In >> Clang, an extra metadata field will be added as float-abi to show current >> long double format. So backend can e

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1839 +PreviousNotConst = PreviousNotConst->getPreviousNonComment(); +} Remove braces. Comment at: clang/lib/Format/TokenAnnotator.cpp:1875 +// cons

[clang] 9c11e95 - [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

Author: jacquesguan Date: 2021-12-20T14:25:06+08:00 New Revision: 9c11e952868342dfbf0efedd246dac6191ee98d7 URL: https://github.com/llvm/llvm-project/commit/9c11e952868342dfbf0efedd246dac6191ee98d7 DIFF: https://github.com/llvm/llvm-project/commit/9c11e952868342dfbf0efedd246dac6191ee98d7.diff L

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c11e9528683: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

jacquesguan added a comment. Sorry, I should use --author="Luhaocong " in my git command, and I will pay attention next time to land revision that created by other one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115430/new/ https://reviews.llv

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

owenpan updated this revision to Diff 395380. owenpan added a comment. Additional cleanups: - Restrict parsing `=>` to JavaScript and C#. - Rename `tryToParseCSharpLambda` to `tryToParseChildBlock`. - Remove redundant caret `case`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/ne

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1641 case tok::equal: - // Fat arrows (=>) have tok::TokenKind tok::equal but TokenType - // TT_FatArrow. They always start an expression o