[PATCH] D117857: [clang-tidy] Remove gsl::at suggestion from cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp created this revision. Herald added subscribers: shchenz, arphaman, kbarton, kristof.beyls, xazax.hun, nemanjai. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently the fix hint is hardcoded to

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp added a comment. I believe this other solution has lower complexity and still achieves my goal, let me know which one you prefer! https://reviews.llvm.org/D117857 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117205/new/ https://revi

[PATCH] D117857: [clang-tidy] Remove gsl::at suggestion from cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp updated this revision to Diff 401880. carlosgalvezp added a comment. Fix alphabetical order in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117857/new/ https://reviews.llvm.org/D117857 Files: clang-tools-extra/clan

[PATCH] D117857: [clang-tidy] Remove gsl::at suggestion from cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp updated this revision to Diff 401882. carlosgalvezp edited the summary of this revision. carlosgalvezp added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117857/new/ https://reviews.llvm.org/D117857

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

eopXD created this revision. eopXD added reviewers: craig.topper, asb, frasercrmck. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, armkevincheng, eric-k256, vkmr, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, a

[PATCH] D117862: [clang][tests] Fix a typo in wasm-toolchain.cpp tests

tbaeder created this revision. tbaeder added reviewers: sbc100, dlj, sunfish. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This seemed odd to me while looking at the tests. Note that I couldn't make the tests fail when p

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

ArcsinX added a comment. Friendly ping. I am not sure that this patch is clear, so I will try to explain it again: - clang static analyzer plugins are *NOT* a typical clang plugins: instead of `llvm::Registry<>::Add` usage, these plugins provides `сlang_registerCheckers` and `clang_analyzerAPI

[PATCH] D117864: [clangd] Enable hover on character literal.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In the initial hover expression patch (https://revi

[PATCH] D117864: [clangd] Enable hover on character literal.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:733 llvm::isa(E) || llvm::isa(E) || llvm::isa(E) || llvm::isa(E); } there may be some value to enable StringLiteral as well (e.g. see the length of the string), but

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

khchen updated this revision to Diff 401899. khchen added a comment. address frasercrmck's comments. rewrite snippet of code to fix potential bug and make more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117647/new/ https://reviews.llvm

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a subscriber: junaire. fhahn added a comment. Thanks for the patch! > For other reductions, we've tried to share builtins for float/integer > vectors, but the fadd/fmul reduction builtins also take a starting value > argument. Technically I could support float by using default value

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

kadircet added a comment. here are some more comments, can't say I've been able to go through all of the patch yet, unfortunately it's considerably big in size. it would be great to get rid of some of those extra code by just dropping accessors/classes when not needed. Comme

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

kadircet added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/Inputs/nolintbeginend/1st-translation-unit.cpp:1 +// NOLINTBEGIN +class A { A(int i); }; kadircet wrote: > no run lines or anything here (and the following file) oops, n

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen updated this revision to Diff 401910. steffenlarsen added a comment. Moved comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

RKSimon added a comment. Thanks! Comment at: clang/lib/Headers/avx512bwintrin.h:894 return (__m512i)__builtin_ia32_selectb_512((__mmask64)__M, (__v64qi)_mm512_min_epu8(__A, __B), (__

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

fhahn accepted this revision. fhahn added a comment. Thanks for the patch, it's great to see! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117798/new/ https://reviews.llvm.org/D117798 ___ cfe-commits ma

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen marked an inline comment as done. steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:468 + + // General case. Parse all available expressions. + CommaLocsTy CommaLocs; aaron.ballman wrote: > I think it'd be good

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. I'm happy to continue with this just for integers or wait until we have a plan for floats as well. I guess we need to decide if we want to support the starting value in the fadd/fmul intrinsics from the builtin or not? If we don't then adding float support to the add/mu

[PATCH] D112073: [PowerPC] Emit warning when SP is clobbered by asm

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112073/new/ https://reviews.llvm.org/D112073 ___

[clang-tools-extra] 597eae9 - [clangd][Background] Make index validation logs verbose

Author: Kadir Cetinkaya Date: 2022-01-21T12:37:20+01:00 New Revision: 597eae998a874a872b67d1a22a04d7c45d2ef94b URL: https://github.com/llvm/llvm-project/commit/597eae998a874a872b67d1a22a04d7c45d2ef94b DIFF: https://github.com/llvm/llvm-project/commit/597eae998a874a872b67d1a22a04d7c45d2ef94b.dif

[PATCH] D117792: [clangd][Background] Make index validation logs verbose

This revision was automatically updated to reflect the committed changes. Closed by commit rG597eae998a87: [clangd][Background] Make index validation logs verbose (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117792/new/ http

[PATCH] D117776: [clangd] Fail inlayHints requests on content changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG825a3cd6b697: [clangd] Fail inlayHints requests on content changes (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117776/new/ https:/

[clang-tools-extra] 825a3cd - [clangd] Fail inlayHints requests on content changes

Author: Kadir Cetinkaya Date: 2022-01-21T12:40:49+01:00 New Revision: 825a3cd6b6972b6a50b80bed7d951d7ea7f90669 URL: https://github.com/llvm/llvm-project/commit/825a3cd6b6972b6a50b80bed7d951d7ea7f90669 DIFF: https://github.com/llvm/llvm-project/commit/825a3cd6b6972b6a50b80bed7d951d7ea7f90669.dif

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. In D117829#3260772 , @RKSimon wrote: > I'm happy to continue with this just for integers or wait until we have a > plan for floats as well. I guess we need to decide if we want to support the > starting value in the fadd/fmul intr

[PATCH] D117717: [clang] Ignore -fconserve-stack

steakhal added a comment. I'm not really familiar with `scan-build`, we at CodeChecker, we ignore this gcc specific flag explicitly: https://github.com/Ericsson/codechecker/blob/85dd52dc8f4d47fcf26419fcb44de1ff2a58924f/analyzer/codechecker_analyzer/buildlog/log_parser.py#L72 So, IMO we should pr

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4727d29d908f: [X86] Remove __builtin_ia32_pabs intrinsics and use generic… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 4727d29 - [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

Author: Simon Pilgrim Date: 2022-01-21T11:59:08Z New Revision: 4727d29d908f9dd608dd97a58c0af1ad579fd3ca URL: https://github.com/llvm/llvm-project/commit/4727d29d908f9dd608dd97a58c0af1ad579fd3ca DIFF: https://github.com/llvm/llvm-project/commit/4727d29d908f9dd608dd97a58c0af1ad579fd3ca.diff LOG:

[clang] ced077e - [clang][deps] NFC: Simplify handling of cached FS errors

Author: Jan Svoboda Date: 2022-01-21T13:04:25+01:00 New Revision: ced077e1ba52ec2937aab538e9b6fa5149f8c567 URL: https://github.com/llvm/llvm-project/commit/ced077e1ba52ec2937aab538e9b6fa5149f8c567 DIFF: https://github.com/llvm/llvm-project/commit/ced077e1ba52ec2937aab538e9b6fa5149f8c567.diff L

[clang] 5daeada - [clang][deps] Ensure filesystem cache consistency

Author: Jan Svoboda Date: 2022-01-21T13:04:25+01:00 New Revision: 5daeada33051aa85777593d3f69eb29f26e7fb2f URL: https://github.com/llvm/llvm-project/commit/5daeada33051aa85777593d3f69eb29f26e7fb2f DIFF: https://github.com/llvm/llvm-project/commit/5daeada33051aa85777593d3f69eb29f26e7fb2f.diff L

[clang] 8cc2a13 - [clang][deps] Handle symlinks in minimizing FS

Author: Jan Svoboda Date: 2022-01-21T13:04:25+01:00 New Revision: 8cc2a137270462bc191377dbab97c739583814dd URL: https://github.com/llvm/llvm-project/commit/8cc2a137270462bc191377dbab97c739583814dd DIFF: https://github.com/llvm/llvm-project/commit/8cc2a137270462bc191377dbab97c739583814dd.diff L

[PATCH] D115935: [clang][deps] NFC: Simplify handling of cached FS errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGced077e1ba52: [clang][deps] NFC: Simplify handling of cached FS errors (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D114966: [clang][deps] Ensure filesystem cache consistency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5daeada33051: [clang][deps] Ensure filesystem cache consistency (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc2a1372704: [clang][deps] Handle symlinks in minimizing FS (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D114971

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij marked 2 inline comments as done. stuij added a comment. > Thanks for the update. Same(ish) questions for the Arm side. Otherwise this > LGTM Ai, thanks. Should have checked Arm as well. > Oh, also is there an ID for this CPU that is worth adding to > getHostCPUNameForARM in Host.cpp? Y

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij updated this revision to Diff 401936. stuij marked an inline comment as done. stuij added a comment. Herald added a subscriber: dexonsmith. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.ll

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

kadircet added a comment. I was also thinking about a cache-based solution in which we can update results as we please, and as you noted the idea definitely generalizes to other requests as well, with possibly little nuances around the definition of "as we please", which makes things a lot more

[clang] 8ee135d - [X86] Remove `__builtin_ia32_pmax/min` intrinsics and use generic `__builtin_elementwise_max/min`

Author: Simon Pilgrim Date: 2022-01-21T12:24:58Z New Revision: 8ee135dcf8ff060656ad481c3e980fe8763576f5 URL: https://github.com/llvm/llvm-project/commit/8ee135dcf8ff060656ad481c3e980fe8763576f5 DIFF: https://github.com/llvm/llvm-project/commit/8ee135dcf8ff060656ad481c3e980fe8763576f5.diff LOG:

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ee135dcf8ff: [X86] Remove `__builtin_ia32_pmax/min` intrinsics and use generic… (authored by RKSimon). Changed prior to commit: https://reviews.l

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

junaire added a comment. > @junaire has been looking into this and put up D117480 > as an option to extend the intrinsic to > have a dedicated order argument. Hi @fhahn, I wonder if we should continue working on this as I remember one of the reviewers was dou

[clang] 3ef88b3 - Revert rG8ee135dcf8ff060656ad481c3e980fe8763576f5 "[X86] Remove `__builtin_ia32_pmax/min` intrinsics and use generic `__builtin_elementwise_max/min`"

Author: Simon Pilgrim Date: 2022-01-21T12:34:19Z New Revision: 3ef88b31843e040c95f23ff2c3c206f1fa399c05 URL: https://github.com/llvm/llvm-project/commit/3ef88b31843e040c95f23ff2c3c206f1fa399c05 DIFF: https://github.com/llvm/llvm-project/commit/3ef88b31843e040c95f23ff2c3c206f1fa399c05.diff LOG:

[clang] 0abaf64 - Revert rG4727d29d908f9dd608dd97a58c0af1ad579fd3ca "[X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs"

Author: Simon Pilgrim Date: 2022-01-21T12:35:36Z New Revision: 0abaf64580921e31983e355972b91c83fd7521f2 URL: https://github.com/llvm/llvm-project/commit/0abaf64580921e31983e355972b91c83fd7521f2 DIFF: https://github.com/llvm/llvm-project/commit/0abaf64580921e31983e355972b91c83fd7521f2.diff LOG:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added a comment. In D117520#3260443 , @curdeius wrote: > In D117520#3258454 , > @MyDeveloperDay wrote: > >> I think its been fixed, in the last but one diff. >> >> Generally speaking we simply cannot have --

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. Aaron and Eric, I'm currently on an extended leave, so I'll only get back to this in a few weeks' time, but I did want to let you know that I've seen this. Thanks for the detailed comments! Cheers, Martin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 75e164f - [llvm] Cleanup header dependencies in ADT and Support

Author: serge-sans-paille Date: 2022-01-21T13:54:49+01:00 New Revision: 75e164f61d391979b4829bf2746a5d74b94e95f2 URL: https://github.com/llvm/llvm-project/commit/75e164f61d391979b4829bf2746a5d74b94e95f2 DIFF: https://github.com/llvm/llvm-project/commit/75e164f61d391979b4829bf2746a5d74b94e95f2.d

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 added a comment. @vsapsai do you have any further concerns? My only intended change at this point is Duncan's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114095/new/ https://reviews.llvm.org/D114095

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401950. glaubitz added a comment. Made changes according to review and dropped every change except removing __sparcv9 and __sparcv9__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 ___ cfe-co

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401951. glaubitz edited the summary of this revision. glaubitz added a comment. Updated the patch as requested and dropped all changes except the removal of __sparcv9 and __sparcv9__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:347 +NoLint.SpecifiesChecks = true; + } +} Nit: tab with spaces Comment at: clang-tools-extra/clang-tidy/ClangTidyDia

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401953. glaubitz edited the summary of this revision. glaubitz added a comment. Minor improvement to the commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D9

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, fhahn. RKSimon requested review of this revision. Herald added a project: clang. None of these have any reordering issues, and they still emit the same reduction intrinsics without any change in the existing test cover

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

hans added a comment. Do you think you'll have time to work on this? Otherwise I'd be happy to take it over. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438 ___

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

aaron.ballman added a comment. In D116966#3260571 , @ArcsinX wrote: > Friendly ping. > > I am not sure that this patch is clear, so I will try to explain it again: > > - clang static analyzer plugins are *NOT* a typical clang plugins: instead of > `llvm:

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

ArcsinX added a comment. In D116966#3261168 , @aaron.ballman wrote: > However, the changes you've made don't look to be specific to building on > Windows; this removes `PLUGIN_TOOL` for all targets. I presume it's still > needed for non-Windows targets

[PATCH] D117836: Fix obvious typo

gftg created this revision. gftg added a comment. gftg updated this revision to Diff 401949. gftg updated this revision to Diff 401963. gftg edited the summary of this revision. gftg published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. /me wond

[clang-tools-extra] 622354a - [llvm][ADT] Implement `BitVector::{pop_, }back`

Author: Jan Svoboda Date: 2022-01-21T14:50:53+01:00 New Revision: 622354a522073b0a048a88c957b161fb376a40eb URL: https://github.com/llvm/llvm-project/commit/622354a522073b0a048a88c957b161fb376a40eb DIFF: https://github.com/llvm/llvm-project/commit/622354a522073b0a048a88c957b161fb376a40eb.diff L

[PATCH] D117115: [llvm][ADT] Implement `BitVector::{pop_,}back`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG622354a52207: [llvm][ADT] Implement `BitVector::{pop_,}back` (authored by jansvoboda11). Herald added subscribers: cfe-commits, carlosgalvezp, usaxen

[clang] 622354a - [llvm][ADT] Implement `BitVector::{pop_,}back`

Author: Jan Svoboda Date: 2022-01-21T14:50:53+01:00 New Revision: 622354a522073b0a048a88c957b161fb376a40eb URL: https://github.com/llvm/llvm-project/commit/622354a522073b0a048a88c957b161fb376a40eb DIFF: https://github.com/llvm/llvm-project/commit/622354a522073b0a048a88c957b161fb376a40eb.diff L

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda created this revision. jchlanda added reviewers: csigg, tra, bkramer. Herald added subscribers: asavonic, hiraditya, jholewinski. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Adds support fo

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder created this revision. tbaeder added reviewers: sbc100, dlj, aheejin, sunfish. Herald added subscribers: jgravelle-google, dschuff. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The WebAssembly toolchain currently supports

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

curdeius added a comment. I'd like to see the refactor of the parts repeated from UnwrappedLineParser. No comments otherwise. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134 + OperateIndex + 1 < Lines.size()) { +// UnwrappedLineParser's recognitio

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 updated this revision to Diff 401973. tyb0807 edited the summary of this revision. tyb0807 added a comment. Update reference to ACLE specification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117753/new/ https://reviews.llvm.org/D117753 F

[clang-tools-extra] b810244 - [clang-tidy] Avoid binding nullptr to a reference

Author: Benjamin Kramer Date: 2022-01-21T15:55:17+01:00 New Revision: b8102449a72c5144cb75cfca46e78b517d7f6606 URL: https://github.com/llvm/llvm-project/commit/b8102449a72c5144cb75cfca46e78b517d7f6606 DIFF: https://github.com/llvm/llvm-project/commit/b8102449a72c5144cb75cfca46e78b517d7f6606.dif

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D116966#3261202 , @ArcsinX wrote: > In D116966#3261168 , @aaron.ballman > wrote: > >> Howev

Re: [PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

I wouldn't be able to look at this for a few weeks. If you have the time to take it over, that works for me. Thanks! On Fri, Jan 21, 2022, 07:24 Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > Do you think you'll have time to work on this? Otherwise I'

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

frasercrmck added a comment. Thanks, LGTM. As a heads up, I've pinched the use of `_TU` as a suffix in D117561 . The conflicts should be minor (one location) for whichever patch is merged second. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 401982. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/lib/Dri

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

sammccall added a comment. In D116786#3260970 , @kadircet wrote: > I feel like this is the way to go, but we'll need to put more thought into > the design Agree. I guess then we ignore the issue for this patch? As you say that's affects other hints too

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

nemanjai added a comment. I don't think this is the right approach. Personally, I would find it surprising if simply having GCC 12.1 on the system changes my `long double` default. Imagine if I simply install and use such a toolchain on a machine for whatever reason. If the default for such a t

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. Thanks for your suggestion ! I have changed to check avr-1 in `Clang::ConstructJob`, which is much more clear than my previous solution ! Really appreicate. A bit pity is that I have to make big changes to the constructor `AVRToolChain::AVRToolChain`, otherwise the ex

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Would there be a way to query the GCC toolchain for what the default is for > `long double`? There would certainly be ways to query. But I don't think we should change the default *BASED* on the gcc toolchain installed. As you mentioned, `I would find it surprising i

[PATCH] D117626: [ADT] [NFC] Add StringRef::detectEOL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d3437fbf341: [ADT] [NFC] Add StringRef::detectEOL (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D117626?vs=401074&id=401

[clang] 9d3437f - [ADT] [NFC] Add StringRef::detectEOL

Author: Chris Bieneman Date: 2022-01-21T09:47:02-06:00 New Revision: 9d3437fbf3419502351d41ff9e28f06b0c3f06e8 URL: https://github.com/llvm/llvm-project/commit/9d3437fbf3419502351d41ff9e28f06b0c3f06e8 DIFF: https://github.com/llvm/llvm-project/commit/9d3437fbf3419502351d41ff9e28f06b0c3f06e8.diff

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

khchen added a comment. Herald added a subscriber: eopXD. It seems like not only one place need to have a consistent way to process intrinsic. (ex. InitIntrinsicList/createRVVIntrinsics and RVVIntrinsic::RVVIntrinsic/InitRVVIntrinsic) I'm think how to avoid mismatch implementation in the future,

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. The previous logic of the constructor `AVRToolChain::AVRToolChain` 1. if `-c` or `-nostdlib` is specified, no error will rise (even if no MCU is specified). 2. if no MCU is specified, two warnings will rise warning: no target microcontroller specified on command li

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

frasercrmck added a comment. Thanks for the patch! Not sure the best way to review this. The tests are passing, which is a good sign. One option could be to split the "meaningful" changes into a separate diff for easier viewing? We probably don't need to see all the test RUN line changes, for e

[PATCH] D117894: [clang-format] Space between attribute closing parenthesis and qualified type colon.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/35711. Repository: rG LLVM

[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

beanz added a comment. Have you looked at the impact on binary size? PLUGIN_TOOL _should_ cause the plugins to link against the copy of LLVM & Clang in the tool target binary which reduces the binary size of the plugin and avoids duplicate global initializations. Repository: rG LLVM Github

[clang] f24fe96 - [ifs] Use a tmp file instead of "-"

Author: Jake Egan Date: 2022-01-21T11:19:37-05:00 New Revision: f24fe96f469b8ccdb8504f998d1107d79c8fd363 URL: https://github.com/llvm/llvm-project/commit/f24fe96f469b8ccdb8504f998d1107d79c8fd363 DIFF: https://github.com/llvm/llvm-project/commit/f24fe96f469b8ccdb8504f998d1107d79c8fd363.diff LOG

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24fe96f469b: [ifs] Use a tmp file instead of "-" (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.or

[PATCH] D117895: address review feedback

vtjnash created this revision. Herald added subscribers: carlosgalvezp, arphaman, mgorny. vtjnash requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117895 Files:

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 401997. vtjnash added a comment. address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt c

[PATCH] D117895: address review feedback

vtjnash abandoned this revision. vtjnash added a comment. arc error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117895/new/ https://reviews.llvm.org/D117895 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D98574: [Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. It's been a while so I've since forgotten the details, but this looks fine now to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ h

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck added inline comments. Herald added subscribers: eopXD, VincentWu, luke957, achieveartificialintelligence. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101 + } else { +RVVBitsMin = RVVVectorBitsMinOpt; +RVVBitsMax = RVVVectorBitsMaxOpt; -

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, aaron.ballman, scanon, craig.topper. Herald added subscribers: pengfei, sunfish, kristof.beyls, dschuff. RKSimon requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. This patch implement

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 402006. ksyx edited the summary of this revision. ksyx added a comment. Add token type `FunctionLikeOrFreestandingMacro` and use it to replace duplicated check with UnwrappedLineParser CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

alexfh added a comment. We've started seeing some tests dying with SIGILL (illegal instruction) after this patch. I'm working on a reduced repro, but please take a look, if you can find any issues yourself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D117899: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Ensure any use of a `read_write` image is guarded behind the `__op

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

svenvh added a comment. Thanks for committing this! The corresponding TableGen changes are in D117899 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539

[clang] 23a7bb5 - [clang-format] Fix comment in spaceRequiredBefore. NFC.

Author: Marek Kurdej Date: 2022-01-21T18:17:55+01:00 New Revision: 23a7bb541dae47e691be5380e96ca63f04d6d194 URL: https://github.com/llvm/llvm-project/commit/23a7bb541dae47e691be5380e96ca63f04d6d194 DIFF: https://github.com/llvm/llvm-project/commit/23a7bb541dae47e691be5380e96ca63f04d6d194.diff

[PATCH] D98574: [Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+

glaubitz added a comment. Could someone land this for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 _

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

RKSimon added a comment. Quick update: we're hitting an issue with the libc-x86_64-debian-fullbuild-dbg and asan build bots which is using the wrong headers and breaks when the `__builtin_ia32_pabs*` builtins are removed. Once that has been addressed I'll recommit. Repository: rG LLVM Githu

[PATCH] D98574: [Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+

MaskRay accepted this revision. MaskRay added a comment. Testing and will push it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cf

[clang] 5061eb6 - [Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+

Author: John Paul Adrian Glaubitz Date: 2022-01-21T09:57:17-08:00 New Revision: 5061eb6b0121af11a784d92e2dee5996858d04cd URL: https://github.com/llvm/llvm-project/commit/5061eb6b0121af11a784d92e2dee5996858d04cd DIFF: https://github.com/llvm/llvm-project/commit/5061eb6b0121af11a784d92e2dee599685

[PATCH] D98574: [Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5061eb6b0121: [Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+ (authored by glaubitz, committed by MaskRay). Repository: rG LLVM

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

sandoval added a comment. I don't see a clear explain the motivation for this change - can you confirm my understanding or provide clarification? It looks like the issue is that D110337 caused a regression for cases when user code directly calls a device libr

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101 + } else { +RVVBitsMin = RVVVectorBitsMinOpt; +RVVBitsMax = RVVVectorBitsMaxOpt; frasercrmck wrote: > frasercrmck wrote: > > craig.topper wrote: > > > If cla

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna updated this revision to Diff 402031. dcastagna added a comment. Rebase on ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

  1   2   >