[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. This situation isn't properly diagnosed (false positive): #ifdef USE_FOO #if USE_FOO // code #endif #endif CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522

[PATCH] D118578: [RISCV] Make Zfhmin in march imply F.

craig.topper created this revision. craig.topper added reviewers: asb, achieveartificialintelligence, luismarques, kito-cheng. Herald added subscribers: VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

aybassiouny added a comment. Thanks @curdeius for checking this in, apologies for delay on my side. Glad the bug is not there in the new version! Comment at: clang/lib/Format/TokenAnnotator.cpp:3498 + !Tok.isOneOf(TT_ObjCBlockLBrace, TT_DictLiteral) && +

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. Thanks for the fix. The fix of off-by-one issue looks ok to me. Will continue reviewing other parts in one week due to the Spring Festival in China. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114413/new/

[PATCH] D118542: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

peixin accepted this revision. peixin added a comment. This revision is now accepted and ready to land. Function code LGTM. Please fix the CI fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118542/new/ https://reviews.llvm.org/D118542

[clang-tools-extra] 2f18b02 - [clang-tools-extra] Remove unused forward declarations (NFC)

Author: Kazu Hirata Date: 2022-01-30T16:05:00-08:00 New Revision: 2f18b02de7e365d9be1877810843a459bbe0d73d URL: https://github.com/llvm/llvm-project/commit/2f18b02de7e365d9be1877810843a459bbe0d73d DIFF: https://github.com/llvm/llvm-project/commit/2f18b02de7e365d9be1877810843a459bbe0d73d.diff

[PATCH] D118386: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b11c7659f8: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase` (authored by zero9178). Changed prior to commit:

[clang] e0b11c7 - [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase`

Author: Markus Böck Date: 2022-01-30T22:09:07+01:00 New Revision: e0b11c7659f81a382a3c76e26ed792308248f41c URL: https://github.com/llvm/llvm-project/commit/e0b11c7659f81a382a3c76e26ed792308248f41c DIFF: https://github.com/llvm/llvm-project/commit/e0b11c7659f81a382a3c76e26ed792308248f41c.diff

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

dmgreen accepted this revision. dmgreen added a comment. Thanks. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117753/new/ https://reviews.llvm.org/D117753 ___ cfe-commits mailing list

[clang] fdd0e74 - [clang] Remove redundant string initialization (NFC)

Author: Kazu Hirata Date: 2022-01-30T12:32:55-08:00 New Revision: fdd0e745c35dd9f8747d0aaa66488cfefc9634a6 URL: https://github.com/llvm/llvm-project/commit/fdd0e745c35dd9f8747d0aaa66488cfefc9634a6 DIFF: https://github.com/llvm/llvm-project/commit/fdd0e745c35dd9f8747d0aaa66488cfefc9634a6.diff

[PATCH] D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bcd2588a986: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z (authored by atrosinenko). Repository: rG LLVM Github

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1aed486efc6: [clang-format] Handle C variables with name that matches c++ access specifier (authored by psigillito, committed by curdeius).

[clang] d1aed48 - [clang-format] Handle C variables with name that matches c++ access specifier

Author: Philip Sigillito Date: 2022-01-30T20:56:50+01:00 New Revision: d1aed486efc6d35a81ca4acbabb4203c4b91cda9 URL: https://github.com/llvm/llvm-project/commit/d1aed486efc6d35a81ca4acbabb4203c4b91cda9 DIFF:

[PATCH] D118386: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase`

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118386/new/ https://reviews.llvm.org/D118386 ___

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito added a comment. In D117416#3282937 , @HazardyKnusperkeks wrote: > In D117416#3282853 , @psigillito > wrote: > >> Do I need to care about these pre-build checks failing? F21921747: image.png >>

[PATCH] D118573: [clang][WebAssemmbly]: Call TargetInfo::adjust in derived method.

sbc100 created this revision. Herald added subscribers: wingo, jgravelle-google, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. The superclass method handles a bunch of useful things. For example it applies flags

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3282853 , @psigillito wrote: > Do I need to care about these pre-build checks failing? F21921747: image.png > The checks passed, the build on linux failed. But as far

[PATCH] D118571: [clang][WebAssembly] Imply -fno-threadsafe-static when threading is disabled

sbc100 updated this revision to Diff 404402. sbc100 added a comment. - revert unrelated line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118571/new/ https://reviews.llvm.org/D118571 Files: clang/lib/Basic/Targets/WebAssembly.cpp

[PATCH] D118571: [clang][WebAssembly] Imply -fno-threadsafe-static when threading is disabled

sbc100 created this revision. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. When we don't enable atomics we completely disabled threading in

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3272589 , @aaron.ballman wrote: > There's a testing issue on Windows: > > TEST 'Clang :: Headers/mm_malloc.c' FAILED > > Script: > -- > : 'RUN: at line 1'; >

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3272594 , @jdoerfert wrote: > Don't test with O1 , add the > dummy include folder to the include path > (`clang/test/Headers/Inputs/include`), stdlib.h is already there,

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404397. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/test/Headers/mm_malloc.c Index:

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404395. xbolva00 added a comment. Added newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404394. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/test/Headers/mm_malloc.c Index:

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404393. xbolva00 added a comment. Herald added a subscriber: mstorsjo. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h

[PATCH] D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9595f0051000: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls (authored by atrosinenko). Repository: rG LLVM Github

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

nemanjai added a comment. Would it make sense (and would it be possible) to check the linkage of the callee? Presumably calling something like `static void localfunc(int *)` with an over-aligned member shouldn't be a problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito added a comment. Do I need to care about these pre-build checks failing? F21921747: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito added a comment. @HazardyKnusperkeks Ok thanks, someone else can commit on my behalf while I wait for commit access. name: Philip Sigillito email: psigill...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3282775 , @psigillito wrote: > @HazardyKnusperkeks I do not have commit access. This is my first commit to > the project. Do I just need to issue an 'arc land' command? I've never used arc, so I can't

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 404381. Quuxplusone added a comment. Poke CI (clang-format failed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117603/new/ https://reviews.llvm.org/D117603 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaExprMember.cpp

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone updated this revision to Diff 404380. Quuxplusone added a comment. Poke CI (clang-format failed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118552/new/ https://reviews.llvm.org/D118552 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaOverload.cpp

[PATCH] D118552: [clang] [concepts] Correctly(?) handle placeholder types in ExprRequirements.

Quuxplusone added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3375 +assert(T->isSpecificPlaceholderType(BuiltinType::UnknownAny) && "Unresolved placeholder type"); + } Quuxplusone wrote: > Btw, I strongly suspect that the presence of

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito added a comment. @HazardyKnusperkeks I do not have commit access. This is my first commit to the project. Do I just need to issue an 'arc land' command? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Yes, please push a revert so I can look later. Do you have a link to the buildbot configuration, so I can reproduce that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Have you commit access, or do you need some one to commit it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

RKSimon added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1534 } else if (StoreInst *SI = dyn_cast(I)) { -if (!ClInstrumentWrites || ignoreAccess(SI->getPointerOperand())) +if (!ClInstrumentWrites || ignoreAccess(LI,

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 updated this revision to Diff 404350. njames93 marked 5 inline comments as done. njames93 added a comment. Refactored implementation to not store state in ClangTidyContext. This will let external consumers of clang-tidy opt into the behaviour. As well as integrate the reporting to any

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. mlir-windows buildbot looks to be green now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 ___ cfe-commits mailing list

[PATCH] D118519: [clang-tidy] Organize the release notes a little better

njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:221-227 Removed checks ^^ Improvements to include-fixer - The improvements are... LegalizeAdulthood wrote: > salman-javed-nz

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 updated this revision to Diff 404347. tyb0807 added a comment. Add more tests and update accordingly to change from ACLE specification: `__builtin_arm_mops_memset_tag` requires _both_ MOPS and MTE features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION