[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

cmtice added a comment. When building/running third_party/llvm/llvm-project/clang/test/OpenMP/atomic_messages.c and third_party/llvm/llvm-project/clang/test/OpenMP/atomic_ast_print.cpp, we get use-of-uninitialized-variable error messages: SUMMARY: MemorySanitizer: use-of-uninitialized-value t

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 22 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3516-3518 +The clause tries to stick to the template declaration in case of class +templates or between template and function

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406167. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Incorporated review notes - Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113319/new/ https://reviews.llvm.org/D113319 Files: cl

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

Szelethus added a comment. Now that I remember, the ever so slightly different overloads of `ProgramState::getSVal` is a prime example I think. I always percieved that I have the means to invoke several of them at any point, but I never really knew which one. Though, to be fair, they were not d

[clang] 74b1c4c - [clang] added alloc allign attr to memalign

Author: Dávid Bolvanský Date: 2022-02-05T11:46:56+01:00 New Revision: 74b1c4c36740fe94953ef648e40df7dd9e9a9c7d URL: https://github.com/llvm/llvm-project/commit/74b1c4c36740fe94953ef648e40df7dd9e9a9c7d DIFF: https://github.com/llvm/llvm-project/commit/74b1c4c36740fe94953ef648e40df7dd9e9a9c7d.dif

[PATCH] D113319: [clang-format] Improve require and concept handling

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. @HazardyKnusperkeks I think this is tremendous, I think this looks and feels like a much more thorough approach to formatting concepts. Thank you so much for taking this on and

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

MyDeveloperDay added a comment. Thank you for looking into this, I'm more than happy for us to change the values to their more accurate first releases, but can I ask how you went about making those assumptions? For me initially I simply looks at the commit in the blame then tracked that to what

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this. LGTM (I double-checked a few and they all look good to me!) Comment at: clang/docs/ClangFormatStyleOptions.rst:2212 -**EmptyLineAfterAc

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

kuzkry added a comment. Hey @MyDeveloperDay, Thank you for your positive feedback :) You asked about my technique. Well, I did it empirically. There is a really splendid repository on GitHub by muttleyxd, i.e. https://github.com/muttleyxd/clang-tools-static-binaries. What muttleyxd did is he

[PATCH] D113319: [clang-format] Improve require and concept handling

curdeius accepted this revision. curdeius added a comment. I can just say: ship it! Thanks for all the work! Comment at: clang/lib/Format/ContinuationIndenter.cpp:1499-1500 + if (State.NextToken->ClosesRequiresClause && Style.IndentRequiresClause) { +// Remove the indenta

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3298635 , @cmtice wrote: > When building/running > third_party/llvm/llvm-project/clang/test/OpenMP/atomic_messages.c and > third_party/llvm/llvm-project/clang/test/OpenMP/atomic_ast_print.cpp, we get > use-of-

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7119f76 - [clang] added allocsize attribute to allocation functions

Author: Dávid Bolvanský Date: 2022-02-05T14:26:35+01:00 New Revision: 7119f76c47797391fddcfcb60f29e70a2b424713 URL: https://github.com/llvm/llvm-project/commit/7119f76c47797391fddcfcb60f29e70a2b424713 DIFF: https://github.com/llvm/llvm-project/commit/7119f76c47797391fddcfcb60f29e70a2b424713.dif

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

Bhramar.vatsa added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1892 + bool FieldPacked = + (Packed && (!FieldClass || D->getType().isCXX11PODType(Context) || + Context.getLangOpts().getClangABICompat() <= Maybe irres

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:186 void VisitCallExpr(const CallExpr *E) { FoundCallExpr = true; } + void VisitAsmStmt(const AsmStmt *S) { FoundCallExpr = true; } This is totally wrong, just big hack to smuggle i

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

qiucf added a comment. In D117972#3287553 , @pkubaj wrote: > Since I'm not a LLVM committer, can you commit it and merge to 14 branch? Sure. Sorry for late response, I'm on vacation these days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406186. HazardyKnusperkeks marked 7 inline comments as done. HazardyKnusperkeks added a comment. - Fixed use of a variable which slipped in from another change. - Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113319/new/ https://

[clang] f2f4080 - [PowerPC] Fix SSE translation on FreeBSD

Author: Piotr Kubaj Date: 2022-02-06T01:20:31+08:00 New Revision: f2f4080c10f4319adf75c660425911cd4e0e1843 URL: https://github.com/llvm/llvm-project/commit/f2f4080c10f4319adf75c660425911cd4e0e1843 DIFF: https://github.com/llvm/llvm-project/commit/f2f4080c10f4319adf75c660425911cd4e0e1843.diff L

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2f4080c10f4: [PowerPC] Fix SSE translation on FreeBSD (authored by pkubaj, committed by Qiu Chaofan ). Repository: rG LLVM Gi

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

MyDeveloperDay added a comment. Do you need someone to land this for you? if so we need your "name " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118991/new/ https://reviews.llvm.org/D118991 ___ cfe-co

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

kuzkry added a comment. In D118991#3298823 , @MyDeveloperDay wrote: > Do you need someone to land this for you? if so we need your "name > " Yes, I need someone to do that. Could you do this for me, please? It's "Krystian Kuzniarek ". Thanks in advanc

LLVM build master will be restarted at 1PM PST

Hello, LLVM build master will be restarted at 1pm PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 527654d - [libunwind] Attempt to fix broken sphinx doc link

Author: Simon Pilgrim Date: 2022-02-05T21:05:01Z New Revision: 527654dcebf83052ec05c087b98dd16c2313e9f9 URL: https://github.com/llvm/llvm-project/commit/527654dcebf83052ec05c087b98dd16c2313e9f9 DIFF: https://github.com/llvm/llvm-project/commit/527654dcebf83052ec05c087b98dd16c2313e9f9.diff LOG:

[libunwind] 2b9554b - [libunwind] [sparc] Add SPARCv9 support

Author: Koakuma Date: 2022-02-05T13:08:26-08:00 New Revision: 2b9554b8850192bdd86c02eb671de1d866df8d87 URL: https://github.com/llvm/llvm-project/commit/2b9554b8850192bdd86c02eb671de1d866df8d87 DIFF: https://github.com/llvm/llvm-project/commit/2b9554b8850192bdd86c02eb671de1d866df8d87.diff LOG:

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG171da443d598: [HIPSPV] Fix literals are mapped to Generic address space (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam created this revision. colavitam added reviewers: mizvekov, rsmith. Herald added a subscriber: arphaman. colavitam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Resolve the crash in issue #53609. The ArgumentPackSubstitutionInde

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam updated this revision to Diff 406213. colavitam added a comment. Fix comments for new test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119063/new/ https://reviews.llvm.org/D119063 Files: clang/lib/Sema/SemaTemplateInstantiate.c

[clang] 171da44 - [HIPSPV] Fix literals are mapped to Generic address space

Author: Yaxun (Sam) Liu Date: 2022-02-05T17:26:52-05:00 New Revision: 171da443d598662371f4101f0ba92c0138011ff6 URL: https://github.com/llvm/llvm-project/commit/171da443d598662371f4101f0ba92c0138011ff6 DIFF: https://github.com/llvm/llvm-project/commit/171da443d598662371f4101f0ba92c0138011ff6.dif

[PATCH] D118711: [hack] Build a tree of preprocessing directives

LegalizeAdulthood updated this revision to Diff 406220. LegalizeAdulthood added a comment. - Use LLVM RTTI for PP node types - Add routines to dump PP nodes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118711/new/ https://reviews.llvm.org/D118711 Files: clang-tools-extra/clang-tidy/

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:575 +// times 100. +if (getTarget().getTargetOpts().CodeObjectVersion != "none") { + unsigned CodeObjVer; tra wrote: > yaxunl wrote

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

yaxunl updated this revision to Diff 406221. yaxunl marked an inline comment as done. yaxunl added a comment. marshalling the arg as enum. fix test failures for -cc1as. temporarily disable it except v5. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119026/new/ https://reviews.llvm.org/

[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

ksyx created this revision. ksyx added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. ksyx added a project: clang-format. ksyx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit fixes https://github.com/llvm/llvm-project/

[clang] 6cd0015 - [clang-format][docs] Fix incorrect 'clang-format 14' option markers

Author: Krystian Kuzniarek Date: 2022-02-05T20:04:39-08:00 New Revision: 6cd0015e7827dd429844a18b7c8306e1d98044e4 URL: https://github.com/llvm/llvm-project/commit/6cd0015e7827dd429844a18b7c8306e1d98044e4 DIFF: https://github.com/llvm/llvm-project/commit/6cd0015e7827dd429844a18b7c8306e1d98044e4.

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cd0015e7827: [clang-format][docs] Fix incorrect 'clang-format 14' option markers (authored by kuzkry, committed by owenpan). Repository: rG LLVM