[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:39 + /// All elements in `Vals` must be non-null. + virtual Result solve(llvm::DenseSet Vals) = 0; +}; ymandel wrote: > Which `Result` is expected if the `Solver`

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev updated this revision to Diff 410460. sgatev marked 6 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120289/new/ https://reviews.llvm.org/D120289 Files:

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

jansvoboda11 added inline comments. Comment at: clang/test/Modules/cxx20-multiple-partitions.cpp:48 +#else +#error "no TU set" +#endif Instead of splitting the file with preprocessor, you could use the `split-file` utility (introduced in D83834). Repository:

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

curdeius added a comment. Nice job! Please let us a bit of time to review that. Also, I think it would be good to get a reviewer that knows well the yaml parts. Or even split it to a separate revision. And this part needs tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. In D118586#3336933 , @iains wrote: > In D118586#3336892 , @ChuanqiXu > wrote: > >> In D118586#3336865 , @iains wrote: >> >>> In

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added a comment. In D118586#3336892 , @ChuanqiXu wrote: > In D118586#3336865 , @iains wrote: > >> In D118586#3336612 , @ChuanqiXu >> wrote: >> >>> (May off the

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. In D118586#3336865 , @iains wrote: > In D118586#3336612 , @ChuanqiXu > wrote: > >> (May off the patch) > > I am not sure what you mean here. I mean this comment is not related to the

[PATCH] D111100: enable plugins for clang-tidy

tstellar added a comment. I've proposed a fix for the standalone builds here D120301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar created this revision. tstellar added a reviewer: vtjnash. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang-tools-extra. This fixes clang + clang-tools-extra standalone build after 36892727e4f19a60778e371d78f8fb09d8122c85

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains added a comment. In D118586#3336612 , @ChuanqiXu wrote: > (May off the patch) I am not sure what you mean here. > BTW, I know you also work on GCC frontend. I want to consultant what's your > opinion to uniform the command line options between

[PATCH] D120290: [WIP][Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 410448. tianshilei1992 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/include/clang/AST/StmtOpenMP.h

[clang] 8d9eeb0 - [Driver][OpenBSD] Add comments for C++ tests

Author: Brad Smith Date: 2022-02-22T00:20:46-05:00 New Revision: 8d9eeb03b3e9c800843659f243242f262d7bd786 URL: https://github.com/llvm/llvm-project/commit/8d9eeb03b3e9c800843659f243242f262d7bd786 DIFF: https://github.com/llvm/llvm-project/commit/8d9eeb03b3e9c800843659f243242f262d7bd786.diff

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 410444. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[clang] 289b725 - [Driver][OpenBSD] Test tweaking and clean up

Author: Brad Smith Date: 2022-02-21T23:44:53-05:00 New Revision: 289b725051cfb4a7167936db89583aa6b8a12d18 URL: https://github.com/llvm/llvm-project/commit/289b725051cfb4a7167936db89583aa6b8a12d18 DIFF: https://github.com/llvm/llvm-project/commit/289b725051cfb4a7167936db89583aa6b8a12d18.diff

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77e60bc42c48: [clang-format] Add option to insert braces after control statements (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 77e60bc - [clang-format] Add option to insert braces after control statements

Author: owenca Date: 2022-02-21T20:16:25-08:00 New Revision: 77e60bc42c48e16d646488d43210b1630cd4db49 URL: https://github.com/llvm/llvm-project/commit/77e60bc42c48e16d646488d43210b1630cd4db49 DIFF: https://github.com/llvm/llvm-project/commit/77e60bc42c48e16d646488d43210b1630cd4db49.diff LOG:

[clang] 95fed2b - [Driver][OpenBSD] Pass sysroot to the linker

Author: Brad Smith Date: 2022-02-21T23:11:13-05:00 New Revision: 95fed2b267ee87e6cba72ebe73f0d6fdab37f995 URL: https://github.com/llvm/llvm-project/commit/95fed2b267ee87e6cba72ebe73f0d6fdab37f995 DIFF: https://github.com/llvm/llvm-project/commit/95fed2b267ee87e6cba72ebe73f0d6fdab37f995.diff

[PATCH] D120298: [HIP] Support `--default-stream`

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: dexonsmith, dang. yaxunl requested review of this revision. Introduce `--default-stream={legacy|per-thread}` option to support per-thread default stream for HIP runtime. When `--default-stream=per-thread`, HIP

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" +

[PATCH] D120297: [Driver][RISCV] Add missing rv64 test case

eopXD created this revision. eopXD added a reviewer: rogfer01. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Current ASTContext.getAttributedType() takes attribute kind, ModifiedType and EquivType as

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee abandoned this revision. bc-lee added a comment. Closed in favor of https://reviews.llvm.org/D118862 and https://reviews.llvm.org/D118875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:39 + /// All elements in `Vals` must be non-null. + virtual Result solve(llvm::DenseSet Vals) = 0;

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +//

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. (May off the patch) BTW, I know you also work on GCC frontend. I want to consultant what's your opinion to uniform the command line options between Clang and GCC. Now it looks totally different. I feel it would be a problem for clang. Since the command line between

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i8

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +//

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

tyb0807 updated this revision to Diff 410418. tyb0807 added a comment. Revert latest change, as it is likely that people still rely on `ARM_FEATURE_CRYPTO` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118757/new/ https://reviews.llvm.org/D118757

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. LGTM. Thanks Alex. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118875/new/ https://reviews.llvm.org/D118875 ___

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + tianshilei1992 wrote: > ABataev

[PATCH] D120290: [WIP][Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the codegen

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 410414. jhuber6 added a comment. Changing after rebasing previous commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files:

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 updated this revision to Diff 410413. jhuber6 added a comment. Updating after moving dense map implementation out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 Files:

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, mstorsjo, rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) :

[PATCH] D120288: [OpenMP] Implement dense map info for device file

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch implements a DenseMap info struct

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +//

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, wait for the other patches though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120270/new/ https://reviews.llvm.org/D120270

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 updated this revision to Diff 410405. jhuber6 added a comment. Removing unrelated changes and adding test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120270/new/ https://reviews.llvm.org/D120270 Files:

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i8

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

iains updated this revision to Diff 410404. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 updated this revision to Diff 410403. tyb0807 added a comment. Add checks for default ACLE macros for different architecture versions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153 Files:

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 410400. sstwcw marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw marked 3 inline comments as done. sstwcw added a comment. About the unit tests that failed in B150668 . It looks like they were stopped because they took over 1 minute. I ran the first test on my laptop. Both this revision and main took about 2

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +//

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + tianshilei1992 wrote: >

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 added a comment. In D120270#3336272 , @jdoerfert wrote: > Can we have a test for this? Sure. Comment at: clang/include/clang/CodeGen/BackendUtil.h:48 - void EmbedObject(llvm::Module *M, const CodeGenOptions ,

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jdoerfert added a comment. Tests? Comment at: clang/lib/Driver/Driver.cpp:3956 LA = C.MakeAction(LinkerInputs, types::TY_Image); - LA->propagateHostOffloadInfo(OffloadKinds, + LA->propagateHostOffloadInfo(C.getActiveOffloadKinds(),

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. In D120271#3336277 , @jdoerfert wrote: > The failing test needs to be adjusted, right? Yes, forgot about that. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187 +return

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jdoerfert added a comment. The failing test needs to be adjusted, right? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:187 +return LHS.OffloadKind == RHS.OffloadKind && + LHS.TheTriple == RHS.TheTriple && LHS.Arch == RHS.Arch; + }

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jdoerfert added a comment. Can we have a test for this? Comment at: clang/include/clang/CodeGen/BackendUtil.h:48 - void EmbedObject(llvm::Module *M, const CodeGenOptions , DiagnosticsEngine ); Seems unrelated, please remove it from this

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall added a comment. I don't know a good way to automatically reduce examples, I usually do it by hand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258

[PATCH] D120282: [Format] Remove unused LineContainsContinuedForLoopSection. NFC

sammccall created this revision. sammccall added a reviewer: MyDeveloperDay. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120282 Files:

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336145 , @ABataev wrote: > In D118632#3336133 , > @tianshilei1992 wrote: > >> In D118632#3336094 , @ABataev >> wrote: >> >>>

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. No apparent differences. Is there a way to automatically reduce it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 ___ cfe-commits

[clang] eec3488 - [CMake][Fuchsia] Disable assertions and analyzer for stage 1

Author: Petr Hosek Date: 2022-02-21T13:31:13-08:00 New Revision: eec3488cf1d84d3503d5a8535b64374b79287bb9 URL: https://github.com/llvm/llvm-project/commit/eec3488cf1d84d3503d5a8535b64374b79287bb9 DIFF: https://github.com/llvm/llvm-project/commit/eec3488cf1d84d3503d5a8535b64374b79287bb9.diff

[PATCH] D120280: [CMake][Fuchsia] Disable assertions and analyzer for stage 1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeec3488cf1d8: [CMake][Fuchsia] Disable assertions and analyzer for stage 1 (authored by phosek). Herald added a project: clang. Herald added a

[PATCH] D120278: [clang-format] Don't break semi after requires clause regardless of the chosen style

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius, JohelEGP. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

iains updated this revision to Diff 410371. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added a comment. In D118632#3336133 , @tianshilei1992 wrote: > In D118632#3336094 , @ABataev wrote: > >> LG with a nit > > Actually I got two question in the inline comments. Can you please take a >

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 410370. jhuber6 added a comment. Make sure we don't pass PTX to nvlink. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files:

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336094 , @ABataev wrote: > LG with a nit Actually I got two question in the inline comments. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall added a comment. Thanks - any chance you can reduce an example where hover works and inlay hints do not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. Looks like this only covers a subset. I see hints for some generic lambdas but not for others while hovering over auto reveals the type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/

[libunwind] 3fa2e66 - [libunwind] Further fix for 32-bit PowerPC processors without AltiVec

Author: George Koehler Date: 2022-02-21T15:31:23-05:00 New Revision: 3fa2e66c10aadac1d209afadba34d90c9bd95221 URL: https://github.com/llvm/llvm-project/commit/3fa2e66c10aadac1d209afadba34d90c9bd95221 DIFF:

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c3310d32c6: [OPENMP]Fix PR49366: crash on VLAs in task untied

[clang] f9c3310 - [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

Author: Alexey Bataev Date: 2022-02-21T12:28:47-08:00 New Revision: f9c3310d32c62b28c10084a0104563aeeecc06ec URL: https://github.com/llvm/llvm-project/commit/f9c3310d32c62b28c10084a0104563aeeecc06ec DIFF: https://github.com/llvm/llvm-project/commit/f9c3310d32c62b28c10084a0104563aeeecc06ec.diff

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

owenpan updated this revision to Diff 410365. owenpan marked an inline comment as done. owenpan added a comment. If the line immediately following `// clang-format off` is a line comment, `assert(!Token->Finalized)` will fail. Fixed it and updated the corresponding unit test. CHANGES SINCE

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/include/clang/AST/StmtOpenMP.h:2970 + } + /// Get + Expr *getCondExpr() { Fix comment Repository: rG LLVM Github

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein updated this revision to Diff 410360. ibookstein added a comment. clang-format + description wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120266/new/ https://reviews.llvm.org/D120266 Files:

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. After basic support for embedding and handling

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the basic support

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the offload kind to the embedded section name in preparation for

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: ormris, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently we use the

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

iains updated this revision to Diff 410348. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118587/new/ https://reviews.llvm.org/D118587 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein created this revision. ibookstein added reviewers: erichkeane, rsmith, MaskRay. ibookstein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The purpose of this change is to fix the following codegen bug: // main.c

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2855e17601e: [Clang][OpenMP] Add Sema support for atomic compare capture (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[clang] e2855e1 - [Clang][OpenMP] Add Sema support for atomic compare capture

Author: Shilei Tian Date: 2022-02-21T14:21:02-05:00 New Revision: e2855e17601e8a193bf07b0533be69dbf85b811c URL: https://github.com/llvm/llvm-project/commit/e2855e17601e8a193bf07b0533be69dbf85b811c DIFF: https://github.com/llvm/llvm-project/commit/e2855e17601e8a193bf07b0533be69dbf85b811c.diff

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:49 +/// | `printf("hello, "); +/// |-+ Conditional -+ Directive #ifndef NDEBUG +/// | |-+ Code printf("debug\n");

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

sammccall updated this revision to Diff 410340. sammccall marked 26 inline comments as done. sammccall added a comment. Herald added a subscriber: dexonsmith. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119162/new/

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam added a comment. `release/14.x` now configures but fails to build on MSVC2019 with `-D LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON` like at https://reviews.llvm.org/D00 FAILED: bin/CTTestTidyModule.dll cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Until now, any types that had TypeExtensions attached to them were

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

JonasToth abandoned this revision. JonasToth added a comment. Herald added a subscriber: mgehre. won't happen anymore realistically. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54141/new/ https://reviews.llvm.org/D54141

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

zoecarver accepted this revision. zoecarver added a comment. This revision is now accepted and ready to land. This looks great, thanks Egor! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120160/new/ https://reviews.llvm.org/D120160

[PATCH] D119481: run-clang-tidy: Fix infinite loop on windows

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM with a small nit Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:69 while not os.path.isfile(os.path.join(result, path)): -if

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall added a comment. D120258 is the followup with inlay hints. It rearranges some of the code from this patch for reuse, and proposes dropping support for multiple instantiations yielding the same result, as this inevitably pushes complexity into each

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

sammccall created this revision. sammccall added reviewers: nridge, Trass3r. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This takes a

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains updated this revision to Diff 410320. iains added a comment. rebased, added a multi-partition testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 Files: clang/include/clang/AST/Decl.h

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: tyb0807 wrote: > SjoerdMeijer wrote: > > tyb0807 wrote: > > >

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

fonzvermund added a comment. http://webonlinegambling.idea.informer.com/ https://webonlinegambling.com/mobile-casinos/ http://playlegalsportsbetting.idea.informer.com/ http://legalsportsbetting.idea.informer.com/ https://sourceforge.net/u/legalsportsbet/profile

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410318. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

fonzvermund added a comment. https://njonlinecasinos.webgarden.com/casinos/nj-casino-reviews/tropicana-online-casino http://playlegalsportsbetting.com/borgata-online-casino-pa/ https://casinowatchnj.com/borgata-online-casino/ https://casinowatchnj.com/betmgm-online-casino/

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: SjoerdMeijer wrote: > tyb0807 wrote: > > SjoerdMeijer wrote: > > >

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif I'm in doubt whether we could just reuse `__opencl_c_subgroups` for this?

[PATCH] D120252: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a3d9ae54592: [Clang][OpenMP] Fix wrong form of cond-update-stmt in atomic_ast_print.cpp (authored by tianshilei1992). Repository: rG LLVM

[clang] 3a3d9ae - [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

Author: Shilei Tian Date: 2022-02-21T11:40:09-05:00 New Revision: 3a3d9ae545925162ebbe820639cd2fe072ff4dd8 URL: https://github.com/llvm/llvm-project/commit/3a3d9ae545925162ebbe820639cd2fe072ff4dd8 DIFF: https://github.com/llvm/llvm-project/commit/3a3d9ae545925162ebbe820639cd2fe072ff4dd8.diff

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh created this revision. svenvh added a reviewer: azabaznov. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now, subgroup builtins are available with `opencl-c.h` when

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410313. tianshilei1992 added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:958 case llvm::ARM::ArchKind::ARMV8_6A: + case llvm::ARM::ArchKind::ARMV8_7A: case llvm::ARM::ArchKind::ARMV8_8A: tyb0807 wrote: > SjoerdMeijer wrote: > > I see tests for the

  1   2   >