[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

yurai007 added a comment. In D120334#3338367 , @jansvoboda11 wrote: > In D120334#3338314 , @yurai007 > wrote: > >> In D120334#3337961 , @jansvoboda11 >> wrote: >> >>>

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. In D120374#3339337 , @penagos wrote: > Though it's still unclear to me whether or not it'd make more sense to > continue to pursue a change to

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410719. SAtacker added a comment. Attempt to update this commit appropriately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files:

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410718. SAtacker added a comment. Removed whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410717. SAtacker added a comment. Suspected reason why the patch isn't applied: trailing space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files:

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410715. SAtacker retitled this revision from "[clang-tidy][run-clang-tidy.py] Whitespace addition Depends on D120385" to "[clang-tidy][run-clang-tidy.py] Whitespace addition". SAtacker edited the summary of this revision. SAtacker added a comment. Fix CI

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition Depends on D120385

SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - spaces: - Consistent with the rest of the

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

SAtacker accepted this revision. SAtacker added a comment. This revision is now accepted and ready to land. In D120385#3339440 , @Eugene.Zelenko wrote: > I think will be good to merge these changes to D120331 > .

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. Looking into the (new) build failure on Windows, since the change has already been reviewed, will try to commit after resolving the build failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

Eugene.Zelenko added a comment. I think will be good to merge these changes to D120331 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120385/new/ https://reviews.llvm.org/D120385

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:239 help='Specify the path of .clang-tidy or custom config' - 'file: e.g. -config-file=/some/path/myTidyConfigFile' +

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Depends on D120331

[PATCH] D120383: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain.

vvereschaka created this revision. vvereschaka added a reviewer: vvereschaka. Herald added subscribers: kristof.beyls, mgorny. vvereschaka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provide CMAKE_SYSROOT for the

[PATCH] D101322: [clang-format] Add comment justification for https://reviews.llvm.org/D100778

penagos abandoned this revision. penagos added a comment. Closing old review request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101322/new/ https://reviews.llvm.org/D101322 ___ cfe-commits mailing

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

penagos created this revision. penagos added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. penagos updated this revision to Diff 410700. penagos added a comment. penagos published this revision for review. penagos added a comment. Herald added a project: clang. Herald added a

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

tschuett added subscribers: MaskRay, tschuett. tschuett added a comment. https://reviews.llvm.org/D117809 There was a discussion that `-emit-llvm` is considered a mistake. @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

rovka added a comment. Nit: Should we also have a test for print-effective-triple? Otherwise LGTM, although I'm not sure that -emit-llvm is necessarily something we'd want flang users to be exposed to. Comment at: flang/include/flang/Frontend/TargetOptions.h:20 +/// Options

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5153d9e7262: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst… (authored by arphaman). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Changed

[PATCH] D120375: Trim unnecessary component/library dependencies.

mehdi_amini added a comment. Please expand the description and include how you figured this out and how do we know it is actually correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120375/new/ https://reviews.llvm.org/D120375

[PATCH] D120298: [HIP] Support `-fgpu-default-stream`

yaxunl updated this revision to Diff 410691. yaxunl marked an inline comment as done. yaxunl retitled this revision from "[HIP] Support `--default-stream`" to "[HIP] Support `-fgpu-default-stream`". yaxunl edited the summary of this revision. yaxunl added a comment. rename the option and use

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

mwyman added inline comments. Comment at: clang/test/SemaObjC/objc-precise-lifetime-unused-variable.m:7 + // no diagnostics for objects with precise lifetime semantics. + __attribute__((objc_precise_lifetime)) id x; + x = getFoo(); dmaclach wrote: > what

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:5944 + (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C), \ + (unsigned char)(imm), (__mmask16)-1)) + craig.topper wrote: > Why do we need to change the

[PATCH] D119479: [clang][extract-api] Add global record support

MaskRay added a comment. There is a circular dependency if you use `-DBUILD_SHARED_LIBS=on`: CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle): "clangFrontend" of type SHARED_LIBRARY depends on "clangIndex" (weak)

[clang] 36e335e - [clang] Remove Address::deprecated() calls in CodeGenFunction.cpp

Author: Arthur Eubanks Date: 2022-02-22T18:28:49-08:00 New Revision: 36e335eeb577b6dc559de3a66bc832afae1f56c4 URL: https://github.com/llvm/llvm-project/commit/36e335eeb577b6dc559de3a66bc832afae1f56c4 DIFF:

[clang] 6a0b78a - [OpenMP] Remove static allocator in linker wrapper

Author: Joseph Huber Date: 2022-02-22T21:22:19-05:00 New Revision: 6a0b78af9175af45641c854a88761f284361aaee URL: https://github.com/llvm/llvm-project/commit/6a0b78af9175af45641c854a88761f284361aaee DIFF: https://github.com/llvm/llvm-project/commit/6a0b78af9175af45641c854a88761f284361aaee.diff

[clang] 55cb84d - [OpenMP] Unrecognized objects should not be considered failure

Author: Joseph Huber Date: 2022-02-22T21:22:18-05:00 New Revision: 55cb84d9fbea1ead9434de519e1b4e1d2d803048 URL: https://github.com/llvm/llvm-project/commit/55cb84d9fbea1ead9434de519e1b4e1d2d803048 DIFF: https://github.com/llvm/llvm-project/commit/55cb84d9fbea1ead9434de519e1b4e1d2d803048.diff

[PATCH] D120352: [C++20][Modules] Rework testcase to use split file [NFC].

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120352/new/ https://reviews.llvm.org/D120352

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

dmaclach accepted this revision. dmaclach added inline comments. Comment at: clang/test/SemaObjC/objc-precise-lifetime-unused-variable.m:7 + // no diagnostics for objects with precise lifetime semantics. + __attribute__((objc_precise_lifetime)) id x; + x = getFoo();

[PATCH] D117611: [Sema] Warn about printf %n on Android and Fuchsia

glandium added a comment. This doesn't leave much room to use `__attribute__((format(printf)))` on custom printf implementations that do support `%n` on Android does it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117611/new/

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

stephanemoore added a comment. Maybe ahatanak might be a good reviewer based on https://reviews.llvm.org/D112850? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120372/new/ https://reviews.llvm.org/D120372

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Make sense to me. I don't know offhand who might be a good second pair of eyes to take a look. Comment at:

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

mwyman created this revision. mwyman added reviewers: stephanemoore, dmaclach. mwyman added a project: clang. mwyman requested review of this revision. Herald added a subscriber: cfe-commits. The `objc_precise_lifetime` attribute is applied to Objective-C pointers to ensure the optimizer does

[clang] cde658f - [clang] Remove Address::deprecated() calls in CGVTables.cpp

Author: Arthur Eubanks Date: 2022-02-22T16:54:28-08:00 New Revision: cde658fa1f1449d2ec966b8c0df0444b882eb69f URL: https://github.com/llvm/llvm-project/commit/cde658fa1f1449d2ec966b8c0df0444b882eb69f DIFF:

[PATCH] D120369: [analyzer] Add more propagations to Taint analysis

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. gamesh411 requested review of this

[clang] 3ef7e6c - [clang] Remove an Address::deprecated() call in CGClass.cpp

Author: Arthur Eubanks Date: 2022-02-22T16:19:06-08:00 New Revision: 3ef7e6c53c825903d77a8d004a82c865f493e1bf URL: https://github.com/llvm/llvm-project/commit/3ef7e6c53c825903d77a8d004a82c865f493e1bf DIFF:

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao created this revision. shangwuyao added reviewers: jlebar, tra, yaxunl. Herald added subscribers: carlosgalvezp, ThomasRaoux, Anastasia. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch converts CUDA pointer

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:358 + /// function declarations when we do not emit a definition for the resolver. + std::vector MultiVersionIFuncs; + Optional: `SmallVector` typically compiles to less code.

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw marked 18 inline comments as done. sstwcw added a comment. The YAML stuff are now in D120363 . Comment at: clang/docs/ClangFormatStyleOptions.rst:1408-1415 + Precise control over the wrapping of braces. + + .. code-block:: c++ + +

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire added a comment. Gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120361: [clang-format] Extract doc for entire configuration structs

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously the comments for configuration structs as a whole like

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3338718 , @ABataev wrote: > In D120353#3338647 , @jhuber6 wrote: > >> But the main reason I made this patch is for interoperability. Without this >> if you want to call a CUDA

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:236 'each source file in its parent directories.') + parser.add_argument('-config-file', default=None, + help='Specify the path of

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

li.zhe.hua added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:68 +using AnyGenerator2 = std::shared_ptr>; + Placeholder name; suggestions welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a subscriber: carlosgalvezp. li.zhe.hua requested review of this revision. Herald added projects: clang, clang-tools-extra. Change RewriteRule from holding an `Explanation` to being able to generate arbitrary

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

ABataev added a comment. In D120353#3338647 , @jhuber6 wrote: > In D120353#3338589 , @ABataev wrote: > >>> This is necessary for implementing features like conditional offloading and >>> ensuring that unhandled

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3338589 , @ABataev wrote: >> This is necessary for implementing features like conditional offloading and >> ensuring that unhandled pragmas don't result in missing symbols. > > This behavior is part of the standard.

[PATCH] D113319: [clang-format] Improve require and concept handling

curdeius added a comment. In D113319#3338290 , @HazardyKnusperkeks wrote: > > That means someone guesses this is a binary op and guesses wrong. I try to > take a look at it. Yeah, I just found out that it is set in `determineStarAmpUsage` here:

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius requested review of this revision. curdeius added a comment. I took another approach to fix the problem found in polly tests. I added CppCastLParen kind so as not to interfere with C-style casts. I also added a test case taken from lib/Format that got misformatted by the previous

[PATCH] D120140: [clang-format] Avoid inserting space after C++ casts.

curdeius updated this revision to Diff 410638. curdeius added a comment. This revision is now accepted and ready to land. - Fix. Add tests from inspired by polly and lib/Format that had misformats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

ABataev added a comment. > This is necessary for implementing features like conditional offloading and > ensuring that unhandled pragmas don't result in missing symbols. This behavior is part of the standard. > For offloading tests we can silently fail to the host without realizing that >

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. For a callback like [](auto) {...} the inlay hint is displayed after the `)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 ___

[PATCH] D120278: [clang-format] Don't break semi after requires clause regardless of the chosen style

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG923c3755ea80: [clang-format] Dont break semi after requires clause ... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D120237: [clang-format][NFC] Simplify if in ContinuationIndenter::addTokenOCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ebb00a22e7e: [clang-format][NFC] Simplify if in ContinuationIndenter::addTokenOCL (authored by HazardyKnusperkeks). Repository: rG LLVM Github

[clang] 923c375 - [clang-format] Don't break semi after requires clause ...

Author: Björn Schäpers Date: 2022-02-22T22:08:03+01:00 New Revision: 923c3755ea809275d6c06caf547525452568eb5f URL: https://github.com/llvm/llvm-project/commit/923c3755ea809275d6c06caf547525452568eb5f DIFF:

[clang] 7ebb00a - [clang-format][NFC] Simplify if in ContinuationIndenter::addTokenOCL

Author: Björn Schäpers Date: 2022-02-22T22:08:02+01:00 New Revision: 7ebb00a22e7ec78a3090ecc15f59d247e0f390db URL: https://github.com/llvm/llvm-project/commit/7ebb00a22e7ec78a3090ecc15f59d247e0f390db DIFF:

[PATCH] D120352: [C++20][Modules] Rework testcase to use split file [NFC].

iains created this revision. iains added reviewers: urnathan, ChuanqiXu. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. probably qualifies as trivial/obvious but in case anyone has any comments. This

[PATCH] D120309: [clang-format] Fix QualifierOrder breaking the code with requires clause.

curdeius updated this revision to Diff 410618. curdeius added a comment. Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120309/new/ https://reviews.llvm.org/D120309 Files: clang/lib/Format/QualifierAlignmentFixer.cpp

[PATCH] D120309: [clang-format] Fix QualifierOrder breaking the code with requires clause.

curdeius added a comment. In D120309#3338265 , @HazardyKnusperkeks wrote: > Does it work with a more complex requires clause? Or were they unaffected > before? Like `Foo && Bar`? They were unaffected but I'll add a test. Repository: rG LLVM Github

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

jansvoboda11 added a comment. In D120334#3338314 , @yurai007 wrote: > In D120334#3337961 , @jansvoboda11 > wrote: > >> The performance implications are pretty interesting! Have you tried avoiding >> the copy

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

NeHuang added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117355/new/ https://reviews.llvm.org/D117355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

yurai007 added a comment. In D120334#3337961 , @jansvoboda11 wrote: > The performance implications are pretty interesting! Have you tried avoiding > the copy altogether by just storing the reference? Yes, actually that was my first attempt but I

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains updated this revision to Diff 410599. iains added a comment. reformat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119823/new/ https://reviews.llvm.org/D119823 Files: clang/lib/Frontend/FrontendActions.cpp

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 410597. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

yaxunl added a comment. In D88425#3337003 , @MaskRay wrote: > I plan to default CMake `CLANG_DEFAULT_PIE_ON_LINUX` to on in D120305 > and hip-fpie-option.hip will fail. Do you > mind investigating the issue? You need

[PATCH] D113319: [clang-format] Improve require and concept handling

; > AnnotatedTokens(L=1): >M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=semi L=1 PPK=2 FakeLParens= > FakeRParens=0 II=0x0 Text=';' > > AnnotatedTokens(L=0): >M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=eof L=0 PPK=2 FakeLParens= > FakeRParens=0 II=0x0

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

mariospr added a comment. In D117238#3338205 , @aaron.ballman wrote: > In D117238#3338092 , @erichkeane > wrote: > >> Hi Mario! Thank you for inquiring! As you may know, we disabled _BitInt >> this large

[PATCH] D120309: [clang-format] Fix QualifierOrder breaking the code with requires clause.

HazardyKnusperkeks added a comment. Does it work with a more complex requires clause? Or were they unaffected before? Like `Foo && Bar`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120309/new/ https://reviews.llvm.org/D120309

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

xazax.hun added a comment. In D120289#3338244 , @sgatev wrote: >> I wonder if it would make sense to have a SAT base class for the SMT API and >> reuse that here? > > I think that on a high level we can either 1) integrate the SMT API types > deeply

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added a comment. In D119599#3336936 , @curdeius wrote: > Nice job! Please let us a bit of time to review that. > Also, I think it would be good to get a reviewer that knows well the yaml > parts. Or even split it to a separate

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro abandoned this revision. ro added a comment. Superceded by D119829 and D120048 . If absolutely necessary, D120059 could be revived if Illumos cannot implement `dlpi_tls_modid`.

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some small nits, but can you also add a release note for the fix? (If there was a bug report for this issue, you should mention that report in the release note and

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev added a comment. > Did you look into reusing existing SAT solvers like miniSAT? What was the > main reason for rolling our own instead of picking something up off the > shelves? Mainly to provide a lightweight out-of-the-box alternative. The solver interface is simple so one should be

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fc966d2e41: [Driver] Support Solaris/amd64 GetTls (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/

[clang] b1fc966 - [Driver] Support Solaris/amd64 GetTls

Author: Rainer Orth Date: 2022-02-22T20:14:33+01:00 New Revision: b1fc966d2e4176e640cda52c7148f565e93bedd0 URL: https://github.com/llvm/llvm-project/commit/b1fc966d2e4176e640cda52c7148f565e93bedd0 DIFF: https://github.com/llvm/llvm-project/commit/b1fc966d2e4176e640cda52c7148f565e93bedd0.diff

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:5944 + (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C), \ + (unsigned char)(imm), (__mmask16)-1)) + Why do we need to change the type on `imm`

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman added a comment. In D117238#3338092 , @erichkeane wrote: > In D117238#3338071 , @mariospr > wrote: > >> In D117238#3270125 , >> @aaron.ballman wrote: >>

[PATCH] D120132: [HIP] Fix HIP include path

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } My impression, after reading the

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120298: [HIP] Support `--default-stream`

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:962 NegFlag>; +def default_stream_EQ : Joined<["--"], "default-stream=">, + HelpText<"Specify default stream. Valid values are 'legacy' and 'per-thread'.

[PATCH] D119128: [analyzer] Fix taint propagation by remembering to the location context

steakhal added a comment. I'll re-land the whole stack tomorrow, by adding the asserts requirement for the tests to make the tests pass on all bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119128/new/ https://reviews.llvm.org/D119128

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

xazax.hun added a comment. Note that, there are already precedents for Clang using solver tech from LLVM. E.g., the clang static analyzer's Z3-based refutation support is using the SMT API in LLVM, and there are experiments integrating yet another solver with the SA:

[PATCH] D120298: [HIP] Support `--default-stream`

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:962 NegFlag>; +def default_stream_EQ : Joined<["--"], "default-stream=">, + HelpText<"Specify default stream. Valid values are 'legacy' and 'per-thread'. The default value is 'legacy'. (HIP

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

xazax.hun added a comment. Hi! Just a quick high level question. Did you look into reusing existing SAT solvers like miniSAT? What was the main reason for rolling our own instead of picking something up off the selves? Also, LLVM already has a SMT API

[PATCH] D120149: [clang][dataflow] Add support for global storage values

sgatev updated this revision to Diff 410580. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120149/new/ https://reviews.llvm.org/D120149 Files:

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120333

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

erichkeane added a subscriber: mgehre-amd. erichkeane added a comment. In D117238#3338071 , @mariospr wrote: > In D117238#3270125 , @aaron.ballman > wrote: > >> Updated to allow targets to specify the max

[PATCH] D119470: [clang-tidy] Don't check decltype return types in `readability-const-return-type`

aaron.ballman added a comment. In D119470#3312223 , @Izaron wrote: > I think we don't need to update the docs > (https://clang.llvm.org/extra/clang-tidy/checks/readability-const-return-type.html) > Because a user would expect this behaviour. > > //If

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

mariospr added a comment. In D117238#3270125 , @aaron.ballman wrote: > Updated to allow targets to specify the max bitwidth. I was aware that the > x86 backend had issues with doing division on larger `_BitInt` objects, but > it turns out *all*

[PATCH] D120149: [clang][dataflow] Add support for global storage values

xazax.hun added a comment. In D120149#056 , @sgatev wrote: > I think we should provide such functionality and it probably should also > apply to some of the pointer and reference values. Not sure what the default > should be, but having the ability

[clang] 16994a2 - Fix the Sphinx build after f8cedc642d9b85720cb7175ef25ddde90a3fbca2

Author: Aaron Ballman Date: 2022-02-22T12:50:39-05:00 New Revision: 16994a2cfaac6305f49a02afc1218e5c33199ea4 URL: https://github.com/llvm/llvm-project/commit/16994a2cfaac6305f49a02afc1218e5c33199ea4 DIFF: https://github.com/llvm/llvm-project/commit/16994a2cfaac6305f49a02afc1218e5c33199ea4.diff

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. In D120271#3338034 , @saiislam wrote: > Will it be possible to use Bundle Entry ID format [1] for naming sections and > being sort of the the primary key to refer an offload object? > The arch string following the triple will be

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

saiislam added a comment. Will it be possible to use Bundle Entry ID format [1] for naming sections and being sort of the the primary key to refer an offload object? The arch string following the triple will be just offload-arch (or march, or mcpu) for others, but for amdgpu it may contain some

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains added a comment. this now uses the split-file approach to the test case so that we have the test case self-contained, but avoid the use of preprocessor directives before the module lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains updated this revision to Diff 410568. iains added a comment. rebased, amended testcases to use split-file, handle partition enumerations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119823/new/ https://reviews.llvm.org/D119823 Files:

[PATCH] D120325: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Besides abusing the `-analyzer-constraints=z3` option we should really have some way displaying whether or not this clang was built w/o Z3. I'm accepting this, given that

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337045 , @atanasyan wrote: > In D120305#3337019 , @MaskRay wrote: > >> @atanasyan A few mips test/Driver tests will fail. Wonder if you have time >> making them more

[clang] cedc23b - [MIPS] Add `-no-pie` option to the clang driver's tests depend on it

Author: Simon Atanasyan Date: 2022-02-22T20:24:21+03:00 New Revision: cedc23bc8612feea61c0a7d92ccaae1ce51520ce URL: https://github.com/llvm/llvm-project/commit/cedc23bc8612feea61c0a7d92ccaae1ce51520ce DIFF:

[PATCH] D120066: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue.

probinson added a comment. Seems to me there have been other cases where `.*` matching was greedier than expected, so this seems like the right fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120066/new/ https://reviews.llvm.org/D120066

  1   2   3   >