[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/test/Modules/cxx20-10-1-ex2.cpp:15-17 -// Not expected to work yet. // %clang_cc1 -std=c++20 -emit-module-interface %t/std10-1-ex2-tu4.cpp \ // -fmodule-file=%t/B.pcm -o %t/B_X2.pcm

[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

iains updated this revision to Diff 411741. iains added a comment. rebased, fix missing RUN lines for two cases in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118599/new/ https://reviews.llvm.org/D118599 Files:

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

tbaeder added a comment. The failing tests seem all omp related and not about this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120644/new/ https://reviews.llvm.org/D120644 ___ cfe-commits

[PATCH] D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.

nridge added a comment. will leave approval to hokein, but LGTM Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:172 - /// Return whether this visitor should recurse into - /// template instantiations. + /// Return whether we should traverse of AST nodes that

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

tbaeder created this revision. tbaeder added reviewers: kaz7, simoll, aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise, the `// DEF-SAME: "[[RESOURCE_DIR]]/lib/linux/libclang_rt.builtins-ve.a" "-lc"` line

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 411734. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Address @jrtc27's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 411730. StephenFan added a comment. Address @jrtc27 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:10923-10924 - return TargetLowering::getRegForInlineAsmConstraint(TRI, Constraint, VT); + std::pair Res; + Res = TargetLowering::getRegForInlineAsmConstraint(TRI, Constraint, VT); +

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

jrtc27 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:764 CmdArgs.push_back(MArchName.data()); +if (Args.hasArg(options::OPT_mno_relax)) + CmdArgs.push_back("-mno-relax"); I doubt this does the right thing for `-mrelax

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 411729. Sockke added a comment. Removed the fix for a template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 411724. StephenFan added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan created this revision. StephenFan added reviewers: asb, jrtc27, craig.topper. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

Sockke updated this revision to Diff 411722. Sockke added a comment. Added a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116439/new/ https://reviews.llvm.org/D116439 Files: clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 411719. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Can you help test if this patch works fine now? @krasimir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___

[clang] bcbb037 - [Driver][OpenBSD] Enable unwind tables on all architectures

Author: Todd Mortimer Date: 2022-02-27T19:43:49-05:00 New Revision: bcbb03754ef19a8682635ab83fe5283db27b94f5 URL: https://github.com/llvm/llvm-project/commit/bcbb03754ef19a8682635ab83fe5283db27b94f5 DIFF: https://github.com/llvm/llvm-project/commit/bcbb03754ef19a8682635ab83fe5283db27b94f5.diff

[PATCH] D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default

davidxl added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:157 + bool shouldVisitTemplateInstantiations() { return true; } + This one line change looks ok to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

h-vetinari added a comment. A non-actionable comment out of curiosity for the work Comment at: clang/test/Modules/cxx20-10-1-ex2.cpp:15-17 -// Not expected to work yet. // %clang_cc1 -std=c++20 -emit-module-interface %t/std10-1-ex2-tu4.cpp \ // -fmodule-file=%t/B.pcm -o

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight updated this revision to Diff 411692. jyknight added a comment. Minor tweaks to comments and docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 Files: clang/docs/LanguageExtensions.rst

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 411688. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files:

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry added a comment. Here's a list of earliest commits where each option changed in this PR was introduced: AlignOperands - introduced by 3219e43c9467e47be9b1a9e32b3ed42a50f6b280 AllowShortEnumsOnASingleLine - introduced by 292058a5d6d708ec7d285a452d4350b33ba080dc

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry created this revision. kuzkry added a reviewer: MyDeveloperDay. kuzkry added a project: clang-format. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D120569: [clang] Improve laziness of resolving module map headers.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, this LGTM. but I am afraid all users of modules/modulemaps might not be aware of the fact that a module might be "partially" resolved (or still unresolved after a resolve

[PATCH] D120629: [clang] Remove unused variable AllElementsInt. NFC.

Quuxplusone created this revision. Quuxplusone added reviewers: rnk, rsmith, sammccall. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. This has been unused ever since it was committed in b8a501ccf1. Repository: rG

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

Quuxplusone added a comment. > Any runtime penalty? (Usually compilers choose a faster underlying type for > enums, not smaller) > The decision is made in the header (so I think it will always be `int` until > this doesn't fit). To decide what is faster the compiler would need to know > all

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 411676. achieveartificialintelligence added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 411675. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Thanks for @craig.topper's detailed advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

xbolva00 added a comment. What is the status of this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86559/new/ https://reviews.llvm.org/D86559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. The decision is made in the header (so I think it will always be `int` until this doesn't fit). To decide what is faster the compiler would need to know all the usages. Which it can't. We have multiple times bit

[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

HazardyKnusperkeks added a comment. This went totally over my head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93758/new/ https://reviews.llvm.org/D93758 ___ cfe-commits mailing list

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

curdeius added a comment. Looks innocent but I have a few questions. What's the size difference that you observe? Any runtime penalty? (Usually compilers choose a faster underlying type for enums, not smaller) Also, is this change very relevant to clang-format? We should not copy FormatStyle a

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

MyDeveloperDay added a comment. Is there a clang-tidy check for this? I mean if we are doing this because it helps reduce the size of FormatStyle and its recommended practice for small enums, then we should have a clang-tidy check that catches us on this. (no?) Repository: rG LLVM Github

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr updated this revision to Diff 411666. kimgr added a comment. Fix typo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119476/new/ https://reviews.llvm.org/D119476 Files: clang/lib/AST/Expr.cpp Index: clang/lib/AST/Expr.cpp

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added a comment. I have a local branch with both D119476 and this patch. - Rebased on latest main (853ca5472314e109b98e46f0985f27f79e17d2bd ) - Ran `ninja check-clang` and `ninja

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG853ca5472314: [C++20][Modules][6/8] Record direct module imports. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 853ca54 - [C++20][Modules][6/8] Record direct module imports.

Author: Iain Sandoe Date: 2022-02-27T10:07:11Z New Revision: 853ca5472314e109b98e46f0985f27f79e17d2bd URL: https://github.com/llvm/llvm-project/commit/853ca5472314e109b98e46f0985f27f79e17d2bd DIFF: https://github.com/llvm/llvm-project/commit/853ca5472314e109b98e46f0985f27f79e17d2bd.diff LOG:

[PATCH] D120511: [clang-format] Allow to set token types final

owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:382 + } + bool typeIsFinalized() const { return TypeIsFinalized; } HazardyKnusperkeks wrote: > owenpan wrote: > > I thought you didn't like using the same [[ > >

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:382 + } + bool typeIsFinalized() const { return TypeIsFinalized; } owenpan wrote: > I thought you didn't like using the same [[ >

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks updated this revision to Diff 411663. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Renamed member function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120511/new/ https://reviews.llvm.org/D120511 Files:

[PATCH] D120621: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

HazardyKnusperkeks updated this revision to Diff 411662. HazardyKnusperkeks added a comment. Formatted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120621/new/ https://reviews.llvm.org/D120621 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp