[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 417502. pengfei added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/include/clang/CodeGen/CGFunctionInfo.h

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

yonghong-song added a comment. LGTM. Maybe @efriedma can look at this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122271/new/ https://reviews.llvm.org/D122271 ___ cfe-commits mailing list

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! I agree that this assertion doesn't make much sense. Judging by the name, the function should be able to handle all symbols. Comment at:

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:41 // -// The following standard C functions are currently supported: -// This comment has been out of date for years and I don't think it makes sense to

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ created this revision. NoQ added reviewers: t-rasmud, Szelethus, martong, steakhal, ASDenysPetrov, balazske, gamesh411. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. NoQ requested

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#3398808 , @JonChesterfield wrote: > It lets applications run with the libomp and libomptarget built with the > toolchain. For users, they don't have to be root. For compiler devs, we test > our work instead of

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32103608fc07: [Inline-asm] Add diagnosts for unsupported inline assembly arguments (authored by pengfei). Repository: rG LLVM Github Monorepo

[clang] 3210360 - [Inline-asm] Add diagnosts for unsupported inline assembly arguments

Author: Phoebe Wang Date: 2022-03-23T11:25:19+08:00 New Revision: 32103608fc073700f04238872d8b22655ddec3fb URL: https://github.com/llvm/llvm-project/commit/32103608fc073700f04238872d8b22655ddec3fb DIFF: https://github.com/llvm/llvm-project/commit/32103608fc073700f04238872d8b22655ddec3fb.diff

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

MaskRay added a comment. Herald added a subscriber: StephenFan. This may need a test in `clang/test/Misc/cc1as-*`. Can you add to the description what the `clang -cc1as` usage looks like? Comment at: clang/tools/driver/cc1as_main.cpp:217 +llvm::Triple TVT(A->getValue());

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D120397#3399808 , @aaron.ballman wrote: > Can you also add a release note that explains we've fixed the crash? My thought is to edit a release note standalone. Since there are

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu updated this revision to Diff 417479. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 Files: clang/lib/AST/Decl.cpp clang/unittests/AST/DeclTest.cpp Index:

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added a comment. Thanks @jyu2 ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. This is okay with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu added a comment. @iains ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a subscriber: urnathan. ChuanqiXu added a comment. In D119409#3400287 , @dblaikie wrote: > In D119409#3398483 , @ChuanqiXu > wrote: > >> In D119409#3396690

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417475. rZhBoYao added a comment. Don't break template declarations. re-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu added a comment. In D122119#3400032 , @urnathan wrote: > In D122119#3398949 , @ChuanqiXu > wrote: > >> > > > >> The first feeling I saw the change is that not every C++ programmer knows >> about

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. @shafik, can you please check the patch? Or maybe recommend somebody who worked both on ASTStructuralEquivalence and Objective-C part of clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai updated this revision to Diff 417468. vsapsai added a comment. Fix bug with anonymous enum constant lookup in C++. Turns out the lookup was broken by using `ObjCInterfaceDecl` as a semantic decl context for anonymous enums. Fixing that fixed the lookup. Also added in tests checking

[PATCH] D121359: [AVR] Add more devices

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6edfe45a6312: [AVR] Add more devices (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6edfe45 - [AVR] Add more devices

Author: Ben Shi Date: 2022-03-23T02:00:15Z New Revision: 6edfe45a63125a8938a5bea13534a118b0e31023 URL: https://github.com/llvm/llvm-project/commit/6edfe45a63125a8938a5bea13534a118b0e31023 DIFF: https://github.com/llvm/llvm-project/commit/6edfe45a63125a8938a5bea13534a118b0e31023.diff LOG:

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417461. rZhBoYao retitled this revision from "[clang] Fix PR28101" to "[Clang] Fix PR28101". rZhBoYao edited the summary of this revision. rZhBoYao added a reviewer: cor3ntin. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao

[clang] 818e72d - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-22T18:39:16-07:00 New Revision: 818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db URL: https://github.com/llvm/llvm-project/commit/818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db DIFF:

[PATCH] D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG818e72d1b09b: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417458. junfd added a comment. Apply clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

fwolff created this revision. fwolff added reviewers: rsmith, cor3ntin, mizvekov. fwolff added a project: clang. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes #50794 .

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

ributzka added inline comments. Comment at: clang/include/clang/SymbolGraph/FrontendActions.h:35 + /// This is called before executing the action on any inputs. This merges all + /// the provided headers into a single header for processing. + bool

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:176-188 const char IncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; +R"(^[\t\ ]*[@#][\t\ ]*(import|include)([^"]*("[^"]+")|[^<]*(<[^>]+>)|[\t\

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers updated this revision to Diff 417450. vabridgers added a comment. remove assert that was commented out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122277/new/ https://reviews.llvm.org/D122277 Files:

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers created this revision. vabridgers added reviewers: martong, NoQ. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:2692-2695 + for (int i = Matches.size() - 1; i > 0; i--) { +if (!Matches[i].empty()) + return Matches[i]; + } I think you missed `Matches[0]`. Comment at:

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417443. hubert.reinterpretcast added a comment. - Address review comments: Add release notes, expand comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121927/new/

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417439. yihanaa added a comment. Remove useless comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D122202: [clang][extract-api] Add struct support

zixuw updated this revision to Diff 417438. zixuw marked 3 inline comments as done. zixuw added a comment. Address review issues: fix Symbol Graph struct kind identifiers and display names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3400408 , @xbolva00 wrote: >>> the remaining changes are code formatting > > Please remove code formatting changes. Okay, i have removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417435. yihanaa added a reviewer: xbolva00. yihanaa added a comment. Remove code formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 Files:

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

This revision was automatically updated to reflect the committed changes. fwolff marked an inline comment as done. Closed by commit rG07675b0b38e9: [clang-tidy] Fix false positives in `misc-redundant-expression` check (authored by fwolff). Changed prior to commit:

[clang-tools-extra] 07675b0 - [clang-tidy] Fix false positives in `misc-redundant-expression` check

Author: Fabian Wolff Date: 2022-03-23T00:32:45+01:00 New Revision: 07675b0b38e930c2c582122ac93efcdf7859a772 URL: https://github.com/llvm/llvm-project/commit/07675b0b38e930c2c582122ac93efcdf7859a772 DIFF: https://github.com/llvm/llvm-project/commit/07675b0b38e930c2c582122ac93efcdf7859a772.diff

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 created this revision. xbolva00 added reviewers: efriedma, yonghong-song. Herald added a project: All. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang fails to diagnose: void test() { int j = 0; for

[PATCH] D122202: [clang][extract-api] Add struct support

zixuw updated this revision to Diff 417430. zixuw added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/ https://reviews.llvm.org/D122202 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

wenlei added a comment. The linter warning seems legit, otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 ___ cfe-commits mailing list

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw updated this revision to Diff 417424. zixuw added a comment. Rebase on main with changed and merged refactoring in D122160 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121873/new/

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective ) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); Why

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added a comment. In D121951#3393928 , @sameerds wrote: > In D121951#3392470 , @scott.linder > wrote: > >> In D121951#3391472 , @sameerds >> wrote: >> >>>

[PATCH] D122265: [Clang][NFC] Cleanup dcl.constexpr/p3 tests

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Check for warnings instead of using -Werror, to avoid masking the type of diagnostic emitted - use different -verify

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); This approach is valid for static

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

hvdijk added a comment. In D118935#3399095 , @Fznamznon wrote: > I was under impression that the change is small and therefore easy to > understand. Would some comment like "SYCL re-uses OpenCL mode diagnostics to > emit errors in case the cast happens

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a comment. Oops, forgot conclusion: Thanks for incorporating my testcase, and the patch LGTM in its current form (most of the alternatives discussed also sound OK). I'll leave to Haojian to stamp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a subscriber: rsmith. sammccall added a comment. In D121824#3400720 , @hokein wrote: > Sorry, I thought this crash is fixed as a bonus effort by improving the AST > for reference-type var-decl. > > Beyond the crash cased by the

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2570 + State, TotalSize.castAs(), + svalBuilder.makeIntValWithPtrWidth(Arg1->getType(), 0)); NoQ wrote: >

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers updated this revision to Diff 417415. vabridgers added a comment. update per @NoQ's latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 Files:

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. @tonic, can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 ___ cfe-commits mailing list

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

hoy accepted this revision. hoy added a comment. This revision is now accepted and ready to land. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

jyknight added a comment. Given that this is an error `error: functions cannot be declared in an anonymous struct` (thus you can assume that function declarations inside a struct imply that the struct MUST have a linkage name) struct { static int foo(); }; then I don't think there's

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

hokein added a comment. Sorry, I thought this crash is fixed as a bonus effort by improving the AST for reference-type var-decl. Beyond the crash cased by the dependent-type `RecoveryExpr` built in `Sema::BuildDeclarationNameExpr`, I think there is another issue which is worth fixing: whether

[clang] b62d402 - [NFC][clang][extract-api] Use proper name string for Objective-C language

Author: Zixu Wang Date: 2022-03-22T14:18:26-07:00 New Revision: b62d40216f4742d46b1d2942617cf567e74272c4 URL: https://github.com/llvm/llvm-project/commit/b62d40216f4742d46b1d2942617cf567e74272c4 DIFF: https://github.com/llvm/llvm-project/commit/b62d40216f4742d46b1d2942617cf567e74272c4.diff

[PATCH] D122255: Meta directive runtime support

jdoerfert added a comment. In D122255#3400636 , @abidmalikwaterloo wrote: > Is it okay if I can put comments on the patch? Not sure what you mean but feel free. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:33 + : alias(Alias), loc(Loc) {} + inline IdentifierInfo *getAlias() const { return alias; } inline SourceLocation getLocation() const { return loc; }

[PATCH] D122261: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`

hubert.reinterpretcast created this revision. hubert.reinterpretcast added a reviewer: aaron.ballman. Herald added a project: All. hubert.reinterpretcast requested review of this revision. Herald added a project: clang. `DeclarationName` already takes `const IdentifierInfo *`. Propagate the

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:66-67 - if (T.isWatchABI()) -OmitDwarfIfHaveCompactUnwind = true; @MaskRay > I vaguely remember there is a place where DWARF unwind info is enabled for > all but few environments

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

MaskRay added a comment. > Previously, omitting unnecessary DWARF unwinds was only done for watchOS, I have looked at compact unwind descriptors in 2020-11 to write https://maskray.me/blog/2020-11-08-stack-unwinding#compact-unwind-descriptors I vaguely remember there is a place where DWARF

[clang] 2cedaee - [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct

Author: Mike Rice Date: 2022-03-22T13:55:47-07:00 New Revision: 2cedaee6f7387b39f7a534883050d66fd78e15a4 URL: https://github.com/llvm/llvm-project/commit/2cedaee6f7387b39f7a534883050d66fd78e15a4 DIFF: https://github.com/llvm/llvm-project/commit/2cedaee6f7387b39f7a534883050d66fd78e15a4.diff

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Is it okay if I can put comments on the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 ___ cfe-commits mailing list

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121525/new/ https://reviews.llvm.org/D121525

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added a comment. Does anyone implement/take care of the "otherwise" clause? If I am correct, OpenMP 5.2 supports otherwise instead of the default for meta directive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120573/new/

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 created this revision. int3 added reviewers: davide, kledzik, lhames. Herald added subscribers: StephenFan, cmtice, hiraditya, kristof.beyls, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a project: All. int3 requested review of this

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi added a comment. Sorry, I flagged this as "accepted", but I'm not sure I am allowed to do that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

zixuw added a comment. LGTM. Need to rebase. Do you think `ProductName` should be a general property of `APISerializer` or something specific to the `SymbolGraphSerializer`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi accepted this revision. saudi added a comment. This revision is now accepted and ready to land. It is indeed much cleaner this way`, thanks! The tests are not anymore the same for `clang-cl` as for `clang`, but I agree what needs testing is the clang-cl specific behaviors, not having the

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417387. junfd added a comment. Check the mixing -fsplit-machine-functions and -fno-split-machine-functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files:

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417386. hubert.reinterpretcast marked 2 inline comments as done. hubert.reinterpretcast added a comment. - Address review comments: Use default member init in WeakInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121525/new/ https://reviews.llvm.org/D121525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122255: Meta directive runtime support

jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen. jdoerfert added a comment. This contains a lot of unrelated changes, leftover comments, etc. As you clean up the code, please also include tests. Clang format the patch, go over the new code and make sure you follow the coding style.

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG89f6b26f1beb: [clang][extract-api] Refactor ExtractAPI and improve docs (authored by zixuw). Changed prior to commit: https://reviews.llvm.org/D122160?vs=417365=417383#toc Repository: rG LLVM Github

[clang] 89f6b26 - [clang][extract-api] Refactor ExtractAPI and improve docs

Author: Zixu Wang Date: 2022-03-22T13:21:57-07:00 New Revision: 89f6b26f1beb2c1344f5cfeb34e405128544c76b URL: https://github.com/llvm/llvm-project/commit/89f6b26f1beb2c1344f5cfeb34e405128544c76b DIFF: https://github.com/llvm/llvm-project/commit/89f6b26f1beb2c1344f5cfeb34e405128544c76b.diff

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk marked 2 inline comments as done. kwk added a comment. @HazardyKnusperkeks I've addressed your comments and did an early return together with `llvm_unreachable()` which is used in the `clang/lib/Format` in other places as well. I hope this is to your liking. There's no longer an `assert`.

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 417379. kwk added a comment. - Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cpp

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:33 + : alias(Alias), loc(Loc) {} + inline IdentifierInfo *getAlias() const { return alias; } inline SourceLocation

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks added a comment. Just a side note, I often get this on your changes: Unhandled Exception ("Exception") Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file . Comment at:

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417376. cor3ntin added a comment. - fix formatting - use cxx2b in the test as per aaron request. This doesn't really matter as this part of the test file is only executed in c++2b mode though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. Just a formality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo created this revision. Herald added subscribers: mgrang, hiraditya. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2694-2697 +if (!Matches[i].empty()) { + res = Matches[i]; + break; +} Comment at:

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

xbolva00 added a comment. >> the remaining changes are code formatting Please remove code formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:62 +return false; + return LHS.getAlias()->getName() == RHS.getAlias()->getName(); +}

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

aaron.ballman added a comment. FWIW, I plan to land this sometime tomorrow (Mar 23) unless there are additional review comments before then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122029/new/ https://reviews.llvm.org/D122029 ___

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr closed this revision. kimgr added a comment. Herald added a project: All. Now that D119477 has landed, this suggested change is obsolete. Closing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2725 +def warn_cxx20_compat_constexpr_var : Warning< + "definition of a %select{static variable|thread_local variable|variable of non-literal type}1 " "in a constexpr

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +"results of

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

aaron.ballman added a comment. In D119017#3400347 , @devin.jeanpierre wrote: > Please revert it, I don't have easy access to a Windows machine at work so am > struggling with the reproduction instructions. Thanks for letting us know! @Manna -- I'll

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

devin.jeanpierre added a comment. Please revert it, I don't have easy access to a Windows machine at work so am struggling with the reproduction instructions. This has failed twice, and this time with a one month delay! Is there any way to run and confirm all tests pass before I try to merge

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417365. zixuw added a comment. Address review issue: remove unnecessary `copyString` overload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 Files:

[clang] 8f05736 - [Clang][NFC] Add braces to help readability

Author: Corentin Jabot Date: 2022-03-22T20:12:20+01:00 New Revision: 8f057362a87f1b3c6072c1d0c4d66867ded99669 URL: https://github.com/llvm/llvm-project/commit/8f057362a87f1b3c6072c1d0c4d66867ded99669 DIFF:

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin added a comment. @hubert.reinterpretcast @aaron.ballman @erichkeane Thanks a lot for the review. I'm working on making PRs for the further changes we agreed to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417361. zixuw marked 3 inline comments as done. zixuw added a comment. Address review issues: - Documenting the responsibility of keeping StringRefs alive for APISet - Remove unnecessary `static` for helper functions in an anonymous namespace Repository:

  1   2   3   >