[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

MaskRay added a comment. To add more why I think the current semantics may need more discussion before we quickly commit to such a driver option: - interaction with --dyld-prefix: --sysroot does not affect the fallback --dyld-prefix. It seems even less appropriate for --overlay-platform-toolcha

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:275 + State.Env.getValue(*ValueOrPredExpr, SkipPast::None)); + if (ExprValue == nullptr) { +auto &ExprLoc = State.Env.creat

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf added a comment. In D121992#3418443 , @MaskRay wrote: > To add more why I think the current semantics may need more discussion before > we quickly commit to such a driver option: > > - interaction with --dyld-prefix: --sysroot does not affect the f

[clang] e1b8543 - Revert "[Clang] Add option to set alternative toolchain path"

Author: Qiu Chaofan Date: 2022-03-31T15:58:01+08:00 New Revision: e1b85430e98f243a32156617a54f3f01fd74fd8e URL: https://github.com/llvm/llvm-project/commit/e1b85430e98f243a32156617a54f3f01fd74fd8e DIFF: https://github.com/llvm/llvm-project/commit/e1b85430e98f243a32156617a54f3f01fd74fd8e.diff L

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:145 + case ARM::VMVNq: +return CondCodeIsAL(3); + // VMOV of 64-bit value between D registers (when condition = al) Can/should all these use findFirstPredOperan

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

mgorny created this revision. mgorny added reviewers: kostyakozko, MaskRay, alekseyshl, tianqing, pengfei. mgorny added a project: Sanitizers. Herald added subscribers: StephenFan, cryptoad, dberris. Herald added a project: All. mgorny requested review of this revision. Update the hardware CRC32 l

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

ChuanqiXu added a comment. I've just skimmed over the patch and it is a little bit hard to understand for people who don't have a strong background. Is it possible to split this one into several parts? Comment at: clang/lib/Sema/Scope.cpp:72 + // Lambdas have an extra protot

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. Thanks for the review. Lots of comments inline, hopefully Phab doesn't mangle the large one. Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:145 + case ARM::VMVNq: +return CondCodeIsAL(3); + // VMOV of 64-bit value between D regi

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. I am interested in this one. But it is absolutely not easy to understand... Comment at: clang/include/clang/Sema/Sema.h:6991-6993 /// \param TemplateArgs the list of template arguments to substitute into the - /// constraint expression. + /// con

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:200-207 + case ARM::VMOVv2f32: + case ARM::VMOVv4f32: + case ARM::VMOVv2i32: + case ARM::VMOVv4i32: + case ARM::VMOVv4i16: + case ARM::VMOVv8i16: + case ARM::VMOVv8i8:

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

martong added a comment. Nice catch! Comment at: clang/lib/AST/ASTImporter.cpp:8789-8791 +// The import path contains child nodes first. +// (Parent-child relationship is used here in sense of import +// dependency.) I think, this commen

[PATCH] D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks! Good catch! (For inexperienced readers, let me explain why I accepted the patch: If there is an error then the imported Decl is marked as erroneous, i.e an Error object is associate

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 419378. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

martong added a comment. Related: https://reviews.llvm.org/D112132 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122525/new/ https://reviews.llvm.org/D122525 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D121756: [clang-format] Clean up code looking for if statements NFC

owenpan requested changes to this revision. owenpan added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:252-256 +} else if (OpeningParen.isConditionLParen(/*IncludeFor=*/false) || + (OpeningParen.

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. In D121445#3418195 , @zixuan-wu wrote: > I have met this before because the downloading of patch will ignore empty > files. You can have a check t

[PATCH] D122798: [clang][extract-api][NFC] Add documentation

dang created this revision. dang added a reviewer: zixuw. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add struct level documentation for MacroDefinitionRecord. Repository: rG LLVM Github Monorepo h

[clang-tools-extra] 4cb38bf - [clangd] IncludeCleaner: Add support for IWYU pragma private

Author: Kirill Bobyrev Date: 2022-03-31T12:49:52+02:00 New Revision: 4cb38bfe76b7ef157485338623c931d04d17b958 URL: https://github.com/llvm/llvm-project/commit/4cb38bfe76b7ef157485338623c931d04d17b958 DIFF: https://github.com/llvm/llvm-project/commit/4cb38bfe76b7ef157485338623c931d04d17b958.diff

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb38bfe76b7: [clangd] IncludeCleaner: Add support for IWYU pragma private (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

aaron.ballman added a comment. In D122627#3417919 , @beanz wrote: > In D122627#3417557 , @aaron.ballman > wrote: > >> Are you sure that's what you want? This returns true for a static C++ member >> function, fal

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

aaron.ballman added a comment. Thanks! This is missing test coverage for the new matcher, and you should also add a release note for it. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7837-7839 + if (const CallExpr *Config = Node.getConfig()) { +return InnerMat

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong created this revision. martong added reviewers: steakhal, gamesh411. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

steakhal added a comment. Please add a test case where the class is trivial but the global variable of such is non-const, thus the initialized expression is not imported. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:112 -// Returns true if the variable or a

[PATCH] D122732: [Clang][AArch64][SVE] Allow subscript operator for SVE types

DavidTruby added a comment. > Not sure what you mean by this; LLVM supports extractelement on ` x i1>` vectors. I guess the fact that it's a "vscale x 16" element vector > might not be intuitive? It's a native operation at the LLVM level but not at the ISA level, unlike the data registers. Cod

[clang] 7f07600 - [clang][dataflow] Add support for `value_or` in a comparison.

Author: Yitzhak Mandelbaum Date: 2022-03-31T13:21:39Z New Revision: 7f076004e941fe60ab613a218da31a25b09b0925 URL: https://github.com/llvm/llvm-project/commit/7f076004e941fe60ab613a218da31a25b09b0925 DIFF: https://github.com/llvm/llvm-project/commit/7f076004e941fe60ab613a218da31a25b09b0925.diff

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f076004e941: [clang][dataflow] Add support for `value_or` in a comparison. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/

[PATCH] D122808: [clang] Fix warnings with `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto created this revision. antoniofrighetto added reviewers: aaron.ballman, dblaikie. antoniofrighetto added a project: clang. Herald added a project: All. antoniofrighetto requested review of this revision. Herald added a subscriber: cfe-commits. clang may throw the following warning

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. Generally I think things are looking pretty good, but there's still an open question and Precommit CI is still failing on Windows: Failed Tests (7): Clang-Unit :: AST/./ASTTests.exe/StructureLayoutRandomization.AnonymousStructsAndUnionsRetainFieldOrder C

[libunwind] cb055e5 - [libc++] Add a CI job running MSAN

Author: Louis Dionne Date: 2022-03-31T09:31:22-04:00 New Revision: cb055e51f994806160465212ac100485dac48125 URL: https://github.com/llvm/llvm-project/commit/cb055e51f994806160465212ac100485dac48125 DIFF: https://github.com/llvm/llvm-project/commit/cb055e51f994806160465212ac100485dac48125.diff

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

hvdijk added a comment. Herald added a project: All. In D120254#3342551 , @dyung wrote: > Hi, our internal release build bots are showing failures in two clang-tidy > tests that I bisected back to your commit, > clang-tidy/checkers/altera-id-dependent-b

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 419438. vabridgers added a comment. add NDEBUG around assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050 Files: clang/lib/StaticAnalyzer/Checkers/CStringChec

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

hans added a comment. > we should have a flag that controls which slash direction to use on windows > triples, since different people will want different things. > And since most people who use clang-cl run it on Windows, the default for > that flag should imho stay a backslash (but projects can

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers added a comment. I added #ifndef NDEBUG around the assert since I'm not sure if downstream consumers that use different pointer sizes by address space will hit this assert. Our downstream target causes this assert to fire, so I will be continuing to find and fix these issues, submitt

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

hans added reviewers: mstorsjo, aaron.ballman. hans added a comment. Maybe Martin or Aaron have opinions here too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 _

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

sammccall added a comment. OK, I think the main remaining thing is enclosing contexts... (sorry, I wasn't thinking clearly about these in the last round, and I think existing code gets this slightly wrong too). Each declaration has potentially *two* contexts, semantic and syntactic, and the di

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. In D120254#3419221 , @hvdijk wrote: > This was worked around by modifying tests, but I believe this is a > fundamental problem in this change and was able to reproduce the error with > plain old clang: > > $ cat test.cl > voi

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

sammccall added a comment. In D116514#3311780 , @avogelsgesang wrote: > Can we add this tweak as the default "fix-it" action for > >> Class '...' does not declare any constructor to initialize its >> non-modifiable members > > on structs like > > stru

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/SpecialMembers.cpp:120 +// they should be =default or =delete. +Inputs.AST->getSema().ForceDeclarationOfImplicitMembers(Class); +std::string Code = buildSpecialMemberDeclarations(*Cl

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

hubert.reinterpretcast added a comment. In D121992#3418443 , @MaskRay wrote: > If you intend to overlay ld.so, you'll necessarily overlay libc, then > --sysroot seems just unneeded at all. Why? The header and library search paths are not restricted to a

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel created this revision. ymandel added reviewers: sgatev, gribozavr2. Herald added subscribers: tschuett, steakhal. Herald added a project: All. ymandel updated this revision to Diff 417906. ymandel added a comment. ymandel updated this revision to Diff 419430. ymandel retitled this revision

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

hvdijk added a comment. In D120254#3419369 , @svenvh wrote: > In D120254#3419221 , @hvdijk wrote: > >> The problem is that this change enables certain built-ins in OpenCL 1.2 that >> take a memory_scope argument,

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers planned changes to this revision. vabridgers added a comment. I need to make a few changes. Please hold off any comments until the next patch, coming soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.o

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

erichkeane created this revision. erichkeane added reviewers: rjmccall, aaron.ballman, tahonermann. Herald added a project: All. erichkeane requested review of this revision. As reported in https://github.com/llvm/llvm-project/issues/54588 and discussed in https://github.com/itanium-cxx-abi/cxx-ab

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 ___ cfe-commits mailing list cf

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122608/new/ https://reviews.llvm.org/D122608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa created this revision. yihanaa added reviewers: aaron.ballman, erichkeane, MaskRay. yihanaa added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. yihanaa requested review of this revision. Herald added a subscriber: cfe-commits. Add constant array supp

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:168 +static void +getFieldsFromClassHierarchy(QualType Type, bool IgnorePrivateFields, +

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 419462. vabridgers added a comment. This revision is now accepted and ready to land. make assert function void, update summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.o

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 __

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

yaxunl added a comment. Is the OpenMP lit test missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] d9739f2 - Serialize PragmaAssumeNonNullLoc to support preambles

Author: David Goldman Date: 2022-03-31T11:08:01-04:00 New Revision: d9739f29cdd4c066763275d09e1d26ee315cfdf5 URL: https://github.com/llvm/llvm-project/commit/d9739f29cdd4c066763275d09e1d26ee315cfdf5 DIFF: https://github.com/llvm/llvm-project/commit/d9739f29cdd4c066763275d09e1d26ee315cfdf5.diff

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 419463. erichkeane marked 5 inline comments as done. erichkeane added a comment. Respond to @ChuanqiXu and fix a few comments he suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clan

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9739f29cdd4: Serialize PragmaAssumeNonNullLoc to support preambles (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https:

[PATCH] D118050: [analyzer] Avoid checking addrspace pointers in cstring checker

steakhal accepted this revision. steakhal added a comment. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050 ___ cfe-commits mailing list cfe-commits

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/55402/step_9.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.l

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

sammccall added a comment. Herald added a project: All. @njames93 I had completely forgotten about this when I attempted the same thing early this year. I never finished it but wanted to share what I had in case it's useful: http://reviews.llvm.org/D122827. Also happy to finish that sometime if

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateFields=*/true, +

[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Adds logical interpretation of built-in equality operators, `==`

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong marked 3 inline comments as done. martong added a comment. In D122805#3419129 , @steakhal wrote: > Please add a test case where the class is trivial but the global variable of > such is non-const, thus the initialized expression is not imported.

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

zixuw updated this revision to Diff 419474. zixuw added a comment. Add missing documentatin for ObjCCategoryRecord. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122774/new/ https://reviews.llvm.org/D122774 Files: clang/include/clang/ExtractAPI/

[PATCH] D122805: [analyzer][ctu] Only import const and trivial VarDecls

martong updated this revision to Diff 419475. martong marked 3 inline comments as done. martong added a comment. - Remove blank line - Fix comment - Add new check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122805/new/ https://reviews.llvm.org/D1

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { Instead of this initialization, can we make this a constexpr

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

ampandey-AMD added a comment. Yes, it is missing here because there is some part of the code in AMDGPUOpenMP.cpp on which openmp sanitize lit test case is dependent and that part of code is dependent on Greg's DLR patch. I will upstream the missing source code and lit test case afterwards when

[clang] 4d5b824 - [analyzer] Avoid checking addrspace pointers in cstring checker

Author: Vince Bridgers Date: 2022-03-31T17:34:56+02:00 New Revision: 4d5b824e3df21c9cfa7a14ea746c83d0d41dd3ed URL: https://github.com/llvm/llvm-project/commit/4d5b824e3df21c9cfa7a14ea746c83d0d41dd3ed DIFF: https://github.com/llvm/llvm-project/commit/4d5b824e3df21c9cfa7a14ea746c83d0d41dd3ed.diff

[PATCH] D118050: [analyzer] Avoid checking addrspace pointers in cstring checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d5b824e3df2: [analyzer] Avoid checking addrspace pointers in cstring checker (authored by vabridgers, committed by einvbri

[clang] 4dfec37 - [OpenCL] Set MinVersion for sub_group_barrier with memory_scope

Author: Sven van Haastregt Date: 2022-03-31T16:41:40+01:00 New Revision: 4dfec37037f5f96db8898b79601c7a1d19177027 URL: https://github.com/llvm/llvm-project/commit/4dfec37037f5f96db8898b79601c7a1d19177027 DIFF: https://github.com/llvm/llvm-project/commit/4dfec37037f5f96db8898b79601c7a1d19177027.

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. I've submitted the fix in `4dfec37037f5`. As for testing, unfortunately I couldn't just extend the `SemaOpenCL/fdeclare-opencl-builtins.cl` test: the OpenCL 1.2 RUN lines explicitly disable the `cl_intel_subgroups` extension (which is the extension that brings in `sub_g

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, grokos, ABataev, ronlieb, tianshilei1992, saiislam. Herald added subscribers: asavonic, kerbowa, guansong, yaxunl, mgorny, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald add

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09b53121c323: [compiler-rt] [scudo] Use -mcrc32 on x86 when available (authored by mgorny). Herald added a subscriber: Sanitizers. Repository: rG

[PATCH] D122104: [X86][regcall] Support passing / returning structures

erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3992 --FreeIntRegs; + else if (NeededSSE && MaxVectorWidth > 0) +FI.setMaxVectorWidth(MaxVectorWidth); This line here accesses NeededSSE while uninitialized. Do you need to

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 419490. jhuber6 added a comment. Fixing unrelated formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOption

[clang-tools-extra] f43c4c5 - Revert "[clangd] IncludeCleaner: Add support for IWYU pragma private"

Author: Kirill Bobyrev Date: 2022-03-31T17:59:52+02:00 New Revision: f43c4c5be29b4111bb953371b8ca83a4511fb1c1 URL: https://github.com/llvm/llvm-project/commit/f43c4c5be29b4111bb953371b8ca83a4511fb1c1 DIFF: https://github.com/llvm/llvm-project/commit/f43c4c5be29b4111bb953371b8ca83a4511fb1c1.diff

[clang] 2267549 - Fix the build after cd26190a10fceb6e1472fabcd9e1736f62f078c4

Author: Aaron Ballman Date: 2022-03-31T12:03:53-04:00 New Revision: 2267549296dabfed31ce194bb124f7bdb91f74c5 URL: https://github.com/llvm/llvm-project/commit/2267549296dabfed31ce194bb124f7bdb91f74c5 DIFF: https://github.com/llvm/llvm-project/commit/2267549296dabfed31ce194bb124f7bdb91f74c5.diff

[PATCH] D122104: [X86][regcall] Support passing / returning structures

erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3992 --FreeIntRegs; + else if (NeededSSE && MaxVectorWidth > 0) +FI.setMaxVectorWidth(MaxVectorWidth); erichkeane wrote: > This line here accesses NeededSSE while uninitializ

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jdoerfert added a comment. I feel we should port some of the clang driver tests rather than running them only for the old one. The old one is on its way out, so ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 419491. abrachet added a comment. Rebase so patch applies CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/include/clang/Driver/Options.h cla

[PATCH] D122104: [X86][regcall] Support passing / returning structures

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3992 --FreeIntRegs; + else if (NeededSSE && MaxVectorWidth > 0) +FI.setMaxVectorWidth(MaxVectorWidth); erichkeane wrote: > erichkeane wrote: > > This line here accesses Ne

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 added a comment. In D122831#3419768 , @jdoerfert wrote: > I feel we should port some of the clang driver tests rather than running them > only for the old one. > The old one is on its way out, so ... I tried to keep it where it worked, most of t

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 added a comment. In D94942#3419616 , @sammccall wrote: > @njames93 I had completely forgotten about this when I attempted the same > thing early this year. > I never finished it but wanted to share what I had in case it's useful: > http://review

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

jdoerfert added a comment. Commit name and message should be revisited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 ___ cfe-commits mailing list cfe-commits

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 419493. paulkirth added a comment. Herald added a subscriber: pengfei. Update tests. - Dont rely on size of `int` based on platform - Add checking to backend tests for warn-stack-size to ensure the behavior is consistant when safestack is enabled Reposit

[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:56 +Env.getValue(*RHSNorm, SkipPast::Reference))) + return Env.makeIff(*LHSValue, *RHSVal

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419496. ymandel added a comment. address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/Analysis/FlowSensitive/Storage

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added a comment. Thanks for your suggestion @erichkeane ! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { erichkeane wrote: > Instea

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 419494. john.brawn added a comment. Adjusted formatting slightly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics-constrained.c llvm/lib/CodeG

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419499. ymandel marked 5 inline comments as done. ymandel added a comment. adjusted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel added a comment. Thanks for the reviews. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateFields=*/true, +

[clang] 1905416 - [HLSL] Further improve to numthreads diagnostics

Author: Chris Bieneman Date: 2022-03-31T11:34:01-05:00 New Revision: 19054163e11a6632b4973c936e5aa93ec742c866 URL: https://github.com/llvm/llvm-project/commit/19054163e11a6632b4973c936e5aa93ec742c866 DIFF: https://github.com/llvm/llvm-project/commit/19054163e11a6632b4973c936e5aa93ec742c866.diff

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

beanz added a comment. I just pushed one more commit rG19054163e11a6632b4973c936e5aa93ec742c866 that further refines the subject specification and covers the merging attributes and conflicting attributes on the same decl. Th

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateF

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. Ping, I'd like to finalize the new driver in time for the GPU newsletter and the LLVM Performance Workshop at CGO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 ___

[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:56 +Env.getValue(*RHSNorm, SkipPast::Reference))) + return Env.makeIff(*LHSValue, *RHSValue); + xazax.hun wrote: >

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 + QualType Type) { + static llvm::DenseMap Types; if (Types.empty()) { yihanaa wrote: > erichkeane wrote: > > Instead of this initi

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

goncharov added a comment. Hi, I have found this test to cs-preinline-sample-profile.test to be flaky around 10% of the runs. Could you please check what might be the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122471/new/ https://reviews

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

yaxunl added a comment. This patch can be retitled as "Refactor sanitizer options handling for AMDGPU Toolchain". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 _

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2071 + if (Types.find(Type) == Types.end()) +return Types[Context.VoidPtrTy]; + return Types[Type]; erichkeane wrote: > yihanaa wrote: > > erichkeane wrote: > > > When can we hit thi

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2071 + if (Types.find(Type) == Types.end()) +return Types[Context.VoidPtrTy]; + return Types[Type]; yihanaa wrote: > erichkeane wrote: > > yihanaa wrote: > > > erichkeane wrote: >

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46774df30715: [misexpect] Re-implement MisExpect Diagnostics (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 0e89090 - Use functions with prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-03-31T13:45:39-04:00 New Revision: 0e890904ea342aba088ed2a55b537ffdb0562234 URL: https://github.com/llvm/llvm-project/commit/0e890904ea342aba088ed2a55b537ffdb0562234 DIFF: https://github.com/llvm/llvm-project/commit/0e890904ea342aba088ed2a55b537ffdb0562234.diff

[PATCH] D122822: [Clang][CodeGen]Add constant array support for __builtin_dump_sturct

yihanaa added a comment. There is another question, which way should I print for an empty array? #1: Same as non empty array int[0] a = [ ] #2: int[0] a = [] The #1's format is more uniform, and the #2 maybe looks a little clearer. What do you think? @erichkeane Repository: rG LLVM

  1   2   >