[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73da7eed8fac: [clang-tidy] Add portability-std-allocator-const check (authored by MaskRay). Changed prior to commit:

[clang-tools-extra] 73da7ee - [clang-tidy] Add portability-std-allocator-const check

Author: Fangrui Song Date: 2022-04-13T22:35:11-07:00 New Revision: 73da7eed8fac84c9005518740f12d58389998d95 URL: https://github.com/llvm/llvm-project/commit/73da7eed8fac84c9005518740f12d58389998d95 DIFF: https://github.com/llvm/llvm-project/commit/73da7eed8fac84c9005518740f12d58389998d95.diff

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1791 +tokenCanStartNewLine(*FormatTok) && Text == Text.upper() && +!PreviousToken->isTypeFinalized()) {

[PATCH] D123737: [clang-format] Skip preprocessor lines when finding the record lbrace

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123737/new/ https://reviews.llvm.org/D123737

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. Could you please help me review the code？@rsmith，thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 ___ cfe-commits mailing list

[clang] bfafa10 - [Driver] Simplify some hasFlag patterns with addOptInFlag/addOptOutFlag. NFC

Author: Fangrui Song Date: 2022-04-13T22:00:44-07:00 New Revision: bfafa105aab05e2c243e74114739b7d37f8ab0be URL: https://github.com/llvm/llvm-project/commit/bfafa105aab05e2c243e74114739b7d37f8ab0be DIFF: https://github.com/llvm/llvm-project/commit/bfafa105aab05e2c243e74114739b7d37f8ab0be.diff

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

rsmith added a comment. Hey @cor3ntin, sorry, I reverted this again. It's breaking thread-safety annotations on lambdas in a pretty severe way: Mutex m; auto lambda = [=]() EXCLUSIVE_LOCKS_REQUIRED(m) {...} doesn't compile any more. Presumably we should be parsing the attribute in the

[clang] 836e610 - Revert "[clang] Implement Change scope of lambda trailing-return-type"

Author: Richard Smith Date: 2022-04-13T21:34:08-07:00 New Revision: 836e610d9332772ad4511e86ef126a200f1ab281 URL: https://github.com/llvm/llvm-project/commit/836e610d9332772ad4511e86ef126a200f1ab281 DIFF: https://github.com/llvm/llvm-project/commit/836e610d9332772ad4511e86ef126a200f1ab281.diff

[PATCH] D121915: RISCV] Add clang builtins for CLZ instruction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f47a99aafe: RISCV] Add clang builtins for CLZ instruction. (authored by joker881). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a4f47a9 - RISCV] Add clang builtins for CLZ instruction.

Author: joker881 Date: 2022-04-14T12:29:15+08:00 New Revision: a4f47a99aafe57db0176ef7dad1a9ba72854439f URL: https://github.com/llvm/llvm-project/commit/a4f47a99aafe57db0176ef7dad1a9ba72854439f DIFF: https://github.com/llvm/llvm-project/commit/a4f47a99aafe57db0176ef7dad1a9ba72854439f.diff

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz updated this revision to Diff 422738. beanz added a comment. Updating based on PR feedback. I've moved the error reporting into Sema, and added additional errors for unsupported operators. I've also expanded the test coverage with some of @aaron.ballman's cursed code, which improves

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d88b4ba8b0: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC… (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123438/new/

[clang] 71d88b4 - [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

Author: Brad Smith Date: 2022-04-13T23:56:09-04:00 New Revision: 71d88b4ba8b0d45070b2f52b807f461fec737638 URL: https://github.com/llvm/llvm-project/commit/71d88b4ba8b0d45070b2f52b807f461fec737638 DIFF: https://github.com/llvm/llvm-project/commit/71d88b4ba8b0d45070b2f52b807f461fec737638.diff

[PATCH] D123297: [flang][driver] Add support for -mmlir

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:3272 MarshallingInfoStringVector>; +def mmlir : Separate<["-"], "mmlir">,Flags<[CoreOption,FC1Option,FlangOption]>, + HelpText<"Additional arguments to forward to MLIR's option processing">;

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1791 +tokenCanStartNewLine(*FormatTok) && Text == Text.upper() && +!PreviousToken->isTypeFinalized()) {

[clang] c98b601 - [randstruct] Fix -Wunused-but-set-variable with Clang>=D122271 in -DLLVM_ENABLE_ASSERTIONS=off builds

Author: Fangrui Song Date: 2022-04-13T17:09:30-07:00 New Revision: c98b601b7fad9500742a9221bd8de4a86d68175e URL: https://github.com/llvm/llvm-project/commit/c98b601b7fad9500742a9221bd8de4a86d68175e DIFF: https://github.com/llvm/llvm-project/commit/c98b601b7fad9500742a9221bd8de4a86d68175e.diff

[PATCH] D123744: [Driver] Change CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL to affect driver default instead of cc1 default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab8abeaf48ab: [Driver] Change CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL to affect driver default… (authored by MaskRay). Changed prior to commit:

[clang] ab8abea - [Driver] Change CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL to affect driver default instead of cc1 default

Author: Fangrui Song Date: 2022-04-13T16:58:00-07:00 New Revision: ab8abeaf48abb3addcbdb6136b1975b4afa3b37c URL: https://github.com/llvm/llvm-project/commit/ab8abeaf48abb3addcbdb6136b1975b4afa3b37c DIFF: https://github.com/llvm/llvm-project/commit/ab8abeaf48abb3addcbdb6136b1975b4afa3b37c.diff

[PATCH] D123744: [Driver] Change CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL to affect driver default instead of cc1 default

MaskRay updated this revision to Diff 422692. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: mgorny. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123744/new/

[PATCH] D121915: [RISCV] CLZ Instruction

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM though I think the title needs to be updated. Should be something like "[RISCV] Add clang builtins for CLZ instruction." Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122008: [flang][driver] Add support for generating executables

rouson added a comment. @awarzynski I'll echo your comment that "... most people new to LLVM Flang use flang rather than flang-new and most (all?) find it very confusing." I've known of flang in various forms (including a flang predated classic flang) and yet I'm still finding new information

[PATCH] D123744: [Driver] Change CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL to affect driver default instead of cc1 default

MaskRay created this revision. MaskRay added reviewers: opaque-pointers, rsmith, aeubanks, nikic. Herald added a subscriber: StephenFan. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this revision. Herald added a

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

dexonsmith added a comment. In D122766#3450348 , @dexonsmith wrote: > - Only canonicalize `__FILE__` for the target platform when there's a > command-line flag that suggests it's okay. I suggest adding > `-ffile-reproducible`, which could be implied

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

dexonsmith added a comment. In D122766#3450298 , @ayzhao wrote: > So, the general consensus seems to be that we should use backslashes when > targeting Windows. > > I implemented using only backslashes for Windows; however, >

[PATCH] D122008: [flang][driver] Add support for generating executables

rouson added a comment. @awarzynski based on @h-vetinari's optimism about adding flags, I still like option 2. If it's not possible to add flags, then I would prefer option 1. If we go with option 3, then I am at least encouraged by reviewing the upstreaming project status links that @kiran

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

nemanjai added a comment. In D67678#3446526 , @rsmith wrote: > @dexonsmith @arphaman What do we need to do to get this re-landed? FWIW, on the PPC side, we are working on cleaning up `altivec.h` and plan to eventually make `-fno-lax-vector-conversions`

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 422687. samitolvanen added a comment. Dropped `-fsanitize-kcfi-offset` and added an error when used with `-fpatchable-function-entry=N,M`, where M > 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao added a comment. So, the general consensus seems to be that we should use backslashes when targeting Windows. I implemented using only backslashes for Windows; however, clang/test/SemaCXX/destructor.cpp

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422677. python3kgae added a comment. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D121756: [clang-format] Clean up code looking for if statements

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:133-136 -(isKeywordWithCondition(*Line.First) || - CurrentToken->getStartOfNonWhitespace() == - CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset(

[PATCH] D123682: [clang-tblgen] Automatically document options values

MaskRay added subscribers: dexonsmith, aaron.ballman. MaskRay added a comment. cd clang path/to/clang-tblgen --gen-opt-docs -I ../llvm/include -I include/clang/Driver include/clang/Driver/ClangOptionDocs.td > /tmp/0 nvim -d docs/ClangCommandLineReference.rst /tmp/0 Hope a native speaker

[PATCH] D122008: [flang][driver] Add support for generating executables

h-vetinari added a comment. Speaking as a relative outside (but who's been waiting for flang in LLVM since well before it joined the monorepo), I'd much prefer code-generation-with-rough-edges in LLVM 15 (to start testing and raising eventual bugs), rather than a more polished flang

[PATCH] D121756: [clang-format] Clean up code looking for if statements

owenpan added a comment. Please see D123741 . It should make it easier to see if you are making NFC changes at other places as well. Comment at: clang/lib/Format/TokenAnnotator.cpp:252-256 +} else if

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

rsmith added a comment. It seems surprising to me for the diagnostic to change from warn-by-default to error-by-default when changing from C99 to C11, given that the language rule did not change between C99 and C11 (as a Clang user, when changing my `-std=` flag, I don't want other changes to

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. FWIW I interpreted dexonsmith's resign from the patch as his ambivalence or minor objection to the direction, otherwise I'd expect a LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. In D121560#3448733 , @abrachet wrote: > In D121560#3439570 , @MaskRay wrote: > >> If you need a -static-libstdc++ not subject to unused argument warning, >> --start-no-unused-arguments

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

xbolva00 added subscribers: jwakely, jakubjelinek, msebor. xbolva00 added a comment. >> IMO, it is basically a historical bug in GCC that it ignores the type >> alignment Do you have any comments related to this issue by gcc devs that this is a "known" bug? cc @jakubjelinek @msebor @jwakely

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma updated this revision to Diff 422671. efriedma added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123649/new/ https://reviews.llvm.org/D123649 Files: clang/include/clang/AST/Decl.h

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

efriedma added a comment. > I disagree with this on principle -- IMO, it is basically a historical bug in > GCC that it ignores the type alignment, and we should NOT try to match that > -- it's dangerous. gcc has always behaved this way, and I don't see any indication they intend to change

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

rsmith added a comment. Thanks for working on this! Comment at: clang/include/clang/AST/DeclBase.h:228 +/// This declaration has an owninig module, and is visible to lookups +/// that occurs within that module. And it is reachable to other module

[PATCH] D123737: [clang-format] Skip preprocessor lines when finding the record lbrace

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With D117142 , we would now format struct A { #define A void f() { a(); }

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7443a504bf6c: [clang][extract-api] Add support for true anonymous enums (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c729d5b - [clang] Implement Change scope of lambda trailing-return-type

Author: Corentin Jabot Date: 2022-04-13T23:07:39+02:00 New Revision: c729d5be781a8e80137c11ab28aa14d9ace148db URL: https://github.com/llvm/llvm-project/commit/c729d5be781a8e80137c11ab28aa14d9ace148db DIFF:

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 422643. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Update based on review feedback. - Removed a typo correction note so that we don't recommend a previous declaration which was implicitly declared - Removed several

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman marked 10 inline comments as done. aaron.ballman added a comment. Thank you for the thorough double-check on the test changes, @jyknight! I was able to remove most of the ones you called out (I commented where I couldn't) plus a few more `-std=c99` from RUN lines, but there are

[PATCH] D123636: [randstruct] Add test for "-frandomize-layout-seed-file" flag

void added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:56 + llvm::SmallString<256> SeedFilename; + EXPECT_FALSE(llvm::sys::fs::createTemporaryFile("seed", "rng", SeedFileFD, + SeedFilename));

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

MaskRay added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/portability-std-allocator-const.cpp:76 +void temp() { + std::vector v; + // CHECK-MESSAGES: [[#@LINE-1]]:8: warning: container sammccall wrote: > This case will always be an

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

MaskRay updated this revision to Diff 422640. MaskRay added a comment. improve test. mention in the diagnostic this is a deprecated libc++ extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/ https://reviews.llvm.org/D123655 Files:

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dexonsmith added a comment. In D67678#3446526 , @rsmith wrote: > @dexonsmith @arphaman What do we need to do to get this re-landed? (I'm sorry I missed your ping two years ago :(... I was on an extended leave at the time and never ended up catching up

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void added a comment. In D123544#3448046 , @aaron.ballman wrote: > In D123544#3446814 , @void wrote: > >> Let me work on that. But otherwise are you okay with this patch? > > Yes, I'm okay with the direction of

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

MaskRay updated this revision to Diff 422619. MaskRay marked 3 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Catch std::vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/

[PATCH] D123586: [clang][dataflow] Weaken abstract comparison to enable loop termination.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbcf11f5af98: [clang][dataflow] Weaken abstract comparison to enable loop termination. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang] bbcf11f - [clang][dataflow] Weaken abstract comparison to enable loop termination.

Author: Yitzhak Mandelbaum Date: 2022-04-13T19:49:50Z New Revision: bbcf11f5af98a6e0fa008e180404cfc397f336fa URL: https://github.com/llvm/llvm-project/commit/bbcf11f5af98a6e0fa008e180404cfc397f336fa DIFF: https://github.com/llvm/llvm-project/commit/bbcf11f5af98a6e0fa008e180404cfc397f336fa.diff

[clang] 26eec9e - Revert "[clang] Implement Change scope of lambda trailing-return-type"

Author: Mehdi Amini Date: 2022-04-13T19:35:13Z New Revision: 26eec9e9dbc20186f6b810fe01d3a01aac8ae6f4 URL: https://github.com/llvm/llvm-project/commit/26eec9e9dbc20186f6b810fe01d3a01aac8ae6f4 DIFF: https://github.com/llvm/llvm-project/commit/26eec9e9dbc20186f6b810fe01d3a01aac8ae6f4.diff LOG:

[PATCH] D123648: Restrict lvalue-to-rvalue conversions in CGExprConstant.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd791de0e25e1: Restrict lvalue-to-rvalue conversions in CGExprConstant. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d791de0 - Restrict lvalue-to-rvalue conversions in CGExprConstant.

Author: Eli Friedman Date: 2022-04-13T12:34:57-07:00 New Revision: d791de0e25e13cd8ae066e6f0fa03b384502b02e URL: https://github.com/llvm/llvm-project/commit/d791de0e25e13cd8ae066e6f0fa03b384502b02e DIFF: https://github.com/llvm/llvm-project/commit/d791de0e25e13cd8ae066e6f0fa03b384502b02e.diff

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

mehdi_amini added a comment. In D119136#3449325 , @cor3ntin wrote: > Yes, working on a fix as we speak. > The meaning of that code changed (in all c++ language modes), I'm > currently trying to find if we have any other issue of that sort and will >

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2388 + // evaluation. Make sure we emit a sane error message, for now. + constexpr A c = {1, 2, 3}; // expected-warning {{flexible array initialization is a GNU extension}} +

[PATCH] D123586: [clang][dataflow] Weaken abstract comparison to enable loop termination.

ymandel added a comment. In D123586#3449291 , @xazax.hun wrote: > In D123586#3449256 , @ymandel wrote: > >> In D123586#3446956 , @xazax.hun >> wrote: >> >>> Yeah, this

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. Yes, working on a fix as we speak. The meaning of that code changed (in all c++ language modes), I'm currently trying to find if we have any other issue of that sort and will commit a fix in a few hours Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123586: [clang][dataflow] Weaken abstract comparison to enable loop termination.

xazax.hun added a comment. In D123586#3449256 , @ymandel wrote: > In D123586#3446956 , @xazax.hun > wrote: > >> Yeah, this is a hard problem in general. This looks like a sensible >> workaround for the short

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

mehdi_amini added a comment. Seems like this is breaking clang bootstrapping? llvm/include/llvm/CodeGen/LiveInterval.h:630:53: error: captured variable 'Idx' cannot appear here [=](std::remove_reference_t V, ^ Repository:

[PATCH] D123586: [clang][dataflow] Weaken abstract comparison to enable loop termination.

ymandel added a comment. In D123586#3446956 , @xazax.hun wrote: > Yeah, this is a hard problem in general. This looks like a sensible > workaround for the short term, but I'm looking forward to a better solution. > I'm a bit worried that the memory

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3448554 , @DavidSpickett wrote: > Is there any reason to have an AArch64 specific section? A lot of the files > do apply to both Arm and AArch64 but for example the mve file Momchil > mentioned does not. > >

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! (I'm sorry, somehow I had misunderstood what this patch was about, and wasn't paying attention) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 updated this revision to Diff 422589. qiongsiwu1 added subscribers: abdulras, compnerd. qiongsiwu1 added a comment. Herald added subscribers: pcwang-thead, luke957, s.egerton, simoncook. Addressing review comments: 1. @chill pointed out that the generated headers are missing. The

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-std-allocator-const.rst:6 + +This check reports use of ``vector`` (and similar containers of const +elements). These are not allowed in standard C++, and should usually be

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from my side. It won't catch all cases, but I think it gets the common ones. Up to you/Louis how best to describe the libc++ behavior. Comment at:

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 422586. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123127/new/ https://reviews.llvm.org/D123127 Files:

[clang-tools-extra] a3b73b6 - Fix a typo with this test function name

Author: Aaron Ballman Date: 2022-04-13T14:44:27-04:00 New Revision: a3b73b60be4467d2194d3c95e7b943f1644cf92b URL: https://github.com/llvm/llvm-project/commit/a3b73b60be4467d2194d3c95e7b943f1644cf92b DIFF: https://github.com/llvm/llvm-project/commit/a3b73b60be4467d2194d3c95e7b943f1644cf92b.diff

[PATCH] D122673: Add kcfi_unchecked attribute

samitolvanen abandoned this revision. samitolvanen added a comment. Alright, thanks for the feedback everyone! I'll abandon this patch and look into adding a built-in function instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122673/new/

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 422580. jhuber6 added a comment. Fix test after move to opaque pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files:

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang-tools-extra/clang-tidy/portability/PortabilityTidyModule.cpp:28 +CheckFactories.registerCheck( +"portability-std-allocator-const-t"); } sammccall wrote: >

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

MaskRay updated this revision to Diff 422579. MaskRay marked 10 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123655/new/

[clang] 925acfe - [Clang] Fix html error in cxx_status.html [NFC]

Author: Corentin Jabot Date: 2022-04-13T20:27:34+02:00 New Revision: 925acfea8836ffe97a1c1d76d31df3229e978a11 URL: https://github.com/llvm/llvm-project/commit/925acfea8836ffe97a1c1d76d31df3229e978a11 DIFF:

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. @aaron.ballman @ChuanqiXu Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 ___ cfe-commits mailing list

[PATCH] D123648: Restrict lvalue-to-rvalue conversions in CGExprConstant.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1096 +case CK_LValueToRValue: { + // We don't really support doing lvalue-to-rvalue conversions here; any + // interesting conversions should be done in Evaluate(). But as a

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadff142dc253: [clang] Implement Change scope of lambda trailing-return-type (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES

[clang] 38823b7 - Fix Werror build issue from 6f20744b7ff875

Author: Erich Keane Date: 2022-04-13T11:00:09-07:00 New Revision: 38823b7f5f01e01c44360b17b4ab99b2729b7197 URL: https://github.com/llvm/llvm-project/commit/38823b7f5f01e01c44360b17b4ab99b2729b7197 DIFF: https://github.com/llvm/llvm-project/commit/38823b7f5f01e01c44360b17b4ab99b2729b7197.diff

[clang] adff142 - [clang] Implement Change scope of lambda trailing-return-type

Author: Corentin Jabot Date: 2022-04-13T20:00:03+02:00 New Revision: adff142dc253d65b6560e420bba6b858d88d4a98 URL: https://github.com/llvm/llvm-project/commit/adff142dc253d65b6560e420bba6b858d88d4a98 DIFF:

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

ldionne added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-std-allocator-const-t.rst:11 + +libstdc++ never supports ``std::allocator`` and containers using them. +Since GCC 8.0 (`PR48101

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

arphaman added a comment. The change itself LGTM. It would be really good if we can have a unit test that tests the new API when it lands, to ensure that this is tested in LLVM-project itself , in addition to Swift. Do you think it's possible to write a unit tests that constructs a compiler

[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

ldionne added a comment. In D123655#3448472 , @Eugene.Zelenko wrote: > Shouldn't this check be enabled only when libstdc++ is used? No, because we would like to enforce this in libc++ as well! Thanks @MaskRay for pursuing this! Repository: rG LLVM

[PATCH] D122748: [Sema] Don't check bounds for function pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2c3ae0b6f05: [Sema] Dont check bounds for function pointer (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/

[clang] b2c3ae0 - [Sema] Don't check bounds for function pointer

Author: Aleksandr Platonov Date: 2022-04-13T20:39:38+03:00 New Revision: b2c3ae0b6f05fd0c2184aea82637685a13b8dc4f URL: https://github.com/llvm/llvm-project/commit/b2c3ae0b6f05fd0c2184aea82637685a13b8dc4f DIFF:

[PATCH] D123680: Add support for ignored bitfield conditional codegen.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f20744b7ff8: Add support for ignored bitfield conditional codegen. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM

[clang] 6f20744 - Add support for ignored bitfield conditional codegen.

Author: Erich Keane Date: 2022-04-13T10:33:55-07:00 New Revision: 6f20744b7ff875bb5eb735d1e7636ad6a66d4526 URL: https://github.com/llvm/llvm-project/commit/6f20744b7ff875bb5eb735d1e7636ad6a66d4526 DIFF: https://github.com/llvm/llvm-project/commit/6f20744b7ff875bb5eb735d1e7636ad6a66d4526.diff

[PATCH] D123680: Add support for ignored bitfield conditional codegen.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123680/new/ https://reviews.llvm.org/D123680 ___ cfe-commits mailing list

[libunwind] 7165edc - [libunwind][AIX] implementation of the unwinder for AIX

Author: Xing Xue Date: 2022-04-13T13:18:10-04:00 New Revision: 7165edcad76fec2e025414ddf44e76363806fc3d URL: https://github.com/llvm/llvm-project/commit/7165edcad76fec2e025414ddf44e76363806fc3d DIFF: https://github.com/llvm/llvm-project/commit/7165edcad76fec2e025414ddf44e76363806fc3d.diff

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 422557. cor3ntin added a comment. Cleanup SemaLambda as discussed with Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/docs/ReleaseNotes.rst

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1127-1132 + auto it = LSI->DelayedCaptures.end(); + if (Var) +it = llvm::find_if(LSI->DelayedCaptures, [](auto &) { + return Pair.second.Var == Var; +}); + if

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1127-1132 + auto it = LSI->DelayedCaptures.end(); + if (Var) +it = llvm::find_if(LSI->DelayedCaptures, [](auto &) { + return Pair.second.Var == Var; +}); + if (it !=

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1127-1132 + auto it = LSI->DelayedCaptures.end(); + if (Var) +it = llvm::find_if(LSI->DelayedCaptures, [](auto &) { + return Pair.second.Var == Var; +}); + if (it !=

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 422547. jhuber6 added a comment. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:173 __wmmintrin_pclmul.h x86gprintrin.h x86intrin.h qiongsiwu1 wrote: > abhina.sreeskantharajan wrote: > > nit: There are some x86 headers here that appear to be

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! When landing, please revert the changes to SemaDecl.cpp (no need to churn that file) and apply the one suggested refactoring (I commented to make it more clear which one I mean). Comment at:

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 422544. jhuber6 added a comment. Maxing suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 Files: llvm/include/llvm/Object/OffloadBinary.h

[PATCH] D123680: Add support for ignored bitfield conditional codegen.

erichkeane updated this revision to Diff 422539. erichkeane added a comment. Added support for chained-conditional operators as requested. All of the variants I could come up with that I was afraid would be breaking ended up having an rvalue conversion (which makes it 'work'). CHANGES SINCE

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet added a comment. In D121560#3439570 , @MaskRay wrote: > If you need a -static-libstdc++ not subject to unused argument warning, > --start-no-unused-arguments and D53238 > (-static=c++stdlib) may be better

  1   2   >