[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, si

[clang-tools-extra] 8a9e2dd - [clang-tidy][NFC] Re-alphabetize the clang tidy release notes

Author: Nathan James Date: 2022-05-01T07:41:04+01:00 New Revision: 8a9e2dd48d8102fdb940db87e57192e399e7e61b URL: https://github.com/llvm/llvm-project/commit/8a9e2dd48d8102fdb940db87e57192e399e7e61b DIFF: https://github.com/llvm/llvm-project/commit/8a9e2dd48d8102fdb940db87e57192e399e7e61b.diff

[PATCH] D124729: [Driver][Ananas] -r: imply -nostdlib like GCC

brad created this revision. brad added reviewers: MaskRay, zhmu. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Similar to D116843 for Gnu.cpp Repository: rG LLVM Github

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added a comment. FYI, once nice addition of the parsing of macro bodies is that it paves the way for a modernize-macro-to-function check that converts function-like macros that compute values to template functions. Once this change has landed, I'll be putting up a review for t

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 426263. LegalizeAdulthood added a comment. Recognize comma operator expressions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt cl

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:204 + return true; +} + LegalizeAdulthood wrote: > aaron.ballman wrote: > > LegalizeAdulthood wrote: > > > aaron.ballman wrote: > >

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/test/OpenMP/predefined_macro.c:7 // RUN: %clang_cc1 -fopenmp-simd -fopenmp-version=50 -verify -o - %s -// expected-no-diagnostics +// expected-warning@+5 {{'#elsif' directive not found, did you mean '#elif'?}} #ifdef FOPENMP -

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui created this revision. ken-matsui added a reviewer: aaron.ballman. Herald added a subscriber: mgorny. Herald added a project: All. ken-matsui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements suggestion for ty

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Curre

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

briantracy updated this revision to Diff 426259. briantracy added a comment. Updated sanitizer tests to include newly fixed error message strings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124708/new/ https://reviews.llvm.org/D124708 Files:

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, saiislam, tianshilei1992, tra. Herald added subscribers: kerbowa, guansong, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1,

[PATCH] D124719: [clang,doc] PCH usage documentation update

ivanmurashko updated this revision to Diff 426248. ivanmurashko added a comment. Minor changes at the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124719/new/ https://reviews.llvm.org/D124719 Files: clang/docs/UsersManual.rst Index: clang

[PATCH] D124719: [clang,doc] PCH usage documentation update

ivanmurashko created this revision. Herald added a project: All. ivanmurashko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation has an incorrect example of PCH files usage via `-include` option. The possibility has not been

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:171 check_symbol_exists(__ve__ "" __VE) + check_symbol_exists(__AVR__ "" __AVR) if(__ARM) ---

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

rjmccall added a comment. IIRC, the reason it works it that way is that "warnings which default to an error" are really "errors which you can explicitly downgrade to a warning". Maybe those ought to be different categories, or maybe we ought to just be telling people to downgrade this specific

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

manojgupta added a comment. Hmm, the commit message says that Wno-error should work but this is not really the case :(. > (they can disable the warning or use -Wno-error to downgrade the > error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3484097 , @aaron.ballman wrote: > In D122895#3484076 , @manojgupta > wrote: > >> Tried locally but I still see the warning with -fno-knr-functions. It also >> says that

[clang] 786954d - Accept -fno-knr-functions as a driver flag as well

Author: Aaron Ballman Date: 2022-04-30T13:37:55-04:00 New Revision: 786954db06ab253dbd62d059036e06f6bbd9223c URL: https://github.com/llvm/llvm-project/commit/786954db06ab253dbd62d059036e06f6bbd9223c DIFF: https://github.com/llvm/llvm-project/commit/786954db06ab253dbd62d059036e06f6bbd9223c.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3484064 , @manojgupta wrote: > We are finding a lot of failures in our ToT builds with this change. here is > an example for a configure script: > > $ cat tent.c > int main () > { > tgetent(0,0); > return 0;

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3484076 , @manojgupta wrote: > Tried locally but I still see the warning with -fno-knr-functions. It also > says that the argument is unused. > > bin/clang --version > clang version 15.0.0 (https://github.com/ll

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

manojgupta added a comment. Following behavior is also surprising: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/ https://reviews.llvm.org/D122895 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

manojgupta added a comment. Tried locally but I still see the warning with -fno-knr-functions. It also says that the argument is unused. bin/clang --version clang version 15.0.0 (https://github.com/llvm/llvm-project.git a9d68a5524dea113cace5983697786599cbdce9a

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

xbolva00 added a comment. In D122983#3484064 , @manojgupta wrote: > We are finding a lot of failures in our ToT builds with this change. here is > an example for a configure script: > > $ cat tent.c > int main () > { > tgetent(0,0); > return 0; > } >

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

manojgupta added a comment. We are finding a lot of failures in our ToT builds with this change. here is an example for a configure script: $ cat tent.c int main () { tgetent(0,0); return 0; } $ bin/clang -c tent.c -Wno-error tent.c:3:2: error: call to undeclared function 'tgetent'; ISO C99 a

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller updated this revision to Diff 426233. stefanhaller added a comment. Fix documentation of ThreadPriority::Low (was: Background), and move it up from set_thread_priority to ThreadPriority. (Is it ok that there's no documentation left for set_thread_priority? I couldn't come up with any

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman added inline comments. Comment at: llvm/include/llvm/Support/Threading.h:239 }; /// If priority is Background tries to lower current threads priority such /// that it does not affect foreground tasks significantly. Can be used for Should be "Low

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. Herald added a project: All. stefanhaller requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, ilya-biryukov. Herald added projects: clang, LLVM, cl

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15319-15321 // OpenCL v2.0 s6.9.u - Implicit function declaration is not supported. else if (getLangOpts().OpenCL) diag_id = diag::err_opencl_im

[clang-tools-extra] a9d68a5 - Generalize calls to ImplicitlyDefineFunction

Author: Aaron Ballman Date: 2022-04-30T10:03:51-04:00 New Revision: a9d68a5524dea113cace5983697786599cbdce9a URL: https://github.com/llvm/llvm-project/commit/a9d68a5524dea113cace5983697786599cbdce9a DIFF: https://github.com/llvm/llvm-project/commit/a9d68a5524dea113cace5983697786599cbdce9a.diff

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj created this revision. upsj added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. upsj updated this revision to Diff 426127. upsj added a comment. upsj added a reviewer: sammccall. upsj updated this revision to Diff 426224. upsj updated

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

sammccall added a comment. Great! If this were to be a public, user-controlled feature we'd make it part of the config file which is a bit more involved, but I think this is rather just a developer toggle until it's time to turn it on by default, so a command-li

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj updated this revision to Diff 426217. upsj added a comment. don't add reference inlay hints for r-value refs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://reviews.llvm.org/D124359 Files: clang-tools-extra/clangd/InlayHin

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj added a comment. Thanks for checking! Putting it behind a flag was my intention from the start anyways, since ideally I would like to traverse the AST through something like emplace_back ->construct/realloc_insert -> allocator::construct until I reach a non-forwarding function. Do you have

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

Mordante added a comment. Thanks for these fixes. SGTM, but I want to see the CI pass. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:135 FD->getNameForDiagnostic(Out, FD->getASTContext().getLangOpts(), true); - Out << "' call may invalidat

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

sammccall added a comment. Trying this on a few files, this seems like it increases preamble sizes up to 1% or so: | Before| After -+---+-- AST.cpp | 42249648 | 42419732 XRefsTests.cpp | 56525116 | 56763768

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

sammccall added a subscriber: adamcz. sammccall added a comment. It was intentional to only (initially) support std::make_unique as its implementation is trivial. Whereas I looked at std::make_shared and it appears to result in instantiating a lot of templates. This was more "I'm sure this is us

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

sammccall added a comment. Thanks for revert, and apologies for missing the bots. (I did of course run the tests locally, but in a weird config that didn't trigger the failure) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124679/new/ https://rev

[clang-tools-extra] 816399c - Reland [clangd] More precisely enable clang warnings through ClangTidy options

Author: Sam McCall Date: 2022-04-30T11:07:11+02:00 New Revision: 816399cac2475499437c5a62e21a165f2de6460a URL: https://github.com/llvm/llvm-project/commit/816399cac2475499437c5a62e21a165f2de6460a DIFF: https://github.com/llvm/llvm-project/commit/816399cac2475499437c5a62e21a165f2de6460a.diff LO

[clang] a60ef98 - ClangDriverTests:ToolChainTest.cpp: Fix warnings. [-Wsign-compare]

Author: NAKAMURA Takumi Date: 2022-04-30T17:19:26+09:00 New Revision: a60ef98bb11378b24045372a53c55923df13ddc3 URL: https://github.com/llvm/llvm-project/commit/a60ef98bb11378b24045372a53c55923df13ddc3 DIFF: https://github.com/llvm/llvm-project/commit/a60ef98bb11378b24045372a53c55923df13ddc3.dif