[PATCH] D126042: [RISCV][NFC] Remove `*=` operator for LMULType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda201aa4242e: [RISCV][NFC] Remove `*=` operator for LMULType (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] da201aa - [RISCV][NFC] Remove `*=` operator for LMULType

Author: eopXD Date: 2022-05-19T23:47:44-07:00 New Revision: da201aa4242ebb06209296962a28f89297d0c9a1 URL: https://github.com/llvm/llvm-project/commit/da201aa4242ebb06209296962a28f89297d0c9a1 DIFF: https://github.com/llvm/llvm-project/commit/da201aa4242ebb06209296962a28f89297d0c9a1.diff LOG: [R

[PATCH] D126042: [RISCV][NFC] Remove `*=` operator for LMULType

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126042/new/ https://reviews.llvm.org/D126042 __

[PATCH] D126042: [RISCV][NFC] Remove `*=` operator for LMULType

eopXD created this revision. eopXD added reviewers: khchen, kito.cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228 + void Visit(const OMPFailClause *C) { +getNodeDelegate().AddChild([=] { tianshilei1992 wrote: > koops wrote: > > tianshilei1992 wrote: > > > Why would we want a dedica

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 430883. koops added a comment. Further changes in the code to confirm to the clang format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta added a comment. In D125961#3526347 , @wanders wrote: > There are other pragmas which include colon. How do they fare? > > Example > https://docs.microsoft.com/en-us/cpp/preprocessor/warning?view=msvc-170 > > #pragma warning( disable : 4507 34;

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta updated this revision to Diff 430882. thieta added a comment. Added additional tests to check other pragma statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125961/new/ https://reviews.llvm.org/D125961 Files: clang/lib/Format/Forma

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

khchen added a comment. In D125765#3526835 , @pcwang-thead wrote: > In D125765#3524456 , @khchen wrote: > >> I think we have no consensus in >> https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuec

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

khchen added a comment. please move those tests to `test/CodeGen/RISCV/rvv-intrinsics` and rename them without `rvv-` prefix. Comment at: clang/include/clang/Basic/riscv_vector.td:1511 +__extension__ extern __inline +__attribute__ ((__always_inline__, __gnu_inline__, __artific

[PATCH] D126002: [clang] Fixing arm-common, windows only and openmp header install targets

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126002/new/ https://reviews.llvm.org/D126002 ___

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

pcwang-thead added a comment. In D125947#3525539 , @jrtc27 wrote: > Also, the tests where you have codegen changes rather than preserving a > soft-float ABI should probably be put up for review separately by adding an > explicit hard single-float ABI, a

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

pcwang-thead added a comment. In D125947#3525537 , @jrtc27 wrote: > It's currently this way in order to be compatible with GCC. Changing this > requires consensus from both toolchains to ensure compatibility is preserved. > See https://github.com/riscv-

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead added a comment. In D125765#3524456 , @khchen wrote: > I think we have no consensus in > https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, > and most people disagree the current naming, > maybe we need to

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. In D119544#3494281 , @erichkeane wrote: > Updated to include the fix for the libcxx issue, which was that we weren't > properly differentiating between 'friend' functions based on concepts. I'll > likely be submitting this e

[PATCH] D125635: Make CompoundStmtBitfields::NumStmts not a bit-field

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125635/new/ https://reviews.llvm.org/D125635 __

[PATCH] D122869: [lit] Fix setup of sanitizer environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd33c36235df1: [lit] Fix setup of sanitizer environment (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. @rsmith gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Thanks! Comment at: clang/unittests/Driver/ToolChainTest.cpp:618 + + // Check (newer) GCC toolset installation + {

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

Amir added a comment. Looks like this commit breaks msvc build: https://lab.llvm.org/buildbot/#/builders/222/builds/532 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.org/D124836 ___

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e00a34cdb49: [AArch64] Add support for -fzero-call-used-regs (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6e00a34 - [AArch64] Add support for -fzero-call-used-regs

Author: Bill Wendling Date: 2022-05-19T16:58:28-07:00 New Revision: 6e00a34cdb49ba1d4b72ec274e52260da9c52380 URL: https://github.com/llvm/llvm-project/commit/6e00a34cdb49ba1d4b72ec274e52260da9c52380 DIFF: https://github.com/llvm/llvm-project/commit/6e00a34cdb49ba1d4b72ec274e52260da9c52380.diff

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

efriedma added a comment. `uxtw #3` makes me think you're not generating the right code... the zero-extension hopefully doesn't matter, but the shift is significant. Maybe should be generating `getelementptr i8`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void updated this revision to Diff 430858. void added a comment. Last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.org/D124836 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/C

[PATCH] D126034: bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops

usama54321 created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. usama54321 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman created this revision. arphaman added reviewers: egorzhdan, jansvoboda11, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. arphaman requested review of this revision. This patch builds upon recently added indexing support for C++ concepts from https://reviews.l

[PATCH] D125952: [Serialization] Delta encode locations in expansion sloc entries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dfd8e99f91c: [Serialization] Delta encode locations in expansion sloc entries (authored by sammccall). Repository: rG LLVM Github Monorepo CHANG

[clang] 1dfd8e9 - [Serialization] Delta encode locations in expansion sloc entries

Author: Sam McCall Date: 2022-05-20T01:05:53+02:00 New Revision: 1dfd8e99f91c52879fd361466ad8765293a872be URL: https://github.com/llvm/llvm-project/commit/1dfd8e99f91c52879fd361466ad8765293a872be DIFF: https://github.com/llvm/llvm-project/commit/1dfd8e99f91c52879fd361466ad8765293a872be.diff LO

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 430838. Herald added subscribers: cfe-commits, arichardson. Herald added a reviewer: MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D1258

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong updated this revision to Diff 430831. steplong added a comment. - Rebased it on top of main instead of D126024 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong added reviewers: hans, mstorsjo, rnk, efriedma, thakis. steplong added a comment. Like D126023 , the generated assembly for MSVC is slightly different: MSVC LLVM __readx18byte

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong added reviewers: hans, rnk, efriedma, thakis, mstorsjo. steplong added a comment. The generated assembly is a little different from MSVC's: MSVC LLVM __writex18byte: strbw1, [x18

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. Unintentionally created this patch against an older version of main and it interacted badly with D124998 on the rebase. Rerunning tests now, and will leave this open for further comments for a little while. Thanks all Reposit

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield updated this revision to Diff 430821. JonChesterfield added a comment. - Fix git merge misfires Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125970/new/ https://reviews.llvm.org/D125970 Files: clang/include/clang/Basic/Attr.td

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield updated this revision to Diff 430820. JonChesterfield added a comment. - Fix git merge misfires Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125970/new/ https://reviews.llvm.org/D125970 Files: clang/include/clang/Basic/Attr.td

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield updated this revision to Diff 430818. JonChesterfield added a comment. - Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125970/new/ https://reviews.llvm.org/D125970 Files: clang/include/clang/Basic/Attr.td clang/i

[PATCH] D125961: [clang-format] Don't break lines after pragma region

wanders added a comment. There are other pragmas which include colon. How do they fare? Example https://docs.microsoft.com/en-us/cpp/preprocessor/warning?view=msvc-170 #pragma warning( disable : 4507 34; once : 4385; error : 164 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. Thanks for accepting! I'm interested to learn more about how the calling conv works, e.g. if parts of it are implemented in clang and parts of it patched on the fly by opt, but that's downstream of easy access to writing C tests that use it. Repository: rG L

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125970/new/ https://reviews.llvm.org/D125970 __

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4639 + getDataLayout().getTypeAllocSize(Init->getType())); + assert(VarSize == CstSize && "Emitted constant has unexpected size"); +#endif ahatanak wrote: > efriedma wro

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. Added a codegen test for arg passing. It establishes that most arguments are left alone, but structs passed by value are handled as an addrspace(4) byref. Letting opt -O2 run annotated some argument pointers as being in addrspace(1) which I think is wrong. I ha

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield updated this revision to Diff 430801. JonChesterfield added a comment. - Add O0 arg passing codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125970/new/ https://reviews.llvm.org/D125970 Files: clang/include/clang/Basic/

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. OK, so that's a different thing. CUDA/HIP has a bunch of rules about implicitly tagging things with addrspace(1) at the call boundary. I don't think any of that magic should exist for C or C++, the developer gets to spell out the address space stuff they want ex

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

yaxunl added a comment. In D125970#3526053 , @JonChesterfield wrote: > In D125970#3525985 , @yaxunl wrote: > >> need a codegen test to make sure amdgpu_kernel ABI is used in C/C++ for >> functions with this attr

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

wanders added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4760-4762 // reject options that shouldn't be supported in bitcode // also reject kernel/kext static const constexpr unsigned kBitcodeOptionIgnorelist[] = { This comme

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. In D125970#3525985 , @yaxunl wrote: > need a codegen test to make sure amdgpu_kernel ABI is used in C/C++ for > functions with this attribute We've already got tests that check the amdgpu_kernel calling conv is lowered

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122126/new/ https://reviews.llvm.org/D122126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne updated this revision to Diff 430779. ldionne marked 3 inline comments as done. ldionne added a comment. Herald added a subscriber: arichardson. Address some comments (but not @phosek's yet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa9c3938198: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause (authored by jyu2). Changed prior to commit: https://reviews.llv

[clang] 7aa9c39 - [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

Author: Jennifer Yu Date: 2022-05-19T12:43:13-07:00 New Revision: 7aa9c39381989134e5d36ec1ea859dc6dc44d8eb URL: https://github.com/llvm/llvm-project/commit/7aa9c39381989134e5d36ec1ea859dc6dc44d8eb DIFF: https://github.com/llvm/llvm-project/commit/7aa9c39381989134e5d36ec1ea859dc6dc44d8eb.diff L

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

yaxunl added a comment. need a codegen test to make sure amdgpu_kernel ABI is used in C/C++ for functions with this attribute. https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu#L64 may be used as an example. Repository: rG LLVM Github Mo

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Don't forget to rebase this on top of https://reviews.llvm.org/D125421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/ne

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.org/D124836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} craig.topper wrote: > qiongsiwu1 wrote: > > craig.topper wrote: > > > qiongsiwu1 wrote: > > > > craig.topper wrote: > > > > > There appear

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:537 + FILES ${openmp_wrapper_files} + DESTINATION ${header_install_dir} + EXCLUDE_FROM_ALL craig.topper wrote: > Should this be ${header_install_dir}/openmp_wrappers Oh good catch!

[PATCH] D126002: [clang] Fixing arm-common, windows only and openmp header install targets

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: craig.topper, DavidSpickett, nemanjai. qiongsiwu1 added a project: clang. Herald added subscribers: StephenFan, guansong, kristof.beyls, yaxunl, mgorny. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald ad

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

xazax.hun added a comment. Actually, I think in most cases we want to consistent how to merge bool values. So I wonder whether instead of reimplementing the merge operation in this check we should just call a function that does the work. And the same function should be used within the engine to

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

steven_wu added a comment. LGTM. Can you add a test for your usecase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125974/new/ https://reviews.llvm.org/D125974 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3525533 , @paulkirth wrote: > We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the > new changes to DWARF introduced in this patch. It appears as if CGo is > confused because it found a `DW_TAG_

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Summary updated :) In D125788#3524338 , @kiranchandramohan wrote: > I think it is a driver flag `-flang-experimental-exec`. I was only requesting > the add this information to the patch summary. If you feel it should be > p

[clang] d640442 - [NFC] Fix a couple of whitespace issues.

Author: Paul Walker Date: 2022-05-19T17:27:09Z New Revision: d640442518d5b095cbf10d4c8eae569425f0506e URL: https://github.com/llvm/llvm-project/commit/d640442518d5b095cbf10d4c8eae569425f0506e DIFF: https://github.com/llvm/llvm-project/commit/d640442518d5b095cbf10d4c8eae569425f0506e.diff LOG: [

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

jrtc27 added a comment. Also, the tests where you have codegen changes rather than preserving a soft-float ABI should probably be put up for review separately by adding an explicit hard single-float ABI, as those seem worthwhile for reducing noise Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

jrtc27 added a comment. It's currently this way in order to be compatible with GCC. Changing this requires consensus from both toolchains to ensure compatibility is preserved. See https://github.com/riscv-non-isa/riscv-toolchain-conventions/issues/13 for some discussion on this. Repository:

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

paulkirth added a comment. We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the new changes to DWARF introduced in this patch. It appears as if CGo is confused because it found a `DW_TAG_variable` that doesn't have a name, which is allowed by the DWARF standard. This

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.h:63 std::vector IncludesToBeProcessed; + bool WarnIntoHeaders; }; whisperity wrote: > LegalizeAdulthood wrote: > > 1) How is this different fr

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd374b65f2da1: Drop qualifiers from return types in C (DR423) (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d374b65 - Drop qualifiers from return types in C (DR423)

Author: Aaron Ballman Date: 2022-05-19T13:06:50-04:00 New Revision: d374b65f2da1bdd3d9a7e9ac8ed4ad5467c882f9 URL: https://github.com/llvm/llvm-project/commit/d374b65f2da1bdd3d9a7e9ac8ed4ad5467c882f9 DIFF: https://github.com/llvm/llvm-project/commit/d374b65f2da1bdd3d9a7e9ac8ed4ad5467c882f9.diff

[PATCH] D125983: [DeadArgElim] Use poison instead of undef as placeholder for dead arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fc9449c962a: [DeadArgElim] Use poison instead of undef as placeholder for dead arguments (authored by nlopes). Herald added subscribers: cfe-commits

[clang] 5fc9449 - [DeadArgElim] Use poison instead of undef as placeholder for dead arguments

Author: Nuno Lopes Date: 2022-05-19T18:00:24+01:00 New Revision: 5fc9449c962a0703a658aa8e29162e00dc2fecf1 URL: https://github.com/llvm/llvm-project/commit/5fc9449c962a0703a658aa8e29162e00dc2fecf1 DIFF: https://github.com/llvm/llvm-project/commit/5fc9449c962a0703a658aa8e29162e00dc2fecf1.diff LO

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added a comment. In D125771#3525252 , @njames93 wrote: > Tbh the whole testing infrastructure for clang-tidy is a mess. When I have > wanted to verify fixes and diagnostics for header files, I find manually > invoking clang-tidy is bet

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc35ca3a1c78f: [PowerPC] Implement XL compat __fnabs and __fnabss builtins. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c35ca3a - [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

Author: Amy Kwan Date: 2022-05-19T11:28:40-05:00 New Revision: c35ca3a1c78f693b749ad11742350b7fc6c5cd89 URL: https://github.com/llvm/llvm-project/commit/c35ca3a1c78f693b749ad11742350b7fc6c5cd89 DIFF: https://github.com/llvm/llvm-project/commit/c35ca3a1c78f693b749ad11742350b7fc6c5cd89.diff LOG:

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

jyu2 updated this revision to Diff 430715. jyu2 added a comment. Thanks Alexey for the review. This is fix the nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125912/new/ https://reviews.llvm.org/D125912 Files: clang/docs/LibASTMatchersRefer

[PATCH] D125909: [AMDGPU] emit macro __GFX9__ etc

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG559b8fc17ef6: [AMDGPU] emit macro __GFX9__ etc (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D125909?vs=

[clang] 559b8fc - [AMDGPU] emit macro __GFX9__ etc

Author: Yaxun (Sam) Liu Date: 2022-05-19T12:06:56-04:00 New Revision: 559b8fc17ef6f5a65ccf9a11fce5f91c0a011b00 URL: https://github.com/llvm/llvm-project/commit/559b8fc17ef6f5a65ccf9a11fce5f91c0a011b00 DIFF: https://github.com/llvm/llvm-project/commit/559b8fc17ef6f5a65ccf9a11fce5f91c0a011b00.dif

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:596-598 + MergedEnv.makeOr( + MergedEnv.makeAnd(Env1.getFlowConditionToken(), *HasValueVal1), + MergedEnv.makeAnd(Env2.getFlowConditionTok

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

njames93 added a comment. Tbh the whole testing infrastructure for clang-tidy is a mess. When I have wanted to verify fixes and diagnostics for header files, I find manually invoking clang-tidy is better than using the check_clang_tidy script. I don't have the time right now, but a verify mode l

[clang] cefe472 - [clang] Fix __has_builtin

Author: Yaxun (Sam) Liu Date: 2022-05-19T11:34:42-04:00 New Revision: cefe472c51fbcd1aed4d4a090709f25a12a8bc2c URL: https://github.com/llvm/llvm-project/commit/cefe472c51fbcd1aed4d4a090709f25a12a8bc2c DIFF: https://github.com/llvm/llvm-project/commit/cefe472c51fbcd1aed4d4a090709f25a12a8bc2c.dif

[PATCH] D125829: [clang] Fix __has_builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGcefe472c51fb: [clang] Fix __has_builtin (authored by yaxunl). Herald added a project: clang. Changed prior t

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-avoid-bind.cpp:367 +// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer a lambda to std::bind +// CHECK-FIXES: auto EEE = [d] { d->operator()(1, 2); } + Fixi

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

tahonermann added a comment. > So the proposal is that -fheader-modules=parse would parse #include of header > unit in the same TU, and import .pcm on import, right? Per cpp.includep7 , "If the header identified by the //header-name// denotes an importable

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ed9f603fd59: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the… (authored by TiehuZhang, committed by mdchen). Change

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

ilya-biryukov planned changes to this revision. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. Richard, thanks for course correcting. I was under impression that header modules are not in the standard, my mistake. It looks like this particular change actually brea

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 430691. MosheBerman added a comment. Missed a whitespace. (Looks like there may be another merge conflict, in NullabilityChecker.cpp:117, but not sure if that's the issue. Let's try this just in case it's not.) Repository: rG LLVM Github Monorepo CH

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 430686. MosheBerman marked an inline comment as not done. MosheBerman added a comment. My IDE auto-formatted away some whitespace, causing a merge conflict for the test CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

sepavloff added a comment. In D125635#3514607 , @rjmccall wrote: > On the one hand, I'm not sure 8M statements in a block — or 1M, for that > matter — is an unreasonable implementation limit. On the other hand, this > patch looks like it only changes o

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

jyknight added a comment. In D125773#3523459 , @rsmith wrote: > Header modules are part of the C++20 standard (where they are called "header > units"), and module maps are an intended way for Clang to provide this > functionality in C++20 mode. I don't

[PATCH] D125954: [analyzer][NFC] Factor out the copy-paste code repetition of assumeDual and assumeInclusiveRangeDual

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Okay, it still looks a bit odd, but this is definitely an increment. Comment at: clang/lib/StaticAnalyzer/Core/ConstraintManager.cpp:48 +ConstraintManager::assumeDualImpl

[libunwind] a5f3625 - [libunwind] Remove unused _LIBUNWIND_HAS_NO_THREADS macro in tests

Author: Louis Dionne Date: 2022-05-19T10:58:13-04:00 New Revision: a5f36259a20533d9c970ab6a5faab7cf341ca1c9 URL: https://github.com/llvm/llvm-project/commit/a5f36259a20533d9c970ab6a5faab7cf341ca1c9 DIFF: https://github.com/llvm/llvm-project/commit/a5f36259a20533d9c970ab6a5faab7cf341ca1c9.diff

[PATCH] D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGe601b2a15427: [flang][driver] Add support for generating executables on MacOSX/Darwin (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D125628?vs=429528&id=430679#toc Reposit

[clang] e601b2a - [flang][driver] Add support for generating executables on MacOSX/Darwin

Author: Andrzej Warzynski Date: 2022-05-19T15:47:59+01:00 New Revision: e601b2a1542710789395ab1121b1ccc7076e39d1 URL: https://github.com/llvm/llvm-project/commit/e601b2a1542710789395ab1121b1ccc7076e39d1 DIFF: https://github.com/llvm/llvm-project/commit/e601b2a1542710789395ab1121b1ccc7076e39d1.d

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk updated this revision to Diff 430671. amyk added a comment. - Add a P6 +VSX run line and remove extra P7 /P8 lines for backend test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125974: Limit bitcode option ignorelist to Darwin

MichielDerhaeg created this revision. MichielDerhaeg added reviewers: steven_wu, compnerd. Herald added a project: All. MichielDerhaeg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This ignore list prevents embedding of bitcode fo

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.ll:46 +; RUN: -mattr=-vsx < %s | FileCheck %s --check-prefix=CHECK-NOVSX + +declare double @llvm.ppc.fnabs(double) lei wrote: > nit: same as before no need to test all

[PATCH] D125925: Add an option to fill container for ref

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bbf6ad5b64c: Add an option to fill container for ref (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

  1   2   >