[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

aaron.ballman added a comment. Thank you for your work on this, I generally like this new approach and think we're heading in the right direction. Comment at: clang/include/clang/Sema/DeclSpec.h:1853-1856 /// Attrs - Attributes. ParsedAttributes Attrs; + ParsedAttribu

[PATCH] D126274: [clangd] Handle '--' in QueryDriverDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rG175833ed6f62: [clangd] Handle '--' in QueryDriverDatabase (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126274/new/ https://reviews.ll

[clang-tools-extra] 175833e - [clangd] Handle '--' in QueryDriverDatabase

Author: Nathan Ridge Date: 2022-05-24T13:10:41-04:00 New Revision: 175833ed6f62b697ce6248930da54e4ddb7f4c00 URL: https://github.com/llvm/llvm-project/commit/175833ed6f62b697ce6248930da54e4ddb7f4c00 DIFF: https://github.com/llvm/llvm-project/commit/175833ed6f62b697ce6248930da54e4ddb7f4c00.diff

[clang] 4a3e2af - Reland "[PS5] Verify defaults to -fno-stack-size-section"

Author: Paul Robinson Date: 2022-05-24T10:09:39-07:00 New Revision: 4a3e2aff5f849278f6c49678fd21f8ca5e59c4e7 URL: https://github.com/llvm/llvm-project/commit/4a3e2aff5f849278f6c49678fd21f8ca5e59c4e7 DIFF: https://github.com/llvm/llvm-project/commit/4a3e2aff5f849278f6c49678fd21f8ca5e59c4e7.diff

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee8524087c78: [libclang] add supporting for indexing/visiting C++ concepts (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] ee85240 - [libclang] add supporting for indexing/visiting C++ concepts

Author: Alex Lorenz Date: 2022-05-24T10:02:53-07:00 New Revision: ee8524087c78a673fcf5486ded69ee597a85e0f1 URL: https://github.com/llvm/llvm-project/commit/ee8524087c78a673fcf5486ded69ee597a85e0f1 DIFF: https://github.com/llvm/llvm-project/commit/ee8524087c78a673fcf5486ded69ee597a85e0f1.diff L

[clang] efebb27 - Revert "[PS5] Verify defaults to -fno-stack-size-section"

Author: Paul Robinson Date: 2022-05-24T10:00:33-07:00 New Revision: efebb27b745a0d677ad2ea9aefff242c12aef29c URL: https://github.com/llvm/llvm-project/commit/efebb27b745a0d677ad2ea9aefff242c12aef29c DIFF: https://github.com/llvm/llvm-project/commit/efebb27b745a0d677ad2ea9aefff242c12aef29c.diff

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. In D125788#3534482 , @sscalpone wrote: > My belief is that we should wait until f18 hits a reasonable quality bar for > executables before making flang-new the default. My reasoning seems not to > have carried the day. It would

[PATCH] D126224: Add DWARF string debug to clang release notes.

probinson added a comment. I see some unrelated whitespace changes, we generally don't like mixing those with "real" changes. But the description seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi added a comment. Thank you @jansvoboda11 for reviewing and helping me qualify the changes! 🙇🏻‍♂️ If I receive no further comments I will commit the changes on Thursday; if anyone wants some more time to take a look just let me know. I intend to commit in 2 commits, the first patch as one

[PATCH] D126224: Add DWARF string debug to clang release notes.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/docs/ReleaseNotes.rst:447 + structures *without* a ``DW_AT_name`` field, which is valid DWARF, but may + lead to assertion failures in some so

[clang] 28432b0 - [PS5] Verify defaults to -fno-stack-size-section

Author: Paul Robinson Date: 2022-05-24T09:47:37-07:00 New Revision: 28432b0f655641df7f9d079cf69ba235038d6340 URL: https://github.com/llvm/llvm-project/commit/28432b0f655641df7f9d079cf69ba235038d6340 DIFF: https://github.com/llvm/llvm-project/commit/28432b0f655641df7f9d079cf69ba235038d6340.diff

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 updated this revision to Diff 431702. jhuber6 added a comment. Adding extra commentto mention the hidden requirement that the driver shuold not define a different `-D` option for the host and device. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. It sounds like the consensus is what's represented in the release notes, "if this new feature breaks you, then you need to fix yourself". Does anyone have any concerns with the specific text, or does it LGTY? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6845-6846 +llvm::MD5::MD5Result Result; +for (const auto &Arg : PreprocessorOpts.Macros) + Hash.update(Arg.first); +Hash.final(Result); yaxunl wrote: > jhuber6 wrote:

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

yaxunl added a comment. In HIP, kernels are represented by attribute `global` and not by calling convention in clang. This may be an alternative. Another alternative might be merging amdgpu_kernel and opencl_kernel calling convention since for the same target they are the same. They could be r

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Should I update the patch? I am waiting for quick feedback on the concept of handling conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 __

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added inline comments. Herald added a subscriber: bzcheeseman. Comment at: clang/lib/Testing/CMakeLists.txt:33 + clangBasic + clangFrontend ) Are these okay? In D105584 these were not Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6845-6846 +llvm::MD5::MD5Result Result; +for (const auto &Arg : PreprocessorOpts.Macros) + Hash.update(Arg.first); +Hash.final(Result); jhuber6 wrote: > yaxunl wrote: >

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma added a comment. In D116088#3534100 , @kpdev42 wrote: > 1. Sets memory barrier > 2. Calls atomic load from memory location > 3. Modifies data > 4. Calls atomic store to memory location > 5. Checks that operation is consistent, if not goes to step

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:480 +// They are handled by riscv_vector.h +if (Name == "vsetvli" || Name == "vsetvlimax") + continue; khchen wrote: > I feel little tricky to checking the name here

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked an inline comment as done. abidmalikwaterloo added inline comments. Herald added a subscriber: bzcheeseman. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend shraiysh wrote: > abidmalikwaterloo w

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6845-6846 +llvm::MD5::MD5Result Result; +for (const auto &Arg : PreprocessorOpts.Macros) + Hash.update(Arg.first); +Hash.final(Result); yaxunl wrote: > Are these optio

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. I'm not super familiar with concepts but this LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6845-6846 +llvm::MD5::MD5Result Result; +for (const auto &Arg : PreprocessorOpts.Macros) + Hash.update(Arg.first); +Hash.final(Result); Are these options always the sam

[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

Laurentiu added a comment. Hi Nemanja, I just realized I only had a personal account on llvm.org. Would you be able to remove me from that review and add laurentiu.ter...@windriver.com instead? Thanks, Laurentiu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a14e817eeb: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls. (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] a1a14e8 - [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

Author: Cyndy Ishida Date: 2022-05-24T08:43:31-07:00 New Revision: a1a14e817eeb5a0663b1342a125674348b8aac06 URL: https://github.com/llvm/llvm-project/commit/a1a14e817eeb5a0663b1342a125674348b8aac06 DIFF: https://github.com/llvm/llvm-project/commit/a1a14e817eeb5a0663b1342a125674348b8aac06.diff

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. My belief is that we should wait until f18 hits a reasonable quality bar for executables before making flang-new the default. My reasoning seems not to have carried the day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:463 +std::string +AVRToolChain::buildCompilerRTBasename(const llvm::opt::ArgList &Args, + StringRef Component, FileType Type, This method decides

[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

nemanjai created this revision. nemanjai added reviewers: Laurentiu, PowerPC. Herald added subscribers: shchenz, kbarton. Herald added a project: All. nemanjai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current behaviour with these

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

Anastasia added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:122 + if (Opts.HLSL) +Includes.push_back("hlsl.h"); Is this header expected to be large? You might want to flag up in the description of the review and the comments in the header

[PATCH] D126224: Add DWARF string debug to clang release notes.

probinson added a comment. In D126224#3532769 , @dblaikie wrote: > While the string would be deduplicated, the offset in the DIEs (or index in > DWARFv5, plus offset in .debug_str_offsets) for each of these strings would > not. But perhaps that would st

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:412 + class ZeroRelatedErrnoConstraint : public ErrnoConstraintKind { +clang::BinaryOperatorKind Relation; + The explicit qualification is not necess

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 updated this revision to Diff 431666. jhuber6 added a comment. Removing use of the line number, instead replacing it with an 8 character wide hash of the `-D` options passed to the front-end. This should make it sufficiently unique for users compiling the same file with different options

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 431665. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126299/new/ https://reviews.llvm.org/D126299 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskRay. Herald added a project: clang. Repository:

[PATCH] D124751: [HLSL] Support -E option for HLSL.

beanz added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9887 + break; +case llvm::Triple::EnvironmentType::Compute: + ShaderType = HLSLShaderAttr::ShaderType::Compute; If the `HLSLShaderAttr::ShaderType` enum is properly ord

[PATCH] D126062: [clang] Don't parse MS attributes in `ParseExportDeclaration()`.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- I checked as well and these changes are NFC. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126062/new/ https://rev

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param.cpp:1 // RUN: %check_clang_tidy %s performance-unnecessary-value-param %t This will fix your Windows testing issue, I believe. CH

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

erichkeane added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:1901 + for (auto* Decl : R) { +auto* DD = dyn_cast(Decl); +if (DD && DD->isEligibleOrSelected()) What cases happen when the lookup for a destructor name ends up not being a destruct

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added a comment. In D125506#3528380 , @nathanchance wrote: > I bisected a crash when compiling the Linux kernel to this change. > > A reduced C reproducer: > > enum { > OP_CB_GETATTR = 3, > OP_CB_RECALL, > OP_CB_RECALL_ANY = 8, > O

[PATCH] D126187: [C++20] [Coroutines] Conform the updates for CWG issue 2585

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I have a change to the release note that I'd like to see improved in SOME way, but I trust you to correct/reword as you wish. I'm still not particularly happy with the mechanism of th

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3914-3918 + if (Old->hasInheritedPrototype()) +Old = Old->getCanonicalDecl(); Diag(New->getLocation(), diag::err_conflicting_types) << New; Diag(Old->getLocation(), PrevDiag) <

[PATCH] D125911: [pseudo] (trivial) bracket-matching

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG0360b9f1599b: [pseudo] (trivial) bracket-matching (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D125911?vs=430440&id=431658#toc

[clang-tools-extra] 0360b9f - [pseudo] (trivial) bracket-matching

Author: Sam McCall Date: 2022-05-24T15:13:36+02:00 New Revision: 0360b9f1599b0b13f164d8170a619b19f9cb8bb4 URL: https://github.com/llvm/llvm-project/commit/0360b9f1599b0b13f164d8170a619b19f9cb8bb4 DIFF: https://github.com/llvm/llvm-project/commit/0360b9f1599b0b13f164d8170a619b19f9cb8bb4.diff LO

[PATCH] D125911: [pseudo] (trivial) bracket-matching

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/unittests/BracketTest.cpp:103 +TEST(Bracket, SimplePair) { + verifyBrackets("^{ ^[ ^( ^) ^( ^) ^] ^}"); + verifyBrackets(") ^{ ^[ ^] ^} ("); hokei

[PATCH] D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rGf37101983fc9: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D12

[clang] f371019 - [OpenMP] Add `-Xoffload-linker` to forward input to the device linker

Author: Joseph Huber Date: 2022-05-24T09:11:02-04:00 New Revision: f37101983fc9fabbbde4b10f613ed248a424d71a URL: https://github.com/llvm/llvm-project/commit/f37101983fc9fabbbde4b10f613ed248a424d71a DIFF: https://github.com/llvm/llvm-project/commit/f37101983fc9fabbbde4b10f613ed248a424d71a.diff

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

cishida added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3914-3918 + if (Old->hasInheritedPrototype()) +Old = Old->getCanonicalDecl(); Diag(New->getLocation(), diag::err_conflicting_types) << New; Diag(Old->getLocation(), PrevDiag) << Old

[PATCH] D115232: [clangd] Indexing of standard library

sammccall closed this revision. sammccall added a comment. Landed finally as 03ea140b3a285c9a4400ee007b1790b110cbf984 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ h

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. At the moment, in case of compiler-rt, `__sync_add_and_fetch` boils down to `__sync_add_and_fetch_N`, where `N` is the size of data being fetched (4 for int). The implementation of `__sync_fetch_and_add_N` does approximately the following: 1. Sets memory barrier 2. Calls

[PATCH] D126294: Add !nosanitize to FixedMetadataKinds

Enna1 created this revision. Herald added subscribers: ormris, hiraditya. Herald added a project: All. Enna1 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:182 } + // If not set entry, default is main. + if (!DAL->hasArg(options::OPT_hlsl_entrypoint)) { -> `If no set entry` or `If entry is not set explicitly` Repository: rG LL

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel added a comment. sgatev@ -- gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead updated this revision to Diff 431654. pcwang-thead added a comment. - Rebase. - move tests to `test/CodeGen/RISCV/rvv-intrinsics`. - Update functions' attrs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llv

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

Anastasia added inline comments. Comment at: clang/lib/AST/Mangle.cpp:138 + // HLSL shader entry function never need to be mangled. + if (getASTContext().getLangOpts().HLSL && D->hasAttr()) Does HLSL shader entry inherits the same behavior as C-linkage functi

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 431652. balazske added a comment. added comments. added note tag, added test, improved the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files: clang/lib/St

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. In D125904#3532608 , @tra wrote: > That said, I would consider compiling the same source with different > preprocessor options to be a legitimate use case that we should support. > Explicitly passing cuid would work as a workaro

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though this should have a release note for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126138/new/ https://reviews.llvm.org/D126138 _

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 431646. kito-cheng marked 5 inline comments as done. kito-cheng added a comment. Changes: - Split out several NFC changes to individual NFC patchs. - Moving most code emission logic into RISCVVIntrinsicUtils to prevent require sync manually. - PCH support

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for catching this! Comment at: clang/lib/Sema/SemaDecl.cpp:3914-3918 + if (Old->hasInheritedPrototype()) +Old = Old->getCanonicalDe

[PATCH] D125814: Improve the strict prototype diagnostic behavior

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125814/new/ https://reviews.llvm.org/D125814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126191: [Clang][CodeGen] Fix the cmse-clear-return.c test.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe4eaf10eef7: [Clang][CodeGen] Fix the cmse-clear-return.c test. (authored by kosarev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126191/new/ https://re

[clang] be4eaf1 - [Clang][CodeGen] Fix the cmse-clear-return.c test.

Author: Ivan Kosarev Date: 2022-05-24T12:49:42+01:00 New Revision: be4eaf10eef76869eb404f68703a1a09b344a7e5 URL: https://github.com/llvm/llvm-project/commit/be4eaf10eef76869eb404f68703a1a09b344a7e5 DIFF: https://github.com/llvm/llvm-project/commit/be4eaf10eef76869eb404f68703a1a09b344a7e5.diff

[PATCH] D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy

datacompboy added a comment. In D126077#3530189 , @njames93 wrote: > Do you know of any other instances where this issue could surface? I didn't found any other cases where isDerivedFrom used directly, only in couple of internal checks, none of which ar

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka created this revision. rovka added reviewers: awarzynski, kiranchandramohan. rovka added a project: Flang. Herald added a subscriber: jdoerfert. Herald added a reviewer: sscalpone. Herald added a project: All. rovka requested review of this revision. Herald added subscribers: cfe-commits, Mas

[PATCH] D126093: Sema: adjust assertion to account for deduced types

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a testing request and a nit. Thanks for the fix! Comment at: clang/include/clang/Sema/DeclSpec.h:520 +assert(isDeclRep((TST)TypeSpecType) || isTypeRep((TST)TypeSpecType) || + isEx

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan created this revision. Herald added subscribers: pmatos, asb, jgravelle-google, sbc100, dschuff. Herald added a project: All. egorzhdan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. Currently if `--sysroot /` is

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked 2 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:1167 + STI.hasV5TOps()); + // Only unused return registers can be used as copy regs at this point + popRegsFromStack(MBB, MI, T

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

c-rhodes added a comment. can the diagnostics improvements be broke out into separate patches? I think it would make this easier to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124860/new/ https://reviews.llvm.org/D124860

[PATCH] D107082: [X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI

skan added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:136 -* ... +* Support ``half`` type on SSE2 and above targets. Just for curiosity, why is SSE2? Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:593 +// Half type w

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

martong added inline comments. Comment at: clang/test/Analysis/symbol-simplification-assertion.c:27 + assert(a + L1 + 1 + b != c); + assert(a == 0); // no-assertion +} steakhal wrote: > Is this statement still reachable? Demonstrate it by using the > `clang_an

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

martong updated this revision to Diff 431635. martong marked an inline comment as done. martong added a comment. - Add clang_analyzer_warnIfReached() to the test and remove unused debug function decls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 431634. pratlucas marked 2 inline comments as done. pratlucas added a comment. Avoiding unecessary uses of FP and addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd61ded1034bb: [OpenCL] Make -cl-ext a driver option. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D125243?

[clang] d61ded1 - [OpenCL] Make -cl-ext a driver option.

Author: Anastasia Stulova Date: 2022-05-24T11:34:19+01:00 New Revision: d61ded1034bb9563c43d048ba0be4eff662e6144 URL: https://github.com/llvm/llvm-project/commit/d61ded1034bb9563c43d048ba0be4eff662e6144 DIFF: https://github.com/llvm/llvm-project/commit/d61ded1034bb9563c43d048ba0be4eff662e6144.d

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

martong added a comment. In D126123#3531150 , @steakhal wrote: > In D126123#3531112 , @martong wrote: > >> Is it documented with `getRegion`? Could we decorate that with >> `returns-nonnull` >> https://clang.ll

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

steakhal added a comment. In D126281#3533755 , @martong wrote: >> Point 2) above has negligible performance impact, empirical measurements do >> not show any noticeable difference in the run-time. > > Attaching the measurement results that show the run-t

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:38 unsigned DataAddr; + unsigned FlashSize; + unsigned SRAMSize; We need these information to correctly linking with lld. Comment at: clang/lib/Driver/ToolCha

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

martong added a comment. > Point 2) above has negligible performance impact, empirical measurements do > not show any noticeable difference in the run-time. Attaching the measurement results that show the run-time difference is not noticeable, or rather it is within the margin of error. F23176

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 updated this revision to Diff 431625. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126282/new/ https://reviews.llvm.org/D126282 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c ==

[PATCH] D126282: [Driver] Add more options for target AVR when linking with lld

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

martong added inline comments. Comment at: clang/test/Analysis/symbol-simplification-assertion.c:15-18 +void clang_analyzer_printState(); +void clang_analyzer_dump(long); +void clang_analyzer_eval(int); + TODO remove. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D126196: [analyzer] SATest: Ensure Docker image can be built

mantognini added a comment. In D126196#3533678 , @steakhal wrote: > LGTM; > So you have used this tool. Could you add some notes somewhere on how to get > this to work? > What is the workflow? > Is it documented anywhere? > > I know that's an unrelated t

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

wanders added a comment. This looks sensible to me. But I'm not an expert in the area (and still not 100% clear on the purpose of the ignorelist) so can't really say if the added comments captures the intent accurately. Comment at: clang/test/Driver/embed-bitcode-elf.c:1 +//

[PATCH] D126197: [analyzer] SATest: Weaken assumption about HTML files

mantognini added a comment. In D126197#3533674 , @steakhal wrote: > I'm not using this script file, so I'm not gonna be too picky about this. > However, I would be more confident landing changes if we had tests exercising > the changed behavior. > If you

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb166aa833e44: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES S

[clang] b166aa8 - [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

Author: Kito Cheng Date: 2022-05-24T17:24:32+08:00 New Revision: b166aa833e44a5af6d6f39c34b79fe21b443e424 URL: https://github.com/llvm/llvm-project/commit/b166aa833e44a5af6d6f39c34b79fe21b443e424 DIFF: https://github.com/llvm/llvm-project/commit/b166aa833e44a5af6d6f39c34b79fe21b443e424.diff LO

[PATCH] D126196: [analyzer] SATest: Ensure Docker image can be built

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM; So you have used this tool. Could you add some notes somewhere on how to get this to work? What is the workflow? Is it documented anywhere? I know that's an unrelated topic, but I mi

[PATCH] D126197: [analyzer] SATest: Weaken assumption about HTML files

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'm not using this script file, so I'm not gonna be too picky about this. However, I would be more confident landing changes if we had tests exercising the changed behavior. If you plan to

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder added a comment. In D125862#3532630 , @MaskRay wrote: >> Harbormaster completed remote builds in `B165047: Diff 430277.` > > You can get Windows bot results in the link. Hm, the windows pre-merge checks don't fail. Just the buildbots. I wonder if

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal added a comment. @NoQ, please have a look at this. Comment at: clang/test/Analysis/deprecated-flags-and-options.cpp:1-13 +// RUN: %clang_analyze_cc1 -analyzer-checker=core %s 2>&1 \ +// RUN: | FileCheck %s --check-prefixes=CHECK + +// RUN: %clang_analyze_cc1 -analyzer-

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal updated this revision to Diff 431618. steakhal edited the summary of this revision. steakhal added a comment. Herald added a subscriber: MaskRay. - Emit a warning when passing this option. - State explicitly in the release notes that passing this option to `clang-17` and above will cause

[PATCH] D126274: [clangd] Handle '--' in QueryDriverDatabase

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks so much for tracking this down! The number of times we've had this bug :-( I wish we were using something a little more structured than array-of-strings. Repository: rG LLVM Gi

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 431609. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driver/ToolChainTest.cpp ==

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei added inline comments. Comment at: clang/docs/ReleaseNotes.rst:371 +- Support ``-mharden-sls=all`` for X86. + nickdesaulniers wrote: > This should be updated if additional options are supported. > > You should also update `clang/docs/ClangCommandLineRe

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei updated this revision to Diff 431607. pengfei marked 5 inline comments as done. pengfei added a comment. Address @nickdesaulniers 's comments. Thanks for the thorough review and suggestions! > So we pessimize tail calls. Please fix and add a test case for that. This > might be an uninte

<    1   2   3   >