[PATCH] D126689: [IR] Enable opaque pointers by default

uabelho added a comment. In D126689#3553292 , @nikic wrote: > @uabelho Here's a slightly cleaned up test case that does not use opaque > pointers: > > target triple = "x86_64-unknown-linux-gnu" > > define void @test(i1 %cond, <1 x i16>* %p) { >

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

browneee added a comment. More details on the bug: https://reviews.llvm.org/D125802#3551305 Alternative implementation for fix: https://reviews.llvm.org/D126937 I'm not yet sure if these changes are correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

browneee added a comment. I was also looking into fixing this: https://reviews.llvm.org/D126944 I'm not yet sure if my changes are correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126937/new/ https://reviews.llvm.org/D126937

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

browneee created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. browneee requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. It

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:138-139 TYPE(CSharpGenericTypeConstraintComma) \ + TYPE(VerilogNumberBase) /* for the base in a number literal, not including \ +

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

MitalAshok planned changes to this revision. MitalAshok added a comment. Appears that more things need to be changed, I'll get that done soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126937/new/ https://reviews.llvm.org/D126937

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

MitalAshok added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:5561 Var = cast_or_null(Instantiator.VisitVarTemplateSpecializationDecl( VarSpec->getSpecializedTemplate(), Def, VarSpec->getTemplateArgsInfo(),

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

MitalAshok created this revision. Herald added a project: All. MitalAshok added reviewers: akyrtzi, aaron.ballman, erichkeane, browneee. MitalAshok published this revision for review. MitalAshok added a project: LLVM. MitalAshok added a comment. Herald added a project: clang. Herald added a

[PATCH] D126934: [clang-format] NFC Sort names of format token types

owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:39-45 + TYPE(CSharpGenericTypeConstraint) \ + TYPE(CSharpGenericTypeConstraintColon) \ +

[clang] b917433 - [NFC][Doc] Finish atomic compare

Author: Shilei Tian Date: 2022-06-02T21:50:07-04:00 New Revision: b917433835473d5a9dff5b1034e861cf5dc9e5bc URL: https://github.com/llvm/llvm-project/commit/b917433835473d5a9dff5b1034e861cf5dc9e5bc DIFF: https://github.com/llvm/llvm-project/commit/b917433835473d5a9dff5b1034e861cf5dc9e5bc.diff

[PATCH] D126934: [clang-format] NFC Sort names of format token types

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Suggested by HazardyKnusperkeks in D126845

[clang] 48d6a6c - [OpenMP][NFC] update status for 'omp_all_memory' directive to 'done'

Author: Mike Rice Date: 2022-06-02T17:31:33-07:00 New Revision: 48d6a6c9add90f3684de362907d5f05a0988244a URL: https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a DIFF: https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a.diff

[PATCH] D126084: [Sema] Reject list-initialization of enumeration types from a brace-init-list containing a single element of a different scoped enumeration type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66e08995b0b7: [Sema] Reject list-initialization of enumeration types from a (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES

[clang] 66e0899 - [Sema] Reject list-initialization of enumeration types from a

Author: Akira Hatanaka Date: 2022-06-02T17:25:11-07:00 New Revision: 66e08995b0b72d28acb5e87b90292e59fabfadae URL: https://github.com/llvm/llvm-project/commit/66e08995b0b72d28acb5e87b90292e59fabfadae DIFF:

[PATCH] D126084: [Sema] Reject list-initialization of enumeration types from a brace-init-list containing a single element of a different scoped enumeration type

ahatanak updated this revision to Diff 433922. ahatanak added a comment. Fix the comment to match the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126084/new/ https://reviews.llvm.org/D126084 Files: clang/lib/Sema/SemaInit.cpp

[clang] b64f6e5 - Add a release note for the scope enum initialization bug fix in

Author: Akira Hatanaka Date: 2022-06-02T17:13:05-07:00 New Revision: b64f6e5722024b29f0799f2a0eae08778162dc61 URL: https://github.com/llvm/llvm-project/commit/b64f6e5722024b29f0799f2a0eae08778162dc61 DIFF:

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

This revision was automatically updated to reflect the committed changes. Closed by commit rG987f9cb6b970: [clang-tidy] Add proper emplace checks to modernize-use-emplace (authored by nicovank, committed by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 987f9cb - [clang-tidy] Add proper emplace checks to modernize-use-emplace

Author: Nicolas van Kempen Date: 2022-06-03T00:14:57+01:00 New Revision: 987f9cb6b9708ff16980c4f8c3f8ba4674463fb5 URL: https://github.com/llvm/llvm-project/commit/987f9cb6b9708ff16980c4f8c3f8ba4674463fb5 DIFF:

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + joaomoreira wrote: > samitolvanen wrote: > > joaomoreira wrote: > > > I did not revise the entire patch yet. With this said, IMHO,

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

rjmccall added a comment. Okay, I understand. So, first off, I wouldn't really call that a "weak" symbol rather than, say, a lazily-emitted symbol; "weak" already has plenty of different senses, and we should try to avoid coining more. Also, your patch description makes it sound like there's

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim created this revision. hctim added reviewers: vitalybuka, kstoimenov. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds generation of sanitizer metadata attributes (which were added in

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb added a comment. In D126832#3553569 , @aaron.ballman wrote: > Can you post some examples of the output from this option so we can see what > the end results look like more easily? Right now this doesn't do anything at all, except feed the

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb updated this revision to Diff 433901. cjdb added a comment. - simplifies code - minimises test to only a handful of cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 Files: clang/include/clang/Driver/Options.td

[PATCH] D126396: Clean "./" from __FILE__ expansion.

ayzhao added a comment. In D126396#3554701 , @ppluzhnikov wrote: > Alan, > > Thanks for the approval. > Could you push this patch -- I don't have commit rights. Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126396: Clean "./" from __FILE__ expansion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ad17d2e96a3: Clean ./ from __FILE__ expansion. (authored by ppluzhnikov, committed by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126396/new/

[clang] 4ad17d2 - Clean "./" from __FILE__ expansion.

Author: Paul Pluzhnikov Date: 2022-06-02T18:00:19-04:00 New Revision: 4ad17d2e96a382e5f595bab30920ba26762a6fa9 URL: https://github.com/llvm/llvm-project/commit/4ad17d2e96a382e5f595bab30920ba26762a6fa9 DIFF:

[PATCH] D126602: [Clang][OpenMP] Avoid using `IgnoreImpCasts` if possible

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a96256b7e29: [Clang][OpenMP] Avoid using `IgnoreImpCasts` if possible (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3a96256 - [Clang][OpenMP] Avoid using `IgnoreImpCasts` if possible

Author: Shilei Tian Date: 2022-06-02T17:45:02-04:00 New Revision: 3a96256b7e292de15ad57438202aeea4818956ba URL: https://github.com/llvm/llvm-project/commit/3a96256b7e292de15ad57438202aeea4818956ba DIFF: https://github.com/llvm/llvm-project/commit/3a96256b7e292de15ad57438202aeea4818956ba.diff

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

v.g.vassilev added a comment. Thanks for the prompt reply. We have seen that when there is an inline/weak symbol with no use CodeGen decides not to emit that symbol and moves it into a map. Upon a use it would lazily emit it. However, in cling/clang-repl the use might come on the next line,

[PATCH] D119296: KCFI sanitizer

joaomoreira added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + samitolvanen wrote: > joaomoreira wrote: > > I did not revise the entire patch yet. With this said, IMHO, this looks > > like an

[clang] aa1cdf8 - [PS5] Ignore 'packed' on one-byte bitfields, matching PS4

Author: Paul Robinson Date: 2022-06-02T14:41:18-07:00 New Revision: aa1cdf87b5a97c2476a80f3aa6ac5af3e5ec0494 URL: https://github.com/llvm/llvm-project/commit/aa1cdf87b5a97c2476a80f3aa6ac5af3e5ec0494 DIFF: https://github.com/llvm/llvm-project/commit/aa1cdf87b5a97c2476a80f3aa6ac5af3e5ec0494.diff

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

MatzeB added a comment. In D125847#3554569 , @Jake-Egan wrote: > Hi, this caused `arm-float-abi-lto.c` to fail on AIX. The failure went away > for a few builds, then came back. Could you take a look? > >

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

ivanmurashko accepted this revision. ivanmurashko added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 ___ cfe-commits mailing list

[PATCH] D126396: Clean "./" from __FILE__ expansion.

ppluzhnikov added a comment. Alan, Thanks for the approval. Could you push this patch -- I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126396/new/ https://reviews.llvm.org/D126396

[PATCH] D126689: [IR] Enable opaque pointers by default

aprantl added a comment. I was able to update LLDB https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/44252/. We can leave this in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126689/new/ https://reviews.llvm.org/D126689

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim added a comment. Also, the bitset now doesn't have positive-inclusions for ASan/HWASan, and no mention of MTE yet (which will come later). Sanitizers are applied to all GVs implicitly, so we only need to carry around the exclude masks. Added a comment to the struct that clarifies this.

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 433889. hctim marked an inline comment as done. hctim added a comment. Add round-trip tests, fork out the clang and langref changes for further commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

d-e-s-o added a comment. In D126839#3554570 , @yonghong-song wrote: > In D126839#3554474 , @d-e-s-o wrote: > >> In D126839#3554125 , >> @yonghong-song wrote: >> >>>

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

d-e-s-o added a comment. In D126839#3554474 , @d-e-s-o wrote: > In D126839#3554125 , @yonghong-song > wrote: > >> Also let us merge it unti kernel side change is in reasonable shape. > > From what I understand

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + joaomoreira wrote: > I did not revise the entire patch yet. With this said, IMHO, this looks like > an overcomplication of a

[PATCH] D126396: Clean "./" from __FILE__ expansion.

ppluzhnikov created this revision. Herald added a project: All. ppluzhnikov updated this revision to Diff 432064. ppluzhnikov added a comment. Herald added a subscriber: hiraditya. ppluzhnikov updated this revision to Diff 433837. ppluzhnikov published this revision for review. Herald added a

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

tahonermann added a comment. I wonder if I'm reading (temp.friend)p9` sentence 2 correctly. Which of these should it be parsed as? 1. A (friend function template with a constraint) that depends on a template parameter from an enclosing

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. Ah, true, the standard doesn't describe it as a normal qualifier. From the DR, it sounds like the committee certainly expected that this reasoning would also apply to `_Atomic`, even if that's not quite what they've written, but that the DR submitter seems to not

[PATCH] D119296: KCFI sanitizer

joaomoreira added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + I did not revise the entire patch yet. With this said, IMHO, this looks like an overcomplication of a simple problem. Is there a

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:53 + : CGBuilderBaseTy(C), TypeCache(TypeCache) {} + CGBuilderTy(const CodeGenTypeCache , llvm::LLVMContext , + const llvm::ConstantFolder , There are a lot of unrelated

[PATCH] D102122: Support warn_unused_result on typedefs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dblaikie marked an inline comment as done. Closed by commit rGcb08f4aa4467: Support warn_unused_result on typedefs (authored by dblaikie). Changed prior to commit:

[clang] cb08f4a - Support warn_unused_result on typedefs

Author: David Blaikie Date: 2022-06-02T20:57:31Z New Revision: cb08f4aa4467cf562b62e542725f5351c5482495 URL: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495 DIFF: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495.diff

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

yonghong-song added a comment. In D126839#3554474 , @d-e-s-o wrote: > In D126839#3554125 , @yonghong-song > wrote: > >> Also let us merge it unti kernel side change is in reasonable shape. > > From what I

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

Jake-Egan added a comment. Hi, this caused `arm-float-abi-lto.c` to fail on AIX. The failure went away for a few builds, then came back. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/1625/steps/6/logs/FAIL__Clang__arm-float-abi-lto_c Repository: rG LLVM Github

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Hmm. I'm sorry, seeing the impact of this, I think it's not great to have this `PromotionTy` field; it's too hard to get the invariants right. Let's do this instead: 1. Add an `EmitPromoted` method to `ScalarExprEmitter`. The general rule for this method is that it

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

d-e-s-o added a comment. In D126839#3554125 , @yonghong-song wrote: > Also let us merge it unti kernel side change is in reasonable shape. From what I understand it may take several days or some other not-precisely specified time until "nightly"

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

d-e-s-o added a comment. In D126839#3554125 , @yonghong-song wrote: > LGTM. But add the reference (https://reviews.llvm.org/D126838) to the commit > message to indicate which 'earlier change'. Also let us merge it unti kernel > side change is in

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 433858. gchatelet added a comment. - remove unused variable and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/LanguageExtensions.rst

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG6bea9ff91378: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL (authored by

[clang] 6bea9ff - [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

Author: Xiang Li Date: 2022-06-02T13:06:01-07:00 New Revision: 6bea9ff91378571b3bedcdc12fac7bb916371871 URL: https://github.com/llvm/llvm-project/commit/6bea9ff91378571b3bedcdc12fac7bb916371871 DIFF: https://github.com/llvm/llvm-project/commit/6bea9ff91378571b3bedcdc12fac7bb916371871.diff

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3554310 , @rjmccall wrote: > Ah, yeah, that seems unrelated (and surprising). > > You think we're *not* supposed to drop `_Atomic` in a return type per C2x? > That seems surprising; I thought it was generally

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. Ah, yeah, that seems unrelated (and surprising). You think we're *not* supposed to drop `_Atomic` in a return type per C2x? That seems surprising; I thought it was generally treated as a qualifier and would expect that we'd be supposed to drop it. Repository: rG

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rnk added a comment. Well, I guess we're out of luck, but that seems like a very poorly considered requirement from the standard. If we can't use comdats for inline variables, every time you include a header with a dynamically initialized variable, it will generate extra initialization code in

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3554233 , @rjmccall wrote: > In D125919#3554195 , @aaron.ballman > wrote: > >> However, I reverted the changes in this patch in >>

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + Anastasia wrote: > python3kgae wrote: > > Anastasia

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

rjmccall added a comment. You haven't really described the issue you're having. The code looks like it's maintaining a map from symbol names to the `GlobalDecl` from which it'll be emitted; can you explain what Cling wants this for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

vangthao created this revision. Herald added a project: All. vangthao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In expected diagnostic checks containing newlines, anything after the last newline would be discarded since we stop

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae updated this revision to Diff 433841. python3kgae added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

MaskRay added a comment. (I still think it helps to drop some RUN lines from pic.c but that change can be separate.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126862/new/ https://reviews.llvm.org/D126862

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126862/new/ https://reviews.llvm.org/D126862 ___ cfe-commits mailing list

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. In D125919#3554195 , @aaron.ballman wrote: > However, I reverted the changes in this patch in > c745f2ce6c03bc6d1e59cac69cc15923d4400191 > as I > don't

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + python3kgae wrote: > Anastasia wrote: > > FYI we most of time try to add a builtin name using a reserved

[clang] 30b7ffe - [PS5] Pack non-POD members in packed structs, matching PS4 ABI

Author: Paul Robinson Date: 2022-06-02T12:26:26-07:00 New Revision: 30b7ffe74e66aa0c33c689429c593f261c2c9d13 URL: https://github.com/llvm/llvm-project/commit/30b7ffe74e66aa0c33c689429c593f261c2c9d13 DIFF: https://github.com/llvm/llvm-project/commit/30b7ffe74e66aa0c33c689429c593f261c2c9d13.diff

[clang] bb7835e - [PS5] Apply 'packed' attribute to base classes, matching PS4 ABI

Author: Paul Robinson Date: 2022-06-02T12:26:26-07:00 New Revision: bb7835e2a7fbb12d711736862e75497c83a45be2 URL: https://github.com/llvm/llvm-project/commit/bb7835e2a7fbb12d711736862e75497c83a45be2 DIFF: https://github.com/llvm/llvm-project/commit/bb7835e2a7fbb12d711736862e75497c83a45be2.diff

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. In D125919#3554078 , @delcypher wrote: > @aaron.ballman Hey I just saw this change and had questions about it. For > others looking I think the resolution to DR423 is in >

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2651 +Expr *DefaultArgumentY = NTTPY->getDefaultArgument()->IgnoreImpCasts(); +ODRHash X, Y; +X.AddStmt(DefaultArgumentX); ODR hashing is intended to produce a hash that's

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3554078 , @delcypher wrote: > @aaron.ballman Hey I just saw this change and had questions about it. For > others looking I think the resolution to DR423 is in >

[PATCH] D126862: [clang] [MSVC] Enable unwind tables for ARM

mstorsjo updated this revision to Diff 433836. mstorsjo added a comment. Added testing, including testing for the existing architectures. There was a good match for testing for this in windows-exceptions.cpp - unfortunately it ends up with 2 more RUN lines, but it fits in so well there so I'd

[PATCH] D112916: Confusable identifiers detection

Mordante added a comment. Thanks for the update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. Thanks @mizvekov for such an insightful review. I'll try to address ASAP everything you said and let you know the results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172

[PATCH] D112916: Confusable identifiers detection

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D112916#3554158 , @Mordante wrote: > In D112916#3113140 , @tstellar > wrote: > >> The LLVM Board of

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + Anastasia wrote: > FYI we most of time try to add a builtin name using a reserved identifier > which

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae updated this revision to Diff 433835. python3kgae marked 2 inline comments as done. python3kgae added a comment. Change to verify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 Files:

[PATCH] D112916: Confusable identifiers detection

Mordante added a comment. Herald added a project: All. In D112916#3113140 , @tstellar wrote: > The LLVM Board of Directors will do a legal review of this change. We will > give an update in 4-6 weeks. @tstellar, is there an update from the LLVM Board

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane created this revision. erichkeane added reviewers: ChuanqiXu, clang-language-wg. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a reviewer: dang. Herald added a project: All. erichkeane requested review of this revision. This is a continuation of

[PATCH] D126839: [clang][BPF] Update comment to include TYPE_MATCH

yonghong-song added a comment. LGTM. But add the reference (https://reviews.llvm.org/D126838) to the commit message to indicate which 'earlier change'. Also let us merge it unti kernel side change is in reasonable shape. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3553183 , @LegalizeAdulthood wrote: > In D126495#3552887 , @njames93 > wrote: > >> Can I ask what the motivation is for this change? > >

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + FYI we most of time try to add a builtin name using a reserved identifier which is not part of the

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. Okay, I understand why `-W` isn't being printed now, but the missing ones are still a bit baffling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 ___ cfe-commits mailing

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb updated this revision to Diff 433823. cjdb added a comment. Herald added subscribers: sstefan1, mgrang, aheejin. Herald added a reviewer: jdoerfert. - renames flag to `-print-diagnostic-options` - adds test - adds logic to get as many options to be visible as possible I'm very unhappy with

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

delcypher added a comment. @aaron.ballman Hey I just saw this change and had questions about it. For others looking I think the resolution to DR423 is in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1863.pdf, I found https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2148.htm#dr_423 hard

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae added a comment. In D126857#3554070 , @Anastasia wrote: > ok, so the reason you are adding this to clang is that it needs to be mapped > into a target intrinsic? Yes. The plan is to create a target intrinsic for WaveActiveCountBits which

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

Anastasia added a comment. ok, so the reason you are adding this to clang is that it needs to be mapped into a target intrinsic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added a comment. In D124753#3550670 , @python3kgae wrote: > In D124753#3550337 , @Anastasia > wrote: > >> In D124753#3546608 , @python3kgae >> wrote: >> >>>

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT added a comment. Thanks for reviewing! I will commit it myself later. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 ___ cfe-commits mailing list

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Can there be a test case, not related to Verilog? Or do we need to wait until you pump up the support for that? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126891: [clang-tidy] The check should ignore final classes

carlosgalvezp added a comment. Hmm, `MostDerived` **does** have a public virtual destructor in your example already - if the base class destructor is virtual, the child class destructor is virtual. In that sense the check should not warn. Seems like there's some deeper problem in the check?

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: lld/ELF/Symbols.cpp:553 + // incompatible declarations for the same function. + if (isWeak() && getName().startswith("__kcfi_typeid_") && + cast(this)->value != other.value) MaskRay wrote: > samitolvanen

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet created this revision. gchatelet added reviewers: courbet, efriedma, t.p.northover, jdoerfert. Herald added subscribers: jsji, pengfei, hiraditya. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC)

lgrey added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3368 + fn("C2x", C2x); + OS << "case AttributeCommonInfo::Syntax::AS_Keyword:\n"; + OS << "case AttributeCommonInfo::Syntax::AS_ContextSensitiveKeyword:\n"; Not sure if this

[PATCH] D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC)

lgrey created this revision. lgrey added a reviewer: aaron.ballman. lgrey added a project: clang. Herald added a subscriber: jdoerfert. Herald added a project: All. lgrey requested review of this revision. Herald added a subscriber: cfe-commits. This is setup for allowing `hasAttribute` to work

[PATCH] D126804: [scan-build-py] Change scripts to explicitly require python3

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c1e487c4138: scan-build-py: Change scripts to explicitly require python3 (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126804/new/

[clang] 4c1e487 - scan-build-py: Change scripts to explicitly require python3

Author: Anders Waldenborg Date: 2022-06-02T20:08:21+02:00 New Revision: 4c1e487c413810655757ea19d0cf3d4f5c40898e URL: https://github.com/llvm/llvm-project/commit/4c1e487c413810655757ea19d0cf3d4f5c40898e DIFF:

[PATCH] D126412: Fix a buglet in remove_dots().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35ab2a11bb55: Fix a buglet in remove_dots(). (authored by ppluzhnikov, committed by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   3   >