[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

sammccall added a comment. This sounds correct to me, though I don't feel like an expert here. Upstream in non-experimental IntWidth == Char32Width except on AVR, so it won't actually break anything. Regarding testing, it seems like this should change the diagnostic emitted for `long x = 'abc'`

[PATCH] D127217: [include-cleaner] Fix build error in unit test

ckandeler added a comment. Can you please merge it? I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127217/new/ https://reviews.llvm.org/D127217 ___ cfe-commits mailing list cfe-co

[PATCH] D127217: [include-cleaner] Fix build error in unit test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3520171844a: [include-cleaner] Fix build error in unit test (authored by ckandeler, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1272

[clang-tools-extra] d352017 - [include-cleaner] Fix build error in unit test

Author: Christian Kandeler Date: 2022-06-09T03:38:13-04:00 New Revision: d3520171844a80ff37ede19a14d45a94012d1a15 URL: https://github.com/llvm/llvm-project/commit/d3520171844a80ff37ede19a14d45a94012d1a15 DIFF: https://github.com/llvm/llvm-project/commit/d3520171844a80ff37ede19a14d45a94012d1a15.

[PATCH] D109977: LLVM Driver Multicall tool

nikic added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:890 +configure_file( + ${LLVM_MAIN_SRC_DIR}/cmake/driver-template.cpp.in + ${CMAKE_CURRENT_BINARY_DIR}/${name}-driver.cpp) chapuni wrote: > Do you have a plan to export the te

[PATCH] D109977: LLVM Driver Multicall tool

nikic added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:890 +configure_file( + ${LLVM_MAIN_SRC_DIR}/cmake/driver-template.cpp.in + ${CMAKE_CURRENT_BINARY_DIR}/${name}-driver.cpp) nikic wrote: > chapuni wrote: > > Do you have a plan

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 updated this revision to Diff 435448. jansvoboda11 added a comment. Handle volatile _Atomic as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125349/new/ https://reviews.llvm.org/D125349 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 added a comment. > It doesn't look like the patch handles `volatile _Atomic` correctly, though. That should be fixed in the new revision. > I know we do a lot of candidate prefiltering, and that that can be difficult > because of uesr-defined conversions. How do those things inter

[PATCH] D109977: LLVM Driver Multicall tool

nikic added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:890 +configure_file( + ${LLVM_MAIN_SRC_DIR}/cmake/driver-template.cpp.in + ${CMAKE_CURRENT_BINARY_DIR}/${name}-driver.cpp) nikic wrote: > nikic wrote: > > chapuni wrote: > > >

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

pcwang-thead updated this revision to Diff 435454. pcwang-thead edited the summary of this revision. pcwang-thead added a comment. Add null pointer checking for vlsegff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

nikic added a comment. In D126308#3568696 , @mizvekov wrote: > @nikic ping, can you confirm this current patch works for you? Sorry, missed the update. Just tried this in a local build and it seems to work fine! Repository: rG LLVM Github Monorepo

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

hokein added a comment. Thanks for experimenting this! > the size of the LR table is much smaller (In this patch we go from 340kB => > 120kB, and the encoding isn't efficient) This is interesting. I'd expect we now add more reduce actions into the LRTable, thus the table size should grow (I gu

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

ebevhan added a comment. Hi! This test is failing in some of our downstream builds. Comment at: clang/unittests/Driver/ToolChainTest.cpp:647 +std::unique_ptr C( +TheDriver.BuildCompilation({"--gcc-toolchain="})); +ASSERT_TRUE(C); There's a binar

[clang-tools-extra] 075449d - [pseudo] Fix a sign-compare warning in debug build, NFC.

Author: Haojian Wu Date: 2022-06-09T11:18:03+02:00 New Revision: 075449da80d37bcf3e40ee584753ae0d7ae5afa5 URL: https://github.com/llvm/llvm-project/commit/075449da80d37bcf3e40ee584753ae0d7ae5afa5 DIFF: https://github.com/llvm/llvm-project/commit/075449da80d37bcf3e40ee584753ae0d7ae5afa5.diff LO

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:86 + const ForestNode *Result = nullptr; + StateID AcceptState = Params.Table.getGoToState(StartState, StartSymbol); + glrReduce(PendingReduce, Params, [&](const GSS::Node *NewHead) { --

[clang-tools-extra] 7a05942 - [pseudo] Remove the explicit Accept actions.

Author: Haojian Wu Date: 2022-06-09T11:19:07+02:00 New Revision: 7a05942dd0c548cf4a0cf52d8d3f97b0a11a6509 URL: https://github.com/llvm/llvm-project/commit/7a05942dd0c548cf4a0cf52d8d3f97b0a11a6509 DIFF: https://github.com/llvm/llvm-project/commit/7a05942dd0c548cf4a0cf52d8d3f97b0a11a6509.diff LO

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a05942dd0c5: [pseudo] Remove the explicit Accept actions. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D125677?vs=4353

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 435460. junaire added a comment. OK, then we'd better to roll the condition back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenMo

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu updated this revision to Diff 435461. ChuanqiXu added a comment. Handle function local thread locals. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang

[clang] 40a5d79 - [clang-format][NFC] Format lib/Format and unittests/Format in clang

Author: owenca Date: 2022-06-09T02:25:06-07:00 New Revision: 40a5d79a5cb4edc7343349f17e59377eb9362c4a URL: https://github.com/llvm/llvm-project/commit/40a5d79a5cb4edc7343349f17e59377eb9362c4a DIFF: https://github.com/llvm/llvm-project/commit/40a5d79a5cb4edc7343349f17e59377eb9362c4a.diff LOG: [

[PATCH] D127366: [clang-format][NFC] Format lib/Format and unittests/Format in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40a5d79a5cb4: [clang-format][NFC] Format lib/Format and unittests/Format in clang (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D127283: [pseudo] Simplify the glrReduce implementation.

hokein updated this revision to Diff 435463. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127283/new/ https://reviews.llvm.org/D127283 Files: clang-tools-extra/ps

[clang-tools-extra] 74e4d5f - [pseudo] Simplify the glrReduce implementation.

Author: Haojian Wu Date: 2022-06-09T11:28:52+02:00 New Revision: 74e4d5f256fab1a9a72ef60c1d672441696c52e9 URL: https://github.com/llvm/llvm-project/commit/74e4d5f256fab1a9a72ef60c1d672441696c52e9 DIFF: https://github.com/llvm/llvm-project/commit/74e4d5f256fab1a9a72ef60c1d672441696c52e9.diff LO

[PATCH] D127283: [pseudo] Simplify the glrReduce implementation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74e4d5f256fa: [pseudo] Simplify the glrReduce implementation. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

pcwang-thead updated this revision to Diff 435466. pcwang-thead added a comment. Update test `rvv-intrinsics-overloaded/vlsegff.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 Files: clang/include/c

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. Should this be conditional on the command line flag `-flang-experimental-exec` for the time being (like for the GNU toolchain)? See D122008 Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:133 + if (C.getDriver().

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 435474. carlosgalvezp marked 2 inline comments as done. carlosgalvezp added a comment. Address review comments. Rebase on latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://rev

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidConstOrRefDataMembersCheck.h:29 + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + Eugene.Zelenko wrote: > Please add `isLanguag

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu updated this revision to Diff 435475. ChuanqiXu added a comment. Address inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGe

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 435476. carlosgalvezp added a comment. Remove copy-paste comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 Files: clang-tools-extra/clang-tidy/cppcoreg

[PATCH] D127366: [clang-format][NFC] Format lib/Format and unittests/Format in clang

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25442 "} while (hasMore() && Filter(*I));", - "do { ++I; } while (hasMore() && Filter(*I));", - Style); + "do { ++I; } while (hasMore() && Fi

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h:219 + // ExtensionID is the index of the table. + std::vector AttributeValues; }; sammccall wrote: > looking at this agai

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu marked 4 inline comments as done. ChuanqiXu added a comment. It looks like there are two problems now: (1) The use of TLS variable in the dynamic initializer and the use of generated TLS variable (`__tls_guard`) doesn't get wrapped in @llvm.threadlocal_address() intrinsics. From my pe

[clang-tools-extra] f1ac00c - [pseudo] Add grammar annotations support.

Author: Haojian Wu Date: 2022-06-09T12:06:22+02:00 New Revision: f1ac00c9b0d17e48f464709fc554ebf73f165158 URL: https://github.com/llvm/llvm-project/commit/f1ac00c9b0d17e48f464709fc554ebf73f165158 DIFF: https://github.com/llvm/llvm-project/commit/f1ac00c9b0d17e48f464709fc554ebf73f165158.diff LO

[PATCH] D126536: [pseudo] Add grammar annotations support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1ac00c9b0d1: [pseudo] Add grammar annotations support. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D126536?vs=434906&

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

martong added inline comments. Comment at: clang/test/Analysis/errno-stdlibraryfunctions-notes.c:11 + +int access(const char *path, int amode); + Do you plan to extend the test file for other standard functions as well? Comment at: clang/test/A

[PATCH] D127388: [pseudo] Move grammar-related headers to a separate dir, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. We did that for .cpp, but forgot the headers. Repository: rG LLVM Github

[clang-tools-extra] afbe3ae - [clangd] Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

Author: Paul Pluzhnikov Date: 2022-06-09T12:18:39+02:00 New Revision: afbe3aed4986300ee2cdbb5c0303bee172c2731b URL: https://github.com/llvm/llvm-project/commit/afbe3aed4986300ee2cdbb5c0303bee172c2731b DIFF: https://github.com/llvm/llvm-project/commit/afbe3aed4986300ee2cdbb5c0303bee172c2731b.dif

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rGafbe3aed4986: [clangd] Minor refactor of CanonicalIncludes::addSystemHeadersMapping. (authored by ppluzhnikov, committed by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ilya-biryukov added a comment. In D125742#3563855 , @ppluzhnikov wrote: > Could you commit this? Sure! Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 __

[PATCH] D127388: [pseudo] Move grammar-related headers to a separate dir, NFC.

hokein updated this revision to Diff 435483. hokein added a comment. update missing files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127388/new/ https://reviews.llvm.org/D127388 Files: clang-tools-extra/pseudo/fuzzer/Fuzzer.cpp clang-tools

[PATCH] D127389: [analyzer] Print the offending function at EndAnalysis crash

steakhal created this revision. steakhal added reviewers: NoQ, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steak

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

martong added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2553-2555 +The supported functions are the same that are modeled by checker +:doc:`alpha.unix.StdCLibraryFunctionArgs` (and affect value of ``errno``), +including effect of the ``ModelPOSIX`` option of th

[clang] 5160851 - cmake: use llvm dir variables for clang/utils/hmaptool

Author: Matheus Izvekov Date: 2022-06-09T12:25:38+02:00 New Revision: 51608515faa74c87ae09877be24eeb6a8226ff7e URL: https://github.com/llvm/llvm-project/commit/51608515faa74c87ae09877be24eeb6a8226ff7e DIFF: https://github.com/llvm/llvm-project/commit/51608515faa74c87ae09877be24eeb6a8226ff7e.dif

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

This revision was automatically updated to reflect the committed changes. Closed by commit rG51608515faa7: cmake: use llvm dir variables for clang/utils/hmaptool (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. In D126308#3569379 , @nikic wrote: > Sorry, missed the update. Just tried this in a local build and it seems to > work fine! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D127065: [docs] Update supported language standards list for C++

josemonsalve2 added a comment. Changes are fine. I am not familiar with the progress in C++20 and 23, but I trust your judgement here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127065/new/ https://reviews.llvm.org/D127065

[PATCH] D127389: [analyzer] Print the offending function at EndAnalysis crash

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:616 void ExprEngine::processEndWorklist() { + PrettyStackTraceLocationContext CrashInfo(getRootLocationContext()); getCheckerManager().runCheckersForEndAnalysis(G, BR, *this); ---

[PATCH] D127390: [clang-format][NFC] Remove unused FormatStyle members

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

andrew created this revision. andrew added reviewers: kda, vitalybuka, eugenis, MaskRay. Herald added subscribers: StephenFan, krytarowski, arichardson, emaste. Herald added a project: All. andrew requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D127390: [clang-format][NFC] Remove unused FormatStyle members

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Good finding! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127390/new/ https://reviews.llvm.org/D127390 __

[clang] 65b34b7 - [clang][pr55896]:co_yield/co_await thread-safety

Author: Nathan Sidwell Date: 2022-06-09T04:42:10-07:00 New Revision: 65b34b78f8dafbfd97836af3165e73c5b316c6b5 URL: https://github.com/llvm/llvm-project/commit/65b34b78f8dafbfd97836af3165e73c5b316c6b5 DIFF: https://github.com/llvm/llvm-project/commit/65b34b78f8dafbfd97836af3165e73c5b316c6b5.diff

[PATCH] D127236: [clang][pr55896]:co_yield/co_await thread-safety

This revision was automatically updated to reflect the committed changes. urnathan marked an inline comment as done. Closed by commit rG65b34b78f8da: [clang][pr55896]:co_yield/co_await thread-safety (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Cha

[PATCH] D126536: [pseudo] Add grammar annotations support.

uabelho added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/GrammarBNF.cpp:235 Out.Sequence.push_back({Chunk}); } I get a warning/error on this line with this commit: ``` 13:31:17 ../../clang-tools-extra/pseudo/lib/grammar/Gramma

[PATCH] D127396: [clang][ASTImporter] Fix import of function with auto return type.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D127397: [pseudo] Fix unit test build

ckandeler created this revision. ckandeler added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Analogous to 632545e8ce8

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3569029 , @njames93 wrote: > In D126495#3568998 , > @LegalizeAdulthood wrote: > >> Gentle ping > > My previous point about the links in the header files not being upd

[PATCH] D118711: [hack] Build a tree of preprocessing directives

LegalizeAdulthood added a comment. Herald added a project: All. I'm discarding this review, as it was just for comment purposes, until I have a proper implementation to discuss. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118711/new/ https://reviews.llvm.org/D118711

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 435508. fhahn added a comment. Add TySan library when building on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In the call yesterday it was proposed that we add a CMake option that will control the name of the driver. I suggest adding `FLANG_USE_LEGACY_NAME`: - when set to `ON`, the driver binary will be called `flang-new`, - when set to `OFF`, the driver binary will be called

[PATCH] D127388: [pseudo] Move grammar-related headers to a separate dir, NFC.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h:52 #ifndef CLANG_PSEUDO_GRAMMAR_H #define CLANG_PSEUDO_GRAMMAR_H he

[clang-tools-extra] 9ce232f - [pseudo] Fix the missing-field-initializers warning from f1ac00c9b0d1, NFC

Author: Haojian Wu Date: 2022-06-09T14:10:36+02:00 New Revision: 9ce232fba99c47c3246f06fcbe37c24b9d90585f URL: https://github.com/llvm/llvm-project/commit/9ce232fba99c47c3246f06fcbe37c24b9d90585f DIFF: https://github.com/llvm/llvm-project/commit/9ce232fba99c47c3246f06fcbe37c24b9d90585f.diff LO

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/GrammarBNF.cpp:235 Out.Sequence.push_back({Chunk}); } uabelho wrote: > I get a warning/error on this line with this commit: > ``` > 13:31:17 ../../clang-tools-extra/pseud

[PATCH] D127400: [pseudo] Add xfail tests for a simple-declaration/function-definition ambiguity

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. I expect to eliminate this ambiguity at the grammar level b

[clang-tools-extra] 18f0b70 - [pseudo] Don't clang-format test inputs. NFC

Author: Sam McCall Date: 2022-06-09T14:18:30+02:00 New Revision: 18f0b7092db5b8554415e872d02c4628a5ae7296 URL: https://github.com/llvm/llvm-project/commit/18f0b7092db5b8554415e872d02c4628a5ae7296 DIFF: https://github.com/llvm/llvm-project/commit/18f0b7092db5b8554415e872d02c4628a5ae7296.diff LO

[PATCH] D127397: [pseudo] Fix unit test build

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127397/new/ https://reviews.llvm.org/D127397

[PATCH] D127397: [pseudo] Fix unit test build

ckandeler added a comment. Can you please merge it? I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127397/new/ https://reviews.llvm.org/D127397 ___ cfe-commits mailing list cfe-co

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3560523 , @aaron.ballman wrote: > All that said, I think you can see why I'm hoping to get an answer from WG14 > as to what to do. Reasonable folks are disagreeing on what the standard > requires here. The dis

[PATCH] D126536: [pseudo] Add grammar annotations support.

uabelho added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/GrammarBNF.cpp:235 Out.Sequence.push_back({Chunk}); } hokein wrote: > uabelho wrote: > > I get a warning/error on this line with this commit: > > ``` > > 13:31:17 ../../

[clang-tools-extra] bf83062 - [pseudo] Fix unit test build

Author: Christian Kandeler Date: 2022-06-09T14:42:47+02:00 New Revision: bf830623b063af1c620f369b6bf1808c30d5f0fb URL: https://github.com/llvm/llvm-project/commit/bf830623b063af1c620f369b6bf1808c30d5f0fb DIFF: https://github.com/llvm/llvm-project/commit/bf830623b063af1c620f369b6bf1808c30d5f0fb.

[PATCH] D127397: [pseudo] Fix unit test build

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf830623b063: [pseudo] Fix unit test build (authored by ckandeler, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127397/new/ https://r

[PATCH] D127397: [pseudo] Fix unit test build

hokein added a comment. In D127397#3569925 , @ckandeler wrote: > Can you please merge it? I don't have the rights. sure, committed in bf830623b063af1c620f369b6bf1808c30d5f0fb . Repos

[PATCH] D127396: [clang][ASTImporter] Fix import of function with auto return type.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Thanks, nice work! > This is a fix for issue #55500 . I think github will NOT automatically close the issue, unless you have a more specific format in t

[PATCH] D127400: [pseudo] Add xfail tests for a simple-declaration/function-definition ambiguity

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/cxx/declarator-function.cpp:12 +// CHECK: function-definition := decl-specifier-seq declarator +// function-body CHECK-

[clang] 8e1a29e - Use HTTPS links instead of HTTP ones in the C DR status page

Author: Aaron Ballman Date: 2022-06-09T08:52:30-04:00 New Revision: 8e1a29ecab4e35de72232fc9fd9706ed1cc64f9b URL: https://github.com/llvm/llvm-project/commit/8e1a29ecab4e35de72232fc9fd9706ed1cc64f9b DIFF: https://github.com/llvm/llvm-project/commit/8e1a29ecab4e35de72232fc9fd9706ed1cc64f9b.diff

[PATCH] D127388: [pseudo] Move grammar-related headers to a separate dir, NFC.

hokein updated this revision to Diff 435516. hokein added a comment. update header guards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127388/new/ https://reviews.llvm.org/D127388 Files: clang-tools-extra/pseudo/fuzzer/Fuzzer.cpp clang-tools

[PATCH] D127388: [pseudo] Move grammar-related headers to a separate dir, NFC.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h:52 #ifndef CLANG_PSEUDO_GRAMMAR_H #define CLANG_PSEUDO_GRAMMAR_H sammccall wrote: > header guards should really be updated :-( oops, forgot these. Update

[clang-tools-extra] c70aeaa - [pseudo] Move grammar-related headers to a separate dir, NFC.

Author: Haojian Wu Date: 2022-06-09T14:58:05+02:00 New Revision: c70aeaad2b23b0b30baf6e4580a1995547f9ba41 URL: https://github.com/llvm/llvm-project/commit/c70aeaad2b23b0b30baf6e4580a1995547f9ba41 DIFF: https://github.com/llvm/llvm-project/commit/c70aeaad2b23b0b30baf6e4580a1995547f9ba41.diff LO

[PATCH] D127388: [pseudo] Move grammar-related headers to a separate dir, NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc70aeaad2b23: [pseudo] Move grammar-related headers to a separate dir, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 435520. serge-sans-paille added a comment. Herald added a subscriber: martong. Take into account @efriedma and @kees review, plus adding a bunch of extra test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.

[clang] 8feb92a - [clang][tests] Add missing compiler name

Author: Timm Bäder Date: 2022-06-09T15:11:40+02:00 New Revision: 8feb92add88adbb53729dd10f12667bb326e021e URL: https://github.com/llvm/llvm-project/commit/8feb92add88adbb53729dd10f12667bb326e021e DIFF: https://github.com/llvm/llvm-project/commit/8feb92add88adbb53729dd10f12667bb326e021e.diff LO

[clang] cedfb54 - [docs] Update supported language standards list for C++

Author: Yuki Okushi Date: 2022-06-09T22:14:08+09:00 New Revision: cedfb5462cd86b9790a887e4e566a85cfe4f2313 URL: https://github.com/llvm/llvm-project/commit/cedfb5462cd86b9790a887e4e566a85cfe4f2313 DIFF: https://github.com/llvm/llvm-project/commit/cedfb5462cd86b9790a887e4e566a85cfe4f2313.diff L

[PATCH] D127065: [docs] Update supported language standards list for C++

This revision was automatically updated to reflect the committed changes. Closed by commit rGcedfb5462cd8: [docs] Update supported language standards list for C++ (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127065/new/ htt

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:647 +std::unique_ptr C( +TheDriver.BuildCompilation({"--gcc-toolchain="})); +ASSERT_TRUE(C); ebevhan wrote: > There's a b

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 435524. mboehme added a comment. Rebased to a newer base revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/test/Analysis/errno-stdlibraryfunctions-notes.c:11 + +int access(const char *path, int amode); + martong wrote: > Do you plan to extend the test file for other standard f

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 435528. ymandel added a comment. rebase and merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAc

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3568943 , @ChuanqiXu wrote: > In D126907#3566633 , @erichkeane > wrote: > >> All of the comments from @ChuanqiXu done, thank you so much! >> >> As far as the crash you're se

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:228 + switch (getParsedKind()) { + case AT_AddressSpace: + case AT_OpenCLPrivateAddressSpace: rsmith wrote: > I don't think this one really slide

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

martong added a comment. In D127306#3566984 , @steakhal wrote: > In D127306#3566761 , @martong wrote: > >>> In theory, the engine should propagate taint in default eval call. If that >>> would be the case, we wou

[PATCH] D127389: [analyzer] Print the offending function at EndAnalysis crash

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127389/new/ https://reviews.llvm.org/D127389

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added a comment. In D127285#3566032 , @steakhal wrote: > LGTM > Schedule a measurement to see what changes. Let's hope it won't introduce > more crashes. > If everything checks out, it gets approved. Results are good. No new assertion failures,

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:8982 // Extension: Add the binary operators =, +=, -=, *=, /= for vector types. for (QualType Vec1Ty : CandidateTypes[0].vector_types()) Do we need to handle atomic vecto

[clang] bc2c759 - [analyzer] Fix assertion failure after getKnownValue call

Author: Gabor Marton Date: 2022-06-09T16:13:57+02:00 New Revision: bc2c759aeee7d1560840a24365ce18b8e8b63ded URL: https://github.com/llvm/llvm-project/commit/bc2c759aeee7d1560840a24365ce18b8e8b63ded DIFF: https://github.com/llvm/llvm-project/commit/bc2c759aeee7d1560840a24365ce18b8e8b63ded.diff

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc2c759aeee7: [analyzer] Fix assertion failure after getKnownValue call (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 435537. ymandel added a comment. add missing blank line to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files: clang/lib/Analysis/FlowSensitive/Models/Unche

[clang] dd38caf - [clang][dataflow] Track `optional` contents in `optional` model.

Author: Yitzhak Mandelbaum Date: 2022-06-09T14:17:39Z New Revision: dd38caf3b5b724c1f84998c1ae105f709c3ed405 URL: https://github.com/llvm/llvm-project/commit/dd38caf3b5b724c1f84998c1ae105f709c3ed405 DIFF: https://github.com/llvm/llvm-project/commit/dd38caf3b5b724c1f84998c1ae105f709c3ed405.diff

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd38caf3b5b7: [clang][dataflow] Track `optional` contents in `optional` model. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. In D125919#3569928 , @aaron.ballman wrote: > In D125919#3560523 , @aaron.ballman > wrote: > >> All that said, I think you can see why I'm hoping to get an answer from WG14 >> as to wha

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 _

  1   2   3   >