[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rGda6a14b91ad9: [clang] Enforce instantiation of constexpr template functions during non… (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] da6a14b - [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

Author: serge-sans-paille Date: 2022-07-10T08:40:03+02:00 New Revision: da6a14b91ad999327b41a9040577273591e4ad1d URL: https://github.com/llvm/llvm-project/commit/da6a14b91ad999327b41a9040577273591e4ad1d DIFF: https://github.com/llvm/llvm-project/commit/da6a14b91ad999327b41a9040577273591e4ad1d.d

[PATCH] D129061: [Lex] Diagnose macro in command lines

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:664 HelpText<"Define to (or 1 if omitted)">; +def DriverDefine : JoinedOrSeparate<["-"], "driver-define">, Group, +Flags<[CC1Option, FlangOption, FC1Option]>, MetaVarName<"=">, -

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, MaskRay. Herald added subscribers: kosarev, StephenFan, tpr. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a proje

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22a01b860b90: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 22a01b8 - [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

Author: Joseph Huber Date: 2022-07-09T21:18:19-04:00 New Revision: 22a01b860b909d7836658e0c58e484950766239b URL: https://github.com/llvm/llvm-project/commit/22a01b860b909d7836658e0c58e484950766239b DIFF: https://github.com/llvm/llvm-project/commit/22a01b860b909d7836658e0c58e484950766239b.diff

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

jhuber6 updated this revision to Diff 443464. jhuber6 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129424/new/ https://reviews.llvm.org/D129424 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Drive

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > This patch adds the ability to use -mllvm options in the linker wrapper when > performing bitcode linking or the module compilation. This is done by passing > in the LLVM argument to the c

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo updated this revision to Diff 443461. mstorsjo added a comment. Reduce the scope and impact of the change: When telling Clang to include a specifically named PCH file, keep tolerating the same set of mismatches as before. (Clang has been tolerating such differences for over 10 years, an

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/CodeGenCXX/constexpr-late-instantiation.cp

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

avogelsgesang added inline comments. Comment at: clang/www/cxx_status.html:1183 https://wg21.link/p1874r1";>P1874R1 -Partial +Clang 15 should this be `class="unreleased"` instead of `class="full"`? At least this is what other pla

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8e6056e2417: [CMake][Fuchsia] Use libunwind as the default unwinder (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D127887?vs=441734&id=443449#toc Repository: rG LLVM Github

[clang] a8e6056 - [CMake][Fuchsia] Use libunwind as the default unwinder

Author: Petr Hosek Date: 2022-07-09T18:15:04Z New Revision: a8e6056e24173167fa8d3a588982f36ba83312bd URL: https://github.com/llvm/llvm-project/commit/a8e6056e24173167fa8d3a588982f36ba83312bd DIFF: https://github.com/llvm/llvm-project/commit/a8e6056e24173167fa8d3a588982f36ba83312bd.diff LOG: [C

[PATCH] D129061: [Lex] Diagnose macro in command lines

jackhong12 updated this revision to Diff 443447. jackhong12 added a comment. Herald added subscribers: mstorsjo, MaskRay. Herald added a reviewer: sscalpone. Herald added a project: clang-tools-extra. I added two flags, `-driver-define` and `-driver-undefine`, to indicate macros that the driver d

[clang] d3dd6e5 - [Fuchsia] Remove the test cflags to explicitly set the unwinder

Author: Petr Hosek Date: 2022-07-09T17:08:35Z New Revision: d3dd6e57fe84e90cadcdc78fa71d632f6573f156 URL: https://github.com/llvm/llvm-project/commit/d3dd6e57fe84e90cadcdc78fa71d632f6573f156 DIFF: https://github.com/llvm/llvm-project/commit/d3dd6e57fe84e90cadcdc78fa71d632f6573f156.diff LOG: [F

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo, JonChesterfield, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This p

[PATCH] D129423: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd3ade17bc1: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129423/n

[clang] dbd3ade - [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline

Author: Joseph Huber Date: 2022-07-09T11:29:04-04:00 New Revision: dbd3ade17bc1ed889f306ce13955b2048b5df969 URL: https://github.com/llvm/llvm-project/commit/dbd3ade17bc1ed889f306ce13955b2048b5df969 DIFF: https://github.com/llvm/llvm-project/commit/dbd3ade17bc1ed889f306ce13955b2048b5df969.diff

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

hubert.reinterpretcast added a comment. In D128059#3640564 , @cor3ntin wrote: > Good point. The error was a bit misleading but i guess what's happening is a > segfault when running `clang-ast-dump`. > I'm reverting for now and I don't really know how to

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. In D128059#3640544 , @hubert.reinterpretcast wrote: > In D128059#3640424 , @cor3ntin > wrote: > >> @aaron.ballman Thanks for the review. I landed the changes and got a bunch >> of bots

[clang] 50416e5 - Revert "[Clang] Add a warning on invalid UTF-8 in comments."

Author: Corentin Jabot Date: 2022-07-09T17:18:35+02:00 New Revision: 50416e5454d802a3ef71bb799e5bfd38e8ec9089 URL: https://github.com/llvm/llvm-project/commit/50416e5454d802a3ef71bb799e5bfd38e8ec9089 DIFF: https://github.com/llvm/llvm-project/commit/50416e5454d802a3ef71bb799e5bfd38e8ec9089.diff

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef0fa9f0ef3e: [C++20][Modules] Update handling of implicit inlines [P1779R3] (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] ef0fa9f - [C++20][Modules] Update handling of implicit inlines [P1779R3]

Author: Iain Sandoe Date: 2022-07-09T16:06:32+01:00 New Revision: ef0fa9f0ef3e530a9d600c0f6a21e68b098df7ed URL: https://github.com/llvm/llvm-project/commit/ef0fa9f0ef3e530a9d600c0f6a21e68b098df7ed DIFF: https://github.com/llvm/llvm-project/commit/ef0fa9f0ef3e530a9d600c0f6a21e68b098df7ed.diff L

[PATCH] D129423: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LTO pipeline handles i

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

hubert.reinterpretcast added a comment. In D128059#3640424 , @cor3ntin wrote: > @aaron.ballman Thanks for the review. I landed the changes and got a bunch of > bots screaming at me for changes that are completely unrelated > > https://lab.llvm.org/buildb

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:250-253 +- Made the fix-it of :doc:`cppcoreguidelines-init-variables + ` use ``false`` to initialize + boolean variables. + nja

[clang-tools-extra] 9631922 - [clang-tidy] Sort release notes entries alphabetically by check name

Author: Danny Mösch Date: 2022-07-09T15:45:19+02:00 New Revision: 963192228b05e3bce86cf520e2bda5f069be9894 URL: https://github.com/llvm/llvm-project/commit/963192228b05e3bce86cf520e2bda5f069be9894 DIFF: https://github.com/llvm/llvm-project/commit/963192228b05e3bce86cf520e2bda5f069be9894.diff L

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:188 by checking for an arbitrary expression in the second argument of ``memset``. - Improved :doc:`cppcoreguidelines-prefer-member-initializer It should live here instead.

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny added a comment. In D129420#3640482 , @njames93 wrote: > Can you add a line to release notes about this fix then LGTM Sure. Thank you for the fast review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e212954430: [clang-tidy] Initialize boolean variables with `false` in cppcoreguidelines… (authored by SimplyDanny). Changed prior to commit: https://reviews.llvm.org/D129420?vs=443429&id=443434#toc R

[clang-tools-extra] 33e2129 - [clang-tidy] Initialize boolean variables with `false` in cppcoreguidelines-init-variables' fix-it

Author: Danny Mösch Date: 2022-07-09T14:48:50+02:00 New Revision: 33e212954430d6116d7743541a7e9be8cdfac196 URL: https://github.com/llvm/llvm-project/commit/33e212954430d6116d7743541a7e9be8cdfac196 DIFF: https://github.com/llvm/llvm-project/commit/33e212954430d6116d7743541a7e9be8cdfac196.diff L

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

njames93 added a comment. Can you add a line to release notes about this fix then LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129420/new/ https://reviews.llvm.org/D129420 ___ cfe-commits mailing l

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

junaire added a comment. gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128782/new/ https://reviews.llvm.org/D128782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny added a comment. This is a potential fix for this issue . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129420/new/ https://reviews.llvm.org/D129420 __

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny created this revision. SimplyDanny added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subsc

[clang] 4328b96 - [C++20][Modules] Fix two tests for CTORs that return pointers [NFC].

Author: Iain Sandoe Date: 2022-07-09T11:23:20+01:00 New Revision: 4328b960176f4394416093e640ad4265bde65ad7 URL: https://github.com/llvm/llvm-project/commit/4328b960176f4394416093e640ad4265bde65ad7 DIFF: https://github.com/llvm/llvm-project/commit/4328b960176f4394416093e640ad4265bde65ad7.diff L

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin added a comment. @aaron.ballman Thanks for the review. I landed the changes and got a bunch of bots screaming at me for changes that are completely unrelated https://lab.llvm.org/buildbot/#/builders/21/builds/45146 https://lab.llvm.org/buildbot/#/builders/36/builds/22838 https://lab.llv

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG355532a1499a: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D12805

[clang] 355532a - [Clang] Add a warning on invalid UTF-8 in comments.

Author: Corentin Jabot Date: 2022-07-09T11:26:45+02:00 New Revision: 355532a1499aa9b13a89fb5b5caaba2344d57cd7 URL: https://github.com/llvm/llvm-project/commit/355532a1499aa9b13a89fb5b5caaba2344d57cd7 DIFF: https://github.com/llvm/llvm-project/commit/355532a1499aa9b13a89fb5b5caaba2344d57cd7.diff

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac507102d258: [C++20][Modules] Build module static initializers per P1874R1. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] ac50710 - [C++20][Modules] Build module static initializers per P1874R1.

Author: Iain Sandoe Date: 2022-07-09T09:09:09+01:00 New Revision: ac507102d258b6fc0cb57eb60c9dfabd57ff562f URL: https://github.com/llvm/llvm-project/commit/ac507102d258b6fc0cb57eb60c9dfabd57ff562f DIFF: https://github.com/llvm/llvm-project/commit/ac507102d258b6fc0cb57eb60c9dfabd57ff562f.diff L

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54f57d3847c0: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name… (authored by njames93). Repository: rG LLVM Github Mo

[clang] 54f57d3 - [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

Author: Nathan James Date: 2022-07-09T08:28:07+01:00 New Revision: 54f57d3847c00d0233e287ebb5283d04e6083062 URL: https://github.com/llvm/llvm-project/commit/54f57d3847c00d0233e287ebb5283d04e6083062 DIFF: https://github.com/llvm/llvm-project/commit/54f57d3847c00d0233e287ebb5283d04e6083062.diff

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/ https://reviews.llvm.org/D129398 ___