[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff created this revision. sepavloff added reviewers: kpn, rjmccall, aaron.ballman. Herald added subscribers: jsji, pengfei. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Previously compilation of a few tests produced incorrect code.

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra added a comment. @abidmalikwaterloo ninja check-mlir is failing with your most upto date patch. Can you please double check? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, hubert.reinterpretcast, PowerPC. Herald added subscribers: jsji, steven.zhang, kbarton, krytarowski, arichardson, emaste. Herald added a project: All. qiucf requested review of this revision. Herald added subscribers: cfe-commi

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Haven't you forgotten to add formatting tests? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.o

[PATCH] D128604: [RISCV] Support Zbpbo extension v0.9.11

sunshaoce updated this revision to Diff 443555. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/lib/Sema/Sema

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.9.11

sunshaoce updated this revision to Diff 443552. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108189 Files: clang/test/Driver/riscv-arch.c clang/test/Preprocessor/riscv-ta

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 + + // Reformat Macro Expansion + if (!HI->MacroExpansion.empty()) { nridge wrote: > daiyousei-qz wrote: > > nridge wrote: > > > It would be interesting to have a couple of test c

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu added inline comments. Comment at: clang/www/cxx_status.html:1183 https://wg21.link/p1874r1";>P1874R1 -Partial +Clang 15 avogelsgesang wrote: > should this be `class="unreleased"` instead of `class="full"`? At least this

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu updated this revision to Diff 443549. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 Files: clang/docs/ReleaseNotes.rst clang/www/cxx_statu

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:935 SmallVector Labels; +SmallVector LifetimeStartMarkers; LexicalScope *ParentScope; LifetimeStartMarkers -> BypassedLifetimeStartMarkers and below if I read this co

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu added a comment. In D129068#3640249 , @vsapsai wrote: > Thanks for the changes, they look good! While I was looking how we handle > "requires" constraints in other cases, I've noticed that they are > suspiciously similar. That's why I offer th

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu updated this revision to Diff 443548. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/test/Modules/conc

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added a comment. looks like check-asan tests fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:3859 +// C++20 [basic.lookup.argdep] p4.3 .. are exported +Module *FM = D->getOwningModule(); +// .. are attached to a named module M, do not appear in the -

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM basically. Comment at: clang/lib/Serialization/ASTReader.cpp:10621-10626 // Compute the hash of the method as if it has no body. -auto ComputeCXXM

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 443536. SchrodingerZhu added a comment. This commit addresses issues mentioned in code reviews: - change applyAlongResolverPath to use reference since the pointer is supposed to be non-null. - update test format to align check rules under the same pre

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

shchenz added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:170 + ppc_wrappers/immintrin.h + ppc_wrappers/tmmintrin.h + ppc_wrappers/x86intrin.h chapuni wrote: > It doesn't contain , forgot? @qiucf Looks like an error here? Repository: rG L

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

NoQ accepted this revision. NoQ added a comment. Thanks! Good to go after the matchers patch is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128314 ___ c

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

NoQ added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3841 +/// matches if ObjCMessageExpr's callee declaration matches +/// Nitpick carryover: needs capital letter and `.` Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D129456: [lldb] Add image dump pcm command

kastiglione updated this revision to Diff 443532. kastiglione added a comment. remove commented-out code in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include/clang/Frontend/Front

[PATCH] D129456: [lldb] Add image dump pcm command

kastiglione updated this revision to Diff 443531. kastiglione added a comment. add @skipUnlessDarwin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include/clang/Frontend/FrontendActions.h

[PATCH] D129456: [lldb] Add image dump pcm command

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, augusto2112. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. kastiglione requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-co

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

phosek abandoned this revision. phosek added a comment. This was broken up into a series of smaller changes which landed separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122931/new/ https://reviews.llvm.org/D122931 ___

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang will attempt to create an alias summary; however, as ifunc is not included in the mod

[PATCH] D129061: [Lex] Diagnose macro in command lines

jackhong12 added inline comments. Comment at: clang/include/clang/Driver/Options.td:664 HelpText<"Define to (or 1 if omitted)">; +def DriverDefine : JoinedOrSeparate<["-"], "driver-define">, Group, +Flags<[CC1Option, FlangOption, FC1Option]>, MetaVarName<"=">, --

[PATCH] D129061: [Lex] Diagnose macro in command lines

jackhong12 updated this revision to Diff 443516. jackhong12 added a comment. - modify option names - only allow driver-defined macros used in cc1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129061/new/ https://reviews.llvm.org/D129061 Files: clang-tools-extra/test/pp-trace/pp-trace

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan created this revision. StephenFan added reviewers: MaskRay, vitalybuka, rsmith. Herald added a project: All. StephenFan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/56356 For fol

[PATCH] D129446: [clang][driver] Find Apple default SDK path

thieta created this revision. thieta added reviewers: egorzhdan, t.p.northover, dexonsmith, ldionne. Herald added a project: All. thieta requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Currently if you download clang and install it on macOS it

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. @LegalizeAdulthood I've addressed your comments, is there anything that should be fixed before landing the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 __

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

tom-anders added a comment. @sammccall I think you can merge this for me now (and also https://reviews.llvm.org/D128202) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128826/new/ https://reviews.llvm.org/D128826 __

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 443503. SchrodingerZhu marked 5 inline comments as done. SchrodingerZhu added a comment. This commit addresses problems mentioned in code reviews: - Fix format and wording for comments - Add more checks with llvm-dis - Adjust code styles for function r

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

eoanermine created this revision. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Add an option whether requires clause body should be aligned with `requires` keyword Fixes https:

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added a comment. @njames93 @LegalizeAdulthood I did integrate the requested changes regarding warning for bad configs, refactoring of map-access and the directory structure of test-files and documentation. given the high interest in the patch and the need to iron out potential false-

[PATCH] D128981: [C++20][Modules] Implement include translation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf2d11b1d5c1: [C++20][Modules] Implement include translation. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews

[clang] af2d11b - [C++20][Modules] Implement include translation.

Author: Iain Sandoe Date: 2022-07-10T11:06:51+01:00 New Revision: af2d11b1d5c1508b506825df460656e0151cd3b0 URL: https://github.com/llvm/llvm-project/commit/af2d11b1d5c1508b506825df460656e0151cd3b0 DIFF: https://github.com/llvm/llvm-project/commit/af2d11b1d5c1508b506825df460656e0151cd3b0.diff L

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth updated this revision to Diff 443486. JonasToth added a comment. - refactor: adjust warning message for mis-configuration to show which check is configured wrong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.ll

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth updated this revision to Diff 443485. JonasToth added a comment. - fix: doc list and release-notes reference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra/clang-tidy/m

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added a comment. In D54943#3619333 , @LegalizeAdulthood wrote: > Clang-tidy tests and docs have been moved to subdirectories by module, please > rebase to `main:HEAD` I moved the tests and the documentation as well. tests + documentation do bu

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-const-correctness.rst:10 +`CppCoreGuidelines ES.25

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth updated this revision to Diff 443484. JonasToth marked 4 inline comments as done. JonasToth added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: abrachet, sstefan1, phosek. - test: move tests into group specific directory - refactor: use more idiomatic c++ for s

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. I fixed it locally by running `dos2unix` on the patch before applying. However, if you're able to, please update the patch to remove the Windows line endings so it can be applied with `arc patch`, otherwise the patch metadata is lost during manual application. Reposito

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. I would like to apply the updated patch to try it some more, but `arc patch` is failing for me. Applying the raw diff manually with `patch` also fails with the following errors: $ patch -p1 < ../patches/macro-hover.patch patching file clang-tools-extra/clangd/Hover.