[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

shafik added a comment. In D131704#3719954 , @thakis wrote: >> This is constant initialization, so this is indeed expected. > > Do we have a test for this in clang? It seems that the diag appeared for that > case after the change that turned this diag in

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452383. alexiprof added a comment. Fix revision Differential Revision: https://reviews.llvm.org/D131808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: cl

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452382. alexiprof added a comment. This is commit fix flang unit tests in using help command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: flang/test/Dri

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

This revision was automatically updated to reflect the committed changes. Closed by commit rGef71383b0cfb: [clang-format] Distinguish logical and after bracket from reference (authored by jackh ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] ef71383 - [clang-format] Distinguish logical and after bracket from reference

Author: jackh Date: 2022-08-13T11:52:23+08:00 New Revision: ef71383b0cfbacdbebf495015f6ead5294bf7759 URL: https://github.com/llvm/llvm-project/commit/ef71383b0cfbacdbebf495015f6ead5294bf7759 DIFF: https://github.com/llvm/llvm-project/commit/ef71383b0cfbacdbebf495015f6ead5294bf7759.diff LOG: [c

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb updated this revision to Diff 452358. cjdb added a comment. rebase messed up diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130867/new/ https://reviews.llvm.org/D130867 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Buil

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb updated this revision to Diff 452357. cjdb added a comment. applies a fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130867/new/ https://reviews.llvm.org/D130867 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Builtins.def

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131750/new/ https://reviews.llvm.org/D131750 ___ cfe-commits mailing list cfe-commits

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

jackhong12 updated this revision to Diff 452351. jackhong12 added a comment. Remove redundant code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131750/new/ https://reviews.llvm.org/D131750 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp clang/un

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

jackhong12 updated this revision to Diff 452345. jackhong12 edited the summary of this revision. jackhong12 added a comment. Remove redundant code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131750/new/ https://reviews.llvm.org/D131750 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

peixin added a comment. The CI failed since the test cases in flang driver have new output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits mail

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:121 +if (N == Value) + return ~Value; + } joaomoreira wrote: > Can we use another constant blinding scheme, such as a Value++ or anything > else? This way, we would p

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

ychen created this revision. ychen added a reviewer: probinson. Herald added a subscriber: inglorion. Herald added a project: All. ychen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae added a comment. In D130131#3720552 , @beanz wrote: > Now that I'm seeing the code in D131370 , I > don't know that this is the right way to do things. > > I think using address spaces like this is odd. Addre

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

beanz added a comment. Now that I'm seeing the code in D131370 , I don't know that this is the right way to do things. I think using address spaces like this is odd. Address spaces aren't really intended for use differentiating high level access types, but rath

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ca27206f973: [OpenMP] Fix segmentation fault when data field is used in is_device_pt (authored by jyu2). Changed prior to commit: https://reviews

[clang] 2ca2720 - [OpenMP] Fix segmentation fault when data field is used in is_device_pt

Author: Jennifer Yu Date: 2022-08-12T17:10:26-07:00 New Revision: 2ca27206f9739bffb50b999bdfb76fec1d7e62a8 URL: https://github.com/llvm/llvm-project/commit/2ca27206f9739bffb50b999bdfb76fec1d7e62a8 DIFF: https://github.com/llvm/llvm-project/commit/2ca27206f9739bffb50b999bdfb76fec1d7e62a8.diff L

[PATCH] D131268: [HLSL] Generate buffer subscript operators

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/buffer-array-operator.hlsl:3 + +const RWBuffer In; +RWBuffer Out; beanz wrote: > python3kgae wrote: > > Why add const instead of using Buffer directly? > > > Making this const forces the const

[PATCH] D131268: [HLSL] Generate buffer subscript operators

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/buffer-array-operator.hlsl:3 + +const RWBuffer In; +RWBuffer Out; python3kgae wrote: > Why add const instead of using Buffer directly? > Making this const forces the const methods to be used. It is

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

ayzhao updated this revision to Diff 452334. ayzhao added a comment. Add a test for non-constexpr if statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131818/new/ https://reviews.llvm.org/D131818 Files: clang/lib/Analysis/ReachableCode.cp

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

ayzhao created this revision. ayzhao added a reviewer: thakis. Herald added a reviewer: NoQ. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The point of a constexpr if statement is to determine which bra

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup

[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

thakis added a comment. In D131704#3717950 , @shafik wrote: > In D131704#3717774 , @akhuang wrote: > >> We're seeing this warning in code with global constants, e.g. >> >> const Enum x = static_cast(-1); >> >> i

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG405ad847931f: Update hwasan test to fix failure on older Android API versions. (authored by mnadeem). Repository: rG LLVM Github Monorepo CHANGES

[clang] 405ad84 - Update hwasan test to fix failure on older Android API versions.

Author: Usman Nadeem Date: 2022-08-12T16:30:08-07:00 New Revision: 405ad847931f68673e6c7e95a26cc265e150d9c6 URL: https://github.com/llvm/llvm-project/commit/405ad847931f68673e6c7e95a26cc265e150d9c6 DIFF: https://github.com/llvm/llvm-project/commit/405ad847931f68673e6c7e95a26cc265e150d9c6.diff

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

mnadeem updated this revision to Diff 452326. mnadeem edited the summary of this revision. mnadeem added a comment. Herald added a subscriber: kristof.beyls. Update to use the same triple as MEMTAG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131806/new/ https://reviews.llvm.org/D13180

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2893-2894 + else if (const auto *RB = dyn_cast(Attr)) +NewAttr = +S.mergeHLSLResourceBindingAttr(D, *RB, RB->getSlot(), RB->getSpace()); else if (Attr->shouldInheritEvenIfAlreadyPresent() |

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae updated this revision to Diff 452325. python3kgae marked 2 inline comments as done. python3kgae added a comment. Remove mergeHLSLResourceBindingAttr since should not be able to set ResourceBinding more than once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Either way is good, but I slightly prefer the triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131806/new/ https://reviews.llvm.org

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

vitalybuka added inline comments. Comment at: clang/test/CodeGen/sanitizer-special-case-list-globals.c:5 // RUN: %clang_cc1 -emit-llvm %s -o -\ // RUN: -fsanitize-ignorelist=%S/Inputs/sanitizer-special-case-list-globals.txt \ // RUN: | FileCheck %s --check-prefix=NONE ---

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10477 Style); + verifyFormat("bool b = 3 == int{3} && true;"); owenpan wrote: > Can you add a similar test in TokenAnnotatorTest.cpp? Nvm. Repository: rG LLVM

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2368-2376 +// Before token annotation, clang-format will split the declaration into +// multiple lines in the struct, union, class, and enum cases. For instance, +// `struct {int n} &&ptr=

[PATCH] D131784: [analyzer] Fix a crash on copy elided initialized lambda captures

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4e3e3a3eb77: [analyzer] Fix a crash on copy elided initialized lambda captures (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] b4e3e3a - [analyzer] Fix a crash on copy elided initialized lambda captures

Author: isuckatcs Date: 2022-08-13T00:22:01+02:00 New Revision: b4e3e3a3eb775df947f10212c461307592a13de0 URL: https://github.com/llvm/llvm-project/commit/b4e3e3a3eb775df947f10212c461307592a13de0 DIFF: https://github.com/llvm/llvm-project/commit/b4e3e3a3eb775df947f10212c461307592a13de0.diff LOG

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie marked an inline comment as done and an inline comment as not done. dblaikie added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:2-9 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown %s -fsyntax-only -verify -std=c++11 -Wno-inaccessible-base -Wno-c++

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a subscriber: hansw. dblaikie added a comment. In D119051#3717934 , @dblaikie wrote: > I guess the other way to test for pod-for-purposes-of-ABI is IRgen. Looks > like MSVC isn't observable based on sizeof or alignof on these issues (the

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 452315. dblaikie added a comment. Add PS4/Darwin handling Remove unnecessary warning suppression Add MSVC return ABI testing Add tail-padding based testing as well as the alignment based testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 __

[libunwind] 2366c6a - [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback table on AIX

Author: Xing Xue Date: 2022-08-12T18:07:56-04:00 New Revision: 2366c6adfc95e1aca9afbbbf5251a61552865b55 URL: https://github.com/llvm/llvm-project/commit/2366c6adfc95e1aca9afbbbf5251a61552865b55 DIFF: https://github.com/llvm/llvm-project/commit/2366c6adfc95e1aca9afbbbf5251a61552865b55.diff LOG:

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3680607 , @royjacobson wrote: > In D128750#3663161 , @ychen wrote: > >> In D128750#3662898 , @royjacobson >> wrote: >> >>> but in your

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 452311. ychen added a comment. - Remove code for temp.func.order p6.2.1 - Add missing handling for partial ordering of partial specialization - Add more tests - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:47 +void addDisableOptimizations(llvm::Module &M) { + StringRef Key = "dx.disable_optimizations"; + M.addModuleFlag(llvm::Module::ModFlagBehavior::Ov

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:47 +void addDisableOptimizations(llvm::Module &M) { + StringRef Key = "dx.disable_optimizations"; + M.addModuleFlag(llvm::Module::ModFlagBehavior::Override, Key, 1); What does this tra

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

xbolva00 added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1408 +// Intrinsic to wrap a thread local variable. +def int_threadlocal_address : DefaultAttrsIntrinsic<[llvm_anyptr_ty], [LLVMMatchType<0>], + [IntrNoMem, IntrSpeculatable,

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added a comment. In D128095#3712343 , @erichkeane wrote: > Can you make a better commit message? I don't have a good idea of the > intent/description of what you're trying to do here. Done. I split this up into two patches: - D131802

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov retitled this revision from "clang: fix checking parameter packs for expansion" to "[clang] Improve diagnostics for expansion length mismatch". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 452306. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 452305. python3kgae added a comment. Change attribute name to hlsl.numthreads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: clang/lib/CodeGen/CGHLSLRun

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

MaskRay added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:151 +static llvm::Reloc::Model getRelocationFromName(llvm::StringRef model) { + if (model.equals("static")) +return llvm::Reloc::Static; awarzynski wrote: > Only `-fpic` and

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:6320-6325 +def pic_level : Separate<["-"], "pic-level">, + HelpText<"Value for __PIC__">, + MarshallingInfoInt>; +def pic_is_pie : Flag<["-"], "pic-is-pie">, + HelpText<"File is for a position ind

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:98 + if (HLSLNumThreadsAttr *NumThreadsAttr = FD->getAttr()) { +const StringRef NumThreadsKindStr = "dx.numthreads"; +std::string NumThreadsStr; This isn't DirectX-specific, so

[PATCH] D131809: [clang][dataflow] Add an option for context-sensitive depth

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof created this revision. Herald added a reviewer: sscalpone. Herald added a project: All. alexiprof requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. this pull request contains a fix for the problem with displaying options -fsyntax_o

[PATCH] D121365: [CFG] Fix crash on CFG building when deriving from a template.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Hi, interesting, the code looks great but at a glance I don't see why would you even want a CFG for an uninstantiated template. Every time you want to analyze the actual runtime behavior of a progra

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3112 +result = CGF.Builder.CreateFPExt(result, ConvertType(E->getType())); + return result; +} zahiraam wrote: > rjmccall wrote: > > The first version of the fallback path (the on

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:950 +ComplexExprEmitter::EmitPromotedComplexOperand(const Expr *E, + QualType PromotionType) { + if (E->getType()->isAnyComplexType()) {

[PATCH] D131806: Update hwasan test to fix failure on older Android API versions.

mnadeem created this revision. mnadeem added reviewers: hctim, vitalybuka, kstoimenov. Herald added a subscriber: danielkiss. Herald added a project: All. mnadeem requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In Android API < 30 there is

[PATCH] D131802: WIP: [clang] fix missing initialization of original number of expansions

mizvekov created this revision. Herald added projects: clang, All. Herald added a subscriber: cfe-commits. mizvekov requested review of this revision. When expanding undeclared function parameters, we should initialize the original number of expansions, if known, before trying to expand them, othe

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 ___

[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

thakis added a comment. > This is constant initialization, so this is indeed expected. Do we have a test for this in clang? It seems that the diag appeared for that case after the change that turned this diag into a disable-able warning. Given it's intentional, we should make sure we test that

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_is_device_ptr_codegen.cpp:296 +// CK2-DAG: [[A8:%.*]] = getelementptr inbounds [[STRUCT_ST]], %struct.ST* [[THIS1]], i32 0, i32 0 +// CK2-DAG: [[B9:%.*]] = getelementptr inbounds [[STRUCT_ST]], %struct.ST* [[THIS1

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 updated this revision to Diff 452272. jyu2 added a comment. Fix test problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I did have a nit about diagnostic wording that you can feel free to take or leave at your discretion. Thank you for this work, this was a very large patch with a whole lot of review comments, but I think what we en

[PATCH] D131796: [clang][deps] Use a cc1 invocation in FullDependencies::getCommandLine()

jansvoboda11 added a comment. I like this direction, I've been wanting to do this for a long time. Since the scanner accepts driver invocations that can expand into multiple (`-cc1`, assembler, linker, ...) invocations, we'll need to update the `clang-scan-deps` output JSON format to accommodat

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5128 +// to the function itself; it points to a stub for the compiler. +// FIXME: We also need to emit an entry thunk. +SmallString<256> MangledName; bcl5980 wrote: > efri

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

artem.tamazov added a comment. In D129570#3717972 , @pfultz2 wrote: > I could extend it to support everything except explicit casts if you think > that would be better. If asked, I would vote for extending this warning. CHANGES SINCE LAST ACTION htt

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:424-431 + static bool isTransformTypeTrait(TST T) { +constexpr TST Traits[] = { +#define TRANSFORM_TYPE_TRAIT_DEF(_, Trait) TST_##Trait, +#include "clang/AST/Tr

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

Eugene.Zelenko added a comment. Please mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131780/new/ https://reviews.llvm.org/D131780 ___ cfe-commits mailing list cfe-commit

[PATCH] D119296: KCFI sanitizer

joaomoreira added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:121 +if (N == Value) + return ~Value; + } Can we use another constant blinding scheme, such as a Value++ or anything else? This way, we would prevent endbrs from being

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

erichkeane added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:892 + LangOptions::ClangABI::Ver15)) { + // C++03 [class]p4: + // A POD-struct is an aggregate class that has [...] no user-defined Does this language change

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae created this revision. python3kgae added reviewers: bogner, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Translate HLSLNumThreadsA

[PATCH] D131388: [docs] Add "C++20 Modules"

dblaikie added a comment. Actually, when it comes to diagrams - maybe what'd be good is a diagram of classic compilation and a diagram of modules and header modules src1.cpp -+> clang++ src1.cpp --> src1.o ---, hdr1.h --' +-> clang++ src1.o src2.o -> execu

[PATCH] D131739: [clang-doc] Always emit the TagType for RecordInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG68266828b170: [clang-doc] Always emit the TagType for RecordInfo (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 6826682 - [clang-doc] Always emit the TagType for RecordInfo

Author: Brett Wilson Date: 2022-08-12T18:39:20Z New Revision: 68266828b170d2f978d0bc2f508de2b3b9e41665 URL: https://github.com/llvm/llvm-project/commit/68266828b170d2f978d0bc2f508de2b3b9e41665 DIFF: https://github.com/llvm/llvm-project/commit/68266828b170d2f978d0bc2f508de2b3b9e41665.diff LOG:

[PATCH] D131793: [clang-doc] Fix assert on startup

This revision was automatically updated to reflect the committed changes. Closed by commit rG75c7e79464a3: [clang-doc] Fix assert on startup (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131793/new/ http

[clang-tools-extra] 75c7e79 - [clang-doc] Fix assert on startup

Author: Brett Wilson Date: 2022-08-12T18:37:23Z New Revision: 75c7e79464a3e77043571d187cd8019370326bcb URL: https://github.com/llvm/llvm-project/commit/75c7e79464a3e77043571d187cd8019370326bcb DIFF: https://github.com/llvm/llvm-project/commit/75c7e79464a3e77043571d187cd8019370326bcb.diff LOG:

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

aaron.ballman added a comment. > In D119051#3715939 , @aaron.ballman > wrote: > >> In D119051#3714645 , @dblaikie >> wrote: >> >>> >> >> I would have thought use of `__is_pod` would tell us, but I'm not seeing t

[PATCH] D131796: [clang][deps] Use a cc1 invocation in FullDependencies::getCommandLine()

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of trying to "fix" the original driver invocatin by ap

[PATCH] D131739: [clang-doc] Always emit the TagType for RecordInfo

brettw added a comment. In D131739#3719634 , @paulkirth wrote: > Can you update the summary to reflect what's in this change now + add a tag > for clang-doc? > > `[clang-doc] Always emit the TagType for RecordInfo` > > I can land this and D131793

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6557-6558 +Here're resource binding examples with and without space: +``RWBuffer Uav : register(u3, space1)`` +``Buffer Buf : register(t1)`` +The full documentation is available here: https://

[PATCH] D131793: [clang-doc] Fix assert on startup

brettw added a comment. In D131793#3719619 , @paulkirth wrote: > This is LGTM, but can you add a tag to the summary title/commit message? ie. > `[clang-doc] Fix assert on startup in clang-doc` Done Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman added a comment. In D131351#3718728 , @mizvekov wrote: > In D131351#3718725 , @aaron.ballman > wrote: > >> However, we don't care about the type mismatch when doing a redeclaration or >> when dropp

[PATCH] D131706: [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the result is not used

This revision was automatically updated to reflect the committed changes. Closed by commit rG42ee0d8c16f7: [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 42ee0d8 - [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the result is not used

Author: Aleksandr Platonov Date: 2022-08-12T21:00:11+03:00 New Revision: 42ee0d8c16f7052c3bc8434325868f48a501baf2 URL: https://github.com/llvm/llvm-project/commit/42ee0d8c16f7052c3bc8434325868f48a501baf2 DIFF: https://github.com/llvm/llvm-project/commit/42ee0d8c16f7052c3bc8434325868f48a501baf2.

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:112-113 +} +if (!Tok.is(tok::identifier)) { + Diag(Tok.getLocation(), diag::err_expected) << tok::identifier; + SkipUntil(tok::r_paren, Sto

[PATCH] D131739: Fix some clang-doc issues.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. Can you update the summary to reflect what's in this change now + add a tag for clang-doc? `[clang-doc] Always emit the TagType for RecordInfo` I can land this and D131793

[PATCH] D131793: Fix assert on startup in clang-doc

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is LGTM, but can you add a tag to the summary title/commit message? ie. `[clang-doc] Fix assert on startup in clang-doc` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[libunwind] b559777 - [libunwind] Remove __ANDROID_API__ < 18 workaround

Author: Fangrui Song Date: 2022-08-12T10:46:46-07:00 New Revision: b559777c308dcdf40a5dc8dffd35867083a46c3c URL: https://github.com/llvm/llvm-project/commit/b559777c308dcdf40a5dc8dffd35867083a46c3c DIFF: https://github.com/llvm/llvm-project/commit/b559777c308dcdf40a5dc8dffd35867083a46c3c.diff

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae updated this revision to Diff 452232. python3kgae marked an inline comment as done. python3kgae added a comment. Limit to lower case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130033/new/ https://reviews.llvm.org/D130033 Files: c

[PATCH] D131739: Fix some clang-doc issues.

brettw updated this revision to Diff 452227. brettw edited the summary of this revision. brettw added a comment. Startup assert fix broken out into https://reviews.llvm.org/D131793 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131739/new/ https://reviews.llvm.org/D131739 Files: clang

[PATCH] D131793: Fix assert on startup in clang-doc

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. When using `clang-doc --format=

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

mstorsjo added a comment. In D131528#3719414 , @shafik wrote: > In D131528#3718405 , @mstorsjo > wrote: > >> In D131528#3716876 , @shafik wrote: >> >>> In D131528#3715841

[PATCH] D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner

craig.topper added inline comments. Comment at: llvm/include/llvm/ADT/iterator_range.h:50 +/// As of C++17, the types of the begin-expr and the end-expr do not have to be +/// the same in 'based-range for loop'. This class represents a tag that should +/// be returned from the 'e

[PATCH] D131789: [clang-tools-extra] Rewrite prints in python3 compatible way

eoanermine created this revision. eoanermine added reviewers: klimek, HazardyKnusperkeks. eoanermine added a project: clang-tools-extra. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

ayermolo added a comment. Was this and previous change intended to capture this case? const enum NumberType neg_one = (enum NumberType) ((enum NumberType) 0 - (enum NumberType) 1); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131528/new/ https:/

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman added a comment. In D131351#3718982 , @mstorsjo wrote: > A different but slightly similar case, where I've run into these errors too, > FWIW: On ARM, when compiling with a hardfloat target, Clang does consider a > function pointer with `__

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

shafik added a comment. In D131528#3718405 , @mstorsjo wrote: > In D131528#3716876 , @shafik wrote: > >> In D131528#3715841 , @thakis wrote: >> >>> We're also still seeing

[clang] b3f1a6b - [clang][dataflow] Encode options using llvm::Optional

Author: Sam Estep Date: 2022-08-12T16:29:41Z New Revision: b3f1a6bf1080fb67cb1760a924a56d38d51211aa URL: https://github.com/llvm/llvm-project/commit/b3f1a6bf1080fb67cb1760a924a56d38d51211aa DIFF: https://github.com/llvm/llvm-project/commit/b3f1a6bf1080fb67cb1760a924a56d38d51211aa.diff LOG: [cl

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f1a6bf1080: [clang][dataflow] Encode options using llvm::Optional (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5825190b8ad: [clang] fix frontend crash when evaluating type trait (authored by inclyc). Changed prior to commit: https://reviews.llvm.org/D13142

[clang] e582519 - [clang] fix frontend crash when evaluating type trait

Author: YingChi Long Date: 2022-08-13T00:02:19+08:00 New Revision: e5825190b8ad7ac8fe762fe4101cd4af04f4c057 URL: https://github.com/llvm/llvm-project/commit/e5825190b8ad7ac8fe762fe4101cd4af04f4c057 DIFF: https://github.com/llvm/llvm-project/commit/e5825190b8ad7ac8fe762fe4101cd4af04f4c057.diff

  1   2   >