[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

Eitot added a comment. In D126365#3565891 , @curdeius wrote: > @Eitot, do you need help landing this? I do need help. Could someone land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/ne

[PATCH] D132275: [clang] Reset some attributed calling lambda

vitalybuka updated this revision to Diff 454175. vitalybuka added a comment. fix for result slot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://reviews.llvm.org/D132275 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/

[PATCH] D132275: [clang] Reset some attributed calling lambda

vitalybuka updated this revision to Diff 454176. vitalybuka added a comment. remove dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://reviews.llvm.org/D132275 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/CodeGenF

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 454179. SixWeining added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining created this revision. SixWeining added reviewers: xen0n, MaskRay, xry111, wangleiat. Herald added subscribers: luke957, mstorsjo, StephenFan, luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. SixWeining requested review of this revision. Herald added su

[PATCH] D132286: [clang][Interp] Implement function calls

tbaeder created this revision. tbaeder added reviewers: erichkeane, aaron.ballman, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a `Call` op and use the existing infrastructure

[PATCH] D132285: [LoongArch] Implement ABI lowering

xry111 added a comment. Are cases like struct x { double a; __int128 : 0; double b;}; double f(struct x x) { return x.a + x.b; } handled properly? AFAIK RISC-V clang currently does not handle it correctly: https://godbolt.org/z/rvM99zbqc (GCC handles it properly) https://godbolt.org/z/sWY5

[PATCH] D132286: [clang][Interp] Implement function calls

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:60 + S.Current = + new InterpFrame(S, const_cast(Func), S.Current, PC, {}); + This patch adds two `const_cast`s. They aren't strictly necessary, since the `InterpFrame` doesn't need

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining added a comment. In D132285#3736922 , @xry111 wrote: > Are cases like > > struct x { double a; __int128 : 0; double b;}; > double f(struct x x) { return x.a + x.b; } > > handled properly? AFAIK RISC-V clang currently does not handle it cor

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

rymiel updated this revision to Diff 454191. rymiel added a comment. Extra tests, including token annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132189/new/ https://reviews.llvm.org/D132189 Files: clang/lib/Format/TokenAnnotator.c

[PATCH] D132289: [analyzer] Drop deprecated flags

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, ASDenysPetrov, isuckatcs, balazske, xazax.hun, vabridgers. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project:

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: aaron.ballman, asoffer. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-shaposhnikov requested rev

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:221 // Destructor. - Finder->addMatcher(cxxDestructorDecl(isDefinition()).bind(Sp

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Yoorkin created this revision. Yoorkin added a reviewer: clang-tools-extra. Yoorkin added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. Yoorkin requested review of this revision. Herald added a subscriber: cfe-commits. Hi, I

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

Eugene.Zelenko added a comment. Please mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132290/new/ https://reviews.llvm.org/D132290 ___ cfe-commits mailing list cfe-commit

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains updated this revision to Diff 454205. iains marked an inline comment as done. iains added a comment. rebased, addressed remaing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128328/new/ https://reviews.llvm.org/D128328 Files: cla

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains marked 2 inline comments as done. iains added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1262 +if (auto *FDD = FD->getDefinition()) { + DefInPMF = FDD->getOwningModule()->isPrivateModule(); + if (!DefInPMF) ChuanqiXu wrot

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SprintfWithFixedSizeBufferCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" + +#include "clang/Lex/Lexer.h" Unnecessary newline. Comment at: cla

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the heuristic was simply to look fo

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 454212. Ericson2314 added a comment. Rebase; Include d3a1dbc4907b59690f9013cdb6221573ca4233f1 as requested Thanks @thakis for letting me know. Repository: rG LLVM Github Monorepo

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Yoorkin added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SprintfWithFixedSizeBufferCheck.h:29 + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + Eugene.Zelenko wrote: > Please add `isLanguageVersionSupport

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SprintfWithFixedSizeBufferCheck.h:29 + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + Yoorkin wrote: > Eugene.Zelenko wrote: > > Please add

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 created this revision. Ericson2314 added a reviewer: sebastian-ne. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, MaskRay. Herald added projects: clang, LLD

[clang] fc4d3a1 - [clang] Use Any::has_value instead of Any::hasValue (NFC)

Author: Kazu Hirata Date: 2022-08-20T08:40:18-07:00 New Revision: fc4d3a1109cde38d64583e21852f83e03aa92a73 URL: https://github.com/llvm/llvm-project/commit/fc4d3a1109cde38d64583e21852f83e03aa92a73 DIFF: https://github.com/llvm/llvm-project/commit/fc4d3a1109cde38d64583e21852f83e03aa92a73.diff L

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Yoorkin updated this revision to Diff 454226. Yoorkin marked 10 inline comments as done. Yoorkin added a comment. I fixed them all CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132294/new/ https://reviews.llvm.org/D132294 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

MyDeveloperDay added a comment. can you add some format tests to show examples of how you think it should change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 ___

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/sprintf-with-fixed-size-buffer.rst:6 + +Find usage of ``sprintf``, which write output string into a fixed-size array. It +will suggest ``snprintf`` instead. Sho

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Yoorkin updated this revision to Diff 454228. Yoorkin added a comment. I fixed it. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132294/new/ https://reviews.llvm.org/D132294 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugp

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

MyDeveloperDay added a comment. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132256/new/ https://reviews.llvm.org/D132256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 3adda39 - [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Author: John Ericson Date: 2022-08-20T12:52:21-04:00 New Revision: 3adda398cef7f56d024924158e7b17d65cbc565d URL: https://github.com/llvm/llvm-project/commit/3adda398cef7f56d024924158e7b17d65cbc565d DIFF: https://github.com/llvm/llvm-project/commit/3adda398cef7f56d024924158e7b17d65cbc565d.diff

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3adda398cef7: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASEN

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. This change breaks libc++'s modular build see build https://buildkite.com/llvm-project/libcxx-ci/builds/12991 Reverting this commit on top of yesterday's build (before your revert) fixes the issue. libc++'s modular build uses Clang's pre-C++20 modules. It can be repro

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. `D130586` was approved; this is a subset; this had no test failures, so I just went ahead and landed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 _

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

MyDeveloperDay added a comment. This looks pretty good to me, but wait for @HazardyKnusperkeks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132189/new/ https://reviews.llvm.org/D132189 ___ cfe-commits m

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1602 Style.AlignTrailingComments = false; + Style.AlignTrailingCommentsIgnoreEmptyLine = false; Style.AllowShortBlocksOnASingleLine = FormatStyle::SBS_Empty; ditto remove =

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. I fixed up the gn build after this in 804d4594cbe217ae817b6786b0e9965283f78aa2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. (ie if you revert that, it'd be appreciated if you could revert that in the same commit) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 __

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 454238. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplateDeduc

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov marked 5 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12218 +CTN, +NExpX && NExpY ? Optional(std::min(*NExpX, *NExpY)) : None); + } davrec wrote: > I'm not clear on how `NExpX` could n

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. OK Thanks @thakis --- I was confused why the last GN fixup added but didn't remove lines. That clears it up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 _

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-equals-default-copy.cpp:38 + NU(const NU &Other) : Field(Other.Field) {} + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:3: warning: use '= default' + // CHECK-FIXES: NU(const NU &Other

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

njames93 added a comment. Why are we only targeting sprintf, vsprintf would also suffer from the same pitfalls. Is there any hard reason that this check always suggests `snprintf` instead of `sprintf_s`, maybe have that dynamically controlled with an option. Comment at: clan

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. I've got everything done locally, but I'm waiting on the decision on the bitset to update the diff, including some minor additional updates I will list then. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SymmetricBinaryOperatorCheck.cpp:

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 created this revision. Ericson2314 added reviewers: phosek, sebastian-ne, beanz. Herald added subscribers: bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jac

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3737375 , @Mordante wrote: > This change breaks libc++'s modular build see build > https://buildkite.com/llvm-project/libcxx-ci/builds/12991 > Reverting this commit on top of yesterday's build (before your revert) f

[libunwind] dad00da - [libunwind] Fixed a number of typos

Author: Gabriel Ravier Date: 2022-08-20T18:09:03-07:00 New Revision: dad00daa7a0a656640f7579c2c21933ef97a1978 URL: https://github.com/llvm/llvm-project/commit/dad00daa7a0a656640f7579c2c21933ef97a1978 DIFF: https://github.com/llvm/llvm-project/commit/dad00daa7a0a656640f7579c2c21933ef97a1978.diff

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: flang/test/Driver/pic-flags.f90:69 +! CHECK-ROPI: "-mrelocation-model" "ropi" +! CHECK-ROPI-NOT: -pic + I'd use `! CHECK-ROPI-NOT: "-pic`

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 created this revision. Ericson2314 added reviewers: ldionne, phosek. Herald added subscribers: Enna1, arichardson, mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added subscribers: llvm-commits, libcxx-commits, Sanitizers, cfe-commits, MaskRa

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

phosek accepted this revision. phosek added a comment. LGTM Comment at: compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh:103 LIBCXX_FLAGS="${FLAGS} -Wno-macro-redefined" PROJECTS= if [[ ! -d $LLVM_SRC/projects/libcxxabi ]] ; then ---

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 updated this revision to Diff 454271. Ericson2314 added a comment. Do the rename @phosek suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324 Files: clang/lib/Driver/ToolChains/Linux.cp

[clang-tools-extra] 258531b - Remove redundant initialization of Optional (NFC)

Author: Kazu Hirata Date: 2022-08-20T21:18:28-07:00 New Revision: 258531b7ac0d43fce84a008235c597f920a6af7e URL: https://github.com/llvm/llvm-project/commit/258531b7ac0d43fce84a008235c597f920a6af7e DIFF: https://github.com/llvm/llvm-project/commit/258531b7ac0d43fce84a008235c597f920a6af7e.diff L

[clang] c5da37e - Use std::is_same_v instead of std::is_same (NFC)

Author: Kazu Hirata Date: 2022-08-20T22:36:26-07:00 New Revision: c5da37e42d388947a40654b7011f2a820ec51601 URL: https://github.com/llvm/llvm-project/commit/c5da37e42d388947a40654b7011f2a820ec51601 DIFF: https://github.com/llvm/llvm-project/commit/c5da37e42d388947a40654b7011f2a820ec51601.diff L

[clang-tools-extra] c5da37e - Use std::is_same_v instead of std::is_same (NFC)

Author: Kazu Hirata Date: 2022-08-20T22:36:26-07:00 New Revision: c5da37e42d388947a40654b7011f2a820ec51601 URL: https://github.com/llvm/llvm-project/commit/c5da37e42d388947a40654b7011f2a820ec51601 DIFF: https://github.com/llvm/llvm-project/commit/c5da37e42d388947a40654b7011f2a820ec51601.diff L

[clang] 8b1b0d1 - Revert "Use std::is_same_v instead of std::is_same (NFC)"

Author: Kazu Hirata Date: 2022-08-20T23:00:39-07:00 New Revision: 8b1b0d1d81213d10e6add52d93d0afd71baf6a04 URL: https://github.com/llvm/llvm-project/commit/8b1b0d1d81213d10e6add52d93d0afd71baf6a04 DIFF: https://github.com/llvm/llvm-project/commit/8b1b0d1d81213d10e6add52d93d0afd71baf6a04.diff L

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 454275. njames93 added a comment. Add NestedControlFlow options This option can be used to silence diagnostics when there aren't any nested blocks inside the if statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.