[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SymmetricBinaryOperatorCheck.cpp:56 +bool isComparisonOperator(OverloadedOperatorKind Kind) { + return llvm::is_contained( + std::initializer_list{ 5chmidti wrote: >

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining updated this revision to Diff 454276. SixWeining added a comment. Ignore zero-width bit fields and add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/ https://reviews.llvm.org/D132285 Files: clang/lib/Basic/Targets/L

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun created this revision. Herald added subscribers: pengfei, mstorsjo. Herald added a reviewer: aaron.ballman. Herald added a project: All. alvinhochun added reviewers: ajpaverd, rnk. alvinhochun updated this revision to Diff 454274. alvinhochun edited the summary of this revision. alvinho

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun updated this revision to Diff 454280. alvinhochun added a comment. Specify x86_64-w64-windows-gnu in tests instead of using %itanium_abi_triple because it doesn't work on Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132302/new/

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 454282. MaskRay marked 6 inline comments as done. MaskRay added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ https://reviews.llvm.org/D131464 Files: clang/test/AST/ast-dump-

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

This revision was automatically updated to reflect the committed changes. iains marked an inline comment as done. Closed by commit rGfee36cda: [C++20][Modules] Improve handing of Private Module Fragment diagnostics. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] fee3ccc - [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

Author: Iain Sandoe Date: 2022-08-21T10:19:46+01:00 New Revision: fee36cdabdeddc688cf7a15b144c814dd93d URL: https://github.com/llvm/llvm-project/commit/fee36cdabdeddc688cf7a15b144c814dd93d DIFF: https://github.com/llvm/llvm-project/commit/fee36cdabdeddc688cf7a15b144c814dd93d.diff L

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 454287. 5chmidti added a comment. - address all comments - minor renames of variables/functions - add missing & when accessing OptTokens value - rebase onto current HEAD - fix llvm::Optional member deprecation warnings - add support to match when the paramete

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti updated this revision to Diff 454292. 5chmidti added a comment. lower c++ version requirement by making the fixes conditional on c++20 instead of the whole check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.ll

[clang] 176db3b - [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

Author: John Ericson Date: 2022-08-21T08:10:56-04:00 New Revision: 176db3b3ab25ff8a9b2405f50ef5a8bd9304a6d5 URL: https://github.com/llvm/llvm-project/commit/176db3b3ab25ff8a9b2405f50ef5a8bd9304a6d5 DIFF: https://github.com/llvm/llvm-project/commit/176db3b3ab25ff8a9b2405f50ef5a8bd9304a6d5.diff

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rG176db3b3ab25: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJEC

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. Ah I see email about sphinx jobs defined out of tree :/ I will take a look at that, see if it is easy to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 454303. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3737641 , @erichkeane wrote: > In D126907#3737375 , @Mordante > wrote: > >> This change breaks libc++'s modular build see build >> https://buildkite.com/llvm-project/libcxx-

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. In 952f90b72b3546d6b6b038d410f07ce520c59b48 I relented and made it a non-fatal error until the remaining jobs are figured out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel updated this revision to Diff 454304. rymiel added a comment. Add a few format tests in addition to the annotator tests >From some incidental testing, I am pretty sure the formatting of lambdas that >were mis-annotated as "array subscript" tended to end up being formatted >correct-ish, h

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

MyDeveloperDay added a comment. If none of the previous tests fail then this looks like it might be a good fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 ___

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM but maybe wait for the others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 _

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

pengfei created this revision. pengfei added reviewers: LuoYuanke, craig.topper, andrew.w.kaylor, RKSimon, FreddyYe, skan. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, j

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

xen0n accepted this revision. xen0n added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2236 + static const char *const LoongArch64LibDirs[] = {"/lib64", "/lib"}; + static const char *const LoongArch64Triples

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Preprocessor/init-loongarch.c:1 +// RUN: %clang_cc1 -E -dM -ffreestanding -fgnuc-version=4.2.1 -triple=loongarch32 /dev/null \ +// RUN: | FileCheck --match-full-lines --check-prefix=LA32 %s -

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:310 - // The deprecated -DLLVM_ENABLE_PROJECTS=libcxx configuration installs - // libc++.so in D.Dir+"/../lib/". Detect this path. @mgorny FYI, this has been removed. Repositor

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

MaskRay added a subscriber: vitalybuka. MaskRay added a comment. @vitalybuka `-DLLVM_ENABLE_PROJECTS='libcxx;libcxxabi'` in `zorg/buildbot/builders/sanitizers/buildbot_functions.sh` needs adjustment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 454333. Herald added a subscriber: arichardson. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 454338. royjacobson added a comment. Address Aaron's comments, add the consteval test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/Release

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson marked 11 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defin

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a subscriber: ldionne. erichkeane added a comment. In D126907#3737986 , @Mordante wrote: > In D126907#3737641 , @erichkeane > wrote: > >> In D126907#3737375

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto updated this revision to Diff 454343. alecto added a comment. Revise based on feedback from Björn Schäpers We updated the version tag to 16 and positioned the DefinitionBLockSpacing field alphabetically. We also updated the documentation with `clang/docs/tools/dump_format_style.py` Repo

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto added a comment. In D132256#3736076 , @HazardyKnusperkeks wrote: > Do we want to define the behavior of `MaxEmptyLinesToKeep < > DefinitionBlockSpacing`? Then we need tests for that! > Tests with `MaxEmptyLinesToKeep < DefinitionBlockSpacing` and

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 454346. SixWeining added a comment. `-triple=` to `-triple ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Ba

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

vitalybuka added a comment. In D132324#3738253 , @MaskRay wrote: > @vitalybuka `-DLLVM_ENABLE_PROJECTS='libcxx;libcxxabi'` in > `zorg/buildbot/builders/sanitizers/buildbot_functions.sh` needs adjustment. If I do -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi

[clang] 4121445 - [clang-format] Fix BeforeHash indent of comments above PPDirective

Author: owenca Date: 2022-08-21T18:23:14-07:00 New Revision: 41214456de9d23b2cf6f87cb39b1c79682d799b7 URL: https://github.com/llvm/llvm-project/commit/41214456de9d23b2cf6f87cb39b1c79682d799b7 DIFF: https://github.com/llvm/llvm-project/commit/41214456de9d23b2cf6f87cb39b1c79682d799b7.diff LOG: [

[PATCH] D132097: [clang-format] Fix BeforeHash indent of comments above PPDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rG41214456de9d: [clang-format] Fix BeforeHash indent of comments above PPDirective (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132097/

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

vitalybuka added a comment. In D132324#3738430 , @vitalybuka wrote: > In D132324#3738253 , @MaskRay wrote: > >> @vitalybuka `-DLLVM_ENABLE_PROJECTS='libcxx;libcxxabi'` in >> `zorg/buildbot/builders/sanitizers/bu

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 454356. yubing added a comment. address simon's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X8

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

craig.topper added inline comments. Comment at: clang/lib/Headers/immintrin.h:300 +{ + unsigned int lo, hi; + if (__builtin_ia32_rdrand32_step(&lo) && __builtin_ia32_rdrand32_step(&hi)) { craig.topper wrote: > variable names in intrinsic headers must start with

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 454357. yubing added a comment. address craig's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X8

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1262 +if (auto *FDD = FD->getDefinition()) { + DefInPMF = FDD->getOwningModule()->isPrivateModule(); + if (!DefInPMF) iains wrote: > ChuanqiXu wrote: > > nit: > (I adde

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei created this revision. pengfei added reviewers: LuoYuanke, craig.topper, yubing, RKSimon, skan, FreddyYe. Herald added a subscriber: StephenFan. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. S

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2d77e050b32: [PowerPC][Coroutines] Add tail-call check with call information for coroutines (authored by tingwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] d2d77e0 - [PowerPC][Coroutines] Add tail-call check with call information for coroutines

Author: Ting Wang Date: 2022-08-21T22:20:40-04:00 New Revision: d2d77e050b32ce3f917688aeeb9e6f8f3c209560 URL: https://github.com/llvm/llvm-project/commit/d2d77e050b32ce3f917688aeeb9e6f8f3c209560 DIFF: https://github.com/llvm/llvm-project/commit/d2d77e050b32ce3f917688aeeb9e6f8f3c209560.diff LOG

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei updated this revision to Diff 454362. pengfei added a comment. Don't know why, but check `!defined(__SSE2__)` leads to compiler_builtins_x86.c fails like below. Move the check into avx512[vl]fp16intrin.h instead. error: 'error' diagnostics seen but not expected: File /export/users

[PATCH] D121670: [RISCV] Add zihintntl instructions

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670 ___

[PATCH] D121779: [RISCV] Add zihintntl compressed instructions

kito-cheng added inline comments. Herald added subscribers: sunshaoce, StephenFan, shiva0217. Comment at: llvm/test/MC/RISCV/rv32zihintntlc-valid.s:42 +# CHECK-ASM: encoding: [0x16,0x90] +c.ntl.all Could you add an invalid check for `c.ntl` instruction to make su

[clang] 7167a42 - [RISCV] Add zihintntl instructions

Author: Shao-Ce SUN Date: 2022-08-22T12:06:30+08:00 New Revision: 7167a4207ee2c07cb192da1788f919332f83b456 URL: https://github.com/llvm/llvm-project/commit/7167a4207ee2c07cb192da1788f919332f83b456 DIFF: https://github.com/llvm/llvm-project/commit/7167a4207ee2c07cb192da1788f919332f83b456.diff L

[PATCH] D121670: [RISCV] Add zihintntl instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7167a4207ee2: [RISCV] Add zihintntl instructions (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D132286: [clang][Interp] Implement function calls

shafik added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:38 +static_assert(add_second(10, 3, true) == 13, ""); +static_assert(add_second(300, -20, false) == 300, ""); I would expect a lot more test cases: trailing return types, default argume

[clang] aaa987d - [clang] Fix warning after D116203

Author: Vitaly Buka Date: 2022-08-21T22:39:23-07:00 New Revision: aaa987ddfbf5f2ee9dfaa9cc29ec224c6c607b65 URL: https://github.com/llvm/llvm-project/commit/aaa987ddfbf5f2ee9dfaa9cc29ec224c6c607b65 DIFF: https://github.com/llvm/llvm-project/commit/aaa987ddfbf5f2ee9dfaa9cc29ec224c6c607b65.diff L

[PATCH] D132286: [clang][Interp] Implement function calls

tbaeder updated this revision to Diff 454386. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132286/new/ https://reviews.llvm.org/D132286 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Eval

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21634 + " }\n" + "};\n"); + verifyFormat("auto L = [](T...) {\n" There should be no terminating newline here.

[PATCH] D132286: [clang][Interp] Implement function calls

tbaeder added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:38 +static_assert(add_second(10, 3, true) == 13, ""); +static_assert(add_second(300, -20, false) == 300, ""); shafik wrote: > I would expect a lot more test cases: trailing return type

[PATCH] D132286: [clang][Interp] Implement function calls

tbaeder updated this revision to Diff 454389. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132286/new/ https://reviews.llvm.org/D132286 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Inter

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

craig.topper added a comment. Should the const change be a separate patch? They feel unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132342/new/ https://reviews.llvm.org/D132342 ___ cfe-commits

[clang] d90c1bc - Revert "[clang-format][NFC] Fix a bug in setting type FunctionLBrace"

Author: owenca Date: 2022-08-21T23:26:51-07:00 New Revision: d90c1bcdf9a495507d7f1dbf829e8e00344bf12e URL: https://github.com/llvm/llvm-project/commit/d90c1bcdf9a495507d7f1dbf829e8e00344bf12e DIFF: https://github.com/llvm/llvm-project/commit/d90c1bcdf9a495507d7f1dbf829e8e00344bf12e.diff LOG: R

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:677 //Builder.defineMacro("__cpp_aggregate_paren_init", "201902L"); -Builder.defineMacro("__cpp_concepts", "201907L"); +Builder.defineMacro("__cpp_concepts", "202002L"); Builder.

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

LuoYuanke added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2472 + case BuiltinType::BFloat16: +mangleArtificialTagType(TTK_Struct, "__bf16", {"__clang"}); This looks irrelative to the patch. Comment at: clang/test/Cod