[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta updated this revision to Diff 455088. thieta added a comment. Fixed variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132486/new/ https://reviews.llvm.org/D132486 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst clang

[PATCH] D132531: [AArch64] Reserve more physical registers

Carrot added a comment. A reserved physical register doesn't mean it can't be used by compiler/linker, it just means it can't be used by register allocator, see the comments in TargetRegisterInfo::getReservedRegs(). The most common example is the stack pointer. So when we reserve X8, X16, X17 a

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM In D132444#3743051 , @mstorsjo wrote: > In D132444#3743020 , @thakis wrote: > >> Makes sense to me. May

[clang] 3f20dcb - [Pipelines] Introduce DAE after ArgumentPromotion

Author: Pavel Samolysov Date: 2022-08-24T10:36:12+03:00 New Revision: 3f20dcbf708cb23f79c4866d8285a8ae7bd885de URL: https://github.com/llvm/llvm-project/commit/3f20dcbf708cb23f79c4866d8285a8ae7bd885de DIFF: https://github.com/llvm/llvm-project/commit/3f20dcbf708cb23f79c4866d8285a8ae7bd885de.dif

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f20dcbf708c: [Pipelines] Introduce DAE after ArgumentPromotion (authored by psamolysov). Changed prior to commit: https://reviews.llvm.org/D12883

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @aeubanks Thank you very much for the benchmark results and review. I've landed the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. In D113107#3744782 , @rjmccall wrote: > In D113107#3744505 , @pengfei wrote: > >>> I'm not sure what optimization you mean. Because the ABI returns 16-bit and >>> 32-bit FP values differe

[PATCH] D131686: [clang-tidy] Add test to cert-dcl58-cpp (NFC).

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131686/new/ https://reviews.llvm.org/D131686 ___

[PATCH] D132531: [AArch64] Reserve more physical registers

kristof.beyls added a comment. See https://reviews.llvm.org/D56305 and https://reviews.llvm.org/D48580 for previous related discussions. I think it would be helpful to understand the use case for being able to reserve x8, x16, x17 and x19 better. Repository: rG LLVM Github Monorepo CHANGES

[clang] d3b14cc - Revert "[Clang] Avoid using unwind library in the MSVC environment"

Author: Petr Hosek Date: 2022-08-24T08:24:18Z New Revision: d3b14ccafb198ac02109dae16e966ba70a6058b7 URL: https://github.com/llvm/llvm-project/commit/d3b14ccafb198ac02109dae16e966ba70a6058b7 DIFF: https://github.com/llvm/llvm-project/commit/d3b14ccafb198ac02109dae16e966ba70a6058b7.diff LOG: Re

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

HsiangKai created this revision. HsiangKai added reviewers: aemerson, paquette. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. HsiangKai requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. AArch64 only

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

mstorsjo added a comment. > This reverts commit eca29d4a37b8d1c93fe99be6289a60bb11cf789d > since > the test fails in the per-target-runtime-dir layout. Does that mean that the testcase ended up looking at other libraries next

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a4c6c9f98a6: [clang] Allow using -rtlib=platform to switching to the default rtlib on all… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 0a4c6c9 - [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

Author: Martin Storsjö Date: 2022-08-24T11:39:03+03:00 New Revision: 0a4c6c9f98a6dd5f12b8ff55c60f446b75958ac7 URL: https://github.com/llvm/llvm-project/commit/0a4c6c9f98a6dd5f12b8ff55c60f446b75958ac7 DIFF: https://github.com/llvm/llvm-project/commit/0a4c6c9f98a6dd5f12b8ff55c60f446b75958ac7.diff

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 455111. avogelsgesang marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D132415 Files: clang/docs/tools/clang-formatted-files.txt lldb/packages/Python/lldbsuite/test/lldbtes

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:39 + CompilerType coro_func_type = ast_ctx.CreateFunctionType( + /*result_type*/ void_type, /*args*/ &void_type, /*num_args*/ 1, + /*is_variadic*/ false, /*qualifiers

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. FYI, this broke the LLDB build bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46324/execution/node/74/log/ Looks like we're testing that unused parameters optimise out but that's not the case anymore `AssertionError: '(void *) unused1 = ' not found i

[clang] 6703ad1 - Revert "[Pipelines] Introduce DAE after ArgumentPromotion"

Author: Pavel Samolysov Date: 2022-08-24T12:44:13+03:00 New Revision: 6703ad1e0c2a30153c75139764672d2ad16069c8 URL: https://github.com/llvm/llvm-project/commit/6703ad1e0c2a30153c75139764672d2ad16069c8 DIFF: https://github.com/llvm/llvm-project/commit/6703ad1e0c2a30153c75139764672d2ad16069c8.dif

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @Michael137 Thank you very much for the information! I'm not sure, but it looks like the introduced change of the `readnone` attribute to `readonly` might make impact on DWARF. Unfortunately, I have no idea should this changes in DWARF be fixed or just it is enough t

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added subscribers: aprantl, dblaikie. Michael137 added a comment. In D128830#3745069 , @psamolysov wrote: > @Michael137 Thank you very much for the information! > > I'm not sure, but it looks like the introduced change of the `readnone` > att

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. I tried to triage a bit. The test `lldb\test\API\functionalities\unused-inlined-parameters\TestUnusedInlinedParameters.py` compiles the code in `main.c` with `-O1` and generates the following IR for the `@f` function: ; Function Attrs: alwaysinline nounwind uwtabl

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

Anastasia updated this revision to Diff 455139. Anastasia added a comment. - Added clarification about the opaque pointers in SPIR-V. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132473/new/ https://reviews.llvm.org/D132473 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/Rele

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:676 + LLVM backend when generating SPIR-V binary. + Floating Point Support in Clang svenvh wrote: > Should we say anything about opaque pointers? Something like: > > ``` > - Although LL

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455141. Codesbyusman added a comment. updated with suggestions and test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files: clang/include/clang/Basic

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455147. Codesbyusman added a comment. updated test cases and suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files: clang/include/clang/Basic/Diag

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:384 +C2X_KEYWORD(true, BOOLSUPPORT) +C2X_KEYWORD(remove_quals, KEYC2X) + aaron.ballman wrote: > This is technically correct, but I thi

[PATCH] D132521: [AST] Reuse PrintingPolicy from ASTContext

JOE1994 updated this revision to Diff 455157. JOE1994 added a comment. Add missed out 'const' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132521/new/ https://reviews.llvm.org/D132521 Files: clang/lib/Frontend/ASTConsumers.cpp Index: clang/li

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

animeshk-amd updated this revision to Diff 455161. animeshk-amd added a comment. The second function was testing the `implementation` trait set for the `vendor` trait with respect to the `metadirective` directive. After Johannes's comment, on further searching it turns out that this trait and tra

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

aaron.ballman created this revision. Herald added a subscriber: yaxunl. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects: clang, clang-tools-extra. This corresponds to the RFC posted to Discourse proposing changes for code ownership in both Clang

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

royjacobson added a comment. I looked at this a bit about a week ago and got it down to 3-4 tests failing, but I'm not sure how much time I'll have to continue working on it. If one of you wants to take over I'll be happy to send you what I've currently got. @erichkeane @ilya-biryukov Also, do

[clang] 3e84cdb - [NFC] Colocate cache values for controling libc++ headers build in stage 2

Author: Louis Dionne Date: 2022-08-24T08:50:52-04:00 New Revision: 3e84cdbee467f97026f1ad421abcaf9b862c1ff4 URL: https://github.com/llvm/llvm-project/commit/3e84cdbee467f97026f1ad421abcaf9b862c1ff4 DIFF: https://github.com/llvm/llvm-project/commit/3e84cdbee467f97026f1ad421abcaf9b862c1ff4.diff

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/docs/ReleaseNotes.rst:676 + LLVM backend when generating SPIR-V binary. + Floating Point Support in Clang Anastasia wrote:

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane added a subscriber: tstellar. erichkeane added a comment. In D53847#3745415 , @royjacobson wrote: > I looked at this a bit about a week ago and got it down to 3-4 tests failing, > but I'm not sure how much time I'll have to continue working on

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Comment at: clang-tools-extra/CODE_OWNERS.TXT:8 +beautification by scripts. The fields are: name (N), email (E), Phabricator +

[clang] b1320f7 - [clang] Explicitly add libcxx and libcxxabi runtimes during Stage2 builds

Author: Louis Dionne Date: 2022-08-24T09:13:29-04:00 New Revision: b1320f7c9b907d39c8ceca9b91d66046441f1ae3 URL: https://github.com/llvm/llvm-project/commit/b1320f7c9b907d39c8ceca9b91d66046441f1ae3 DIFF: https://github.com/llvm/llvm-project/commit/b1320f7c9b907d39c8ceca9b91d66046441f1ae3.diff

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang-tools-extra/CODE_OWNERS.TXT:8 +beautification by scripts. The fields are: name (N), email (E), Phabricator +handle (H), and description (D). xazax.hun wrote:

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. In D131979#3743127 , @rjmccall wrote: > In D131979#3742399 , @yihanaa wrote: > >> As far as I know, turning on the -fsanitizer=alignment options when calling >> __builtin_assume_aligned i

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta added a comment. @jrtc27 What do you think about this patch with the default flipped? I think this is how it should land personally as discussed on discourse. I have been trying to listen in how people want to handle this and I hope this is a good middle ground that we can agree on for 1

[clang] ba57828 - [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

Author: Joseph Huber Date: 2022-08-24T08:47:55-05:00 New Revision: ba57828e11c52f45420f2027dae0843cf83a57bf URL: https://github.com/llvm/llvm-project/commit/ba57828e11c52f45420f2027dae0843cf83a57bf DIFF: https://github.com/llvm/llvm-project/commit/ba57828e11c52f45420f2027dae0843cf83a57bf.diff

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rGba57828e11c5: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGad8c34bc3089: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo

[PATCH] D122255: Meta directive runtime support

jdoerfert added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1679 + OS << ": "; +} + abidmalikwaterloo wrote: > jdoerfert wrote: > > I'm assuming we already have a printer for trait selectors, no? Doesn't > > `OMPTraitInfo::print` do this already

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as discussed over many weeks in our calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130020/new/ https://reviews.llvm.org/D130020

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu updated this revision to Diff 455209. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBitCodes.h llvm/include/llvm/IR/Attri

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: llvm/include/llvm/IR/InstrTypes.h:1863 + /// not access or only reads memory. + bool doesNotReadThreadIDNorLivesInPresplitCoroutine() const { +return doesNoReadThreadID() || !getFunctio

[PATCH] D132503: Add cxx scope if needed for requires clause.

luken-google updated this revision to Diff 455217. luken-google added a comment. Fix clang-format errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132503/new/ https://reviews.llvm.org/D132503 Files: clang/lib/Parse/ParseTemplate.cpp clang/

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

ye-luo accepted this revision. ye-luo added a comment. The new driver remains failing offload to x86 in certain scenarios when linking static libraries. Once I link object files directly there is no issue. This not worse than old driver that only supports linking object files directly. Reposit

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

alexfh added a comment. In D128113#3744353 , @mizvekov wrote: > In D128113#3744315 , @alexfh wrote: > >> The whole project seems like a great improvement in clang diagnostics, but I >> don't yet see how template

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc created this revision. inclyc added a reviewer: aaron.ballman. Herald added a subscriber: emaste. Herald added a project: All. inclyc published this revision for review. inclyc added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. I'd try compiling with `clang -g2` to see the effects of this patch on the debug info in the IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830 _

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

MaskRay accepted this revision. MaskRay added a comment. This is "remove" instead of "deprecate"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130020/new/ https://reviews.llvm.org/D130020 ___ cfe-commit

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. https://lab.llvm.org/buildbot#builders/13/builds/24958 I am worried this failure is not spurious? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

jhuber6 added a comment. In D130020#3746076 , @MaskRay wrote: > This is "remove" instead of "deprecate"? Yes, "remove" is probably more appropriate as this completely removes support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

dblaikie added a comment. In D128830#3745031 , @Michael137 wrote: > FYI, this broke the LLDB build bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46324/execution/node/74/log/ > > Looks like we're testing that inlined unused parameters

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aprantl added a comment. I think we can "fix" the test with the following patch: diff --git a/lldb/test/API/functionalities/unused-inlined-parameters/main.c b/lldb/test/API/functionalities/unused-inlined-parameters/main.c index f2ef5dcc213d..9b9f95f6c946 100644 --- a/lldb/test/API/function

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

sebastian-ne added a comment. The build afterwards succeeded again. Seems like every ~20th build on that windows machine fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson updated this revision to Diff 455258. arichardson marked 2 inline comments as done. arichardson added a comment. Herald added a project: All. rebase and address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108211/new/ https://

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson added a reviewer: tbaeder. arichardson added a comment. This is less useful now that 09117b21890c652994f7ada0229d309b35b44259 / D130894 has landed, but it might still be worth in

[PATCH] D131718: [HLSL] Add abs library function

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/abs.hlsl:20 + +// CHECK: define noundef double @"?abs_double@@YANN@Z"( +// CHECK: call double @llvm.fabs.f64(double %0) Is there a reason why we don't check the function parameter here, b

[PATCH] D131718: [HLSL] Add abs library function

bob80905 added inline comments. Comment at: clang/include/clang/Driver/Options.td:6130 MarshallingInfoFlag>, ImpliedByAnyOf<[fnative_half_arguments_and_returns.KeyPath]>; def fdefault_calling_conv_EQ : Joined<["-"], "fdefault-calling-conv=">, In Clang.cpp,

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. Whew, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D131718: [HLSL] Add abs library function

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6130 MarshallingInfoFlag>, ImpliedByAnyOf<[fnative_half_arguments_and_returns.KeyPath]>; def fdefault_calling_conv_EQ : Joined<["-"], "fdefault-calling-conv=">, bob80905 wrote:

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3740249 , @erichkeane wrote: > FWIW, while I wasn't able to reproduce the problem that @Mordante reported, I > found that the test suite as given has a large number of asserts in debug > mode while trying to compa

[clang] 74af56c - [Clang] Avoid using unwind library in the MSVC environment

Author: Petr Hosek Date: 2022-08-24T17:34:47Z New Revision: 74af56c1c342038d385134add13cd2a7db7f0a70 URL: https://github.com/llvm/llvm-project/commit/74af56c1c342038d385134add13cd2a7db7f0a70 DIFF: https://github.com/llvm/llvm-project/commit/74af56c1c342038d385134add13cd2a7db7f0a70.diff LOG: [C

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

phosek added a comment. In D132440#3744960 , @mstorsjo wrote: >> This reverts commit eca29d4a37b8d1c93fe99be6289a60bb11cf789d >> since >> the test fails in the per-target-runtime-dir

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

rjmccall added a comment. Seems okay to me, but like I said, it'd be good to get AA eyes on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132531: [AArch64] Reserve more physical registers

Carrot added a comment. I want to reserve most of the physical registers, so only a small number of registers can be used by register allocator. Then I can write small test cases to simulate high register pressure situation, it will be much easier to test and debug register allocation changes.

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3740536 , @erichkeane wrote: > For example, this enable-modules flag isn't covered by my local check-cxx, > which I went out of my way to run on this patch locally. Unfortunately there are a lot of different options

[PATCH] D131683: Diagnosing the Future Keywords

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:384 +C2X_KEYWORD(true, BOOLSUPPORT) +C2X_KEYWORD(remove_quals, KEYC2X) + Codesbyusman wrote: > aaron.ballman wrote: > > This is techn

[clang] 002bfdd - [clang][modules] Track affecting modules

Author: Jan Svoboda Date: 2022-08-24T11:09:50-07:00 New Revision: 002bfdd6b119e3543415971fbb219768fd96f86f URL: https://github.com/llvm/llvm-project/commit/002bfdd6b119e3543415971fbb219768fd96f86f DIFF: https://github.com/llvm/llvm-project/commit/002bfdd6b119e3543415971fbb219768fd96f86f.diff L

[PATCH] D132430: [clang][modules] Track affecting modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002bfdd6b119: [clang][modules] Track affecting modules (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D132430?vs=45

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

benlangmuir added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name == "Private" && -Module == Module->getTopLevelModule()) { +if (!Sub && Nam

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman added a subscriber: nickdesaulniers. aaron.ballman added a comment. Thank you for the patch, but it'd be really helpful to me as a reviewer if you and @nickdesaulniers could coordinate so there's only one patch trying to address #57102 instead of two competing patches (I'm happy to

[PATCH] D132531: [AArch64] Reserve more physical registers

efriedma added a comment. > A reserved physical register doesn't mean it can't be used by > compiler/linker, it just means it can't be used by register allocator, see > the comments in TargetRegisterInfo::getReservedRegs(). The target feature to "reserve" a register is meant to be "don't use th

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132538/new/ https://reviews.llvm.org/D132538

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

paquette added inline comments. Comment at: clang/test/Driver/mcmodel.c:9 // RUN: not %clang -c -mcmodel=lager %s 2>&1 | FileCheck --check-prefix=INVALID %s +// RUN: %clang -target aarch64 -### -c -mcmodel=medium %s 2>&1 | FileCheck --check-prefix=AARCH64-MEDIUM %s +// RUN: %c

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name == "Private" && -Module == Module->getTopLevelModule()) { +if (!Sub && Na

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name == "Private" && -Module == Module->getTopLevelModule()) { +if (!Sub && Na

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3745888 , @alexfh wrote: > The main questions we need to answer here are: > > 1. is the cost of storing parameter pack substitution indices while building > AST worth the benefits? > 2. is there an alternative solutio

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Thank you! I think all the invariants look right here; just some minor comments now, and then it should be ready to commit. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:403 + Builder.CreateStore(Val.second, ImagPtr, isVolatile); +} +

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir updated this revision to Diff 455315. benlangmuir added a comment. - Remove CompilerInvocation from Command and ModuleDeps. Only the arg strings are exposed now. - Simplify Command, which is now just a simple struct. - Move the logic for mutating the CompilerInvocation for the TU into

[PATCH] D132531: [AArch64] Reserve more physical registers

Carrot abandoned this revision. Carrot added a comment. Thanks for the clarification, I will propose another patch for my purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132531/new/ https://reviews.llvm.org/D132531 _

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir marked 11 inline comments as done. benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:44 + + enum CommandKind { +CK_CC1, tschuett wrote: > Why is this not an enum class? Removed

[PATCH] D132589: [HLSL] Add acos library function This change exposes the acos library function for HLSL scalar types, excluding long long doubles. Acos is supported for all scalar, vector, and matri

bob80905 created this revision. bob80905 added reviewers: beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...rt. Long long double support is missin

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added a comment. In D118511#3732200 , @tstellar wrote: > @dblaikie Can you file a bug and add the 15.0.0 Release Milestone, so we > don't forget to fix this in the release branch. Yeah, sorry about the delay on this, last week was a lot on my s

[PATCH] D132592: Clang] Implement function attribute nouwtable

ychen created this revision. ychen added reviewers: aaron.ballman, rnk, rsmith. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To have finer control of IR uwtable attribute generation. For target code ge

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Open comments notwithstanding, I'm happy with this patch. Thank you for working on this, it's a huge step towards getting more helpful diagnostics for C++! @aaron.ballman, @vaibhav.y, do you folks

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:265 + PointerSumTypeMember, + PointerSumTypeMember>, + PointerSumTypeMember> This fails on 32-bit architectures as `PointerEmbeddedInt` doesn't allow storing

[PATCH] D131625: [HLSL] Entry functions require param annotation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf1327fea63: [HLSL] Entry functions require param annotation (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bdf1327 - [HLSL] Entry functions require param annotation

Author: Chris Bieneman Date: 2022-08-24T14:35:11-05:00 New Revision: bdf1327fea632bf9736924acf59675182b528b23 URL: https://github.com/llvm/llvm-project/commit/bdf1327fea632bf9736924acf59675182b528b23 DIFF: https://github.com/llvm/llvm-project/commit/bdf1327fea632bf9736924acf59675182b528b23.diff

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie marked an inline comment as done. dblaikie added a comment. In D119051#3724121 , @rnk wrote: > Regarding the usage of isPOD in the MSVC ABI code, we should have a routine > similar to `isTrivialForAArch64MSVC` that works for the other MSVC > ar

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name

[PATCH] D132503: Add cxx scope if needed for requires clause.

luken-google added a comment. Note that the following tests: Builtins-i386-linux :: muldc3_test.c SanitizerCommon-asan-i386-Linux :: Linux/crypt_r.cpp SanitizerCommon-asan-i386-Linux :: Posix/crypt.cpp SanitizerCommon-lsan-i386-Linux :: Linux/crypt_r.cpp SanitizerCommon-lsan-i386-Linux

[PATCH] D131718: [HLSL] Add abs library function

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. LGTM. Make sure you update the description from saying that this doesn't handle half because of https://llvm.org/pr57100 to saying that it fixes the bug instead. Repository: rG LLVM Github

[PATCH] D132597: remove scalar types lld and ld from test since hlsl won't support them

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132597 Files: cl

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir updated this revision to Diff 455338. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132405/new/ https://reviews.llvm.org/D132405 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h clang/include/clang/Tooling/DependencyScanning/DependencyScannin

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 added a comment. In D131009#3744416 , @NoQ wrote: > Aha perfect, now the entire static analyzer knows how to work with these > regions! > > I have one tiny remark and I think we can commit. Thank you! I will make the change then directly c

[PATCH] D132589: [HLSL] Add acos library function

bob80905 updated this revision to Diff 455343. bob80905 added a comment. remove scalar types lld and ld from test since hlsl won't support them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132589/new/ https://reviews.llvm.org/D132589 Files: cla

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

xur created this revision. xur added reviewers: davidxl, tmsriram. Herald added a subscriber: wenlei. Herald added a project: All. xur requested review of this revision. Herald added a project: LLVM. This patch has the following changes: (1) Handling of internal linkage functions (static functions

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___ cfe-commits mailing list c

  1   2   >