[PATCH] D132805: [clang-format] Fix a bug in removing braces for the LLVM style

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132805/new/ https://reviews.llvm.org/D132805

[PATCH] D132805: [clang-format] Fix a bug in removing braces for the LLVM style

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When an

[PATCH] D132804: [clang-tidy] Add option to ignore CRTP overrides in convert-member-functions-to-static

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/convert-member-functions-to-static.rst:23 + warning will be emitted. Often occurs with CRTP like classes. + For the case below a warning would only be emitted for

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. In D132640#3753744 , @njames93 wrote: > LGTM, just with a small nit. @njames93 Thank you but I can not find your comment about nit. Would you like to check the comment one more time? Repository: rG LLVM Github Monorepo

[clang-tools-extra] 33b9304 - Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-08-27T21:21:00-07:00 New Revision: 33b93044352fae09376b7d71ce6f2441a34f343d URL: https://github.com/llvm/llvm-project/commit/33b93044352fae09376b7d71ce6f2441a34f343d DIFF: https://github.com/llvm/llvm-project/commit/33b93044352fae09376b7d71ce6f2441a34f343d.diff

[PATCH] D132804: [clang-tidy] Add option to ignore CRTP overrides in convert-member-functions-to-static

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, LegalizeAdulthood, JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132801 Files:

[PATCH] D132795: [clang-tidy] Tweak diagnostics for bugprone-assign-in-if-condition

This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rG32d88239ae65: [clang-tidy] Tweak diagnostics for bugprone-assign-in-if-condition (authored by njames93). Changed prior to commit:

[clang-tools-extra] 32d8823 - [clang-tidy] Tweak diagnostics for bugprone-assign-in-if-condition

Author: Nathan James Date: 2022-08-28T00:21:40+01:00 New Revision: 32d88239ae654239f16b516ee81ee9ff88b0ce07 URL: https://github.com/llvm/llvm-project/commit/32d88239ae654239f16b516ee81ee9ff88b0ce07 DIFF: https://github.com/llvm/llvm-project/commit/32d88239ae654239f16b516ee81ee9ff88b0ce07.diff

[clang] aa7ce60 - [Clang] Avoid crashes when parsing using enum declarations

Author: Shafik Yaghmour Date: 2022-08-27T15:18:36-07:00 New Revision: aa7ce60536a642e825d26d89b4a4347a36b63360 URL: https://github.com/llvm/llvm-project/commit/aa7ce60536a642e825d26d89b4a4347a36b63360 DIFF:

[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7ce60536a6: [Clang] Avoid crashes when parsing using enum declarations (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132795: [clang-tidy] Tweak diagnostics for bugprone-assign-in-if-condition

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/bugprone/AssignmentInIfConditionCheck.cpp:64 void AssignmentInIfConditionCheck::report(const Expr *MatchedDecl) { +

[clang] 44a06b5 - [clang-format] Rework removeBraces() in Format.cpp

Author: owenca Date: 2022-08-27T14:10:24-07:00 New Revision: 44a06b51b2ce2c75ec327902b7ddd1172e54bc8f URL: https://github.com/llvm/llvm-project/commit/44a06b51b2ce2c75ec327902b7ddd1172e54bc8f DIFF: https://github.com/llvm/llvm-project/commit/44a06b51b2ce2c75ec327902b7ddd1172e54bc8f.diff LOG:

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D132719: [clang-format] Rework removeBraces() in Format.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG44a06b51b2ce: [clang-format] Rework removeBraces() in Format.cpp (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132719/new/

[PATCH] D132719: [clang-format] Rework removeBraces() in Format.cpp

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1914 - assert(Token->isOneOf(tok::l_brace, tok::r_brace)); - assert(Token->Previous || Token == Line->First); - const FormatToken *Next = Token->Next; owenpan

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

njames93 added a comment. LGTM, just with a small nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132795: [clang-tidy] Tweak diagnostics for bugprone-assign-in-if-condition

njames93 updated this revision to Diff 456144. njames93 added a comment. Remove unnecessary includes added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132795/new/ https://reviews.llvm.org/D132795 Files:

[PATCH] D132795: [clang-tidy] Tweak diagnostics for bugprone-assign-in-if-condition

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, LegalizeAdulthood, dodohand. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa updated this revision to Diff 456142. yihanaa added a comment. Format code and recovery builtin-functions.cpp(Wrongly modified in the last update) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131979/new/ https://reviews.llvm.org/D131979

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

wlei added a comment. Hi @ahatanak This or its child diff broke our internal build, I saw it was reverted but the reapplied diff(https://github.com/llvm/llvm-project/commit/2e9df860468425645dcd1b241c5dbf76c072e314) still broke our build. see the log: (1)floatundidf.S.o : FAILED:

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa updated this revision to Diff 456140. yihanaa added a comment. Keep same behavior with current clang, don't emit an error when 1st arg is volatile qualified. Ignore the implicit cast from user-written-type to 'const void *' on the 1st arg, because CodeGen need user-written-type to

[clang-tools-extra] 2a0870c - [clang-tidy] Add missing header from 6bd98b4f2d

Author: Nathan James Date: 2022-08-27T19:59:16+01:00 New Revision: 2a0870c9d38d034b39d7cfa2a9929ff2819ecebd URL: https://github.com/llvm/llvm-project/commit/2a0870c9d38d034b39d7cfa2a9929ff2819ecebd DIFF: https://github.com/llvm/llvm-project/commit/2a0870c9d38d034b39d7cfa2a9929ff2819ecebd.diff

[PATCH] D132786: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bd98b4f2df0: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D132786?vs=456102=456139#toc

[clang-tools-extra] 6bd98b4 - [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

Author: Nathan James Date: 2022-08-27T19:55:08+01:00 New Revision: 6bd98b4f2df02955b72343038ecf20cdfd23e01e URL: https://github.com/llvm/llvm-project/commit/6bd98b4f2df02955b72343038ecf20cdfd23e01e DIFF: https://github.com/llvm/llvm-project/commit/6bd98b4f2df02955b72343038ecf20cdfd23e01e.diff

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3753662 , @davrec wrote: > Thanks for your work on this, and for explaining these complexities. TBH I still don't know what to do here from the project perspective. I have a new deadline now that runs until

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3753656 , @davrec wrote: > If I'm missing something and it is substantially more complex than that, then > you're right that storing the pack index might end up the best solution - we > don't want to e.g. have to do

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

davrec added a comment. In D128113#3753656 , @davrec wrote: > In D128113#3753640 , @mizvekov > wrote: > >> In D128113#3753624 , @davrec wrote: >> >>> Or just

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

davrec added a comment. In D128113#3753640 , @mizvekov wrote: > In D128113#3753624 , @davrec wrote: > >> Or just `SubstTemplateTypeParmType` could store this number in addition to >> its `TemplateTypeParmType`?

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3753624 , @davrec wrote: > Or just `SubstTemplateTypeParmType` could store this number in addition to > its `TemplateTypeParmType`? (E.g. the first Ts in an expansion is 0, the > second Ts in the same expansion is

[clang] 86bc458 - Use std::clamp (NFC)

Author: Kazu Hirata Date: 2022-08-27T09:53:13-07:00 New Revision: 86bc4587e1fdb7b1b90eadc138619f5e3f2dd6fd URL: https://github.com/llvm/llvm-project/commit/86bc4587e1fdb7b1b90eadc138619f5e3f2dd6fd DIFF: https://github.com/llvm/llvm-project/commit/86bc4587e1fdb7b1b90eadc138619f5e3f2dd6fd.diff

[clang] 21de288 - Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-08-27T09:53:11-07:00 New Revision: 21de2888a4b3bf60c68b6e507ed629b977ef5a0e URL: https://github.com/llvm/llvm-project/commit/21de2888a4b3bf60c68b6e507ed629b977ef5a0e DIFF: https://github.com/llvm/llvm-project/commit/21de2888a4b3bf60c68b6e507ed629b977ef5a0e.diff

[clang] a33ef8f - Use llvm::all_equal (NFC)

Author: Kazu Hirata Date: 2022-08-27T09:53:10-07:00 New Revision: a33ef8f2b7b28e4ae50a6e4fa206f82d3b230a68 URL: https://github.com/llvm/llvm-project/commit/a33ef8f2b7b28e4ae50a6e4fa206f82d3b230a68 DIFF: https://github.com/llvm/llvm-project/commit/a33ef8f2b7b28e4ae50a6e4fa206f82d3b230a68.diff

[PATCH] D132791: Fix formatting in release notes

aaronpuchert updated this revision to Diff 456131. aaronpuchert added a comment. Use links instead `:manpage:`, which is meant for man pages cross-referencing each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132791/new/

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

davrec added a comment. Great examples. > Check this example out: https://godbolt.org/z/rsGsM6GrM > > template struct A { > template struct B { > using type1 = void ((void (*...fps)(Ts, Us))); > }; > }; > using type2 = A::B::type1; > > TypeAliasDecl 0x55ffe8b45368

[PATCH] D132791: Fix formatting in release notes

aaronpuchert added a comment. This is for `release/15.x`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132791/new/ https://reviews.llvm.org/D132791 ___ cfe-commits mailing list

[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

shafik updated this revision to Diff 456128. shafik marked an inline comment as done. shafik added a comment. - Move `DS.SetTypeSpecError()` outside the `if` so that it is always called when the diagnostic is triggered. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132695/new/

[PATCH] D132791: Fix formatting in release notes

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, thieta, tstellar. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. aaronpuchert requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D131479: Handle explicitly defaulted consteval special members.

Mordante added a comment. In D131479#3753533 , @aaron.ballman wrote: > In D131479#3753462 , @Mordante > wrote: > >> This change breaks the libc++ test >>

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3753565 , @davrec wrote: > 2: After thinking about it further I don't think the pack index provides > sufficiently useful info in any case, since packs will always be expanded in > full, in order: when you find the

[clang] b9c2b60 - Avoid else-if after return, NFC

Author: Jun Zhang Date: 2022-08-27T23:14:48+08:00 New Revision: b9c2b6069ea7f3d253d88725c1993da463f39575 URL: https://github.com/llvm/llvm-project/commit/b9c2b6069ea7f3d253d88725c1993da463f39575 DIFF: https://github.com/llvm/llvm-project/commit/b9c2b6069ea7f3d253d88725c1993da463f39575.diff

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

davrec added a comment. Two last thoughts: 1: To reiterate it doesn't seem right to view this (or any patch adding not-semantically-relevant info to the AST) as a one-size-fits-all costs vs. benefits optimization. On the one hand, the additional AST info hurts compilation performance. On the

[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f84f1b2e92: [CodeGen] Track DeferredDecls that have been emitted (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a4f84f1 - [CodeGen] Track DeferredDecls that have been emitted

Author: Jun Zhang Date: 2022-08-27T22:32:47+08:00 New Revision: a4f84f1b2e92ea79b70b9961049a1af7d9e1f2fa URL: https://github.com/llvm/llvm-project/commit/a4f84f1b2e92ea79b70b9961049a1af7d9e1f2fa DIFF: https://github.com/llvm/llvm-project/commit/a4f84f1b2e92ea79b70b9961049a1af7d9e1f2fa.diff

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

isuckatcs added a comment. > I'm wondering if we should have a window for backward compatibility; There > are a couple of places already where we check for the presence of some > metadata and display it only if it exists. > Do you think it would be useful for this change as well? It has been

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added a comment. In D131479#3753462 , @Mordante wrote: > This change breaks the libc++ test > `libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/move.fail.cpp`. > >

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca updated this revision to Diff 456116. diseraluca added a comment. Fixed some typos in the added documentation of `clang_getUnqualifiedType`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132749/new/ https://reviews.llvm.org/D132749

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal added a comment. @ChuanqiXu Thanks a lot for this! We are currently implementing this module logic in the Bazel ruleset rules_ll . This page helps clarify the differences between clang modules and C++ modules a lot. If I knew about this earlier

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

tbaeder added inline comments. Comment at: clang/include/clang-c/Index.h:3775 + * + * Executing \c clang_getUnuqalifiedType() on a \c CXType that + * represents \c DifferenceType, will desugar to a type representing Typo: Unuqualified Comment

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 456111. inclyc added a comment. Delete extra newline. Currently this patch has not fully implemented `wchar_t` related support, this type seems to be even platform dependent in C language, if possible, maybe we can consider support in subsequent patches?

[PATCH] D131479: Handle explicitly defaulted consteval special members.

Mordante added a comment. This change breaks the libc++ test `libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/move.fail.cpp`. (https://buildkite.com/llvm-project/libcxx-ci/builds/13149#0182d0d4-341a-4b41-b67f-12937f41e6d5) Looking at the description of this patch it

[clang-tools-extra] 69c20a1 - [clang-tidy] Move bugprone-assignment-in-if-condition check to correct folder

Author: Nathan James Date: 2022-08-27T11:24:57+01:00 New Revision: 69c20a1f49aa5e19ed8ad291598caa1ec3b4d8f5 URL: https://github.com/llvm/llvm-project/commit/69c20a1f49aa5e19ed8ad291598caa1ec3b4d8f5 DIFF: https://github.com/llvm/llvm-project/commit/69c20a1f49aa5e19ed8ad291598caa1ec3b4d8f5.diff

[PATCH] D132786: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood, gribozavr2, dodohand. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca added a comment. In D132749#3752419 , @aaron.ballman wrote: > > Welcome to the community! Thank you for the kind welcome! > Feel free to put up a new review for that and add me as a reviewer, I'm happy > to look at it Thank you, I'll be

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca updated this revision to Diff 456099. diseraluca added a comment. Added a note to the release-notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132749/new/ https://reviews.llvm.org/D132749 Files: clang/docs/ReleaseNotes.rst

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-pointer-as-values.cpp:27-30 + for (const int *p_local1 : p_local0) { + // CHECK-MESSAGES: [[@LINE-1]]:8: warning: variable 'p_local1' of type 'const int *' can be

[clang] b831af5 - [libTooling] Simplify code with constexpr if. NFCI.

Author: Benjamin Kramer Date: 2022-08-27T10:50:06+02:00 New Revision: b831af51977b4150763d69a26a2d912459c1114d URL: https://github.com/llvm/llvm-project/commit/b831af51977b4150763d69a26a2d912459c1114d DIFF:

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. In D131979#3752208 , @rjmccall wrote: > From the test case, it looks like the builtin just ignores pointers to > volatile types, which should be preserved by the conversions you're now doing > in Sema. That is, you should be

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @aeubanks Thank you for the investigation! I believe this patch can be re-landed after D132764 is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/