[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

tejohnson added a comment. In D131306#3756074 , @paulkirth wrote: > In D131306#3756009 , @tejohnson > wrote: > >> @davidxl @xur for review and thoughts. >> >> I'm a little wary of requiring that both pieces of

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. @manas Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132791: Fix formatting in release notes

aaronpuchert added a comment. The documentation build (`docs-{llvm,clang}-{html,man}`) is fine after this, in fact it fixes: Warning, treated as error: [...]/build/tools/clang/docs/ReleaseNotes.rst:632:Bullet list ends without a blank line; unexpected unindent. by adding some indentation.

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. In D131306#3756009 , @tejohnson wrote: > @davidxl @xur for review and thoughts. > > I'm a little wary of requiring that both pieces of metadata be carried > together, as that seems very brittle to maintain in the compiler.

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

rymiel updated this revision to Diff 456402. rymiel added a comment. Add a few token annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM with one comment on the test. Comment at: clang/test/Driver/ps4-ps5-linker-jmc.c:1 +// REQUIRES: x86-registered-target + This REQUIRES is not

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. In D131979#3756006 , @rjmccall wrote: > In D131979#3753358 , @yihanaa wrote: > >> In D131979#3752208 , @rjmccall >> wrote: >> >>> From the test

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. All review comments have been addressed. I assume this can be merged now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 ___

[clang] 2d66571 - [Driver] Fix & re-enable DriverKit test

Author: Julian Lettner Date: 2022-08-29T10:27:04-07:00 New Revision: 2d66571729a2ffcd88398a77508b0d6432ed7ba0 URL: https://github.com/llvm/llvm-project/commit/2d66571729a2ffcd88398a77508b0d6432ed7ba0 DIFF:

[PATCH] D131820: [PS4][driver] make -fjmc work with LTO driver linking stage

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131820/new/ https://reviews.llvm.org/D131820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

tejohnson added subscribers: xur, davidxl. tejohnson added a comment. @davidxl @xur for review and thoughts. I'm a little wary of requiring that both pieces of metadata be carried together, as that seems very brittle to maintain in the compiler. What would happen if the MD_expected didn't get

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added a comment. In D131979#3753358 , @yihanaa wrote: > In D131979#3752208 , @rjmccall > wrote: > >> From the test case, it looks like the builtin just ignores pointers to >> volatile types, which

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. pin～ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131979/new/ https://reviews.llvm.org/D131979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding a few more reviewers for better opinions, but the changes look reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132848/new/

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

rnk added a comment. (I added @maskray based on the new code ownership structure proposed here: https://discourse.llvm.org/t/rfc-proposed-changes-to-clangs-code-ownership/64813) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132810/new/

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

rnk added a comment. +@maskray, should we use `-mguard=` as the GCC spelling of the MSVC `/GUARD:` flag? Short flags are nice, but it seems there may be a risk of GCC using `-mguard=` for something else at some point. I lean towards using `-mguard=` as is. Repository: rG LLVM Github

[PATCH] D132379: [Support] Class for response file expansion

sepavloff updated this revision to Diff 456396. sepavloff added a comment. Move change for VFS support into separate patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 Files:

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

MaskRay accepted this revision. MaskRay added a comment. Herald added a subscriber: StephenFan. I sometimes need to debug builds by disabling modules. This behavior will make debugging easier. Comment at: clang/test/Driver/modules.m:81 // RUN: %clang -fno-modules

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM presuming precommit CI comes back green, but please don't forget the release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132821/new/ https://reviews.llvm.org/D132821

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff created this revision. sepavloff added reviewers: rjmccall, kadircet, sammccall. Herald added a subscriber: hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added projects: clang, LLVM. Clang has

[clang-tools-extra] a11ec00 - FoldingRanges: Handle LineFoldingsOnly clients.

Author: Utkarsh Saxena Date: 2022-08-29T19:03:48+02:00 New Revision: a11ec00afea327419ec1ab7c78ba6818d6c5bbf7 URL: https://github.com/llvm/llvm-project/commit/a11ec00afea327419ec1ab7c78ba6818d6c5bbf7 DIFF:

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa11ec00afea3: FoldingRanges: Handle LineFoldingsOnly clients. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/

[PATCH] D132833: [clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type

This revision was automatically updated to reflect the committed changes. Closed by commit rG9af0a142e436: [clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9af0a14 - [clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type

Author: Nathan Ridge Date: 2022-08-29T12:59:05-04:00 New Revision: 9af0a142e43625cb8478b83692510a5abd39f808 URL: https://github.com/llvm/llvm-project/commit/9af0a142e43625cb8478b83692510a5abd39f808 DIFF: https://github.com/llvm/llvm-project/commit/9af0a142e43625cb8478b83692510a5abd39f808.diff

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder updated this revision to Diff 456389. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132821/new/ https://reviews.llvm.org/D132821 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Parser/cxx-concept-declaration.cpp

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman added a comment. In D132727#3755843 , @tbaeder wrote: > In D132727#3755571 , @aaron.ballman > wrote: > >> Precommit CI found a relevant failure: > > That needs the lvalue-to-rvalue conversion patch

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 456387. python3kgae added a comment. Fix format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/include/clang/Sema/HLSLExternalSemaSource.h

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

jhuber6 abandoned this revision. jhuber6 added a comment. In D131639#3755866 , @jdoerfert wrote: > I think the code as is upstream is fine. The test input is problematic. There > is no guarantee, or even any argument, that stdbool is not included by the

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} tbaeder wrote: > erichkeane wrote: > > Is there nothing special that has to

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

aaron.ballman added a comment. Can you add some more details to the patch summary about what this is fixing? Also, should this have a release note? Documentation changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132853/new/

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. I think the code as is upstream is fine. The test input is problematic. There is no guarantee, or even any argument, that stdbool is not included by the compiler or any header

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Thanks for looking into this so quickly. LGTM with Aaron's suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132821/new/

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder added a comment. In D132727#3755571 , @aaron.ballman wrote: > Precommit CI found a relevant failure: That needs the lvalue-to-rvalue conversion patch first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder updated this revision to Diff 456376. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llvm.org/D132727 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

aaron.ballman added a comment. Please be sure to add a release note for the fix as well. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:776-779 "identifier followed by '<' indicates a class template specialization but " "%0 %select{does not refer to a

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} erichkeane wrote: > Is there nothing special that has to happen when these are

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

erichkeane accepted this revision. erichkeane added a comment. Still LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132851/new/ https://reviews.llvm.org/D132851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3753290 , @tbaeder wrote: > In D132136#3751702 , @erichkeane > wrote: > >> Would be great if we had a better test here... is there anything we can do >> to validate

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman updated this revision to Diff 456366. aaron.ballman added a comment. Update based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132851/new/ https://reviews.llvm.org/D132851 Files: clang/docs/ReleaseNotes.rst

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. In D131639#3749633 , @jhuber6 wrote: > I think it's perfectly reasonable to include system files as part of a > toolchain. I think it comes down to a matter of inconveniencing the user versus the developer. We

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} Is there nothing special that has to happen when these are reference

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:493 + if (auto DS = dyn_cast_or_null(Item.getStmtOrNull())) { +if (auto VD = dyn_cast_or_null(DS->getSingleDecl())) + E = dyn_cast(VD->getInit()); Hmm, when we

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske added a reviewer: martong. balazske added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:537 + errno_modeling::getNoteTagForStdSuccess( + C,

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132832/new/ https://reviews.llvm.org/D132832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132831/new/ https://reviews.llvm.org/D132831

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 nits, otherwise LGTM. Comment at: clang/lib/Sema/SemaChecking.cpp:13080 - S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) -<< PrettyValue <<

[PATCH] D132745: [clang] Fix ambiguous use of `report_fatal_error`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd346eb7bf08c: [clang] Fix ambiguous use of `report_fatal_error`. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132745/new/

[clang] d346eb7 - [clang] Fix ambiguous use of `report_fatal_error`.

Author: Wei Yi Tee Date: 2022-08-29T15:32:49Z New Revision: d346eb7bf08c7780bb80426eabc6b5f81490e9ae URL: https://github.com/llvm/llvm-project/commit/d346eb7bf08c7780bb80426eabc6b5f81490e9ae DIFF: https://github.com/llvm/llvm-project/commit/d346eb7bf08c7780bb80426eabc6b5f81490e9ae.diff LOG:

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:779 + "|refers to a variable template||refers to a concept|" + "refers to a concept template}1">; def err_id_after_template_in_nested_name_spec : Error< cjdb wrote: >

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto : C.getJobs()) { dongjunduo wrote: > Whitney wrote: > > Do you mean Add or replace the modified

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:779 + "|refers to a variable template||refers to a concept|" + "refers to a concept template}1">; def err_id_after_template_in_nested_name_spec : Error< Is "concept

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

aaron.ballman added a comment. > I don't have a test case handy for them since I'm not sure how to trigger > them reliably, but they are easy enough to implement and I ran into them > while working on array fillers. I think we should have test coverage for this if possible.

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman added a comment. Precommit CI found a relevant failure: FAIL: Clang :: AST/Interp/arrays.cpp (67 of 15858) TEST 'Clang :: AST/Interp/arrays.cpp' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. I like the direction this is going; I ran into some questions on the tests about whether we should use a range or not and other small things, but I think this is getting close. Comment at: clang/test/CXX/temp/temp.res/temp.local/p3.cpp:2 +//

[PATCH] D132786: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

njames93 added a comment. In D132786#3755390 , @dodohand wrote: > IMO you have just introduced a bug, not fixed one. > A lambda expression in an if statement condition clause is exactly the kind > of thing that this checker was designed to flag. > The

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

serge-sans-paille created this revision. serge-sans-paille added reviewers: sberg, kees. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman updated this revision to Diff 456343. aaron.ballman added a comment. Added a test case for `true` in C++, and added similar logic for C to reduce the chance for false positives. If the user uses `true` (the macro from stdbool.h), they're signaling an intent that the field is used

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder added inline comments. Comment at: clang/test/Parser/cxx-concept-declaration.cpp:3 // Support parsing of concepts // Disabled for now. I guess we can drop these two lines now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123630: [WIP] Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 456337. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

erichkeane added a comment. LGTM, questioning whether we want to do some macro introspection in C mode (as the CORRECT way to use these 1 bit-bitfields is as a bool), but at least this gives the person the ability to disable this warning. Comment at:

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456335. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files:

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. In D131939#3755399 , @Eugene.Zelenko wrote: > I got notification. Thank you. I got an email for this message but not my own updates, which usually also CC me 路. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added a comment. In D131255#3729304 , @aaron.ballman wrote: > After some more thought and some offline discussions, I think I have a > reasonable way forward: let's add `-Wsingle-bit-bitfield-constant-conversion` > as a new warning group

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman created this revision. aaron.ballman added reviewers: ShawnZhong, thakis, clang-language-wg, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. https://reviews.llvm.org/D131255

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

Eugene.Zelenko added a comment. I got notification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. I feel like Phabricator is not sending notifications for this patch like it usually does (I'm not getting any emails). I'll create a new, identical patch tomorrow if there's still no activity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132786: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

dodohand added a comment. IMO you have just introduced a bug, not fixed one. A lambda expression in an if statement condition clause is exactly the kind of thing that this checker was designed to flag. The BARR group coding guideline, with which this is intended to comply in spirit, makes no

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

tbaeder updated this revision to Diff 456328. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132832/new/ https://reviews.llvm.org/D132832 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:245 + +if (!Init) + return false; erichkeane wrote: > Would be nice to test this before the work to allocate Offset? Ah, sure. Good catch. CHANGES SINCE LAST ACTION

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK:

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

JonasToth added a comment. just my 2 cents Comment at: clang-tools-extra/clang-tidy/readability/UseEarlyExitsCheck.cpp:66 + if (needsParensAfterUnaryNegation(Condition)) { +Diag << FixItHint::CreateInsertion(Condition->getBeginLoc(), "!(") + <<

[clang] b345be1 - Make this test slightly less fragile; NFC

Author: Aaron Ballman Date: 2022-08-29T09:41:23-04:00 New Revision: b345be177d03166add391f090fd0288a23413934 URL: https://github.com/llvm/llvm-project/commit/b345be177d03166add391f090fd0288a23413934 DIFF: https://github.com/llvm/llvm-project/commit/b345be177d03166add391f090fd0288a23413934.diff

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:245 + +if (!Init) + return false; Would be nice to test this before the work to allocate Offset? Comment at: clang/lib/AST/Interp/Function.h:163 +

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

nikic added a comment. Okay, this is a bit tricky because we have three different things: 1. The noread_thread_id attribute, the lack of which was causing issues with intrinsics in the previous version 2. The meaning of the readnone (etc) attributes, which for pragmatic reasons has to exclude

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I assume we're going to see more patches in the future in this space as you discover examples/tests for this, but in order to unblock other tests, this is good enough for now.

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. pin~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131979/new/ https://reviews.llvm.org/D131979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

uabelho added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK:

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:254 +// Remove the ending sentinal "*/" from the block comment range. +if (Code.substr(EndOffset(*LastComment) - 2, 2) == "*/") { + End.character -= 2; this

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

erichkeane added a comment. just a pair of minor changes I'd like to see, otherwise this LGTM. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E,

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt updated this revision to Diff 456323. wyt marked an inline comment as done. wyt added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132763/new/ https://reviews.llvm.org/D132763 Files:

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456321. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files:

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

mstorsjo created this revision. mstorsjo added a reviewer: aaron.ballman. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. We shouldn't just check the clang options, we also should check `Triple::hasDefaultEmulatedTLS()`. This doesn't make

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added a comment. In D131479#3753586 , @Mordante wrote: > In D131479#3753533 , @aaron.ballman > wrote: > >> In D131479#3753462 , @Mordante >> wrote: >> >>>

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:302 +AnnotationStates.insert({It->second, StateT{*Lattice, State.Env}}); +assert(InsertSuccess); }; Please add

[PATCH] D132791: Fix formatting in release notes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! I did not test building the docs, but the changes all look correct based on my experience with RST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132791/new/

[PATCH] D132756: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

wyt updated this revision to Diff 456317. wyt marked 2 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132756/new/ https://reviews.llvm.org/D132756 Files:

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG123062ec2f3e: Expose QualType::getUnqualifiedType in libclang (authored by diseraluca, committed by aaron.ballman). Repository: rG LLVM Github

[clang] 123062e - Expose QualType::getUnqualifiedType in libclang

Author: Luca Di Sera Date: 2022-08-29T08:16:18-04:00 New Revision: 123062ec2f3e45bb1614a63bcb79c22527d9b914 URL: https://github.com/llvm/llvm-project/commit/123062ec2f3e45bb1614a63bcb79c22527d9b914 DIFF: https://github.com/llvm/llvm-project/commit/123062ec2f3e45bb1614a63bcb79c22527d9b914.diff

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note for the new attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/

[PATCH] D131475: [Flang] Use find_program() to find clang-tblgen

awarzynski added a comment. Thanks for the quick fix, makes sense!  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131475/new/ https://reviews.llvm.org/D131475 ___ cfe-commits mailing list

[PATCH] D132745: [clang] Fix ambiguous use of `report_fatal_error`.

wyt updated this revision to Diff 456311. wyt marked an inline comment as done. wyt added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132745/new/ https://reviews.llvm.org/D132745 Files:

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:363-365 +std::sort(AnnotationStatesAsVector.begin(), + AnnotationStatesAsVector.end(), + [](auto a, auto b) { return a.first < b.first; });

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt updated this revision to Diff 456308. wyt marked 6 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132763/new/ https://reviews.llvm.org/D132763 Files:

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:88 +/// Arguments for building the dataflow analysis. +template struct AnalysisInputs { + /// Input code that is analyzed. sgatev wrote: > Why move this? It makes it

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt updated this revision to Diff 456307. wyt marked an inline comment as done. wyt added a comment. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/ https://reviews.llvm.org/D132377 Files:

<    1   2   3   >