[clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

Author: Kazu Hirata Date: 2022-09-03T23:27:27-07:00 New Revision: b7a7aeee90cffefd0f73b8d9f44ab4d1d5123d05 URL: https://github.com/llvm/llvm-project/commit/b7a7aeee90cffefd0f73b8d9f44ab4d1d5123d05 DIFF: https://github.com/llvm/llvm-project/commit/b7a7aeee90cffefd0f73b8d9f44ab4d1d5123d05.diff L

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder updated this revision to Diff 457838. tbaeder added a comment. Add a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132136/new/ https://reviews.llvm.org/D132136 Files: clang/lib/AST/ExprConstant.cpp clang/test/AST/Interp/literals.cpp clang/unittests/AST/Evaluate

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir added a comment. In D132975#3768391 , @tschuett wrote: > Will there be eventually a way to build a fully optimised clang/lld with > ThinLTO, PGO, and Bolt? Short answer is likely yes. For clang, I think this diff should be compatible with PGO, with

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. In D132136#3766958 , @aaron.ballman wrote: > On the one hand, I'm not comfortable landing this without adequate testing, > especially because you want to build more stuff on top of it. I think we need > to make sure the foundat

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

MaskRay abandoned this revision. MaskRay added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. Abandon since we decide to try using normalized target triple and just hard code the Debian multiarch (omitted 'vendor') in few places. Repository: rG LLVM Github Mono

[clang] 83ea47a - [test] Make tests pass regardless of gnu++14/gnu++17 default

Author: Fangrui Song Date: 2022-09-04T05:29:32Z New Revision: 83ea47acd7116bf50274534ba9b3bd3035c01da6 URL: https://github.com/llvm/llvm-project/commit/83ea47acd7116bf50274534ba9b3bd3035c01da6 DIFF: https://github.com/llvm/llvm-project/commit/83ea47acd7116bf50274534ba9b3bd3035c01da6.diff LOG:

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83ea47acd711: [test] Make tests pass regardless of gnu++14/gnu++17 default (authored by MaskRay). Changed prior to commit: https://reviews.llvm.or

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

MaskRay created this revision. MaskRay added reviewers: mstorsjo, mati865, rnk. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. dllimport/dllexport is incompatible

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a subscriber: sunho. v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/ASTConsumer.h:54-59 + /// HandleTopLevelStmts - Handle the specified top-level statements. This is + /// called by the parser to process every top-level Stmt* in incr

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 457830. v.g.vassilev marked 9 inline comments as done. v.g.vassilev added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsume

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mizvekov added inline comments. Comment at: libcxx/docs/Contributing.rst:164-165 + + When this buld fails with an LLVM assertion, the crash diagnostics are + available as an artifact. + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 457829. felix642 added a comment. Fixed compilation issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 Files: clang-tools-extra/clang-tidy/readability/Containe

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146 + + The check now skips containers that are defined in the option IgnoredContainers. The default value is ::std::array. + Please highlight option name and value with

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 457828. felix642 added a comment. + Added test case and updated ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 Files: clang-tools-extra/clang-tidy/re

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

Passw added a comment. I do not have commit access, please help to commit this change. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov added a comment. In D133262#3768883 , @royjacobson wrote: > There are some known bugs about how we handle this built-in in the AST- > #42102, #51928, #54993. Is it possible that your patch solves them? It would > be great if it does, I hit one

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

royjacobson added a comment. There are some known bugs about how we handle this built-in in the AST- #42102, #51928, #54993. Is it possible that your patch solves them? It would be great if it does, I hit one of them in the wild a while back. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 457819. mizvekov marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133072/new/ https://reviews.llvm.org/D133072 Files: clang/lib/AST

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov updated this revision to Diff 457818. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/lib/Driver/Driver.cpp clang/test/Dr

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov updated this revision to Diff 457817. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTemplate.h clang/lib/AST/ASTConte

[PATCH] D133157: Add -sanitizer-coverage-control-flow

MaskRay added a comment. > Add -sanitizer-coverage-control-flow Add -fsanitizer-coverage=control-flow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 ___ cfe-c

[PATCH] D133157: Add -sanitizer-coverage-control-flow

MaskRay added inline comments. Comment at: clang/docs/SanitizerCoverage.rst:338 + +With ``-fsanitize-coverage=control-flow`` the compiler will create a table to collect +control flow for each function. More specifically, for each basic block in the function, Th

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov updated this revision to Diff 457816. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Fil

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We change the template specialization of __make_integer_seq to be an alias t

[PATCH] D133261: NFC: [clang] add template substitution AST test for make_integer_seq

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D133072 Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Mono

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mstorsjo added inline comments. Comment at: clang/www/hacking.html:302 + + For most builds, the pre-commit CI uses a recent + https://apt.llvm.org/";>nightly build of Clang from LLVM's main I'm wondering if there's a better synonym for "builds" here which would

[clang] 9905dae - Revert "[Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type"

Author: Vitaly Buka Date: 2022-09-03T13:12:49-07:00 New Revision: 9905dae5e18cd55ee6bb8678c95fed940ded1ef9 URL: https://github.com/llvm/llvm-project/commit/9905dae5e18cd55ee6bb8678c95fed940ded1ef9 DIFF: https://github.com/llvm/llvm-project/commit/9905dae5e18cd55ee6bb8678c95fed940ded1ef9.diff L

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

HazardyKnusperkeks added a subscriber: tstellar. HazardyKnusperkeks added a comment. You have to ask @tstellar to cherry-pick it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131750/new/ https://reviews.llvm.org/D131750 __

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

steven_wu added a comment. In D131469#3768500 , @dongjunduo wrote: > These related commits have been reverted temporarily. Thanks. Another way to do this is that as you don't really care what linker does in this test case, you just need to fake a linke

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

vitalybuka added a comment. Broken by the patch https://lab.llvm.org/buildbot/#/builders/127/builds/35304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 ___ cf

[clang] 89df4e4 - [Driver] Remove unused -Ttext -Tdata -Tbss

Author: Fangrui Song Date: 2022-09-03T10:57:29-07:00 New Revision: 89df4e4825ee6136bebbe5f70de29eb80456aaa4 URL: https://github.com/llvm/llvm-project/commit/89df4e4825ee6136bebbe5f70de29eb80456aaa4 DIFF: https://github.com/llvm/llvm-project/commit/89df4e4825ee6136bebbe5f70de29eb80456aaa4.diff

[clang] a2ef765 - [Driver] Change some cc1 only JoinedOrSeparate long options to Separate

Author: Fangrui Song Date: 2022-09-03T10:45:30-07:00 New Revision: a2ef7654ec2e907f84a876b1cf5d37fc87754de7 URL: https://github.com/llvm/llvm-project/commit/a2ef7654ec2e907f84a876b1cf5d37fc87754de7 DIFF: https://github.com/llvm/llvm-project/commit/a2ef7654ec2e907f84a876b1cf5d37fc87754de7.diff

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

jackhong12 added a comment. Is there any chance we also add this patch to version 15? https://github.com/llvm/llvm-project/issues/57534#issuecomment-1236132578 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131750/new/ https://reviews.llvm.org/D131

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad2fe913ae0: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array… (authored by yronglin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 3ad2fe9 - [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

Author: yronglin Date: 2022-09-03T23:26:01+08:00 New Revision: 3ad2fe913ae08ca062105731ad2da2eae825c731 URL: https://github.com/llvm/llvm-project/commit/3ad2fe913ae08ca062105731ad2da2eae825c731 DIFF: https://github.com/llvm/llvm-project/commit/3ad2fe913ae08ca062105731ad2da2eae825c731.diff LOG:

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added inline comments. Comment at: flang/runtime/environment.cpp:77 +#else + envp = environ; +#endif What is `environ` used for? Should we try to keep as less extern variable as possible in runtime for security. Comment at: flang/test/

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

Eugene.Zelenko added a comment. Please mention changes in Release Notes and add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 ___ cfe-commits maili

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

mizvekov added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp:310-316 +namespace GH57362 { +template +class TemplateClass {}; + +template // ok, no diagnostic expected +void func() {} +} I think the issue might not be tested in

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

melver added inline comments. Comment at: clang/test/Driver/fsanitize-metadata.c:1 +// RUN: %clang --target=x86_64-linux-gnu -fexperimental-sanitize-metadata=all -fno-experimental-sanitize-metadata=all %s -### 2>&1 | FileCheck %s +// CHECK-NOT: -fexperimental-sanitize-metadata -

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

melver updated this revision to Diff 457779. melver marked 3 inline comments as done. melver added a comment. - Options.td: s/f_clang_Group/f_Group/, remove NoXarchOption - Driver test: also test -fexperimental-sanitize-metadata=all -fno-experimental-metadata= Repository: rG LLVM Github Monor

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. These related commits have been reverted temporarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 ___ cfe-commits mailing list c

[clang] 5e4f69e - Revert "[Clang] change default storing path of `-ftime-trace`"

Author: Junduo Dong Date: 2022-09-03T01:38:37-07:00 New Revision: 5e4f69edbc1e36c47c62a2c522e9a8a6e7b86d06 URL: https://github.com/llvm/llvm-project/commit/5e4f69edbc1e36c47c62a2c522e9a8a6e7b86d06 DIFF: https://github.com/llvm/llvm-project/commit/5e4f69edbc1e36c47c62a2c522e9a8a6e7b86d06.diff L

[clang] 4ff2250 - Revert "[driver][clang] remove the check-time-trace test on the platform "PS4/PS5/Hexagon""

Author: Junduo Dong Date: 2022-09-03T01:37:55-07:00 New Revision: 4ff2250a22ed651facf6dad8f379a3fd24a8f6b1 URL: https://github.com/llvm/llvm-project/commit/4ff2250a22ed651facf6dad8f379a3fd24a8f6b1 DIFF: https://github.com/llvm/llvm-project/commit/4ff2250a22ed651facf6dad8f379a3fd24a8f6b1.diff L

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante created this revision. Mordante added reviewers: aaron.ballman, ldionne. Herald added subscribers: mstorsjo, arphaman. Herald added a project: All. Mordante requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Heral

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:13 +/// currently evaluate other parts of it. +#if 0 +struct fred { aaron.ballman wrote: > I wish we could find some solution that didn't requi

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder updated this revision to Diff 457767. tbaeder marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llvm.org/D132727 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tbaeder updated this revision to Diff 457766. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132831/new/ https://reviews.llvm.org/D132831 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I