[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

khchen added a comment. > Possible solution/results: > > 1. All functions in `a.o` and `b.o` using same target features during the > first build stage, `-march=rv64gc` for a.o, `-march=rv64g` for `b.o`, and > `-march` option given in LTO CodeGen stage is ignored, it only used for ELF >

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

akyrtzi marked 4 inline comments as done. akyrtzi added a comment. @benlangmuir see latest diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133357/new/ https://reviews.llvm.org/D133357 ___

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

akyrtzi updated this revision to Diff 458360. akyrtzi added a comment. Always print `tokens_present_before_eof` and print it as "" for clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133357/new/ https://reviews.llvm.org/D133357 Files:

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

mgorny added a comment. In D133358#3773210 , @MaskRay wrote: > Python 3.7 can use `subprocess.run` with `capture_output`: > https://docs.python.org/3/library/subprocess.html#:~:text=capture_output Well, if you wanted to avoid calling

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea953b9d9a65: [compiler-rt] [test] Handle missing ld.gold gracefully (authored by mgorny). Herald added a project: Sanitizers. Herald added a

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#3755056 , @lewis-revill wrote: > I believe this patch is still relevant/necessary when using LTO for RISCV, so > can I ask if @khchen is able to update it to rebase/address the feedback? If > not, are there are any

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 added a comment. Also @aaron.ballman said me that he was thinking about maybe adding an extension to add support for `auto` in a function return or in a parameter list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:807 << "-fsanitize-coverage=[func|bb|edge]" -<< "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace-pc]"; +<<

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 458358. to268 added a comment. I've added a test case with scopes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/lib/Parse/ParseDecl.cpp

[clang] 4c18670 - [NFC][sancov] Rename ModuleSanitizerCoveragePass

Author: Vitaly Buka Date: 2022-09-06T20:55:39-07:00 New Revision: 4c18670776cd6ac31099a455b2b22b38b0408006 URL: https://github.com/llvm/llvm-project/commit/4c18670776cd6ac31099a455b2b22b38b0408006 DIFF: https://github.com/llvm/llvm-project/commit/4c18670776cd6ac31099a455b2b22b38b0408006.diff

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added a comment. Hello, thanks, I appreciate that you found it helpful! It's pretty late for me now, I will give this another look tomorrow. Comment at: clang/include/clang/Sema/SemaConcept.h:48-52 + if (ArgA.getKind() == TemplateArgument::Expression && +

[clang] 5e38b2a - [NFC][msan] Rename ModuleMemorySanitizerPass

Author: Vitaly Buka Date: 2022-09-06T20:30:35-07:00 New Revision: 5e38b2a456df6e263a509af60a731cec57310498 URL: https://github.com/llvm/llvm-project/commit/5e38b2a456df6e263a509af60a731cec57310498 DIFF: https://github.com/llvm/llvm-project/commit/5e38b2a456df6e263a509af60a731cec57310498.diff

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

raj.khem added a comment. In D71387#3755056 , @lewis-revill wrote: > I believe this patch is still relevant/necessary when using LTO for RISCV, so > can I ask if @khchen is able to update it to rebase/address the feedback? If > not, are there are any

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen marked 4 inline comments as done. ychen added a comment. @mizvekov thanks for the detailed review. It helped me a lot in reconsidering the auto type handling. Comment at: clang/include/clang/Sema/SemaConcept.h:48-52 + if (ArgA.getKind() ==

[PATCH] D133308: [cmake] do not set execution permission to regular files

This revision was automatically updated to reflect the committed changes. Closed by commit rG73593145cb5b: [cmake] do not set execution permission to regular files. (authored by sinan, committed by Lin Sinan linsinan@alibaba-inc.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 7359314 - [cmake] do not set execution permission to regular files.

Author: Sinan Lin Date: 2022-09-07T11:04:12+08:00 New Revision: 73593145cb5b6bbb474e2c53153aabdb362731d5 URL: https://github.com/llvm/llvm-project/commit/73593145cb5b6bbb474e2c53153aabdb362731d5 DIFF: https://github.com/llvm/llvm-project/commit/73593145cb5b6bbb474e2c53153aabdb362731d5.diff

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:688 +auto = getContext(); +auto SizeTy = Context.getSizeType(); +auto T = Builder.getIntNTy(Context.getTypeSize(SizeTy));

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu updated this revision to Diff 458353. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133341/new/ https://reviews.llvm.org/D133341 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst

[clang] 5f571ee - [NFC] [Frontend] Correct the use of 'auto' in SemaCoroutine and CGCoroutine

Author: Chuanqi Xu Date: 2022-09-07T10:45:01+08:00 New Revision: 5f571eeb3f764c6d97b81822464ea420adef2cf7 URL: https://github.com/llvm/llvm-project/commit/5f571eeb3f764c6d97b81822464ea420adef2cf7 DIFF: https://github.com/llvm/llvm-project/commit/5f571eeb3f764c6d97b81822464ea420adef2cf7.diff

[clang] 7354a73 - [CUDA] Actually fix the test correctly this time

Author: Joseph Huber Date: 2022-09-06T20:31:27-05:00 New Revision: 7354a73945f1c123d66b01f51374ecbdba18fab3 URL: https://github.com/llvm/llvm-project/commit/7354a73945f1c123d66b01f51374ecbdba18fab3 DIFF: https://github.com/llvm/llvm-project/commit/7354a73945f1c123d66b01f51374ecbdba18fab3.diff

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

fmayer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:60 + // gadgets. + if (G.getName().startswith("llvm.") || G.isThreadLocal() || G.isConstant()) { +Meta.Memtag = false; not necessarily in this CL: do we want some

[clang] a6bb7c2 - [CUDA] Fix test failing when using the new driver

Author: Joseph Huber Date: 2022-09-06T20:14:20-05:00 New Revision: a6bb7c22fc288686010076ac253a12b4b1cd2ee5 URL: https://github.com/llvm/llvm-project/commit/a6bb7c22fc288686010076ac253a12b4b1cd2ee5 DIFF: https://github.com/llvm/llvm-project/commit/a6bb7c22fc288686010076ac253a12b4b1cd2ee5.diff

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim created this revision. hctim added reviewers: fmayer, eugenis. Herald added subscribers: hiraditya, kristof.beyls, mgorny. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adds the

[clang] 2753eaf - [Clang] Fix the new driver crashing when using '-fsyntax-only'

Author: Joseph Huber Date: 2022-09-06T19:49:47-05:00 New Revision: 2753eafe5a7f003776b12f425c5b0a475e8fb6b7 URL: https://github.com/llvm/llvm-project/commit/2753eafe5a7f003776b12f425c5b0a475e8fb6b7 DIFF: https://github.com/llvm/llvm-project/commit/2753eafe5a7f003776b12f425c5b0a475e8fb6b7.diff

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2753eafe5a7f: [Clang] Fix the new driver crashing when using -fsyntax-only (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D133161?vs=457419=458332#toc Repository: rG LLVM

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 458329. ayzhao added a comment. Update commit with contributions from @royjacobson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files:

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

inclyc added a comment. > Yeah, that's a different way of delineating than I was thinking originally > and it's worth more thought. I was thinking the separation would be "this is > a VLA" (for people who want to avoid all VLA stack allocations due to the > security concerns) and "this is a

[clang] a002063 - Enforce module decl-use restrictions and private header restrictions in textual headers

Author: Richard Smith Date: 2022-09-06T17:12:57-07:00 New Revision: a002063de37c00133b93d2ce1f0ea78fc4b807ff URL: https://github.com/llvm/llvm-project/commit/a002063de37c00133b93d2ce1f0ea78fc4b807ff DIFF: https://github.com/llvm/llvm-project/commit/a002063de37c00133b93d2ce1f0ea78fc4b807ff.diff

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa002063de37c: Enforce module decl-use restrictions and private header restrictions in textual… (authored by rsmith). Changed prior to commit:

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 458321. Navidem added a comment. Apply comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. Thanks for your review @aaron.ballman , I've updated ReleaseNotes. I don’t have commit access, can you land this patch for me?Please use 'yronglin ' to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin updated this revision to Diff 458315. yronglin added a comment. Update ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith updated this revision to Diff 458312. rsmith edited the summary of this revision. rsmith added a comment. - Help text update from Aaron. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132779/new/ https://reviews.llvm.org/D132779 Files:

[clang] d3b9970 - [RISCV] Use llvm::none_of to replace a loop. NFC

Author: Craig Topper Date: 2022-09-06T16:24:23-07:00 New Revision: d3b99703427e354fe9eae6c19971f5b1d77aa2b4 URL: https://github.com/llvm/llvm-project/commit/d3b99703427e354fe9eae6c19971f5b1d77aa2b4 DIFF: https://github.com/llvm/llvm-project/commit/d3b99703427e354fe9eae6c19971f5b1d77aa2b4.diff

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

akyrtzi added inline comments. Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131 +/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this +/// directive will be ignored. /// benlangmuir wrote: > benlangmuir wrote: > >

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb added a comment. In D130867#3759181 , @aaron.ballman wrote: > Thanks for working on this; these sort of improvements to compile time > overhead are very much appreciated! > > Has this been tested against libc++ (our preccommit CI doesn't test

[PATCH] D132918: [clang] Fix a crash in constant evaluation

shafik added a comment. In D132918#3766909 , @ilya-biryukov wrote: > I was just passing by, but wanted to add more context from our investigation > with @kadircet. > If variables with incomplete types appear inside non-template `constexpr` > function

[PATCH] D133358: [compiler-rt] [test] Handle missing ld.gold gracefully

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Python 3.7 can use `subprocess.run` with `capture_output`: https://docs.python.org/3/library/subprocess.html#:~:text=capture_output But llvm-project requires Python >= 3.6 now, so we have

[clang] 93600eb - [NFC][asan] Rename ModuleAddressSanitizerPass

Author: Vitaly Buka Date: 2022-09-06T15:02:11-07:00 New Revision: 93600eb50ceeec83c488ded24fa0fd25f997fec6 URL: https://github.com/llvm/llvm-project/commit/93600eb50ceeec83c488ded24fa0fd25f997fec6 DIFF: https://github.com/llvm/llvm-project/commit/93600eb50ceeec83c488ded24fa0fd25f997fec6.diff

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

efriedma updated this revision to Diff 458290. efriedma added a comment. Herald added subscribers: llvm-commits, arichardson. Herald added a project: LLVM. Update to handle va_arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125419/new/

[PATCH] D133336: [msan] Convert Msan to ModulePass

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7bac3b9fa73: [msan] Convert Msan to ModulePass (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/

[clang] e7bac3b - [msan] Convert Msan to ModulePass

Author: Vitaly Buka Date: 2022-09-06T15:01:04-07:00 New Revision: e7bac3b9fa739f8d167a390a547068aad1d424a7 URL: https://github.com/llvm/llvm-project/commit/e7bac3b9fa739f8d167a390a547068aad1d424a7 DIFF: https://github.com/llvm/llvm-project/commit/e7bac3b9fa739f8d167a390a547068aad1d424a7.diff

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:4396-4398 + bool SingleDeviceOutput = !llvm::any_of(OffloadActions, [](Action *A) { +return A->getType() == types::TY_Nothing; +

[PATCH] D133371: [clang-tidy][WIP] create API for extracting option types.

njames93 updated this revision to Diff 458285. njames93 added a comment. Fix failing test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133371/new/ https://reviews.llvm.org/D133371 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D132192: [RISCV] Add '32bit' feature to rv32 only builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7440e2274fbd: [RISCV] Add 32bit feature to rv32 only builtins. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132192/new/

[clang] 7440e22 - [RISCV] Add '32bit' feature to rv32 only builtins.

Author: Craig Topper Date: 2022-09-06T14:46:35-07:00 New Revision: 7440e2274fbd840178cf73060201e6a2e225c5d1 URL: https://github.com/llvm/llvm-project/commit/7440e2274fbd840178cf73060201e6a2e225c5d1 DIFF: https://github.com/llvm/llvm-project/commit/7440e2274fbd840178cf73060201e6a2e225c5d1.diff

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

benlangmuir added inline comments. Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131 +/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this +/// directive will be ignored. /// benlangmuir wrote: > akyrtzi wrote: > >

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

benlangmuir added inline comments. Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131 +/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this +/// directive will be ignored. /// akyrtzi wrote: > benlangmuir wrote: > >

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

akyrtzi added inline comments. Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131 +/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this +/// directive will be ignored. /// benlangmuir wrote: > Why would you want to

[PATCH] D131563: [clang] Fix clang multiarch isssue with musl

MaskRay added a comment. This can be abandoned as `--print-multiarch` was removed. See also https://github.com/llvm/llvm-project/issues/51469#issuecomment-1236163566 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131563/new/ https://reviews.llvm.org/D131563

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:554 + Req.Subjects = {Base}; + Index.relations(Req, [&](const SymbolID &, const Symbol ) { +IDs.insert(Override.ID); tom-anders wrote: > ilya-biryukov wrote: > >

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders updated this revision to Diff 458270. tom-anders marked an inline comment as done. tom-anders added a comment. Fix recursivelyInsertRenames() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132797/new/ https://reviews.llvm.org/D132797

[clang] d3d334a - Fix the Clang sphinx build bot; NFC

Author: Aaron Ballman Date: 2022-09-06T16:50:22-04:00 New Revision: d3d334a625ddb784baecd483346c4892d33d33a5 URL: https://github.com/llvm/llvm-project/commit/d3d334a625ddb784baecd483346c4892d33d33a5 DIFF: https://github.com/llvm/llvm-project/commit/d3d334a625ddb784baecd483346c4892d33d33a5.diff

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: >

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added inline comments. Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@" config.clang_default_cxx_stdlib = "@CLANG_DEFAULT_CXX_STDLIB@"

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, mgorny, thesamesam. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When

[clang-tools-extra] 4450348 - [clang-tidy] Skip union-like classes in use-equals-default

Author: Alexander Shaposhnikov Date: 2022-09-06T20:19:47Z New Revision: 44503482e0af189d3a7fc57b80238ea4151992b9 URL: https://github.com/llvm/llvm-project/commit/44503482e0af189d3a7fc57b80238ea4151992b9 DIFF:

[PATCH] D132713: [clang-tidy] Skip union-like classes in use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rG44503482e0af: [clang-tidy] Skip union-like classes in use-equals-default (authored by alexander-shaposhnikov). Changed prior to commit: https://reviews.llvm.org/D132713?vs=456800=458258#toc

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but can you add a release note to clang/docs/ReleaseNotes.rst for the fix? Also, do you need someone to commit this on your behalf? If so, what name and email address

[PATCH] D133209: [clang] Document environment variables used by the driver

jansvoboda11 added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added inline comments. Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@" config.clang_default_cxx_stdlib =

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. Is Don'tAlign the same as Leave that other options support (for options

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2930 + Style.ColumnLimit = 15; + EXPECT_EQ("int ab; // line\n" +"int a; // long\n" yusuke-kadowaki wrote: > MyDeveloperDay wrote: > > Why not

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

efriedma added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: >

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a subscriber: mgorny. MaskRay added inline comments. Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@"

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay updated this revision to Diff 458241. MaskRay added a subscriber: sammccall. MaskRay added a comment. Herald added subscribers: kadircet, arphaman. Herald added a project: clang-tools-extra. Rebase. This shall fix a clang/test test. Update

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman added inline comments. Comment at: clang/test/CodeGenHLSL/GlobalConstructors.hlsl:3 + +RWBuffer Buffer; + Can you also add a test using `__attribute__((constructor))`? And probably one using `__attribute__((destructor))` at some point as well?

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: >

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

philnik added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. +

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 28bc410 - [DOC][Clang] Update cxx_status.html after the 15 release and fix a broken link in release notes

Author: Roy Jacobson Date: 2022-09-06T21:59:27+03:00 New Revision: 28bc41099970f5cdab0addc60cc96b115ce657f8 URL: https://github.com/llvm/llvm-project/commit/28bc41099970f5cdab0addc60cc96b115ce657f8 DIFF: https://github.com/llvm/llvm-project/commit/28bc41099970f5cdab0addc60cc96b115ce657f8.diff

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

efriedma added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: >

[clang] 3a62399 - [OpenMP] Fix logic error when building offloading applications

Author: Joseph Huber Date: 2022-09-06T13:56:24-05:00 New Revision: 3a623999f3ff96843f97ee300e0c94b8cbc88a9f URL: https://github.com/llvm/llvm-project/commit/3a623999f3ff96843f97ee300e0c94b8cbc88a9f DIFF: https://github.com/llvm/llvm-project/commit/3a623999f3ff96843f97ee300e0c94b8cbc88a9f.diff

[PATCH] D133371: [clang-tidy][WIP] create API for extracting option types.

njames93 created this revision. njames93 added reviewers: aaron.ballman, LegalizeAdulthood, gribozavr2, JonasToth. Herald added subscribers: carlosgalvezp, mgrang, kbarton, xazax.hun, nemanjai. Herald added a project: All. njames93 requested review of this revision. Herald added a project:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

aaron.ballman added a comment. Thank you for working on this! Comment at: clang/www/hacking.html:33 Testing on the Command Line +Testing changes affecting libcxx Similar capitalization is used in the file. Comment

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

shafik added a comment. The proposal has several nice tests and I don't they are all covered here e.g.: { double a = 7; double b = 9; { double b = b * b; // undefined, uses uninitialized variable without address Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG57ef29f2835e: [OpenMP] Remove use of removed -f[no-]openmp-new-driver flag (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133367/new/

[clang] 57ef29f - [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

Author: Joseph Huber Date: 2022-09-06T13:40:05-05:00 New Revision: 57ef29f2835eb594bc2ad4793df05188be4c2ef6 URL: https://github.com/llvm/llvm-project/commit/57ef29f2835eb594bc2ad4793df05188be4c2ef6 DIFF: https://github.com/llvm/llvm-project/commit/57ef29f2835eb594bc2ad4793df05188be4c2ef6.diff

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3906 - (C.isOffloadingHostKind(Action::OFK_OpenMP) && - Args.hasFlag(options::OPT_fopenmp_new_driver, -

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3906 - (C.isOffloadingHostKind(Action::OFK_OpenMP) && - Args.hasFlag(options::OPT_fopenmp_new_driver, -options::OPT_no_offload_new_driver, true)) || tra wrote:

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders marked 6 inline comments as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:245 trace::Span Tracer("FindOccurrencesWithinFile"); assert(canonicalRenameDecl() == && "ND should be already

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3906 - (C.isOffloadingHostKind(Action::OFK_OpenMP) && - Args.hasFlag(options::OPT_fopenmp_new_driver, -options::OPT_no_offload_new_driver, true)) || The option

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders updated this revision to Diff 458221. tom-anders added a comment. Add test case that triggers assertion, limit recursion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132797/new/ https://reviews.llvm.org/D132797 Files:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

ldionne added a comment. This is awesome. I have some comments, but I have not done an in-depth pass at this yet. Comment at: libcxx/docs/Contributing.rst:139 + +.. [#] There's `Dev meeting talk `__ + explaining the benefits of

[PATCH] D133367: [OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb, tra, yaxunl. Herald added subscribers: kosarev, kerbowa, guansong, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff updated this revision to Diff 458216. sepavloff added a comment. Change help message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133325/new/ https://reviews.llvm.org/D133325 Files: clang/docs/UsersManual.rst

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG94c6dfbaebbd: [clang] Implement setting crash_diagnostics_dir through env variable (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 94c6dfb - [clang] Implement setting crash_diagnostics_dir through env variable

Author: Matheus Izvekov Date: 2022-09-06T19:27:37+02:00 New Revision: 94c6dfbaebbd5b9474794b2437757dfb6aedefc3 URL: https://github.com/llvm/llvm-project/commit/94c6dfbaebbd5b9474794b2437757dfb6aedefc3 DIFF:

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff added a comment. In D132867#3771004 , @sammccall wrote: >> Strictly speaking this is incorrect behavior because file system object must >> be used for all operations on files, according to documentation. > > I don't think this is a strong

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff updated this revision to Diff 458205. sepavloff added a comment. Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132867/new/ https://reviews.llvm.org/D132867 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133349#3772353 , @serge-sans-paille wrote: > That's sounds like an "OK" to me, right? Yeah, this LGTM, thank you! Repository:

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: >

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

efriedma added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: >

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

serge-sans-paille added a comment. That's sounds like an "OK" to me, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133349/new/ https://reviews.llvm.org/D133349 ___ cfe-commits mailing list

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added a comment. @aaron.ballman I think all of your concerns are addressed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 ___ cfe-commits

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

benlangmuir added inline comments. Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131 +/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this +/// directive will be ignored. /// Why would you want to print without this?

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: >

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGacb767f5cda5: [clang] fix profiling of template arguments of template and declaration kind (authored by mizvekov).

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:5817 // fall back to just producing individual arguments. - Converted.insert(Converted.end(), - ArgumentPack.begin(), ArgumentPack.end()); + for

  1   2   >