[PATCH] D132379: [Support] Class for response file expansion

sepavloff updated this revision to Diff 459403. sepavloff added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 Files: clang/lib/Driver/Driver.cpp

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb added a comment. In D130867#3781492 , @ldionne wrote: > In D130867#3781429 , @cjdb wrote: > >> I had not realised that libc++ was listed as a reviewer. > > The change does have an impact on libc++, so I

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 459394. junaire added a comment. Rebase, adjust commit message and release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae added a comment. In D133634#3782999 , @xbolva00 wrote: > Missing IR tests. No issues in codegen? > > Very poor description. Why it was disabled? Why we can enable it now? I'm not sure why it is disabled. I guess it is never enabled and just

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added a comment. HLSL deviates from C here. HLSL doesn't actually have `short` (although I'm actually not sure we should disable it in Clang). We do have `int16_t`, but we don't promote `int16_t` to `int`. We discussed changing codegen to disable promotion for HLSL, but it seemed more

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 459387. royjacobson marked an inline comment as done. royjacobson added a comment. Fix conversion to function pointer, add more tests and apply Corentin's wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson marked 2 inline comments as done. royjacobson added a comment. Wow, thanks for the quick review! In D133659#3783008 , @cor3ntin wrote: > Thanks a lot for working on that! > > I think this is the right direction but i would like to see more

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mstorsjo added inline comments. Comment at: libcxx/docs/Contributing.rst:119 + +Unless specified otherwise the ``main`` version of Clang is used. + Mordante wrote: > aaron.ballman wrote: > > mstorsjo wrote: > > > Mordante wrote: > > > > mstorsjo wrote: > > > > >

[clang-tools-extra] dde62a5 - [test][clangd] Fix use-after-return after 72142fbac4

Author: Vitaly Buka Date: 2022-09-11T11:46:58-07:00 New Revision: dde62a575a3394c7c6734a5a1057bb8f91c729bb URL: https://github.com/llvm/llvm-project/commit/dde62a575a3394c7c6734a5a1057bb8f91c729bb DIFF: https://github.com/llvm/llvm-project/commit/dde62a575a3394c7c6734a5a1057bb8f91c729bb.diff

[clang-tools-extra] cbb3a39 - Revert "[test][clangd] Fix use-after-return after 72142fbac4"

Author: Vitaly Buka Date: 2022-09-11T11:46:58-07:00 New Revision: cbb3a39e4dfcac5ea0ff353b6f81b0ea14eec8e2 URL: https://github.com/llvm/llvm-project/commit/cbb3a39e4dfcac5ea0ff353b6f81b0ea14eec8e2 DIFF: https://github.com/llvm/llvm-project/commit/cbb3a39e4dfcac5ea0ff353b6f81b0ea14eec8e2.diff

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133674 Files:

[clang-tools-extra] c3c930d - [test][clangd] Fix use-after-return after 72142fbac4

Author: Vitaly Buka Date: 2022-09-11T10:15:13-07:00 New Revision: c3c930d573656a825523b7112891bd97eec7b64f URL: https://github.com/llvm/llvm-project/commit/c3c930d573656a825523b7112891bd97eec7b64f DIFF: https://github.com/llvm/llvm-project/commit/c3c930d573656a825523b7112891bd97eec7b64f.diff

[clang-tools-extra] 4891ef2 - Revert "[test][clangd] Try to unbrake bots after 72142fbac4"

Author: Vitaly Buka Date: 2022-09-11T10:07:26-07:00 New Revision: 4891ef23a0acfa0bad244ee89b8d9511a4187a84 URL: https://github.com/llvm/llvm-project/commit/4891ef23a0acfa0bad244ee89b8d9511a4187a84 DIFF: https://github.com/llvm/llvm-project/commit/4891ef23a0acfa0bad244ee89b8d9511a4187a84.diff

[PATCH] D133659: [Clang] P1169R4: static operator()

cor3ntin added a comment. Thanks a lot for working on that! I think this is the right direction but i would like to see more tests. Notably: - converting a lambda with a static operator to a pointer - tests in dependant contexts - classes having both static and non-static `operator()` .

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

On Sat, Sep 10, 2022 at 6:01 PM Kazu Hirata wrote: > > Thank you Aaron and David for your inputs. > > First and foremost, I apologize if I made your job harder by increasing the > number of commits you have to peel to get to the real author. No worries at all! It's all a tradeoff. :-) > I hear

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

aaron.ballman added a comment. Drive-by comment before I get into the review: does HLSL intend to follow the standard in terms of behavior of intN_t? If yes, then this doesn't follow the behavior allowed by the standard or the direction WG14 chose. We discussed

[PATCH] D133634: [clang] Allow vector of BitInt

xbolva00 added a comment. Missing IR tests. No issues in codegen? Very poor description. Why it was disabled? Why we can enable it now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/ https://reviews.llvm.org/D133634

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. my current progress - succesfully build commit cba72b1f620fd on debian6: 1. git checkout cba72b1f620fd 2. download debian-6.0.10-amd64-DVD-1.iso and use it to create a debian6 virtual machine 3. debian6/llvm-project>cp -fr clang llvm/tools 4. modifiy

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 459370. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459369. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 459368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 459367. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 459366. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 459365. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext.h

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov updated this revision to Diff 459364. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133261/new/ https://reviews.llvm.org/D133261 Files: clang/test/SemaTemplate/make_integer_seq.cpp clang/test/SemaTemplate/type_pack_element.cpp Index:

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 459363. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459362. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 459361. royjacobson edited the summary of this revision. royjacobson added a comment. Fix codegen test on windows, rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae updated this revision to Diff 459359. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/ https://reviews.llvm.org/D133634 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, Anastasia, aaron.ballman, bogner. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. short will be promited to int in

[PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + mizvekov wrote: > ChuanqiXu

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + ChuanqiXu wrote: > mizvekov

[PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + mizvekov wrote: > ChuanqiXu

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson created this revision. Herald added a project: All. royjacobson updated this revision to Diff 459334. royjacobson added a comment. royjacobson updated this revision to Diff 459349. royjacobson updated this revision to Diff 459355. royjacobson retitled this revision from "[Clang]

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 459351. Mordante added a comment. Rebased to fix CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files: clang/www/hacking.html

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante added inline comments. Comment at: libcxx/docs/Contributing.rst:88 +* C++XX for the Linux platform (where XX is the latest C++ version). +* MacOS X86_64 and MacOS arm64 for the Apple platform. + philnik wrote: > They are synonyms, since use the

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 459347. Mordante marked 15 inline comments as done. Mordante added a comment. Addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files:

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

tom-anders created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This fixes

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

Maetveis created this revision. Maetveis added a reviewer: clang. Herald added a project: All. Maetveis requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This is an alternative approach for [D131469

[clang-tools-extra] 355dbd3 - [test][clangd] Try to unbrake bots after 72142fbac4

Author: Vitaly Buka Date: 2022-09-11T01:20:31-07:00 New Revision: 355dbd3b2aa28d479170c4e43265de186317dd86 URL: https://github.com/llvm/llvm-project/commit/355dbd3b2aa28d479170c4e43265de186317dd86 DIFF: https://github.com/llvm/llvm-project/commit/355dbd3b2aa28d479170c4e43265de186317dd86.diff