[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

junaire added a comment. F24597444: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134105/new/ https://reviews.llvm.org/D134105 ___ cfe-commits mailing list

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

junaire updated this revision to Diff 461040. junaire added a comment. I bet now it rendered correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134105/new/ https://reviews.llvm.org/D134105 Files: clang/docs/Modules.rst Index: clang/docs/

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

python3kgae updated this revision to Diff 461039. python3kgae added a comment. Only allow redecl custom type checking builtin for HLSL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737 Files: clang/lib/A

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

jdoerfert added a comment. Herald added a subscriber: kosarev. Herald added a project: All. Can we land this? I'd like to use the new intrinsics as I don't understand the old ones. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 ___

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

mizvekov added inline comments. Comment at: clang/docs/ReleaseNotes.rst:149-151 +- Fix C++17 compatibibility warning that checks for use of auto in template + parameters so that it atually has an AutoType before attempting to call + getContainedAutoType(). This Fixes --

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik updated this revision to Diff 461033. shafik added a comment. - Add release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132990/new/ https://reviews.llvm.org/D132990 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplate.cpp clang/test/SemaTemplate/gh57362.

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a reviewer: aaron.ballman. Herald added a reviewer: NoQ. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D134057: [clang][Interp] Start implementing record types

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:316 + // Base above gives us a pointer on the stack. + const auto *FD = dyn_cast(Member); + assert(FD); tbaeder wrote: > erichkeane wrote: > > I THINK Member is a ValueDecl beca

[PATCH] D134103: [clang-format] Skip token annotation in passes that don't need it

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3276 Passes.emplace_back([&](const Environment &Env) { -return BracesInserter(Env, Expanded).process(); +return BracesInserter(Env, Expanded).process(/*SkipsAnnotation=*/true); })

[PATCH] D133643: [analyzer] Cleanup some artifacts from non-POD array evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6931d311eaf4: [analyzer] Cleanup some artifacts from non-POD array evaluation (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[clang] 6931d31 - [analyzer] Cleanup some artifacts from non-POD array evaluation

Author: isuckatcs Date: 2022-09-17T22:46:27+02:00 New Revision: 6931d311eaf483b35d5428ef6db15c0ba9e49840 URL: https://github.com/llvm/llvm-project/commit/6931d311eaf483b35d5428ef6db15c0ba9e49840 DIFF: https://github.com/llvm/llvm-project/commit/6931d311eaf483b35d5428ef6db15c0ba9e49840.diff LOG

[clang] 8009d23 - [clang] Don't include SetVector.h (NFC)

Author: Kazu Hirata Date: 2022-09-17T13:36:13-07:00 New Revision: 8009d236e5ed3225f31364198f8dd2f4ae6a8691 URL: https://github.com/llvm/llvm-project/commit/8009d236e5ed3225f31364198f8dd2f4ae6a8691 DIFF: https://github.com/llvm/llvm-project/commit/8009d236e5ed3225f31364198f8dd2f4ae6a8691.diff L

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 461026. royjacobson added a comment. Added tests for 'this' lambda captures and for the pre-cxx2b compatability warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/

[PATCH] D132285: [Clang][LoongArch] Implement ABI lowering

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. I can't vouch for your ABI correctness, but you seem to have a lot of tests covering what you claim to have implemented, so looks good to me. Thanks for opening an issue for RISC-V. Clang

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

rnk added a comment. Thanks, I have more comments, sorry I didn't add them on the first review. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1785 - if (State.CC == llvm::CallingConv::X86_FastCall || - State.CC == llvm::CallingConv::X86_VectorCall || - State.CC == l

[PATCH] D133874: [clang] Implement sugar retention for converted template arguments

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 461018. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Se

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 461017. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 461016. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 461015. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/cla

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/stddef.h:12 + +using size_t = long long unsigned; + njames93 wrote: > If this is all the file is used for, and it's only used for this one test > file, can prob

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz added a comment. In D133942#3797449 , @njames93 wrote: > How does this handle pathological cases like the statement being the > iteration-expression of a for loop, or a init-statement in an > if/switch/range-for loop. The documentation looks lik

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae updated this revision to Diff 461014. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133993/new/ https://reviews.llvm.org/D133993 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/CodeGen/CGHLS

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz added a comment. In D133942#3797449 , @njames93 wrote: > It would also be nice to add in some unittests to demonstrate that braces are > currently inserted etc. Right sorry, forgot to port unit tests, will do that swiftly Repository: rG LLVM

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

DmitryPolukhin added a comment. In D133948#3793085 , @aaron.ballman wrote: > LGTM! Please add a release note for the fix when you land the changes. Thank you for prompt review! Release notes update in D134112 . Also I

[PATCH] D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628)

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: aaron.ballman, Tyker. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a project: clang. Update ReleaseNotes about a crash fix (Issue 53628) Test Plan: none Repository: rG LLVM Git

[PATCH] D133887: [Clang] Support label at end of compound statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG510383626fe1: [Clang] Support label at end of compound statement (authored by Izaron). Changed prior to commit: https://reviews.llvm.org/D133887?v

[clang] 5103836 - [Clang] Support label at end of compound statement

Author: Evgeny Shulgin Date: 2022-09-17T15:34:56Z New Revision: 510383626fe146e49ae5fa036638e543ce71e5d9 URL: https://github.com/llvm/llvm-project/commit/510383626fe146e49ae5fa036638e543ce71e5d9 DIFF: https://github.com/llvm/llvm-project/commit/510383626fe146e49ae5fa036638e543ce71e5d9.diff LOG

[PATCH] D133887: [Clang] Support label at end of compound statement

cor3ntin accepted this revision as: cor3ntin. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks. This LGTM now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133887/new/ https://reviews.llvm.org/D133887 _

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG133b6d7db90d: [clang][C++20] Fix clang/clangd assert/crash after compilation errors (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 133b6d7 - [clang][C++20] Fix clang/clangd assert/crash after compilation errors

Author: Dmitry Polukhin Date: 2022-09-17T07:37:19-07:00 New Revision: 133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d URL: https://github.com/llvm/llvm-project/commit/133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d DIFF: https://github.com/llvm/llvm-project/commit/133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d.dif

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron updated this revision to Diff 461006. Izaron added a comment. Fix diagnostics for C. Thanks to @cor3ntin and @aaron.ballman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133887/new/ https://reviews.llvm.org/D133887 Files: clang/docs/Rele

[PATCH] D133887: [Clang] Support label at end of compound statement

cor3ntin added a comment. In D133887#3797614 , @Izaron wrote: >> Why checking getLangOpts().C99 instead of just C > > There is no `getLangOpts().C`. Here are possible C/C++ opt flags: > https://github.com/llvm/llvm-project/blob/7914e53e312074828293356f569

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron added a comment. > Why checking getLangOpts().C99 instead of just C There is no `getLangOpts().C`. Here are possible C/C++ opt flags: https://github.com/llvm/llvm-project/blob/7914e53e312074828293356f569d190ac6eae3bd/clang/include/clang/Basic/LangOptions.def#L86-L100 I have no understandin

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/stddef.h:12 + +using size_t = long long unsigned; + If this is all the file is used for, and it's only used for this one test file, can probably remove this he

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 461003. Izaron added a comment. Fix test with `count 0`, thanks to @njames93 ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files: clang-tools-extra/clang-tidy/mi

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, just with one small testing nit Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-values.cpp:533 + int *np_local0[2] = {nullptr, nullp

[PATCH] D133887: [Clang] Support label at end of compound statement

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:738 +} else if (getLangOpts().C99 && !getLangOpts().C2x) { + Diag(Tok, diag::ext_c_label_end_of_compound_statement); +} I do not understand this. Why checking `getLangOpts().C9

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. In D133853#3795579 , @aaron.ballman wrote: > but my suggestion is to only support `[[msvc::constexpr]]` with the semantic > meaning of `constexpr` Sounds good to me. > It's a good question as to whether we want to support tha

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 added a comment. In D122078#3797519 , @Izaron wrote: > The new file was failing with message > > CHECK-FIXES, CHECK-MESSAGES or CHECK-NOTES not found in the input > > So I had to add an additional urrelevant check. > I added a check for constev

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron updated this revision to Diff 461002. Izaron added a comment. Add diagnostics for C language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133887/new/ https://reviews.llvm.org/D133887 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D134103: [clang-format] Skip token annotation in passes that don't need it

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/Format.cpp:3276 Passes.emplace_back([&](const Environment &Env) { -return BracesInserter(Env, Expanded

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good, please wait for other reviewers. Comment at: clang/unittests/Format/FormatTest.cpp:5747 +TEST_F(FormatTest, FormatAlignInsidePreprocessorE

[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder updated this revision to Diff 461001. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134057/new/ https://reviews.llvm.org/D134057 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder updated this revision to Diff 460998. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134057/new/ https://reviews.llvm.org/D134057 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[clang] 7772624 - Add code examples to the potentially breaking changes

Author: Aaron Ballman Date: 2022-09-17T08:44:13-04:00 New Revision: 7772624f3bac5499b36da8a20d5d73fcbc6f8683 URL: https://github.com/llvm/llvm-project/commit/7772624f3bac5499b36da8a20d5d73fcbc6f8683 DIFF: https://github.com/llvm/llvm-project/commit/7772624f3bac5499b36da8a20d5d73fcbc6f8683.diff

[clang] aa9a656 - Fix release note formatting and style; NFC

Author: Aaron Ballman Date: 2022-09-17T08:21:33-04:00 New Revision: aa9a656b03c28386e367f69ceb311c94d62ac1ab URL: https://github.com/llvm/llvm-project/commit/aa9a656b03c28386e367f69ceb311c94d62ac1ab DIFF: https://github.com/llvm/llvm-project/commit/aa9a656b03c28386e367f69ceb311c94d62ac1ab.diff

[clang] 1b2efe8 - Fix this test to be more robust

Author: Aaron Ballman Date: 2022-09-17T08:06:16-04:00 New Revision: 1b2efe8d87b30052de944f0153d3833046b80604 URL: https://github.com/llvm/llvm-project/commit/1b2efe8d87b30052de944f0153d3833046b80604 DIFF: https://github.com/llvm/llvm-project/commit/1b2efe8d87b30052de944f0153d3833046b80604.diff

[clang] 5d92d0b - Correctly diagnose use of long long literals w/o a suffix

Author: Aaron Ballman Date: 2022-09-17T07:55:10-04:00 New Revision: 5d92d0b0f86c2c4e0c6ebd7b1e2113337fec041d URL: https://github.com/llvm/llvm-project/commit/5d92d0b0f86c2c4e0c6ebd7b1e2113337fec041d DIFF: https://github.com/llvm/llvm-project/commit/5d92d0b0f86c2c4e0c6ebd7b1e2113337fec041d.diff

[PATCH] D133920: [X86][fastcall] Move capability check before free register update

pengfei updated this revision to Diff 460991. pengfei marked 2 inline comments as done. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920 Files: clang/doc

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 460990. Izaron added a comment. The new file was failing with message CHECK-FIXES, CHECK-MESSAGES or CHECK-NOTES not found in the input So I had to add an additional urrelevant check. I added a check for consteval function (there were no such tests previous

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added a comment. As an example, we are currently installing the following set of executables + symlinks for clang in Gentoo on amd64 with full multilib: lrwxrwxrwx 1 root root8 Sep 17 12:31 /usr/lib/llvm/16/bin/clang -> clang-16 lrwxrwxrwx 1 root root 10 Sep 17 12:31 /usr/lib/l

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth marked an inline comment as done. JonasToth added a comment. ping @njames93 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793 ___ cfe-commits mailing

[PATCH] D133887: [Clang] Support label at end of compound statement

cor3ntin added a comment. In D133887#3797491 , @Izaron wrote: >> It should definitely be without warning in C23 mode and give an extension >> warning in earlier modes. > > @aaron.ballman we have this extension warning for pre-C++23: > > def ext_label_e

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

ChuanqiXu added a comment. Thanks. I wanted to do this. I suggest to do the change in later sections. Since the document talks more than the clang modules extension. It also describes some general module properties and semantics. It is a pretty document and from my point of view, it shouldn be

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron added a comment. > It should definitely be without warning in C23 mode and give an extension > warning in earlier modes. @aaron.ballman we have this extension warning for pre-C++23: def ext_label_end_of_compound_statement : ExtWarn< "label at end of compound statement is a C++2b ex

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron updated this revision to Diff 460987. Izaron added a comment. Change C2x implementation status and C2x release notes Add an AST test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133887/new/ https://reviews.llvm.org/D133887 Files: clang/

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. There's some merit in this, like wrapping the previous statement in braces.. However, clang-tidy should not focus on the formatting aspect as we have clang-format built in to add

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

junaire created this revision. junaire added a reviewer: ChuanqiXu. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there're two pages that both talk about "Modules" in clang, but they're diffe

[PATCH] D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check

njames93 added a comment. I feel like this matcher could do with some unit testing. I'd say create a test file in `clang-tools-extra/unittests/clang-tidy/MatchersTest.cpp` Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:145 auto UnusedInCompou

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks for fixing! Comment at: clang-tools-extra/clangd/InlayHints.cpp:281 - void addReturnTypeHint(FunctionDecl *D, SourceLocation Loc) { + void addReturnTypeHint(Functi

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/float3.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - %s | FileCheck %s + tahonermann wrote: > Does this need to use driver mode?

[clang] 8b2f8b3 - [NFC} update CodeGenHLSL tests to use cc1 instead of driver-mode

Author: Xiang Li Date: 2022-09-17T00:11:44-07:00 New Revision: 8b2f8b309885e872ad98af381ee5459716955877 URL: https://github.com/llvm/llvm-project/commit/8b2f8b309885e872ad98af381ee5459716955877 DIFF: https://github.com/llvm/llvm-project/commit/8b2f8b309885e872ad98af381ee5459716955877.diff LOG:

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 460976. Izaron added a comment. Created redundant-expression-cxx20.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files: clang-tools-extra/clang-tidy/misc/Redun

[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder updated this revision to Diff 460975. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134057/new/ https://reviews.llvm.org/D134057 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder marked an inline comment as done. tbaeder added a comment. @erichkeane Anything else still missing here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133934/new/ https://reviews.llvm.org/D133934 ___ cfe-commits mailing list cfe-commi