[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

shafik added a comment. @cor3ntin I wonder if these asserts are due to the partial implementation here: https://github.com/llvm/llvm-project/issues/57960 I am happy to look into it if you can point me in the right direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 462697. python3kgae added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/CodeGen/CGHL

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

ychen added a comment. Drive by thoughts: keyed this on assertion/debug build? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134550/new/ https://reviews.llvm.org/D134550 ___ cfe-commits mailing list cfe-

[clang] 910ad36 - [Clang] Improve diagnostics about the invalid target feature.

Author: wangliushuai Date: 2022-09-25T10:27:08+08:00 New Revision: 910ad36e1a2592915b32941844cf089442972d7a URL: https://github.com/llvm/llvm-project/commit/910ad36e1a2592915b32941844cf089442972d7a DIFF: https://github.com/llvm/llvm-project/commit/910ad36e1a2592915b32941844cf089442972d7a.diff

[PATCH] D133563: [Clang] Improve diagnostics about the invalid target feature.

This revision was automatically updated to reflect the committed changes. Closed by commit rG910ad36e1a25: [Clang] Improve diagnostics about the invalid target feature. (authored by MTC). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

iains added a comment. thanks for the review. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:690-695 + // If we have an empty initializer then we do not want to create a guard var. + // 'Empty' needs only to apply to init functions that we call directly, calls + // to imported

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

iains updated this revision to Diff 462689. iains marked 3 inline comments as done. iains edited the summary of this revision. iains added a comment. address review comments, minor amendments to description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. I'm unlikely to get to it in the next 2 weeks (IWOMP and OpenMP F2F). What I would do is to take the new IR, the old IR, run instnamer on the new one. Then splice in the new parts into the old IR removing what was there wrt. parallel_51. Repository: rG LLVM Github

[PATCH] D134587: [clang-format] Correctly annotate static and consteval lambdas

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Fancy stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134587/new/ https://reviews.llvm.org/D134587 ___ cfe-commits mail

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 462685. njames93 added a comment. Rebase fixing merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org/D134549 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 462684. njames93 marked an inline comment as done. njames93 added a comment. Add release notes and fix issue in ASTWriterDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2291 Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 6)); // LocEnd + Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 3)); // Default/DeleteLoc Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp:

[PATCH] D134590: [clang-tidy] Fix a false positive in readability-simplify-boolean-expr

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c783b8ec78e: [clang-tidy] Fix a false positive in readability-simplify-boolean-expr (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[clang-tools-extra] 8c783b8 - [clang-tidy] Fix a false positive in readability-simplify-boolean-expr

Author: Nathan James Date: 2022-09-24T18:29:19+01:00 New Revision: 8c783b8ec78ec857e446a89a35463baed8026f40 URL: https://github.com/llvm/llvm-project/commit/8c783b8ec78ec857e446a89a35463baed8026f40 DIFF: https://github.com/llvm/llvm-project/commit/8c783b8ec78ec857e446a89a35463baed8026f40.diff

[PATCH] D134592: [clang-tidy] Add option to control floating point binary operators in readability-simplify-boolean-expr

njames93 created this revision. njames93 added reviewers: aaron.ballman, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 462680. inclyc added a comment. Address comments. Clang will now consider __builtin_offsetof #defined from "offsetof" to improve diagnostic message. For example: #define offsetof(t, d) __builtin_offsetof(t, d) int main() { return offsetof(struct S

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson planned changes to this revision. royjacobson added a comment. I think I didn't get the overload resolution changes quite right, so this will probably change a bit. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:698 Builder.defineMacro("__cpp_multidimensi

[PATCH] D134590: [clang-tidy] Fix a false positive in readability-simplify-boolean-expr

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134590/new/ https://reviews.llvm.org/D134590 _

[PATCH] D134587: [clang-format] Correctly annotate static and consteval lambdas

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134587/new/ https://reviews.llvm.org/D134587 ___

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. @sepavloff, gentle ping. I'm waiting for your ACK/NAK on the algo in https://reviews.llvm.org/D134337#3805368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:690-695 + // If we have an empty initializer then we do not want to create a guard var. + // 'Empty' needs only to apply to init functions that we call directly, calls + // to imported module initializ

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned AlwaysIncludeTypeForNonTypeTemplateArgumen

[PATCH] D134590: [clang-tidy] Fix a false positive in readability-simplify-boolean-expr

njames93 created this revision. njames93 added reviewers: aaron.ballman, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

iains created this revision. Herald added a project: All. iains added a reviewer: urnathan. iains added a subscriber: clang-modules. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the Itanium ABI, we emit an initializer for each

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

ngg created this revision. ngg added reviewers: clang-tools-extra, njames93. Herald added subscribers: carlosgalvezp, lebedev.ri, xazax.hun. Herald added a reviewer: lebedev.ri. Herald added a project: All. ngg requested review of this revision. Herald added a project: clang-tools-extra. Herald add

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 462673. yaxunl added a comment. I just found clang-offload-bundler reports an error when trying to unbundle an archive but the input file is not an archive. This update let clang-offload-bundler to extract empty archives when the input file is not an archive

[PATCH] D134587: [clang-format] Correctly annotate static and consteval lambdas

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1169 "static

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

jyknight added a comment. In D134550#3813269 , @aaron.ballman wrote: > Alternatively, perhaps those experimental options should be exposed from the > driver instead of being a cc1-only flag? IMO: yes. If we want end-users to use a particular flag, we s

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

This revision was automatically updated to reflect the committed changes. Closed by commit rGe07ead85a368: [Clang] Warn when trying to dereference void pointers in C (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D134461?vs=462643&id=462671#toc Repository: rG LLVM G

[clang] e07ead8 - [Clang] Warn when trying to dereference void pointers in C

Author: Jun Zhang Date: 2022-09-24T22:18:04+08:00 New Revision: e07ead85a368173a56e96a21d6841aa497ad80f8 URL: https://github.com/llvm/llvm-project/commit/e07ead85a368173a56e96a21d6841aa497ad80f8 DIFF: https://github.com/llvm/llvm-project/commit/e07ead85a368173a56e96a21d6841aa497ad80f8.diff LOG

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

jhuber6 added a comment. In D134550#3813259 , @jyknight wrote: > I //really// don't think we should have this behavior. The cc1 options are > supposed to be an internal implementation detail. It's already a problem that > the option name doesn't shout "

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

rymiel updated this revision to Diff 462670. rymiel added a comment. Remove redundant assert thank you for pointing that out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134325/new/ https://reviews.llvm.org/D134325 Files: clang/lib/Format/Unwr

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

DoDoENT added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned AlwaysIncludeTypeForNonTypeTemplateArgument

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

aaron.ballman added a comment. In D134550#3813259 , @jyknight wrote: > I //really// don't think we should have this behavior. The cc1 options are > supposed to be an internal implementation detail. It's already a problem that > the option name doesn't s

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

jyknight added a comment. I //really// don't think we should have this behavior. The cc1 options are supposed to be an internal implementation detail. It's already a problem that the option name doesn't shout "hey I'm an internal interface with no stability guarantees! Don't use me!". Having cl

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 462667. royjacobson marked 7 inline comments as done. royjacobson added a comment. Apply small suggestions by Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit in the tests. Thank you for this! Comment at: clang/test/C/drs/dr1xx.c:191-194 + return *vvp; /* expected-warning {{void function '

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

aaron.ballman added a comment. Thank you for this, I think it's a good idea! Can you also add a release note for the changes? This mostly LG to me but I did spot one thing I was curious about. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2291 Abv->Add(BitCodeAbbre

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2213159fa65: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] e221315 - [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

Author: Joseph Huber Date: 2022-09-24T07:58:40-05:00 New Revision: e2213159fa654a9ba8b211204a7342f6bc1690c6 URL: https://github.com/llvm/llvm-project/commit/e2213159fa654a9ba8b211204a7342f6bc1690c6 DIFF: https://github.com/llvm/llvm-project/commit/e2213159fa654a9ba8b211204a7342f6bc1690c6.diff

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

aaron.ballman accepted this revision. aaron.ballman added a comment. I'm convinced, thanks for the discussion! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134550/new/ https://reviews.llvm.org/D134550 ___

[PATCH] D134513: [RISCV][Clang] Replace all undef value with poison

This revision was automatically updated to reflect the committed changes. Closed by commit rG75279aeecd1d: [RISCV][Clang] Replace all undef value with poison (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134513/new/ https://revi

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 462657. iains added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rebased and reworked. The version here has now been tested to consume all of the libc++ headers including those in experimental and ext. Repository: rG LL