[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu updated this revision to Diff 462700. ChuanqiXu added a comment. - Add ReleaseNotes. - Refine the behavior about partitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134267/new/ https://reviews.llvm.org/D134267 Files: clang/docs/ReleaseNotes.rst clang/include/clang/B

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

ChuanqiXu updated this revision to Diff 462701. ChuanqiXu added a comment. Refine the behavior about partitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134269/new/ https://reviews.llvm.org/D134269 Files: clang/docs/StandardCPlusPlusModules.rst Index: clang/docs/StandardCPlusP

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: nridge wrote: > sammccall wrote: > > I have a couple

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge updated this revision to Diff 462702. nridge added a comment. Updated to use unique_function rather than inheritance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://reviews.llvm.org/D133756 Files: clang-tools-extra/clang

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge updated this revision to Diff 462704. nridge marked 2 inline comments as done. nridge added a comment. This is mostly just a rebase on top of the update to D133756 to turn CompileCommandsAdjuster into a unique_function, and addressing a few minor comments

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice created this revision. paperchalice added a reviewer: phosek. paperchalice added a project: clang. Herald added a project: All. paperchalice requested review of this revision. Herald added a subscriber: cfe-commits. When `CLANG_RESOURCE_DIR` is not empty, clang will look up builtin he

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

tschuett added a comment. Thanks for doing this! The traditional Clang Header modules call this implicit and explicit modules. Feel free to ignore, but I found this awesome article about implicit and explicit modules in Swift. They have same nomenclature and issues. https://forums.swift.org/t/

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

OfekShochat marked an inline comment as done. OfekShochat added a comment. @efriedma would you be able to commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133648/new/ https://reviews.llvm.org/D133648 _

[PATCH] D134568: [AMDGPU] Add pattern for flat fadd f64 intrinsic with local address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcc756d03e59: [AMDGPU] Pattern for flat atomic fadd f64 intrinsic with local addr (authored by Petar.Avramovic). Herald added a project: clang. Heral

[clang] dcc756d - [AMDGPU] Pattern for flat atomic fadd f64 intrinsic with local addr

Author: Petar Avramovic Date: 2022-09-25T13:25:41+02:00 New Revision: dcc756d03e597d6a405493a630f66ce4fcb7d656 URL: https://github.com/llvm/llvm-project/commit/dcc756d03e597d6a405493a630f66ce4fcb7d656 DIFF: https://github.com/llvm/llvm-project/commit/dcc756d03e597d6a405493a630f66ce4fcb7d656.dif

[PATCH] D134176: Add MC support of RISCV Zcf Extension

VincentWu updated this revision to Diff 462720. VincentWu marked 2 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134176/new/ https://reviews.llvm.org/D134176 Files: clang/test/

[PATCH] D134177: Add MC support of RISCV Zcd Extension

VincentWu updated this revision to Diff 462721. VincentWu marked 3 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://reviews.llvm.org/D134177 Files: clang/test/

[PATCH] D131963: [libc++] Add custom clang-tidy checks

Mordante added a subscriber: jwakely. Mordante added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/robust_against_adl.cpp:22 +AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) { + // TODO: Are make_error_code and make_error_condition actually cust

[PATCH] D134592: [clang-tidy] Add option to control floating point binary operators in readability-simplify-boolean-expr

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:155 + + Added an option SafeFloatComparisons to control negating binary operators + with floating point operands. Please enclose `SafeFloatComparisons` into single back-t

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

Eugene.Zelenko added a comment. It'll be good idea to mention change in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134588/new/ https://reviews.llvm.org/D134588 ___ cfe-commits mailing l

[PATCH] D134177: Add MC support of RISCV Zcd Extension

VincentWu updated this revision to Diff 462727. VincentWu added a comment. fix testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://reviews.llvm.org/D134177 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. Well, Something happened after rebasing this patch on D126907 . `s41` below was rejected as the constrain generated from `template ` was no longer considered to subsume the constrain generated from `template requires C` in the template te

[PATCH] D134592: [clang-tidy] Add option to control floating point binary operators in readability-simplify-boolean-expr

njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:155 + + Added an option SafeFloatComparisons to control negating binary operators + with floating point operands. Eugene.Zelenko wrote: > Please enclose `SafeFloatComparisons`

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462731. thakis added a comment. final tweaks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/includ

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:106 + enum SrcHashAlgorithm { +CSK_MD5, +CSK_SHA1, hans wrote: > thakis wrote: > > hans wrote: > > > what does CSK stand for here? > > I'm guessing "check sum kind", but

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WIP - Not ready for review Signed-off-by: Matheus Izvekov Depends on D133874 Repos

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

DoDoENT added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned AlwaysIncludeTypeForNonTypeTemplateArgument

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 462735. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1346

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

sepavloff added a comment. I would propose to slightly modify the config file search algorithm. For the tool named as `x86_64-pc-linux-gnu-clang`, the existing algorithm would search for the files: - `i386-clang.cfg` - `i386.cfg` - `x86_64-clang.cfg` - `x86_64.cfg` We could modify this algorit

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov updated this revision to Diff 462738. Herald added subscribers: kadircet, arphaman. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang-tools-e

[PATCH] D131963: [libc++] Add custom clang-tidy checks

jwakely added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/robust_against_adl.cpp:22 +AST_MATCHER(clang::UnresolvedLookupExpr, isCustomizationPoint) { + // TODO: Are make_error_code and make_error_condition actually customization points? + return std::range

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3813779 , @sepavloff wrote: > First clang tries to find `x86_64-pc-linux-gnu-clang.cfg`. Just tool name > with added suffix `cfg`. No target override, no attempt to split tool name > into components. It provides possib

[PATCH] D134587: [clang-format] Correctly annotate static and consteval lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7847225576d5: [clang-format] Correctly annotate static and consteval lambdas (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 39e6077 - [clang-format] Look ahead before consuming `bool` in requires clause.

Author: Emilia Dreamer Date: 2022-09-25T20:30:21+03:00 New Revision: 39e6077d97238ec13c9ed1b9dbae1e6408e5aba3 URL: https://github.com/llvm/llvm-project/commit/39e6077d97238ec13c9ed1b9dbae1e6408e5aba3 DIFF: https://github.com/llvm/llvm-project/commit/39e6077d97238ec13c9ed1b9dbae1e6408e5aba3.diff

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG39e6077d9723: [clang-format] Look ahead before consuming `bool` in requires clause. (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13432

[clang] 7847225 - [clang-format] Correctly annotate static and consteval lambdas

Author: Emilia Dreamer Date: 2022-09-25T20:29:55+03:00 New Revision: 7847225576d571fb7101463de56330e1f0e84856 URL: https://github.com/llvm/llvm-project/commit/7847225576d571fb7101463de56330e1f0e84856 DIFF: https://github.com/llvm/llvm-project/commit/7847225576d571fb7101463de56330e1f0e84856.diff

[PATCH] D134544: [clang-cl] Implement /ZH: flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8371247f63: [clang-cl] Implement /ZH: flag (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/

[clang] ea83712 - [clang-cl] Implement /ZH: flag

Author: Nico Weber Date: 2022-09-25T14:43:14-04:00 New Revision: ea8371247f6339c32a696e9ea2f84080f91f808d URL: https://github.com/llvm/llvm-project/commit/ea8371247f6339c32a696e9ea2f84080f91f808d DIFF: https://github.com/llvm/llvm-project/commit/ea8371247f6339c32a696e9ea2f84080f91f808d.diff LO

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat abandoned this revision. azat added a comment. Closing in favor of https://reviews.llvm.org/D133092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133875/new/ https://reviews.llvm.org/D133875 ___ cfe

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 462756. azat added a comment. Resubmit with fixed tests and using --plugin-opt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/Commo

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. > If the two patches are basically identical with just some fixes for the > problem, the convention is to reuse the original Differential. I've updated this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/

[clang-tools-extra] 015ce15 - [clang-format][NFC] Rewrite prints in python3 compatible way

Author: Danil Sidoruk Date: 2022-09-25T13:27:42-07:00 New Revision: 015ce15ea27bcd88447d84c4b277d775fede29f7 URL: https://github.com/llvm/llvm-project/commit/015ce15ea27bcd88447d84c4b277d775fede29f7 DIFF: https://github.com/llvm/llvm-project/commit/015ce15ea27bcd88447d84c4b277d775fede29f7.diff

[PATCH] D131789: [clang-format][NFC] Rewrite prints in python3 compatible way

This revision was automatically updated to reflect the committed changes. Closed by commit rG015ce15ea27b: [clang-format][NFC] Rewrite prints in python3 compatible way (authored by eoanermine, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

erichkeane added a comment. In D134542#3812711 , @ychen wrote: > In D134542#3812292 , @erichkeane > wrote: > >> In D134542#3812211 , @ychen wrote: >> >>> The patch looks

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen added a comment. In D134542#3814029 , @erichkeane wrote: > Thanks for the quick review! Yeah, that case is a tough one, we don't really > have a good way of determining whether that was supposed to fail, or be the > best match. GCC does the opt

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[clang] 394f309 - [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

Author: Weining Lu Date: 2022-09-26T08:49:58+08:00 New Revision: 394f30919a029331ebdfe02c180bd1586c0d9ace URL: https://github.com/llvm/llvm-project/commit/394f30919a029331ebdfe02c180bd1586c0d9ace DIFF: https://github.com/llvm/llvm-project/commit/394f30919a029331ebdfe02c180bd1586c0d9ace.diff LO

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

This revision was automatically updated to reflect the committed changes. Closed by commit rG394f30919a02: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13415

[PATCH] D134618: [Syntax] Fix macro-arg handling in TokenBuffer::spelledForExpanded

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. A few cases were not handled correctly. Notably: #define ID(X) X

[clang-tools-extra] 283b6de - [clangd] Make go-to-type work on member function calls

Author: Sam McCall Date: 2022-09-26T04:18:43+02:00 New Revision: 283b6dec8d08520f73ebd4563966f491b49d47b2 URL: https://github.com/llvm/llvm-project/commit/283b6dec8d08520f73ebd4563966f491b49d47b2 DIFF: https://github.com/llvm/llvm-project/commit/283b6dec8d08520f73ebd4563966f491b49d47b2.diff LO

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

ahatanak added a comment. In D86049#3812412 , @plotfi wrote: > In D86049#3812068 , @ahatanak wrote: > >> In D86049#3806898 , @plotfi wrote: >> >>> 1. Do we change the existin

[clang] 30b676a - Don't crash when code completing `using enum ^Foo`.

Author: Sam McCall Date: 2022-09-26T04:52:19+02:00 New Revision: 30b676ac5f3041a5494b1eb9c9a3322cfc56d480 URL: https://github.com/llvm/llvm-project/commit/30b676ac5f3041a5494b1eb9c9a3322cfc56d480 DIFF: https://github.com/llvm/llvm-project/commit/30b676ac5f3041a5494b1eb9c9a3322cfc56d480.diff LO

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG30b676ac5f30: Don't crash when code completing `using enum ^Foo`. (authored by sammccall). Changed prior

[clang] 258d7b8 - [clang-format] Handle constructor invocations after new operator in C# correct

Author: Danil Sidoruk Date: 2022-09-25T21:10:26-07:00 New Revision: 258d7b86eeab4222c783c1a19acd8e18cd7745aa URL: https://github.com/llvm/llvm-project/commit/258d7b86eeab4222c783c1a19acd8e18cd7745aa DIFF: https://github.com/llvm/llvm-project/commit/258d7b86eeab4222c783c1a19acd8e18cd7745aa.diff

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG258d7b86eeab: [clang-format] Handle constructor invocations after new operator in C# correct (authored by eoanermine, committed by owenpan). Changed

[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a compound requirement is too long to fit

[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

rymiel added a comment. Note: I don't have the historical insight to know why the code order was as it was. I simply tried yoinking the place where the level was being set to occur earlier, and it surprisingly seemed to work, and also seemed to not break any other tests; I hope it doesn't break

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae updated this revision to Diff 462819. python3kgae added a comment. Remove empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134617/new/ https://reviews.llvm.org/D134617 Files: clang/include/clang/Basic/Attr.td clang/include

[PATCH] D134629: [clang][Interp] Fix Pointer::toAPValue() LValuePath order

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See the comment I added for an explanation. This fi

[PATCH] D134523: [clang][Interp] Fix copy constructors with record array members

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:160-163 +//static_assert(LT2.v[0].first == false, ""); +//static_assert(LT2.v[0].second == false, ""); +//static_assert(LT2.v[2].first == true, ""); +//static_assert(LT2.v[2].second == false, ""); --

[PATCH] D134629: [clang][Interp] Fix Pointer::toAPValue() LValuePath order

tbaeder updated this revision to Diff 462823. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134629/new/ https://reviews.llvm.org/D134629 Files: clang/lib/AST/Interp/Pointer.cpp clang/test/AST/Interp/records.cpp Index: clang/test/AST/Interp/records.cpp ==