[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

jacob-abraham created this revision. jacob-abraham added reviewers: djasper, Typz. jacob-abraham added a project: clang-format. Herald added a project: All. jacob-abraham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This solves the

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 465968. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:33-34 + /// Primitive representing limits. + // static constexpr auto Min = std::numeric_limits::min(); + // static constexpr auto Max = std::numeric_limits::max(); + jcranmer-intel

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 465967. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder updated this revision to Diff 465966. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D135421: Driver: Change default Android linker to lld.

pcc created this revision. pcc added reviewers: srhines, rprichard, danalbert. Herald added subscribers: danielkiss, cryptoad. Herald added a project: All. pcc requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. The clang distributed with the

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:2277-2278 +if (isFriend && !QualifierLoc && !FunctionTemplate) { + SemaRef.FilterLookupForScope(Previous, DC, /*Scope*/ nullptr, +

[clang] 3af06c7 - [CMake] Update cache file for Win to ARM Linux cross toolchain builders. NFC.

Author: Vladimir Vereschaka Date: 2022-10-06T19:40:33-07:00 New Revision: 3af06c72986356c6d580814fef80813ab3b3c34a URL: https://github.com/llvm/llvm-project/commit/3af06c72986356c6d580814fef80813ab3b3c34a DIFF:

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:169 +if (T.getOS() == llvm::Triple::WatchOS || +this->getCXXABI().getKind() == TargetCXXABI::AppleARM64) + return TargetInfo::UseTailPaddingUnlessPOD11; rnk wrote: >

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie updated this revision to Diff 465957. dblaikie added a comment. Fix to use CXXABI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135326/new/ https://reviews.llvm.org/D135326 Files: clang/include/clang/Basic/TargetCXXABI.h

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:774-775 +if ((!Constructor->isDeleted() && !Constructor->isDefaulted()) || +(getLangOpts().getClangABICompat() <= + LangOptions::ClangABI::Ver15 || Target.isPS() ||

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 465956. dblaikie added a comment. Move condition to TargetInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai updated this revision to Diff 465954. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 465953. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130326/new/ https://reviews.llvm.org/D130326 Files: clang/include/clang/AST/ODRDiagsEmitter.h

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 465952. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130325/new/ https://reviews.llvm.org/D130325 Files: clang/include/clang/AST/ODRDiagsEmitter.h

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 465950. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130324/new/ https://reviews.llvm.org/D130324 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1789 + auto inserted = ConstructedObjects.insert({Exp, Placeholder.first}); + assert(inserted.second && "Are we visiting the same expression again?"); + if (isa(Exp))

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 465943. ayzhao added a comment. Fill out implementation for ClassifyExprValueKind(...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/67644/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/

[PATCH] D135361: [clang][Interp] Implement bitwise Or operations

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135361/new/ https://reviews.llvm.org/D135361

[clang] b924c8c - [clang][LTO] Remove the use of `--` for arange option

Author: Qiongsi Wu Date: 2022-10-06T20:27:55-04:00 New Revision: b924c8c71daaa1bb869c42d9afca2a09a9b94629 URL: https://github.com/llvm/llvm-project/commit/b924c8c71daaa1bb869c42d9afca2a09a9b94629 DIFF: https://github.com/llvm/llvm-project/commit/b924c8c71daaa1bb869c42d9afca2a09a9b94629.diff

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

This revision was automatically updated to reflect the committed changes. Closed by commit rGb924c8c71daa: [clang][LTO] Remove the use of `--` for arange option (authored by Qiongsi Wu qiongs...@gmail.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

chapuni added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1789 + auto inserted = ConstructedObjects.insert({Exp, Placeholder.first}); + assert(inserted.second && "Are we visiting the same expression again?"); + if (isa(Exp))

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

ahatanak accepted this revision. ahatanak added a comment. LGTM Comment at: clang/test/CodeGenObjC/direct-method.m:178 +// CHECK-NEXT: [[IVAR:%.*]] = load {{.*}} @"OBJC_IVAR_$_Root._objectProperty", +// CHECK-NEXT: call i8* @objc_getProperty(i8* noundef [[SELF]], i8* noundef

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen added a comment. In D135411#3841693 , @kees wrote: > What's the best way to test this in the kernel? I assume add > `ARCH_SUPPORTS_CFI_CLANG` to an arch, and see what blows up? :) Yes, I think that's the best way. > Have you tried this on

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

bruno added subscribers: aaron.ballman, bruno. bruno added a reviewer: aaron.ballman. bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Hi Troy, thanks for working on this, nice compile time perf savings. Can you update the diff to contain more

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

vsapsai added a comment. In D133586#3833274 , @aaron.ballman wrote: > Personally, I think the next step is to add a local `assert()` to this > function to try to find out why we're calling this on functions without a > prototype and fix up the call

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX)

[PATCH] D135416: [clang][deps] Respect VFS overlays in canonical preprocessing mode

jansvoboda11 updated this revision to Diff 465936. jansvoboda11 added a comment. Add forgotten hunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135416/new/ https://reviews.llvm.org/D135416 Files:

[PATCH] D135416: [clang][deps] Respect VFS overlays in canonical preprocessing mode

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `-ivfsoverlay`

[PATCH] D135414: [clang][deps] Don't share in-memory VFS across scans

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 465927. ayzhao added a comment. implement StmtPrinter::VisitCXXParenListInitExpr(...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman marked 2 inline comments as done. mwyman added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1116 +// for the `_cmd` argument that no longer exists for direct methods. +static llvm::Value *emitCmdLoadForGetterSetterBody(CodeGenFunction , +

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman updated this revision to Diff 465925. mwyman added a comment. Herald added a subscriber: nlopes. Use explicit `undef` for the `cmd` parameter to `objc_getProperty`/`objc_setProperty` rather declaring and not initializing storage for the implicit `_cmd`. CHANGES SINCE LAST ACTION

[clang] 4aa87a1 - [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

Author: Joseph Huber Date: 2022-10-06T18:22:09-05:00 New Revision: 4aa87a131f93de73b8e245021af0294545d063c5 URL: https://github.com/llvm/llvm-project/commit/4aa87a131f93de73b8e245021af0294545d063c5 DIFF: https://github.com/llvm/llvm-project/commit/4aa87a131f93de73b8e245021af0294545d063c5.diff

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aa87a131f93: [OpenMP][AMDGPU] Add uniform-work-group attribute to OpenMP kernels (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D135374?vs=465769=465923#toc Repository:

[PATCH] D135381: [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader`

This revision was automatically updated to reflect the committed changes. Closed by commit rG586547687946: [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader` (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D135381?vs=465802=465921#toc Repository:

[clang] 5865476 - [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader`

Author: Jan Svoboda Date: 2022-10-06T16:20:24-07:00 New Revision: 586547687946b27a99d3bb4241226f9f126a173e URL: https://github.com/llvm/llvm-project/commit/586547687946b27a99d3bb4241226f9f126a173e DIFF: https://github.com/llvm/llvm-project/commit/586547687946b27a99d3bb4241226f9f126a173e.diff

[clang] 5aba689 - [Clang] Emit a warning for ambiguous joined '-o' arguments

Author: Joseph Huber Date: 2022-10-06T18:20:15-05:00 New Revision: 5aba68960719c5d2de9ee0b459def9203e521f5e URL: https://github.com/llvm/llvm-project/commit/5aba68960719c5d2de9ee0b459def9203e521f5e DIFF: https://github.com/llvm/llvm-project/commit/5aba68960719c5d2de9ee0b459def9203e521f5e.diff

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aba68960719: [Clang] Emit a warning for ambiguous joined -o arguments (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/

[PATCH] D135411: Add generic KCFI operand bundle lowering

kees added a comment. What's the best way to test this in the kernel? I assume add `ARCH_SUPPORTS_CFI_CLANG` to an arch, and see what blows up? :) Have you tried this on any other arch yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1116 +// for the `_cmd` argument that no longer exists for direct methods. +static llvm::Value *emitCmdLoadForGetterSetterBody(CodeGenFunction , +

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen created this revision. Herald added subscribers: Enna1, ormris, pengfei, hiraditya, kristof.beyls. Herald added a project: All. samitolvanen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. The KCFI

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 465913. ayzhao added a comment. implement initialization of remaining elements not in the list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 updated this revision to Diff 465910. qiongsiwu1 added a comment. Thanks for the review! Comment addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files:

[PATCH] D135381: [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader`

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135381/new/ https://reviews.llvm.org/D135381

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debug-options-aranges.c:6 // RUN: %clang -### -g --target=x86_64-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck %s -// CHECK:

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue () { +return takeOwnership(std::make_unique()); + } gribozavr2 wrote: > Should we be creating a new top every time, or should

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:527-528 +auto *Prop2 = Val2.getProperty("has_value"); +return Prop1

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

qiongsiwu1 added a comment. In D134668#3841464 , @MaskRay wrote: > Err since `-plugin-opt=` was used a lot of before this change, I think this > is fine for consistency. Ah ok this sounds good to me as well! Just to make sure I understand, we will

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman updated this revision to Diff 465896. mwyman marked an inline comment as done. mwyman added a comment. Extracted the common new code into a helper function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135091/new/ https://reviews.llvm.org/D135091 Files:

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465894. jhuber6 added a comment. Using the implicit check suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ https://reviews.llvm.org/D135389 Files:

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue () { +return takeOwnership(std::make_unique()); + } Should we be creating a new top every time, or should it be a singleton

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bdfececef43: [HLSL] Remove global ctor/dtor variable for non-lib profile. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2bdfece - [HLSL] Remove global ctor/dtor variable for non-lib profile.

Author: Xiang Li Date: 2022-10-06T15:00:50-07:00 New Revision: 2bdfececef4330b3a6489cdb67c57eb771d5f9e4 URL: https://github.com/llvm/llvm-project/commit/2bdfececef4330b3a6489cdb67c57eb771d5f9e4 DIFF: https://github.com/llvm/llvm-project/commit/2bdfececef4330b3a6489cdb67c57eb771d5f9e4.diff

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

MaskRay added a comment. Err since `-plugin-opt=` was used a lot of before this change, I think this is fine for consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134668/new/ https://reviews.llvm.org/D134668

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s jhuber6 wrote: > tra wrote: > > jhuber6 wrote: > > > tra

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

jwakely added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX)

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet updated this revision to Diff 465888. BigPeet added a comment. - update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 Files:

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

plotfi added a comment. LGTM but waiting on Akira would be nice imho. Comment at: clang/lib/CodeGen/CGObjC.cpp:1192 // corresponding gcc code. -llvm::Value *cmd = - Builder.CreateLoad(GetAddrOfLocalVar(getterMethod->getCmdDecl()), "cmd"); +if

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. BigPeet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Addresses https://github.com/llvm/llvm-project/issues/55870

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

plotfi added a comment. @ahatanak how does this diff look to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135091/new/ https://reviews.llvm.org/D135091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s tra wrote: > jhuber6 wrote: > > tra wrote: > > > Has this patch been updated with

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra accepted this revision. tra added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s jhuber6 wrote: > tra wrote: > > Has this patch been updated with

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465883. jhuber6 added a comment. Apparently `-###` prevents `clang` from returning a non-zero error code. Fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ https://reviews.llvm.org/D135389

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s tra wrote: > Has this patch been updated with incomplete changes? This RUN line seems to

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s Has this patch been updated with incomplete changes? This RUN line seems to miss `2>&1 |

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added a subscriber: jwakely. cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible,

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 added a comment. In D135400#3841321 , @MaskRay wrote: > I missed https://reviews.llvm.org/D134668 . See my comment there I don't > think the change is necessary. Thanks for the comment! I posted a reply there. CHANGES SINCE LAST ACTION

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson created this revision. royjacobson added reviewers: njames93, ymandel, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465876. jhuber6 marked an inline comment as done. jhuber6 added a comment. Changing test to just check that we emit to warnings in a separate run line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

qiongsiwu1 added a comment. In D134668#3841312 , @MaskRay wrote: > I think I want to revert this change. `--plugin-opt=` is entirely fine with > lld and GNU gold/ld... And generally the double-dash long options are > preferred. Sure. What we are

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

stephanemoore accepted this revision. stephanemoore added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1194-1196 + // emitted for it to be passed to the property helper. Since the `_cmd` + // argument was never being initialized by the caller before, still

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, add a TODO to move the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135374/new/ https://reviews.llvm.org/D135374

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

MaskRay added a comment. I missed https://reviews.llvm.org/D134668 . See my comment there I don't think the change is necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 ___ cfe-commits

[PATCH] D134668: [LTO][clang] Using Single Dash Consistently when Passing LTO Options

MaskRay added a comment. I think I want to revert this change. `--plugin-opt=` is entirely fine with lld and GNU gold/ld... And generally the double-dash long options are preferred. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134668/new/

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 updated this revision to Diff 465872. qiongsiwu1 added a comment. Fix a patch upload error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, azat, dblaikie. qiongsiwu1 added projects: clang, LLVM. Herald added subscribers: ormris, StephenFan, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers:

[PATCH] D134733: [clang-format][NFC] more centric handling of include name matching

owenpan added a comment. Can you rebase? I'll finish the review after that. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:410 +llvm::StringRef getIncludeNameFromMatches( +const llvm::SmallVectorImpl ) { + if (Matches.size() >= 3) { Use

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added a comment. Is this option really required? Can we just fix the regression as reported in https://github.com/llvm/llvm-project/issues/56283? It seems that we haven't followed the policy

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Test nit. LGTM otherwise. Comment at: clang/test/Driver/unknown-arg.c:73 +// O-WARN-NEXT: warning: joined argument treated as '-o utput'; did you mean '--output'? +//

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae added a comment. In D133993#3840838 , @efriedma wrote: > It seems like it would be better to put the code in an LLVM IR transform > pass, if we can. It separates the concerns more clearly, and it would make > life easier for other

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

ldionne added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX)

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added a comment. In D135097#3840706 , @aaron.ballman wrote: > I'm also okay with this direction. I took a look to see if people seemed to > be using this option in their build scripts (maybe we would need a louder > deprecation period), and

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, our boolean formulas

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:337 +std::string Nearest; +if (getOpts().findNearest("-" + ArgString, Nearest, IncludedFlagsBitmask, + ExcludedFlagsBitmask) ==

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb added a comment. In D135341#3841126 , @ldionne wrote: > Interesting, I actually wasn't even aware of that C++23 feature in the > library. FWIW, libc++ will be more than happy to use that builtin instead of > trying to figure it out inside the

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465862. jhuber6 added a comment. Adjusting check to ensure that this only applies for an edit length of zero once the `-` is added. Also adding a negative check line for other inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

ldionne added a comment. Interesting, I actually wasn't even aware of that C++23 feature in the library. FWIW, libc++ will be more than happy to use that builtin instead of trying to figure it out inside the library (if that's even possible)! We'll have to check whether GCC implements it, but

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman marked an inline comment as done. mwyman added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:171-177 +// Check the synthesized objectProperty calls objc_getProperty(); this also +// checks that the synthesized method accesses _cmd (or rather loads

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman updated this revision to Diff 465857. mwyman retitled this revision from "Load the `_cmd` selector for generated getters/setters of `direct` Objective-C properties." to "Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C

[PATCH] D135091: Load the `_cmd` selector for generated getters/setters of `direct` Objective-C properties.

stephanemoore accepted this revision. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjC.cpp:1189-1191 // Return (ivar-type) objc_getProperty((id) self, _cmd, offset, true). // FIXME: Can't this be

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0041a69495f8: Thread safety analysis: Support copy-elided production of scoped capabilities… (authored by aaronpuchert). Repository: rG LLVM

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rGd8fa40dfa7ad: Thread safety analysis: Handle additional cast in scoped capability construction

[clang] 0041a69 - Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

Author: Aaron Puchert Date: 2022-10-06T22:19:09+02:00 New Revision: 0041a69495f828f6732803cfb0f1e3fddd7fbf2a URL: https://github.com/llvm/llvm-project/commit/0041a69495f828f6732803cfb0f1e3fddd7fbf2a DIFF: https://github.com/llvm/llvm-project/commit/0041a69495f828f6732803cfb0f1e3fddd7fbf2a.diff

[clang] d8fa40d - Thread safety analysis: Handle additional cast in scoped capability construction

Author: Aaron Puchert Date: 2022-10-06T22:18:26+02:00 New Revision: d8fa40dfa7adb062c969ce7ea6ce505e10626838 URL: https://github.com/llvm/llvm-project/commit/d8fa40dfa7adb062c969ce7ea6ce505e10626838 DIFF: https://github.com/llvm/llvm-project/commit/d8fa40dfa7adb062c969ce7ea6ce505e10626838.diff

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra added a comment. LGTM in principle. Comment at: clang/lib/Driver/Driver.cpp:337 +std::string Nearest; +if (getOpts().findNearest("-" + ArgString, Nearest, IncludedFlagsBitmask, + ExcludedFlagsBitmask) == 1) This looks

[PATCH] D135392: Use PoisonValue in vector BIs [NFC]

ManuelJBrito created this revision. ManuelJBrito added a reviewer: nlopes. ManuelJBrito added a project: clang. Herald added subscribers: dmgreen, arphaman, kbarton, nemanjai. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3839312 , @thieta wrote: > This looks fine to me in principle. But I wonder if we should land the flag > change first separately and make sure that no buildbots break because of it. > Then we can merge the

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

stephanemoore added a comment. LGTM after fixing the assertion ✅ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list

  1   2   3   >