[PATCH] D134749: [clang][Interp] Implement Div opcode

tbaeder updated this revision to Diff 465667. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134749/new/ https://reviews.llvm.org/D134749 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/In

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

thieta added a comment. This looks fine to me in principle. But I wonder if we should land the flag change first separately and make sure that no buildbots break because of it. Then we can merge the simplification a few days later when we are sure it's stabilized, since something similar happen

[PATCH] D135259: [clang] Remove CLANG_ENABLE_OPAQUE_POINTERS cmake option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd785a8eaa25d: [clang] Remove CLANG_ENABLE_OPAQUE_POINTERS cmake option (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[clang] d785a8e - [clang] Remove CLANG_ENABLE_OPAQUE_POINTERS cmake option

Author: Nikita Popov Date: 2022-10-06T09:46:04+02:00 New Revision: d785a8eaa25dd1110dc7b24b16d3b21c9c179837 URL: https://github.com/llvm/llvm-project/commit/d785a8eaa25dd1110dc7b24b16d3b21c9c179837 DIFF: https://github.com/llvm/llvm-project/commit/d785a8eaa25dd1110dc7b24b16d3b21c9c179837.diff

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

kadircet added a comment. In D135257#3836511 , @ilya-biryukov wrote: > Having `nullptr` inside `children()` seems really weird. Should we fix those > instead to never produce `nullptr`? Or is this something that is expected (I > can come up with a few

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:163 clangToolingInclusions + clangToolingInclusionsSTL clangToolingSyntax sammccall wrote: > StandardLibrary or Stdlib? > > STL

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kadircet updated this revision to Diff 465671. kadircet marked 2 inline comments as done. kadircet added a comment. - Rename STL to Stdlib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135245/new/ https://reviews.llvm.org/D135245 Files: clang-to

[PATCH] D129446: [clang][driver] Find Apple default SDK path

MaskRay added a comment. (With configuration file improvement, you can express the intention with a default configuration file.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129446/new/ https://reviews.llvm.org/D129446 __

[clang] d1f13c5 - [clang][Tooling] Move STL recognizer to its own library

Author: Kadir Cetinkaya Date: 2022-10-06T10:09:13+02:00 New Revision: d1f13c54f172875d9a14c46c09afb1f22d78cdf8 URL: https://github.com/llvm/llvm-project/commit/d1f13c54f172875d9a14c46c09afb1f22d78cdf8 DIFF: https://github.com/llvm/llvm-project/commit/d1f13c54f172875d9a14c46c09afb1f22d78cdf8.dif

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1f13c54f172: [clang][Tooling] Move STL recognizer to its own library (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D1

[clang] df61bb2 - [SourceManager] Improve getFileIDLoaded.

Author: Haojian Wu Date: 2022-10-06T10:15:09+02:00 New Revision: df61bb271af9ad6e61c1cd470ea6f4255b2182c7 URL: https://github.com/llvm/llvm-project/commit/df61bb271af9ad6e61c1cd470ea6f4255b2182c7 DIFF: https://github.com/llvm/llvm-project/commit/df61bb271af9ad6e61c1cd470ea6f4255b2182c7.diff LO

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

dang accepted this revision. dang added a comment. In D134813#3838069 , @zixuw wrote: > With the PrintingPolicy fix in https://reviews.llvm.org/D135295 and landed > USR fix, the diff within ExtractAPI tests is only the wording with anonymous > enums, an

[PATCH] D135258: [SourceManager] Improve getFileIDLoaded.

This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rGdf61bb271af9: [SourceManager] Improve getFileIDLoaded. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D135258?vs=465345&id=465678#toc R

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Gentle ping, thank you ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

nikic added a comment. FYI this caused a noticeable compile-time regression (about 0.4% geomean at `-O0`): http://llvm-compile-time-tracker.com/compare.php?from=92233159035d1b50face95d886901cf99035bd99&to=371883f46dc23f8464cbf578e2d12a4f92e61917&stat=instructions Repository: rG LLVM Github M

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

fhahn added a comment. > Adding this metadata allows {loop.vectorize.enable, false} to be used without > disabling the whole pass. Could you please describe the behavior in more detail here? The new metadata should also be documented in `LangRef`, the new pragma in https://clang.llvm.org/docs/

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. @fhahn Thank you very much for the review, backward compatibility is a good point. I will update the revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 _

[PATCH] D135314: [clangd] Avoid scanning up to end of file on each comment!

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. wow, that's an interesting finding. thanks! Comment at: clang-tools-extra/clangd/Headers.cpp:25 -const char IWYUPragmaKeep[] = "// IWYU pragma: keep"; -const char IWYUP

[PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

DavidSpickett added inline comments. Comment at: lldb/test/API/lang/cpp/const_static_integral_member/main.cpp:39 const static auto char_min = std::numeric_limits::min(); const static auto uchar_min = std::numeric_limits::min(); shafik wrote: > We use `sig

[PATCH] D135256: [clang] Add Create method for CXXBoolLiteralExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG7448f38898a8: [clang] Add Create method for CXXBoolLiteralExpr (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135256/new/ https:

[clang] 7448f38 - [clang] Add Create method for CXXBoolLiteralExpr

Author: David Spickett Date: 2022-10-06T09:35:14Z New Revision: 7448f38898a8a0796fa66f1ebcd07c475f329dc4 URL: https://github.com/llvm/llvm-project/commit/7448f38898a8a0796fa66f1ebcd07c475f329dc4 DIFF: https://github.com/llvm/llvm-project/commit/7448f38898a8a0796fa66f1ebcd07c475f329dc4.diff LOG

[PATCH] D135314: [clangd] Avoid scanning up to end of file on each comment!

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:25 -const char IWYUPragmaKeep[] = "// IWYU pragma: keep"; -const char IWYUPragmaExport[] = "// IWYU pragma: export"; -const char IWYUPragmaBeginExports[

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

kadircet added a comment. i'll reland the fix without the test case, as it's clearly fixing one of the codepaths that'll lead to a crash. it's only the test case that's crashing, because i don't think there are certain test cases that exposed literal parser to invalid/incomplete input and i am

[clang-tools-extra] 5d2d527 - [clangd] Avoid scanning up to end of file on each comment!

Author: Sam McCall Date: 2022-10-06T11:38:55+02:00 New Revision: 5d2d527c32da2081b814ef8b446bc3e037f74b0a URL: https://github.com/llvm/llvm-project/commit/5d2d527c32da2081b814ef8b446bc3e037f74b0a DIFF: https://github.com/llvm/llvm-project/commit/5d2d527c32da2081b814ef8b446bc3e037f74b0a.diff LO

[PATCH] D135314: [clangd] Avoid scanning up to end of file on each comment!

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG5d2d527c32da: [clangd] Avoid scanning up to end of file on each comment! (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D135314?vs

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

cor3ntin added a comment. In D135161#3839510 , @kadircet wrote: > i'll reland the fix without the test case, as it's clearly fixing one of the > codepaths that'll lead to a crash. it's only the test case that's crashing, > because i don't think there ar

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a few minor NITs Comment at: clang/include/clang/Sema/Overload.h:1024 /// candidates for operator Op. - bool shouldAddReversed(OverloadedO

[clang] 36f77e2 - Revert "Revert "[clang][Lex] Fix a crash on malformed string literals""

Author: Kadir Cetinkaya Date: 2022-10-06T11:41:18+02:00 New Revision: 36f77e20d9aaaf93a9b00ec1bd6b7e3ceb4918b9 URL: https://github.com/llvm/llvm-project/commit/36f77e20d9aaaf93a9b00ec1bd6b7e3ceb4918b9 DIFF: https://github.com/llvm/llvm-project/commit/36f77e20d9aaaf93a9b00ec1bd6b7e3ceb4918b9.dif

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. I don't see this case different to the unary expressions. Consider the unary minus for example. Let's say, the symbol `a` is constrained to `[1, 1]` and then `-a` is constrained to `[-2, -2]`. This is clearly an infeasible state and the analyzer will terminate the path.

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

martong added a comment. > The two checkers work together and 'apiModeling.StdCLibraryFunctions' > and its 'ModelPOSIX=true' option should be now a dependency of > checker 'alpha.unix.Stream'. Is there a way to stop the analysis with an error if "ModelPOSIX=true" is not set but the 'alpha.unix.

[PATCH] D135115: [clang-format] update --files help description

HazardyKnusperkeks added a comment. It's too long ago for me. Does the `--files` option take multiple file names on the command line, or a file containing the file names? If the latter the patch generally looks good. Except for the `@` part. (Which also isn't handles by clang-format, or is it?

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource marked 2 inline comments as done. tomasz-kaminski-sonarsource added a comment. Where should I add As a result of our internal test on around ~170 projects (~20 Widnows, ~150 Linux) that are compromised of several hundreds of millions of lines of code, the impact on th

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 465686. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files: clang/do

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

ilya-biryukov added a comment. I don't think it's unreasonable to protect against `nullptr` in individual fields. We need **some** value for it and null is a reasonable choice. However, it feels completely wrong to have `nullptr` in collections. Those should be filtered out upon creation, if pos

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

ilya-biryukov added a comment. I guess my question is: is there any fundamental reason why we think we **need** to allow `nullptr` children in `Stmt`? What are the places that actually need it? A quick search shows there are quite a few places in our codebase (many google-internal) that don't

[clang] 89810ce - [RelativeVTablesABI] Convert tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2022-10-06T12:37:42+02:00 New Revision: 89810cee544db09fbf7d578c6e93db7a9cb0d9e5 URL: https://github.com/llvm/llvm-project/commit/89810cee544db09fbf7d578c6e93db7a9cb0d9e5 DIFF: https://github.com/llvm/llvm-project/commit/89810cee544db09fbf7d578c6e93db7a9cb0d9e5.diff

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

goncharov added subscribers: dexonsmith, goncharov. goncharov added a comment. That change might be problematic for content addressing storages. E.g. clang/test/Driver/cl-pch-showincludes.cpp started to fail as clang/test/Driver/header{0,1,3,4}.h are all identical and can be symlinked. cc @dexo

[clang] 956f7f2 - [CodeGenCXX] Remove typed pointer check lines from test (NFC)

Author: Nikita Popov Date: 2022-10-06T13:06:02+02:00 New Revision: 956f7f2b4f785271f7fde2a6ff83472d9451968f URL: https://github.com/llvm/llvm-project/commit/956f7f2b4f785271f7fde2a6ff83472d9451968f DIFF: https://github.com/llvm/llvm-project/commit/956f7f2b4f785271f7fde2a6ff83472d9451968f.diff

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Different loop termination conditions resulted in confusion of whether *Offset was

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/object-size-flex-array.c:45 + // CHECK-STRICT-2: ret i32 -1 + // CHECK-STRICT-3: ret i32 0 return OBJECT_SIZE_BUILTIN(f->c, 1); kees wrote: > serge-sans-paille wrote: > > This one worrie

[clang] 38b9d31 - [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

Author: Utkarsh Saxena Date: 2022-10-06T13:21:34+02:00 New Revision: 38b9d313e6945804fffc654f849cfa05ba2c713d URL: https://github.com/llvm/llvm-project/commit/38b9d313e6945804fffc654f849cfa05ba2c713d DIFF: https://github.com/llvm/llvm-project/commit/38b9d313e6945804fffc654f849cfa05ba2c713d.diff

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38b9d313e694: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/lib/Format/FormatTokenLexer.cpp:767 if (Offset[0] == '\\') { ++Offset; // Skip the escaped character. } else if (Offset + 1 < L

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___ cfe

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

sammccall added a comment. This seems to have regressed comment alignment on unrelated directives: #if 0 #endif #if X int something_fairly_long; // Align here please #endif // Should be aligned These comments were aligned before this patch, but are no longer. I

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. In D134456#3827661 , @aaron.ballman wrote: > Thank you (everyone!) for the discussion on this. To make sure we're all on > the same page for where we're at: > > 1. The changes in this review are reasonable and once review

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 465702. tbaeder added a comment. Another try, this time without any underlying host type. There are a few things I'm uncertain about. The tests are obviously not enough, especially now that I had to add another `CastFP` opcode to cast floats between differe

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:33-34 + /// Primitive representing limits. + // static constexpr auto Min = std::numeric_limits::min(); + // static constexpr auto Max = std::numeric_limits::max(); + This is currently

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 465703. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGe

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added a comment. @aaron.ballman This one has working precommit CI \o/ (array filler patch is not needed for it though) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 ___ cfe-commits mailing

[PATCH] D135314: [clangd] Avoid scanning up to end of file on each comment!

sammccall added a comment. BTW it looks like the 8% profile I saw was an outlier, 3-4% seems more typical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135314/new/ https://reviews.llvm.org/D135314 ___ c

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane updated this revision to Diff 465707. erichkeane marked an inline comment as done. erichkeane added a comment. fix the release note spelling of permanent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.llvm.org/D135287 Files: clang/docs/ReleaseNo

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 465708. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGe

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaConcept.cpp:614 + + static auto UnifyConstraintDepth(Sema &Self, + const NamedDecl *Old,

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaExprCXX.cpp:24 #include "clang/AST/RecursiveASTVisitor.h" +#include "clang/AST/Type.h" #include "clang/AST/TypeLoc.h" ---

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D135361: [clang][Interp] Implement bitwise Or operations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM... Please do the re-ordering separately here, unless it was necessary here. Comment at: clang/lib/Parse/ParseExpr.cpp:1071 REVERTIBLE_TYPE_TRAIT(__is_

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

erichkeane added a comment. Please make sure these are going to be OK with libc++ here. "Triviality" is a bit of a hard nut, the standards have re-defined what they mean quite a few times, so this ends up being pretty worthless if it doesn't match the 'version' of this check that the library i

[PATCH] D135239: [clang] adds copy-assignable type-trait builtins

erichkeane added a comment. Same comment as the previous patch on triviality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135239/new/ https://reviews.llvm.org/D135239 ___ cfe-commits mailing list cfe-c

[PATCH] D135240: [clang] adds move-constructible type-trait builtins

erichkeane added a comment. Same comments on triviality here unfortunately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135240/new/ https://reviews.llvm.org/D135240 ___ cfe-commits mailing list cfe-com

[PATCH] D135338: [clang] adds move-assignable type-trait builtins

erichkeane added a comment. Once again, concerns about triviality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135338/new/ https://reviews.llvm.org/D135338 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D135362: [clang] Make variables of undeduced types to have dependent alignment

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, rsmith, mizvekov. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch `VarDecl::hasDependent()` checks only undeduced

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

erichkeane added a comment. This doesn't cause us to lose this in Microsoft C mode, does it? Otherwise, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135339/new/ https://reviews.llvm.org/D135339

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske added a reviewer: martong. balazske added a comment. Herald added a subscriber: rnkovacs. I found some anomalies during development: - If the checker **StdCLibraryFunctions** is added as dependency for **alpha.unix.Stream** in //checkers.td// I get some "unexplainable" test failures. -

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

thakis added a comment. Thanks! Comment at: clang/lib/Tooling/Inclusions/STL/CMakeLists.txt:2 +add_clang_library(clangToolingInclusionsSTL + StandardLibrary.cpp + kadircet wrote: > sammccall wrote: > > This means the implementation files and the header files h

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

thakis added a comment. (Alternatively, it looks like the only client is clangd, so maybe the file could just live in there instead of being in a dedicated library with a single client.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135245/new/ h

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Comment at: clang/test/OpenMP/target_map_codegen_10.cpp:19 +// RUN: %clang_cc1 -no-opaque-pointers -DCK11 -fopenmp -fopenmp-targets=i386-pc-linux-gnu -x c++ -std=c+

[PATCH] D135300: [PowerPC] Fix types for vcipher builtins.

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135300/new/ https://reviews.llvm.org/D135300 _

[PATCH] D135287: Disallow dereferencing of void* in C++.

aaron.ballman added a comment. In D135287#3837617 , @erichkeane wrote: > In D135287#3837584 , @jrtc27 wrote: > >> What about `__typeof__(*p)`? > > Yes, that would also be an error in C++, as it is on all other co

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

philnik added a comment. TBH I don't think adding these builtins is worth the extra maintenance cost. libc++'s implementation is already really simple, and actually //uses// `__is_constructible`, contrary to the statement in the summary. This is the whole implementation currently: template

[clang] 364003e - [clang][C++20] Note github issue in the FIXME matching requires clause.

Author: Utkarsh Saxena Date: 2022-10-06T16:00:54+02:00 New Revision: 364003e2da7f233725d6200ff469f80cc65b17c5 URL: https://github.com/llvm/llvm-project/commit/364003e2da7f233725d6200ff469f80cc65b17c5 DIFF: https://github.com/llvm/llvm-project/commit/364003e2da7f233725d6200ff469f80cc65b17c5.diff

[PATCH] D135362: [clang] Make variables of undeduced types to have dependent alignment

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135362/new/ https://reviews.llvm.org/D135362 ___

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

emaste added a comment. > The time_t value may be negative True, but we do not need to allow a negative `SOURCE_DATE_EPOCH` though. The spec implies that it must be nonnegative, although doesn't say so explicitly. https://reproducible-builds.org/specs/source-date-epoch/ Repository: rG LLVM

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir added a comment. > That change might be problematic for content addressing storages. E.g. > clang/test/Driver/cl-pch-showincludes.cpp started to fail in my setup as > clang/test/Driver/header{0,1,3,4}.h are all identical and can be symlinked What is the failure you're seeing? I wou

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane marked 4 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6939-6942 + // Note: This uses a different diagnostics group than the C diagnostic + // so that projects that have disabled the ab

[clang] f717050 - Silence a duplicate diagnostic about K&R C function definitions

Author: Aaron Ballman Date: 2022-10-06T10:08:23-04:00 New Revision: f7170500cf10ea9d685eb655c76a7c393fb18708 URL: https://github.com/llvm/llvm-project/commit/f7170500cf10ea9d685eb655c76a7c393fb18708 DIFF: https://github.com/llvm/llvm-project/commit/f7170500cf10ea9d685eb655c76a7c393fb18708.diff

[PATCH] D134749: [clang][Interp] Implement Div opcode

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a simple refactoring (feel free to apply it when landing or do it post-commit as an NFC change). Comment at: clang/lib/AST/Interp/Interp.h:203-211 + if (LHS.isSigned() && LHS.isMin() && RHS.i

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane updated this revision to Diff 465725. erichkeane marked 2 inline comments as done. erichkeane added a comment. Fix based on Aaron's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.llvm.org/D135287 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 __

[PATCH] D134788: [ARM64EC][clang-cl] Add arm64EC test; NFC

DavidSpickett added a comment. This (and it's followup?) has been landed, right? Please close the revision if so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134788/new/ https://reviews.llvm.org/D134788 ___ cfe-commits mailing list cfe-com

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135306/new/ https://reviews.llvm.org/D135306 __

[clang] 8788374 - [ASTMatchers][NFC] Fix wrong code ending command in documentation comments

Author: oToToT Date: 2022-10-06T22:32:15+08:00 New Revision: 87883740ebb3f733985d47e7b3d6b0a4e6670c78 URL: https://github.com/llvm/llvm-project/commit/87883740ebb3f733985d47e7b3d6b0a4e6670c78 DIFF: https://github.com/llvm/llvm-project/commit/87883740ebb3f733985d47e7b3d6b0a4e6670c78.diff LOG: [

[clang] ac135f9 - [Clang] Fix using LTO with the new driver in RDC-mode

Author: Joseph Huber Date: 2022-10-06T09:36:09-05:00 New Revision: ac135f9ee574e7451088926c667d93d51a3d6940 URL: https://github.com/llvm/llvm-project/commit/ac135f9ee574e7451088926c667d93d51a3d6940 DIFF: https://github.com/llvm/llvm-project/commit/ac135f9ee574e7451088926c667d93d51a3d6940.diff

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGac135f9ee574: [Clang] Fix using LTO with the new driver in RDC-mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https:/

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:47 + bool HasThisPointer = false; + if (const auto *MD = dyn_cast(F); MD && !MD->isStatic()) { +HasThisPointer = true; Comment at: clang/lib/AST/In

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl updated this revision to Diff 465731. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. update comments with issue link CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135269/new/ https://reviews.llvm.org/D135269 Files:

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

jcranmer-intel added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:33-34 + /// Primitive representing limits. + // static constexpr auto Min = std::numeric_limits::min(); + // static constexpr auto Max = std::numeric_limits::max(); + tbaeder wro

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:767 if (Offset[0] == '\\') { ++Offset; // Skip the escaped character. } else if (Offset + 1 < Lex->getBuffer().end() && Offset[0] == '$'

[clang] 882a05a - [Format] Fix crash when hitting eof while lexing JS template string

Author: Sam McCall Date: 2022-10-06T17:00:41+02:00 New Revision: 882a05afa17f2a8863978027f562934cd7a7d179 URL: https://github.com/llvm/llvm-project/commit/882a05afa17f2a8863978027f562934cd7a7d179 DIFF: https://github.com/llvm/llvm-project/commit/882a05afa17f2a8863978027f562934cd7a7d179.diff LO

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG882a05afa17f: [Format] Fix crash when hitting eof while lexing JS template string (authored by sammccall). Changed prior to commit: https://review

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: njames93, klimek. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber: cf

[PATCH] D134749: [clang][Interp] Implement Div opcode

tbaeder added a comment. In D134749#3839980 , @aaron.ballman wrote: > LGTM aside from a simple refactoring (feel free to apply it when landing or > do it post-commit as an NFC change). I actually suggested something like this review :P I'll write it do

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:421 +bool CastFP(InterpState &S, CodePtr OpPC, const llvm::fltSemantics *Sem) { + Floating F = S.Stk.pop(); jcranmer-intel wrote: > FWIW, `const llvm::fltSemantics &` is the usual way i

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

dexonsmith added a comment. In D135220#3839671 , @goncharov wrote: > That change might be problematic for content addressing storages. E.g. > clang/test/Driver/cl-pch-showincludes.cpp started to fail in my setup as > clang/test/Driver/header{0,1,3,4}.h

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:638 if (const auto CtorExpr = dyn_cast(Initializer)) { -const CXXConstructorDecl *Ctor = CtorExpr->getConstructor(); -const RecordDecl *RD = Ct

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

thakis added a comment. This breaks tests: http://45.33.8.238/linux/88341/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135356/new/ https://reviews.llvm.org/D135356

[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

This revision was automatically updated to reflect the committed changes. Closed by commit rG561443818a15: [clangd] Optimize Dex::generateProximityURIs(). (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135226/new/ https://rev

[clang-tools-extra] 5614438 - [clangd] Optimize Dex::generateProximityURIs().

Author: Sam McCall Date: 2022-10-06T17:01:04+02:00 New Revision: 561443818a15e7b368ddbb58207a14c60ba55c58 URL: https://github.com/llvm/llvm-project/commit/561443818a15e7b368ddbb58207a14c60ba55c58 DIFF: https://github.com/llvm/llvm-project/commit/561443818a15e7b368ddbb58207a14c60ba55c58.diff LO

  1   2   3   >