[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467812. python3kgae added a comment. Fix clang-format missed by arc lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951 Files:

[PATCH] D134681: [Clang][AArch64] Add SME outer product intrinsics

rsandifo-arm added a comment. Thanks for the patch. This is going to be inconvenient, sorry, but: while implementing the specification in GCC, I noticed that the ZA functions weren't consistent about whether they had an `_m` suffix. `svwrite` (MOVA) had one, but the MOP intrinsics that

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall added a comment. Sorry, I responded as if you were modifying the guards of static constructors, but you're actually modifying the guards of thread locals. I apologize for the confusion. However, my substantive points actually all still hold: - we have to generate code that behaves

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

hubert.reinterpretcast added a comment. In D135919#3858808 , @rjmccall wrote: > We can't set the flag if initialization is aborted by an exception, which is > not ruled out by the use of thread-unsafe statics. So this is not a correct > change.

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper added a comment. In D116735#3857705 , @zixuan-wu wrote: > In D116735#3429850 , @craig.topper > wrote: > >> I'm seeing a regression on 401.bzip2 and possibly 471.astar. And I'm not >> seeing large

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. We can't set the flag if initialization is aborted by an exception, which is not ruled out by the use of thread-unsafe statics. So this is not a correct change. More

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

ChuanqiXu added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:479-480 + + llvm::copy_if(D->attrs(), std::back_inserter(HashableAttrs), +[](const Attr *A) { return !A->isImplicit(); }); +} aaron.ballman wrote: > ChuanqiXu wrote: > >

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

xazax.hun added a comment. In D135964#3858706 , @ymandel wrote: > Reviewers: I'm inclined towards a method vs overloaded operator. Please let > me know. I don't have a strong preference. But in case we come up with multiple kinds of equalities (see my

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

MyDeveloperDay added a comment. Did you test this with nested #if #endif? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 ___ cfe-commits mailing list

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rjmccall added a comment. Does Fuchsia still need this? If those experiments have stabilized, maybe we can just remove it. Also, it should probably have been a -cc1 flag in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Value.cpp:37 + areEquivalentIndirectionValues(Val1, Val2)) && +

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. I think you also need to rebase to get rid of the "ClangFormatStyleOptions.rst" (which means you need to rebase and rerun dump_format_style.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/

[clang] 174e954 - [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

Author: Andrzej Warzynski Date: 2022-10-14T16:20:04Z New Revision: 174e954e370e4f2ae82fea3f959e843bc05e3046 URL: https://github.com/llvm/llvm-project/commit/174e954e370e4f2ae82fea3f959e843bc05e3046 DIFF: https://github.com/llvm/llvm-project/commit/174e954e370e4f2ae82fea3f959e843bc05e3046.diff

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG174e954e370e: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions` (authored by awarzynski). Changed prior to commit:

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. Can you mark your comments done, I think you missed removing some braces that @HazardyKnusperkeks asked you to remove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3857816 , @owenpan wrote: > In D129443#3857608 , @rymiel wrote: > >> Changing the default LLVM style would change the output of all the >> requires-related test

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. For me this is good. But please wait for @MyDeveloperDay . Comment at: clang/lib/Format/WhitespaceManager.cpp:931-933 + if (Style.AlignTrailingComments.Kind == FormatStyle::TCAS_Always) { +

[PATCH] D135966: [X86] Use unsigned int for return type of __get_cpuid_max.

craig.topper created this revision. craig.topper added reviewers: RKSimon, pengfei. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. It looks like gcc's header already uses unsigned int and we should

[clang-tools-extra] 68d714b - [clang-tidy] Use std::underlying_type_t (NFC)

Author: Kazu Hirata Date: 2022-10-14T09:10:09-07:00 New Revision: 68d714b5410209871843f6a5198db95c63da16e8 URL: https://github.com/llvm/llvm-project/commit/68d714b5410209871843f6a5198db95c63da16e8 DIFF: https://github.com/llvm/llvm-project/commit/68d714b5410209871843f6a5198db95c63da16e8.diff

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

ymandel added a comment. Reviewers: I'm inclined towards a method vs overloaded operator. Please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135964/new/ https://reviews.llvm.org/D135964

[PATCH] D131944: [analyzer] Remove pattern matching of lambda capture initializers

isuckatcs marked an inline comment as done. isuckatcs added inline comments. Comment at: clang/test/Analysis/lambdas.cpp:226 + [uniquePtr = MakeUniquePtr()] {}(); + clang_analyzer_warnIfReached(); // expected-warning{{TRUE}} +} steakhal wrote: > It should have

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Defines `operator==` as an

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski abandoned this revision. awarzynski added a comment. In D125788#3622274 , @clementval wrote: > There are open discussion so wait for other to confirm or not. I was under the impression that we did discuss this extensively in our community

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

zahiraam added a comment. In D135963#3858638 , @aaron.ballman wrote: > LGTM -- btw, feel free to land fixes to buildbot breaks without code review. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- btw, feel free to land fixes to buildbot breaks without code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 41ac5d2 - [clang] Fix a warning

Author: Kazu Hirata Date: 2022-10-14T08:36:59-07:00 New Revision: 41ac5d258da3045c871344400aa9e59640ce76a5 URL: https://github.com/llvm/llvm-project/commit/41ac5d258da3045c871344400aa9e59640ce76a5 DIFF: https://github.com/llvm/llvm-project/commit/41ac5d258da3045c871344400aa9e59640ce76a5.diff

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135963 Files: clang/lib/CodeGen/CGCall.cpp Index:

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added a comment. In D135690#3858541 , @aaron.ballman wrote: > In D135690#3856863 , @Trass3r wrote: > >> Didn't realize it has a big cost. Looking inside the `AST_MATCHER` and >> `REGISTER_MATCHER`

[PATCH] D133359: [AArch64] Make ACLE intrinsics always available part1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30b67c677c6b: [AArch64] Make ACLE intrinsics always available part1 (authored by danielkiss). Herald added a project: clang. Herald added a

[clang] 30b67c6 - [AArch64] Make ACLE intrinsics always available part1

Author: Daniel Kiss Date: 2022-10-14T17:23:11+02:00 New Revision: 30b67c677c6baf0d6ef6c3051cf270133c43e4d2 URL: https://github.com/llvm/llvm-project/commit/30b67c677c6baf0d6ef6c3051cf270133c43e4d2 DIFF: https://github.com/llvm/llvm-project/commit/30b67c677c6baf0d6ef6c3051cf270133c43e4d2.diff

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added subscribers: rjmccall, echristo, dblaikie, rsmith. aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++

[PATCH] D131944: [analyzer] Remove pattern matching of lambda capture initializers

steakhal added inline comments. Comment at: clang/test/Analysis/lambdas.cpp:226 + [uniquePtr = MakeUniquePtr()] {}(); + clang_analyzer_warnIfReached(); // expected-warning{{TRUE}} +} It should have said `REACHABLE`. How does this pass? @isuckatcs

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zahiraam marked an inline comment as done. Closed by commit rG84a9ec2ff1ee: Remove redundant option -menable-unsafe-fp-math. (authored by zahiraam). Repository: rG

[clang] 84a9ec2 - Remove redundant option -menable-unsafe-fp-math.

Author: Zahira Ammarguellat Date: 2022-10-14T10:55:29-04:00 New Revision: 84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b URL: https://github.com/llvm/llvm-project/commit/84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b DIFF:

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

aaron.ballman added a comment. In D135690#3856863 , @Trass3r wrote: > In D135690#3852362 , @aaron.ballman > wrote: > >> what's the need for adding this matcher? Do you plan to use it for some >> in-tree needs?

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919

[clang] 6ce8727 - [cmake] Remove LLVM_INCLUDE_GO_TESTS variable

Author: Nikita Popov Date: 2022-10-14T16:34:36+02:00 New Revision: 6ce87272487711c9f0ff408a037f5ca2e1ff5c5d URL: https://github.com/llvm/llvm-project/commit/6ce87272487711c9f0ff408a037f5ca2e1ff5c5d DIFF: https://github.com/llvm/llvm-project/commit/6ce87272487711c9f0ff408a037f5ca2e1ff5c5d.diff

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong added a comment. In D101526#3804623 , @NoQ wrote: > Hi, looks great! I found a couple of typos and the amount of changes in tests > is suspiciously low. And I want to make sure that the promise to change "arg" > -> "argument" isn't lost (but

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong updated this revision to Diff 467773. martong added a comment. - Changed to be more verbose: "arg" -> "argument" - Fixed "less than" to "greater than" - Added new tests - Fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101526/new/

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong updated this revision to Diff 467772. martong marked 3 inline comments as done. martong added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101526/new/ https://reviews.llvm.org/D101526 Files:

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a31970ee2af: [C2x] Implement support for nullptr and nullptr_t (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3a31970 - [C2x] Implement support for nullptr and nullptr_t

Author: Aaron Ballman Date: 2022-10-14T10:06:02-04:00 New Revision: 3a31970ee2af24ffcfd4b6fc11ac9bdf4d4ef2e8 URL: https://github.com/llvm/llvm-project/commit/3a31970ee2af24ffcfd4b6fc11ac9bdf4d4ef2e8 DIFF: https://github.com/llvm/llvm-project/commit/3a31970ee2af24ffcfd4b6fc11ac9bdf4d4ef2e8.diff

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135834/new/ https://reviews.llvm.org/D135834

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06da9b94ae37: [OpenMP] Extend the lit test for uses_allocators in target region (authored by animeshk-amd). Repository: rG LLVM Github Monorepo

[clang] 06da9b9 - [OpenMP] Extend the lit test for uses_allocators in target region

Author: Animesh Kumar Date: 2022-10-14T19:12:33+05:30 New Revision: 06da9b94ae374f81a0898b01608c1c3529dfa29a URL: https://github.com/llvm/llvm-project/commit/06da9b94ae374f81a0898b01608c1c3529dfa29a DIFF: https://github.com/llvm/llvm-project/commit/06da9b94ae374f81a0898b01608c1c3529dfa29a.diff

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

aaron.ballman added a comment. In D135472#3856596 , @vsapsai wrote: > Given all the discussion about which attributes should be added to ODR hash, > I think it is useful at this point to have TableGen infrastructure to get > this information from

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added a comment. I'm out of machines next two days. Sorry for late address in advance... I'll update next Monday. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135931/new/ https://reviews.llvm.org/D135931

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

erichkeane added a comment. So this logically looks/sounds right to me (and I have no code concerns)... But I'm also notoriously bad at anything threading related. I'd love it if one of the other reviewers could sanity check this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

erichkeane accepted this revision. erichkeane added a comment. I would love it if the diagnostic had a little more info why it isn't, but this is probably good enough for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134928/new/

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

aaron.ballman added a comment. In D120862#3857372 , @shafik wrote: > In D120862#3857340 , @pcc wrote: > >> Does that DR apply retroactively to C++17? I get the impression that >> "Status: C++20" means that the

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane updated this revision to Diff 467762. erichkeane marked an inline comment as done. erichkeane added a comment. Thanks for the review @shafik CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 Files: clang/include/clang/Sema/Sema.h

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134928/new/ https://reviews.llvm.org/D134928

[clang] dcee874 - Fix the ExtractAPI tests

Author: Aaron Ballman Date: 2022-10-14T08:58:16-04:00 New Revision: dcee874ee3900fe1617c7562c774e5405439f5c9 URL: https://github.com/llvm/llvm-project/commit/dcee874ee3900fe1617c7562c774e5405439f5c9 DIFF: https://github.com/llvm/llvm-project/commit/dcee874ee3900fe1617c7562c774e5405439f5c9.diff

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd updated this revision to Diff 467757. animeshk-amd added a comment. Another patch that landed after this patch introduced merge conflicts in the target_map_codegen_10.cpp with regards to the use of the `-no-opaque-pointers`. Those merge conflicts are fixed in the revision.

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG5a859432f317: [clang][Interp] Implement while and do-while loops (authored by tbaeder). Changed prior to commit:

[clang] 5a85943 - [clang][Interp] Implement while and do-while loops

Author: Timm Bäder Date: 2022-10-14T14:41:05+02:00 New Revision: 5a859432f31716f780cd662741864ef1a77fc28a URL: https://github.com/llvm/llvm-project/commit/5a859432f31716f780cd662741864ef1a77fc28a DIFF: https://github.com/llvm/llvm-project/commit/5a859432f31716f780cd662741864ef1a77fc28a.diff

[clang] 6fad712 - [clang][Interp][NFC] Remove unused parameter from emitConst()

Author: Timm Bäder Date: 2022-10-14T14:41:05+02:00 New Revision: 6fad7127cb990894cc2392c89152a36af7808736 URL: https://github.com/llvm/llvm-project/commit/6fad7127cb990894cc2392c89152a36af7808736 DIFF: https://github.com/llvm/llvm-project/commit/6fad7127cb990894cc2392c89152a36af7808736.diff

[clang] e83bea4 - [clang][Interp][NFC] Add some tests for invalid array access

Author: Timm Bäder Date: 2022-10-14T14:41:05+02:00 New Revision: e83bea40b6c45bf2a8d4983238da32b5d2be80fc URL: https://github.com/llvm/llvm-project/commit/e83bea40b6c45bf2a8d4983238da32b5d2be80fc DIFF: https://github.com/llvm/llvm-project/commit/e83bea40b6c45bf2a8d4983238da32b5d2be80fc.diff

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations,

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 467749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19e984ef8f49: Properly print unnamed TagDecl objects in diagnostics (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[clang] 19e984e - Properly print unnamed TagDecl objects in diagnostics

Author: Aaron Ballman Date: 2022-10-14T08:18:28-04:00 New Revision: 19e984ef8f49bc3ccced15621989fa9703b2cd5b URL: https://github.com/llvm/llvm-project/commit/19e984ef8f49bc3ccced15621989fa9703b2cd5b DIFF: https://github.com/llvm/llvm-project/commit/19e984ef8f49bc3ccced15621989fa9703b2cd5b.diff

[PATCH] D135361: [clang][Interp] Implement bitwise Or operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce4d5ae9dcf6: [clang][Interp] Implement bitwise Or operations (authored by tbaeder). Changed prior to commit:

[clang] ce4d5ae - [clang][Interp] Implement bitwise Or operations

Author: Timm Bäder Date: 2022-10-14T14:15:08+02:00 New Revision: ce4d5ae9dcf64deade70f305b8d7ab8d0dc80102 URL: https://github.com/llvm/llvm-project/commit/ce4d5ae9dcf64deade70f305b8d7ab8d0dc80102 DIFF: https://github.com/llvm/llvm-project/commit/ce4d5ae9dcf64deade70f305b8d7ab8d0dc80102.diff

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SolverTest.cpp:69 -TEST(SolverTest, UnitConflict) { - ConstraintContext Ctx; gribozavr2 wrote: > Why delete this test? That was a

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467746. ymandel marked an inline comment as done. ymandel added a comment. Adding back accidentally deleted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397

[clang] 62a5805 - [clang][Interp] Implement bitwise and operations

Author: Timm Bäder Date: 2022-10-14T14:00:07+02:00 New Revision: 62a58050ba0afad5c1ca59195f10c6fdc0e0feaa URL: https://github.com/llvm/llvm-project/commit/62a58050ba0afad5c1ca59195f10c6fdc0e0feaa DIFF: https://github.com/llvm/llvm-project/commit/62a58050ba0afad5c1ca59195f10c6fdc0e0feaa.diff

[PATCH] D135012: [clang][Interp] Implement bitwise and operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62a58050ba0a: [clang][Interp] Implement bitwise and operations (authored by tbaeder). Changed prior to commit:

[clang] 11f3604 - [clang][Interp][NFC] Remove an unnecessary local variable

Author: Timm Bäder Date: 2022-10-14T13:33:04+02:00 New Revision: 11f360469599e5c7c470b2071692fc6647cf3280 URL: https://github.com/llvm/llvm-project/commit/11f360469599e5c7c470b2071692fc6647cf3280 DIFF: https://github.com/llvm/llvm-project/commit/11f360469599e5c7c470b2071692fc6647cf3280.diff

[clang] 1b731bd - [clang][Interp][NFC] Zero-initialize Function::FrameSize

Author: Timm Bäder Date: 2022-10-14T13:32:55+02:00 New Revision: 1b731bd8724c2f56550f87d3c4f0fa820b8b4527 URL: https://github.com/llvm/llvm-project/commit/1b731bd8724c2f56550f87d3c4f0fa820b8b4527 DIFF: https://github.com/llvm/llvm-project/commit/1b731bd8724c2f56550f87d3c4f0fa820b8b4527.diff

[clang] 7fbfe55 - [clang][Interp][NFC] Rename a parameter to be more descriptive

Author: Timm Bäder Date: 2022-10-14T13:32:31+02:00 New Revision: 7fbfe5518c363da8ee7eb60352948f0e904f283b URL: https://github.com/llvm/llvm-project/commit/7fbfe5518c363da8ee7eb60352948f0e904f283b DIFF: https://github.com/llvm/llvm-project/commit/7fbfe5518c363da8ee7eb60352948f0e904f283b.diff

[clang] 9b2f2d8 - [clang][Interp][NFC] Remove unused function

Author: Timm Bäder Date: 2022-10-14T13:32:00+02:00 New Revision: 9b2f2d846345dfbc4256db1ebf2b6176553fa157 URL: https://github.com/llvm/llvm-project/commit/9b2f2d846345dfbc4256db1ebf2b6176553fa157 DIFF: https://github.com/llvm/llvm-project/commit/9b2f2d846345dfbc4256db1ebf2b6176553fa157.diff

[clang] 0e69014 - [clang][Interp][NFC] Add a failing test case

Author: Timm Bäder Date: 2022-10-14T13:31:52+02:00 New Revision: 0e6901421247b1c7ce0a2e925666d5314a34fffa URL: https://github.com/llvm/llvm-project/commit/0e6901421247b1c7ce0a2e925666d5314a34fffa DIFF: https://github.com/llvm/llvm-project/commit/0e6901421247b1c7ce0a2e925666d5314a34fffa.diff

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SolverTest.cpp:69 -TEST(SolverTest, UnitConflict) { - ConstraintContext Ctx; Why delete this test? Repository: rG LLVM Github Monorepo

[clang] 77aaf46 - [clang][Interp] Implement ConditionalOperators

Author: Timm Bäder Date: 2022-10-14T13:16:10+02:00 New Revision: 77aaf469a7ae5af26a8fe92ed9d548404831d3ed URL: https://github.com/llvm/llvm-project/commit/77aaf469a7ae5af26a8fe92ed9d548404831d3ed DIFF: https://github.com/llvm/llvm-project/commit/77aaf469a7ae5af26a8fe92ed9d548404831d3ed.diff

[PATCH] D134801: [clang][Interp] Implement ConditionalOperators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77aaf469a7ae: [clang][Interp] Implement ConditionalOperators (authored by tbaeder). Changed prior to commit:

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

sammccall added reviewers: kadircet, hokein. sammccall added a comment. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/0cc7dd1f6c5605837966cb113babe591/raw/7c9a29142eca1fc1f486540f255586a0f72a9c9e/AST.html This is missing tests, my plan is: - add some basic

[PATCH] D134629: [clang][Interp] Fix Pointer::toAPValue() LValuePath order

tbaeder closed this revision. tbaeder added a comment. Meh, looks like I forgot to fix up the commit message for https://github.com/llvm/llvm-project/commit/4d2d426a51e122231443d89b196b0c6e91a5b147. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134629/new/

[PATCH] D134749: [clang][Interp] Implement Div opcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd704ba26b914: [clang][Interp] Implement div opcode (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134744: [clang][Interp] Implement rem opcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9ad877844a7: [clang][Interp] Implement rem opcode (authored by tbaeder). Changed prior to commit:

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG542123465f9e: [clang][Interp] Implement bitwise not operations (authored by tbaeder). Changed prior to commit:

[clang] d704ba2 - [clang][Interp] Implement div opcode

Author: Timm Bäder Date: 2022-10-14T12:57:57+02:00 New Revision: d704ba26b9144829f1c4905c168f6b6278c7a3e6 URL: https://github.com/llvm/llvm-project/commit/d704ba26b9144829f1c4905c168f6b6278c7a3e6 DIFF: https://github.com/llvm/llvm-project/commit/d704ba26b9144829f1c4905c168f6b6278c7a3e6.diff

[clang] c9ad877 - [clang][Interp] Implement rem opcode

Author: Timm Bäder Date: 2022-10-14T12:57:57+02:00 New Revision: c9ad877844a7fd52726ed3f11bb6e7fb90e9358e URL: https://github.com/llvm/llvm-project/commit/c9ad877844a7fd52726ed3f11bb6e7fb90e9358e DIFF: https://github.com/llvm/llvm-project/commit/c9ad877844a7fd52726ed3f11bb6e7fb90e9358e.diff

[clang] 5421234 - [clang][Interp] Implement bitwise not operations

Author: Timm Bäder Date: 2022-10-14T12:57:57+02:00 New Revision: 542123465f9e523ccd82bd91ee17f407ea4b0cd1 URL: https://github.com/llvm/llvm-project/commit/542123465f9e523ccd82bd91ee17f407ea4b0cd1 DIFF: https://github.com/llvm/llvm-project/commit/542123465f9e523ccd82bd91ee17f407ea4b0cd1.diff

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

sammccall created this revision. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The immediate goal is to start producing an HTML report to debug and

[clang] 81c5b5d - [clang][Interp][NFC] Simplify Integral using constexpr if

Author: Timm Bäder Date: 2022-10-14T12:47:07+02:00 New Revision: 81c5b5d80efab9de616d6f8e42cd007f9c16e36b URL: https://github.com/llvm/llvm-project/commit/81c5b5d80efab9de616d6f8e42cd007f9c16e36b DIFF: https://github.com/llvm/llvm-project/commit/81c5b5d80efab9de616d6f8e42cd007f9c16e36b.diff

[clang] 699449d - [clang][Interp][NFC] Use a SourceRange for errors

Author: Timm Bäder Date: 2022-10-14T12:46:51+02:00 New Revision: 699449d71eadb1499bf6a98999c2abdaa6b1294a URL: https://github.com/llvm/llvm-project/commit/699449d71eadb1499bf6a98999c2abdaa6b1294a DIFF: https://github.com/llvm/llvm-project/commit/699449d71eadb1499bf6a98999c2abdaa6b1294a.diff

[clang] 4d2d426 - [clang][Interp] Fix Pointer::toAPValue() LValuePath order

Author: Timm Bäder Date: 2022-10-14T12:31:24+02:00 New Revision: 4d2d426a51e122231443d89b196b0c6e91a5b147 URL: https://github.com/llvm/llvm-project/commit/4d2d426a51e122231443d89b196b0c6e91a5b147 DIFF: https://github.com/llvm/llvm-project/commit/4d2d426a51e122231443d89b196b0c6e91a5b147.diff

[clang] 55c7ad3 - [clang][Interp][NFC] Pass Function* pointers around as const

Author: Timm Bäder Date: 2022-10-14T12:31:24+02:00 New Revision: 55c7ad31aacb6cdef19a7296fda56cc8b177e2b4 URL: https://github.com/llvm/llvm-project/commit/55c7ad31aacb6cdef19a7296fda56cc8b177e2b4 DIFF: https://github.com/llvm/llvm-project/commit/55c7ad31aacb6cdef19a7296fda56cc8b177e2b4.diff

[clang] 6e83209 - [clang][Interp] Fix copy constructors with record array members

Author: Timm Bäder Date: 2022-10-14T11:57:26+02:00 New Revision: 6e83209f623e00b16f5858efbfa0fd6409abf1fe URL: https://github.com/llvm/llvm-project/commit/6e83209f623e00b16f5858efbfa0fd6409abf1fe DIFF: https://github.com/llvm/llvm-project/commit/6e83209f623e00b16f5858efbfa0fd6409abf1fe.diff

[PATCH] D134523: [clang][Interp] Fix copy constructors with record array members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e83209f623e: [clang][Interp] Fix copy constructors with record array members (authored by tbaeder). Changed prior to commit:

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:64 +using SymbolLocation = std::variant; +/// A set of locations that provides the declaration, while indicating if This is an important public API concept

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay added a comment. Thanks @rymiel its great to have another active contributor, especially one who seems so focused on github issues. Really appreciate your recent contributions. Can we start including you as one of the default reviewers that we use to review our stuff?

[clang] b3d495e - [clang][Interp][NFC] Explain why tests are disabled

Author: Timm Bäder Date: 2022-10-14T11:47:25+02:00 New Revision: b3d495e7e082c3a3c77bfcf2ed928f6f18f69fc4 URL: https://github.com/llvm/llvm-project/commit/b3d495e7e082c3a3c77bfcf2ed928f6f18f69fc4 DIFF: https://github.com/llvm/llvm-project/commit/b3d495e7e082c3a3c77bfcf2ed928f6f18f69fc4.diff

[clang] 7229227 - [clang][Interp][NFC] Run record tests on i686 as well

Author: Timm Bäder Date: 2022-10-14T11:19:24+02:00 New Revision: 72292271f6635a812bef42814808f60070297268 URL: https://github.com/llvm/llvm-project/commit/72292271f6635a812bef42814808f60070297268 DIFF: https://github.com/llvm/llvm-project/commit/72292271f6635a812bef42814808f60070297268.diff

[clang] ae27323 - [clang][Interp] Classify ArrayInitIndexExpr type

Author: Timm Bäder Date: 2022-10-14T11:10:28+02:00 New Revision: ae27323428ff9666b1c4cf32e0ea928681ce778e URL: https://github.com/llvm/llvm-project/commit/ae27323428ff9666b1c4cf32e0ea928681ce778e DIFF: https://github.com/llvm/llvm-project/commit/ae27323428ff9666b1c4cf32e0ea928681ce778e.diff

[PATCH] D135937: [X86] Support -march=meteorlake

RKSimon added a comment. Please add this to llvm-project\llvm\test\CodeGen\X86\cpus-intel.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 ___ cfe-commits

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Creates a one to many

<    1   2   3   >