[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

serge-sans-paille added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 /// static_asserts in Triple.cpp and in clang/Basic/HLSLRuntime.h. enum class ShaderStage { Pixel = 0, Looks unrelated to this patch :-) Comme

[PATCH] D131858: [clang] Track the templated entity in type substitution.

eaeltsin added a comment. Heads-up - I'm seeing the compilation failure that reduces to this commit. I didn't get a reproducer of the reasonable size yet :( The problem occurs when using modules only. The module has code like: template class A { public: T x; template frien

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. In D136315#3870829 , @ldionne wrote: > Thanks for picking this up! I looked at my local changes and I had started > modifying `inferDeploymentTargetFromSDK`. I had left the comment: > > /// TODO: We should only infer it i

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 469859. calebzulawski added a comment. Changed to not invoke `xcrun` if the SDK name can't be determined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files:

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3873987 , @xen0n wrote: > In D136436#3873949 , @SixWeining > wrote: > >> How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? > > For the assembler par

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469845. jz10 added a comment. Thanks Johannes I revised those issues, please check if those work CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/libomptarget/include/interop.h openmp/libomp

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth updated this revision to Diff 469840. paulkirth added a comment. git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: llvm/include/llvm/CodeGen/Passes.h llvm/include/llvm/

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth updated this revision to Diff 469838. paulkirth added a comment. Misc cleanups and additional tests - replace stringstream formatting w/ formatv - misc cleanups to includes - fix some typos - add tests for arm and x86 - add more interesting test cases - try to reduce test size w/ llvm-r

[PATCH] D136399: [clang-tidy][modernize-use-equals-default] Avoid adding unnecessary semicolon

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c07bda7a75c: [clang-tidy] Avoid adding unnecessary semicolon in modernize-use-equals-default (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang-tools-extra] 6c07bda - [clang-tidy] Avoid adding unnecessary semicolon in modernize-use-equals-default

Author: Alexander Shaposhnikov Date: 2022-10-22T00:42:50Z New Revision: 6c07bda7a75c68aa14a1e5f1ca0eac9ba6220cbb URL: https://github.com/llvm/llvm-project/commit/6c07bda7a75c68aa14a1e5f1ca0eac9ba6220cbb DIFF: https://github.com/llvm/llvm-project/commit/6c07bda7a75c68aa14a1e5f1ca0eac9ba6220cbb.d

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added a comment. Looks good from my end. Thanks for the updates, I hope they make sense in the end. Some minor style comments below. @tianshilei1992 Should accept once the header concerns are resolved. Comment at: openmp/libomptarget/src/api.cpp:256-257 +// Tas

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron added inline comments. Comment at: clang/unittests/Support/TimeProfilerTest.cpp:11 +#include "clang/Frontend/FrontendActions.h" +#include "clang/Lex/PreprocessorOptions.h" + thakis wrote: > Why is this in clang/unittests/Support (a new binary to boot)? Thi

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 469831. felix642 added a comment. Updated ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 Files: clang-tools-extra/clang-tidy/readability/Containe

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 469830. felix642 added a comment. Updated documentation and code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 Files: clang-tools-extra/clang-tidy/readabi

[PATCH] D136022: [clang] Add time profile for constant evaluation

thakis added inline comments. Comment at: clang/unittests/Support/TimeProfilerTest.cpp:11 +#include "clang/Frontend/FrontendActions.h" +#include "clang/Lex/PreprocessorOptions.h" + Why is this in clang/unittests/Support (a new binary to boot)? This doesn't use a

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:26 constexpr llvm::StringLiteral AddressOfName = "address-of"; +const auto DefaultIgnoredContainers = "::std::array"; fwolff wrote: > This is, o

[PATCH] D135941: [X86] Support AMX-FP16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG661881d43633: [X86] Add AMX-FP16 instructions. (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 661881d - [X86] Add AMX-FP16 instructions.

Author: Xiang1 Zhang Date: 2022-10-22T08:05:22+08:00 New Revision: 661881d43633c00e1ba2ec0ebbc1806d81ad9a11 URL: https://github.com/llvm/llvm-project/commit/661881d43633c00e1ba2ec0ebbc1806d81ad9a11 DIFF: https://github.com/llvm/llvm-project/commit/661881d43633c00e1ba2ec0ebbc1806d81ad9a11.diff

[PATCH] D136511: [RISCV][clang] Suppor RISC-V vectors in UninitializedValues.

craig.topper created this revision. craig.topper added reviewers: erichkeane, aaron.ballman, kito-cheng, eopXD, rogfer01. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the

[PATCH] D136022: [clang] Add time profile for constant evaluation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27d8eedd5a3c: [clang] Add time profile for constant evaluation (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 27d8eed - [clang] Add time profile for constant evaluation

Author: Evgeny Shulgin Date: 2022-10-21T23:24:44Z New Revision: 27d8eedd5a3cd7fd644be4f06225ffa1ff04cccf URL: https://github.com/llvm/llvm-project/commit/27d8eedd5a3cd7fd644be4f06225ffa1ff04cccf DIFF: https://github.com/llvm/llvm-project/commit/27d8eedd5a3cd7fd644be4f06225ffa1ff04cccf.diff LOG

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a comment. This should be ready for review. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469810. jz10 added a comment. Thanks Johannes 1. 'I feel like I'm missing something. As said before, all but 3 lines are identical in these two functions. Now you created a helper for 1/3 of those identical lines but left the other 2/3 being duplicated. Could

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 469807. void added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/LangOp

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 469805. void added a comment. Integrate the new flag level into the FAM predicate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 Files: clang/include/clang/Basic/Lan

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added a comment. In D136103#3876097 , @jz10 wrote: > Thanks Johannes and Shilei > > 1. '385-387 are the same as in omp_target_memcpy_async. Can we also not > duplicate those lines?' > > I put the common code (i.e.helper task creation) into anot

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 469782. nickdesaulniers added a comment. - update LanguageExtensions doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtension

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. > The C++ ABI is not part of the Fuchsia system ABI, nor what we call the > "Fuchsia compiler ABI". Different users of C++ are free to use whatever C++ > ABI they like. Only the backend ABI independent of language-specific issues > is necessary to interoperate with oth

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469772. jz10 added a comment. Thanks Johannes and Shilei 1. '385-387 are the same as in omp_target_memcpy_async. Can we also not duplicate those lines?' I put the common code (i.e.helper task creation) into another static function 2. 'In this code there are a

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. I'm getting a bit exhausted with all the words involved here & not sure how to simplify/clarify this. If @ben.boeckel has particular use cases, it might be easier for him to be here discussing them so we can discuss the tradeoffs directly rather than through intermedi

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron updated this revision to Diff 469771. Izaron added a comment. Mention this in the release notes. Thanks to Aaron for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136022/new/ https://reviews.llvm.org/D136022 Files: clang/docs/R

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. In D134453#3875392 , @erichkeane wrote: > FWIW, i find the GCC diagnostics (and the application of this patch) to be > much more clear/easy to read. The pile of `{` and `}` don't really look > useful/readable/meaningful to me

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added a comment. Note to reviewers: I expect this to be one of a 3 part progression. 1. Fix DomTree D135997 2. Fix front end D136497 3. Fix back end (TODO) Hopefully that's it; famous last words... Repository

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 469767. nickdesaulniers added a comment. - git clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/lib/CodeGen/CGStmt.cpp clan

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 469764. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - add note to commit message (let's see if phab captures what I wrote, used arc diff --verbatim) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135284: [Driver] select alternative target containing . in executable name

MaskRay added a comment. > The gcc compatible driver has support for selecting an alternative target > based on the driver's executable name, for instance > x86_64-unknown-linux-gnu-clang will set the target to linux on x86_64. I think the somewhat canonical term is target override (not selecti

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers created this revision. nickdesaulniers added reviewers: nikic, void, jyknight, efriedma, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added a comment. @rjmccall Would you mind looking at this when you have a moment? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 ___ cfe-commi

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

rupprecht added a comment. In D129755#3869081 , @aaronpuchert wrote: > In D129755#3866887 , @rupprecht > wrote: > >> I might have a better answer in a day or two of how widespread this is >> beyond just the cor

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aganea added a subscriber: stefan_reinalter. aganea added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4354 + +// Emit codeview command line if requested. +if (Args.hasFlag(options::OPT_gcodeview_command_line, aeubanks wrote: > MaskR

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/src/private.h:101 typedef int kmp_int32; +typedef int64_t kmp_int64; typedef intptr_t kmp_intptr_t; Can we put all KMP related code into a separate header, but of course not called `kmp.h`?

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks added a comment. In D136474#3875442 , @aganea wrote: > Thanks for the patch @aeubanks and apologies for this oversight. I am > wondering however if it wouldn’t make more sense to just strip this flag > (-fmessage-length) from the emitted cmd-li

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks updated this revision to Diff 469733. aeubanks added a comment. add driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 Files: clang/include/clang/Basic/CodeGenOptions.def clang/inclu

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/api.cpp:405 + return Rc; +} + Now we have a first helper for the "async" part, we still should deduplicate the entry point code. Above, all but lines 385-387 are the same as in `omp_target_me

[clang] 17f4e1d - Revert "[CMake] Drop libLTO and switch to PIE for Fuchsia toolchain"

Author: Petr Hosek Date: 2022-10-21T19:49:19Z New Revision: 17f4e1d27fbeea94234408814f0497f9ca45b61b URL: https://github.com/llvm/llvm-project/commit/17f4e1d27fbeea94234408814f0497f9ca45b61b DIFF: https://github.com/llvm/llvm-project/commit/17f4e1d27fbeea94234408814f0497f9ca45b61b.diff LOG: Re

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469719. jz10 added a comment. Thanks Johannes and Shilei 1. using a common helper function fixed 2. using push_back for SmallVector fixed 3. add doxygen comments for struct added, please check if that works CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D134974: [OpenMP] Add map clause to the LIT test on use_device_addr clause

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134974/new/ https://reviews.llvm.org/D134974 __

[PATCH] D136449: [Clang] Implement P2513

cor3ntin updated this revision to Diff 469715. cor3ntin edited the summary of this revision. cor3ntin added a comment. Enable the change in -fchar8_t mode as per suggestion from Aaron. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https

[PATCH] D134974: [OpenMP] Add map clause to the LIT test on use_device_addr clause

animeshk-amd added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134974/new/ https://reviews.llvm.org/D134974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D136482: [HLSL] support unbounded global resource array.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. unbounded resource array

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:701 +Builder.defineMacro("__cpp_char8_t", +LangOpts.CPlusPlus20 ? "202207L" : "201811L"); Builder.defineMacro("__cpp_impl_destroying_delete", "201806L"); --

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thakis added a comment. There will be other problems like this. We don't care about having the command in the debug info and we'd rather get rid of this class of bugs Once And For All :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ h

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added a comment. In D134453#3872355 , @dblaikie wrote: > But yeah, not sure/open to perspectives. > > @aaron.ballman - member names V type names V both? I think type names are really the only thing that will disambiguate the expressions in

[PATCH] D136397: [Clang] Change AnonStructIds in MangleContext to per-function based

xur marked an inline comment as done. xur added inline comments. Comment at: clang/include/clang/AST/Mangle.h:97 + +// If FunctionDecl is passed in, the anonnousstructID will be per-function +// based. rsmith wrote: > Fixed. Thanks! CHANGES SINCE LAST

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d89dbceeb57: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135471/new/ ht

[clang] 8d89dbc - [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

Author: Petr Hosek Date: 2022-10-21T18:33:13Z New Revision: 8d89dbceeb576171efd12a5657c038a2ec2e54a5 URL: https://github.com/llvm/llvm-project/commit/8d89dbceeb576171efd12a5657c038a2ec2e54a5 DIFF: https://github.com/llvm/llvm-project/commit/8d89dbceeb576171efd12a5657c038a2ec2e54a5.diff LOG: [C

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aganea added a comment. Thanks for the patch @aeubanks and apologies for this oversight. I am wondering however if it wouldn’t make more sense to just strip this flag (-fmessage-length) from the emitted cmd-line? The goal is to provide a reproducer, this flag does not matter for that purpose.

[PATCH] D136435: [clang][Driver] Add gcc-toolset-12 and devtoolset-12 prefixes

MaskRay added a comment. > If clang16 stops doing the gcc/devtoolset detection and relies on a config > file instead, that's fine but for the time being (and for a backport to > clang15), we need to fix this problem. I think this is fine. The test removal is fine if the future direction is to

[PATCH] D136449: [Clang] Implement P2513

cor3ntin added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:701 +Builder.defineMacro("__cpp_char8_t", +LangOpts.CPlusPlus20 ? "202207L" : "201811L"); Builder.defineMacro("__cpp_impl_destroying_delete", "201806L"); ---

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane updated this revision to Diff 469696. erichkeane added a comment. Woops, forgot to update my test! Do it so we can get tests to run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/new/ https://reviews.llvm.org/D136451 Files: clang/include/clang/AST/ASTNodeTraverser.

[PATCH] D134453: Disambiguate type names when printing NTTP types

erichkeane added subscribers: mizvekov, erichkeane. erichkeane added a comment. FWIW, i find the GCC diagnostics (and the application of this patch) to be much more clear/easy to read. The pile of `{` and `}` don't really look useful/readable/meaningful to me, and leaves us ambiguous, so I'm in

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4354 + +// Emit codeview command line if requested. +if (Args.hasFlag(options::OPT_gcodeview_command_line, This needs a test in clang/test/Driver/ Use `addOptInFlag` Repos

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. In https://reviews.llvm.org/D80833, there were concerns about determinism emitting the commandline into CodeView.

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:3310 +// during constraint checking. +class ConceptSpecializationDecl final +: public Decl, aaron.ballman wrote: > Would it make sense to rename this to `ImplicitConceptSpeci

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane updated this revision to Diff 469693. erichkeane marked 4 inline comments as done. erichkeane added a comment. Changes as Aaron suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/new/ https://reviews.llvm.org/D136451 Files: clang/include/clang/AST/ASTNodeTrave

[PATCH] D136471: [Clang] Implement P2513

cor3ntin abandoned this revision. cor3ntin added a comment. Created by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136471/new/ https://reviews.llvm.org/D136471 ___ cfe-commits mailing list cfe-

[PATCH] D136449: [Clang] Implement P2513

cor3ntin updated this revision to Diff 469690. cor3ntin added a comment. Improve commit message, check proper integral conversions, remove ws changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https://reviews.llvm.org/D136449 Files

[PATCH] D136022: [clang] Add time profile for constant evaluation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please be sure to add a release note to alert folks to the time profiler becoming more awesome. :-) Comment at: clang/unittests/Support/TimeProfilerTest.

[PATCH] D136471: [Clang] Implement P2513

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change allows initializing an array of unsigned char, or char from u8 string literals. This was done both to support

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a tiny grammar nit. Thank you for the fix! If you'd like me to commit this on your behalf, I can fix up the release note myself when landing, but please let me kn

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

tra updated this revision to Diff 469683. tra added a comment. Added LLVM test for bfloat load/stores. Fixed asm output for bf16 constants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136311/new/ https://reviews.llvm.org/D136311 Files: clang/l

[PATCH] D136271: [HLSL] Remove unused frontend-generated ID

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c7218e77026: [HLSL] Remove unused frontend-generated ID (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D136271?vs=468961&id=469681#toc Repository: rG LLVM Github Monorepo CH

[clang] 4c7218e - [HLSL] Remove unused frontend-generated ID

Author: Chris Bieneman Date: 2022-10-21T12:41:09-05:00 New Revision: 4c7218e7702651bb8dd2ef7734ca05ac0ada32fd URL: https://github.com/llvm/llvm-project/commit/4c7218e7702651bb8dd2ef7734ca05ac0ada32fd DIFF: https://github.com/llvm/llvm-project/commit/4c7218e7702651bb8dd2ef7734ca05ac0ada32fd.diff

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman added a comment. In D136449#3875159 , @cor3ntin wrote: > In D136449#3874867 , @aaron.ballman > wrote: > >> Thanks for this! Can you add more details to the patch summary as to what >> this paper do

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

aaron.ballman added a comment. Generally, this looks reasonable to me. I did spot a few things, but nothing major. Should this change come with a release note for the fix? Comment at: clang/include/clang/AST/DeclTemplate.h:3310 +// during constraint checking. +class ConceptSpe

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. ouf, thanks :) I am sure the doc has plenty of other issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits m

[PATCH] D136424: Update links to googletest documentation

DerKasper added a comment. No worries and no need to waste time with redoing stuff. I can live without all the fame and perks that come with this highly complex contribiution! ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://re

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

tra updated this revision to Diff 469676. tra added a comment. Cosmetic refectoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136311/new/ https://reviews.llvm.org/D136311 Files: clang/lib/Basic/Targets/NVPTX.cpp clang/lib/Basic/Targets/NV

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. So I've been messing around with this a bit, and am somewhat confident that IsAtLeastAsConstrainedAs should just contain: unsigned Depth1 = CalculateTemplateDepthForConstraints(*this, D1); unsigned Depth2 = CalculateTemplateDepthForConstraints(*this, D2); f

[PATCH] D136449: [Clang] Implement P2513

cor3ntin added a comment. In D136449#3874867 , @aaron.ballman wrote: > Thanks for this! Can you add more details to the patch summary as to what > this paper does? Paper numbers help, but don't convey a whole lot of > information at a glance if we need

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

fwolff added a comment. I suppose it sounds sensible to have the option of ignoring certain containers in this check; though I haven't needed it myself so far, which is also why I'm leaning against ignoring `std::array` by default. But I do not claim ultimate authority on this question, of cour

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser added a comment. Yes, I agree it is incomplete (aside from being incorrect here :-) I've just been asking to ensure that my understanding of freeze is correct. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136284/new/ http

[PATCH] D136311: [CUDA] Propagate __bf16 type info from the host compilation.

tra updated this revision to Diff 469663. tra added a comment. Make __bf16 available regradless of its availability on the host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136311/new/ https://reviews.llvm.org/D136311 Files: clang/lib/Basic/Ta

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG461a1836d3d7: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking. (authored by w2yehia). Herald added projects: clang, Sanitizer

[clang] 461a183 - [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

Author: Wael Yehia Date: 2022-10-21T16:32:42Z New Revision: 461a1836d3d77371bb6271fefd645897997a22b8 URL: https://github.com/llvm/llvm-project/commit/461a1836d3d77371bb6271fefd645897997a22b8 DIFF: https://github.com/llvm/llvm-project/commit/461a1836d3d77371bb6271fefd645897997a22b8.diff LOG: [P

[PATCH] D136311: [CUDA] Propagate __bf16 type info from the host compilation.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, yaxunl. Herald added a project: All. tra updated this revision to Diff 469453. tra added a comment. Herald added a subscriber: hiraditya. tra updated this revision to Diff 469460. tra updated this revision to

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101526/new/ https://reviews.llvm.org/D101526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the update. Nice Work! Comment at: clang/test/Analysis/region-store.c:66 + // expected-warning@+1 {{passing arguments to 'b' without a prototype is deprecated

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

pengfei updated this revision to Diff 469642. pengfei added a comment. Add intrinsic support first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135951/new/ https://reviews.llvm.org/D135951 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

nlopes added a comment. In D136284#3874755 , @jamieschmeiser wrote: > In D136284#3874614 , @nlopes wrote: > >> In D136284#3874596 , >> @jamieschmeiser wrote: >> >>> In D

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman added a comment. Thanks for this! Can you add more details to the patch summary as to what this paper does? Paper numbers help, but don't convey a whole lot of information at a glance if we need to come back to this review for code archeology. Please also add a test to the correct

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

rui.zhang added subscribers: mcberg2021, craig.topper. rui.zhang added a comment. In D122573#3872138 , @fhahn wrote: > Rebased on current main > > In D122573#3630767 , @rui.zhang > wrote: > >> I like the directio

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:127 + // Default implementation is a Noop. + virtual void branchTransfer(bool Branch, const Stmt *S, Lattice &L, + Environment &Env) {}

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong updated this revision to Diff 469636. martong edited the summary of this revision. martong added a comment. - Rebase to latest llvm/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133698/new/ https://reviews.llvm.org/D133698 Files: cl

[PATCH] D136437: [clang-format] Insert closing braces of unaffected lines

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Does this need a unit test? or are we good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136437/new/ https://reviews.llvm.org/D

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As briefly discussed in https://reviews.llvm.org/D1

[PATCH] D133698: [clang][dataflow] SignAnalysis, edgeTransfer, branchTransfer

martong updated this revision to Diff 469625. martong marked 8 inline comments as done. martong added a comment. - Add comments - Assumption -> ConditionValue - Use CRTP - branchTransfer -> transferBranch - Make just one simple test case for transferBranch Repository: rG LLVM Github Monorepo

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser added a comment. In D136284#3874614 , @nlopes wrote: > In D136284#3874596 , > @jamieschmeiser wrote: > >> In D136284#3874492 , @nikic wrote: >> >>> At leas

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser abandoned this revision. jamieschmeiser added a comment. I checked with a member of the C++ standards committee and he verified that comparing an uninitialized value against itself is, indeed, undefined behaviour, in the general case. I am abandoning this revision. Repository:

[PATCH] D136090: Handle errors in expansion of response files

mgorny added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1205 +if (ArgStr[0] == '@') { + FileName = ArgStr.drop_front(1); + if (!llvm::sys::path::is_relative(FileName)) Also, I think you can use `consume_front()` here. Repository

  1   2   >