[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki added a comment. @MyDeveloperDay @HazardyKnusperkeks Could you land this please if we are not waiting for anything? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 471809. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files:

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov retitled this revision from "[clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types" to "[clang] ASTImporter: Fix importing of va_list types and declarations". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 471808. Herald added a

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 471807. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136977/new/ https://reviews.llvm.org/D136977 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov updated this revision to Diff 471806. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/new/ https://reviews.llvm.org/D136962 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence.cpp

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5be1550f140: [clang-format] Dont crash on malformed preprocessor conditions (authored by sstwcw). Changed prior to commit:

[clang] d5be155 - [clang-format] Don't crash on malformed preprocessor conditions

Author: sstwcw Date: 2022-10-30T02:18:58Z New Revision: d5be1550f1406844501ab87a3e92622927a203e0 URL: https://github.com/llvm/llvm-project/commit/d5be1550f1406844501ab87a3e92622927a203e0 DIFF: https://github.com/llvm/llvm-project/commit/d5be1550f1406844501ab87a3e92622927a203e0.diff LOG:

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added a comment. In D136786#3893485 , @andrew.w.kaylor wrote: > My understanding is this: > > unsafe-fp-math = exception_behavior(ignore) + >fenv_access(off) + >no_signed_zeros(on) + >

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek added inline comments. Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:68-80 +if (COMPILER_RT_HAS_LLVMXRAY OR COMPILER_RT_HAS_LLVMTESTINGSUPPORT) + if (LLVM_LINK_LLVM_DYLIB) +list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVM) + endif() +else() +

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale updated this revision to Diff 471801. michele.scandale added a comment. Use low level properties to set `"unsafe-fp-math"="true"`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136786/new/ https://reviews.llvm.org/D136786 Files:

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

nridge added a comment. For reference, earlier work along these lines which never landed: https://reviews.llvm.org/D119077 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594

[PATCH] D133756: [clangd] Pass the entire tooling::CompileCommand to CommandMangler

nridge added a comment. (I frequently forget that `arc diff` does not update the commit message of an existing revision...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://reviews.llvm.org/D133756

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

mizvekov added a comment. It's not clear to me there is anything wrong besides our not importing of `va_list_tag`. The imported TypedefType should have the same underlying type as the original one, and I did not find anything different is happening on that test case. I will post a patch fixing

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers added a subscriber: gamesh411. vabridgers added a comment. Adding more information, seems this patch's "hack" returns the following QualType(T, 0).getDesugaredType(T->getDecl()->getASTContext()); -> ConstantArrayType 0x11413090 'struct __va_list_tag[1]' imported 1 `-RecordType

[clang] c1728a4 - Revert "Handle errors in expansion of response files"

Author: Serge Pavlov Date: 2022-10-30T02:03:12+07:00 New Revision: c1728a40aae31abc0a5d4d07f6f6a6773d803f2c URL: https://github.com/llvm/llvm-project/commit/c1728a40aae31abc0a5d4d07f6f6a6773d803f2c DIFF: https://github.com/llvm/llvm-project/commit/c1728a40aae31abc0a5d4d07f6f6a6773d803f2c.diff

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added inline comments. Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:68-80 +if (COMPILER_RT_HAS_LLVMXRAY OR COMPILER_RT_HAS_LLVMTESTINGSUPPORT) + if (LLVM_LINK_LLVM_DYLIB) +list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVM) + endif() +else() +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:68-80 +if (COMPILER_RT_HAS_LLVMXRAY OR COMPILER_RT_HAS_LLVMTESTINGSUPPORT) + if (LLVM_LINK_LLVM_DYLIB) +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny created this revision. mgorny added reviewers: dberris, justinkb, tstellar, MaskRay, serge-sans-paille, Hahnfeld, mstorsjo, delcypher, phosek. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. mgorny requested review of this revision. Replace the use of the

[PATCH] D136090: Handle errors in expansion of response files

This revision was automatically updated to reflect the committed changes. Closed by commit rG17eb198de934: Handle errors in expansion of response files (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D136090?vs=469978=471753#toc Repository: rG LLVM Github Monorepo

[clang] 17eb198 - Handle errors in expansion of response files

Author: Serge Pavlov Date: 2022-10-29T22:01:47+07:00 New Revision: 17eb198de934eced784e16ec15e020a574ba07e1 URL: https://github.com/llvm/llvm-project/commit/17eb198de934eced784e16ec15e020a574ba07e1 DIFF: https://github.com/llvm/llvm-project/commit/17eb198de934eced784e16ec15e020a574ba07e1.diff

[PATCH] D136090: Handle errors in expansion of response files

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136090/new/ https://reviews.llvm.org/D136090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added inline comments. Comment at: clang/include/clang/Driver/Options.td:4595-4596 def mno_avxvnniint8 : Flag<["-"], "mno-avxvnniint8">, Group; +def mavxneconvert : Flag<["-"], "mavxneconvert">, Group; +def mno_avxneconvert : Flag<["-"], "mno-avxneconvert">, Group;

[Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

aaron.ballman added a comment. In rGe4ec6ce8a75c208b49b163c81cda90dc7373c791#1139062 , @dblaikie wrote: > Posted, awaiting approval. Thank you! BRANCHES main Users: dblaikie (Author)

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff added a comment. https://github.com/llvm/llvm-project/issues/58355 corresponding github issue with current clang behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137020/new/ https://reviews.llvm.org/D137020

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff created this revision. urazoff added reviewers: sammccall, hokein, adamcz. Herald added a project: All. urazoff requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, declarations containing unknown types are parsed

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

tschuett added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:148 +/// Tests whether the given identifier is reserved as a module name and +/// diagnoses if it is. Returs true if a diagnostic is emitted and false +/// otherwise. Returns CHANGES

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 471748. cor3ntin added a comment. - Fix initialization of nested struct default initializer. - Fix handling of templates. - Better track the initiulization context to make source_location::current work as a consteval function. I've tried to treat

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers added a comment. In D136886#3892261 , @balazske wrote: > `ASTImporterLookupTable` do not contain an entry for `__va_list_tag`, I do > not know why it is missing. If it is added "manually" the crash disappears > (without fix in

[PATCH] D136839: [clang][Interp] Handle non-primitive locals without initializer

tbaeder abandoned this revision. tbaeder added a comment. This got merged into https://reviews.llvm.org/D136815, so abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136839/new/ https://reviews.llvm.org/D136839

[PATCH] D136815: [clang][Interp] Ignore visitDecl() for local declarations

tbaeder updated this revision to Diff 471731. tbaeder edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining updated this revision to Diff 471730. SixWeining added a comment. Fix testcase file name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136841/new/ https://reviews.llvm.org/D136841 Files:

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining added a comment. In D136841#3893966 , @xen0n wrote: > Ah. There's a typo in the name of the testcase file... :(- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136841/new/

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

xen0n added a comment. Ah. There's a typo in the name of the testcase file... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136841/new/ https://reviews.llvm.org/D136841 ___ cfe-commits mailing list

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining updated this revision to Diff 471729. SixWeining added a comment. Fix nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136841/new/ https://reviews.llvm.org/D136841 Files: clang/test/CodeGen/LoongArch/inline-asm-operand-modifiers.c

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. Inching closer to ClangBuiltLinux on LoongArch it seems! Comment at: llvm/lib/Target/LoongArch/LoongArchAsmPrinter.cpp:64 + break; + // TODO: handle other extra

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:3080 + if (I.getName().equals("this")) { +VMap[] = llvm::UndefValue::get(I.getType()); + } Please use PoisonValue instead whenever possible, as we are trying to remove

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

nikic added a comment. I think adding this under a default-disabled flag is fine for evaluation purposes, but I have doubts that we will ever be able to enable this by default. There is a lot of code out there assuming that copying uninitialized data around is fine. Repository: rG LLVM

[clang] efae1a7 - [docs] clang.rst: gnu++14 => gnu++17

Author: Fangrui Song Date: 2022-10-29T00:15:24-07:00 New Revision: efae1a7cf06bd71f7ec6e8dc9e5c2b085150a451 URL: https://github.com/llvm/llvm-project/commit/efae1a7cf06bd71f7ec6e8dc9e5c2b085150a451 DIFF: https://github.com/llvm/llvm-project/commit/efae1a7cf06bd71f7ec6e8dc9e5c2b085150a451.diff

[PATCH] D136830: [clang-format][NFC] Move BracesRemover tests out of FormatTest.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30ea3fcc4c69: [clang-format][NFC] Move BracesRemover tests out of FormatTest.cpp (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 30ea3fc - [clang-format][NFC] Move BracesRemover tests out of FormatTest.cpp

Author: owenca Date: 2022-10-28T23:44:41-07:00 New Revision: 30ea3fcc4c694d9ef3f914f3ad57eef32dc5b910 URL: https://github.com/llvm/llvm-project/commit/30ea3fcc4c694d9ef3f914f3ad57eef32dc5b910 DIFF: https://github.com/llvm/llvm-project/commit/30ea3fcc4c694d9ef3f914f3ad57eef32dc5b910.diff LOG:

[clang] 0e40a78 - [clang][NFC] sync comments from declaration of InitializePreprocessor

Author: YingChi Long Date: 2022-10-29T14:23:03+08:00 New Revision: 0e40a78319232ff22dcc54dcb92bfef8495325f1 URL: https://github.com/llvm/llvm-project/commit/0e40a78319232ff22dcc54dcb92bfef8495325f1 DIFF: https://github.com/llvm/llvm-project/commit/0e40a78319232ff22dcc54dcb92bfef8495325f1.diff