[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rGe18c2c5548f6: [Clang] use non-instantiated function declaration for constraints partial… (authored by ychen). Changed prior to commit: https://reviews.llvm.org/D136545?vs=470546=471902#toc Repository:

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d086cce8b92: [Clang] perform maximum TLS alignment check for template instantiation (authored by ychen). Repository: rG LLVM Github Monorepo

[clang] e18c2c5 - [Clang] use non-instantiated function declaration for constraints partial ordering

Author: Yuanfang Chen Date: 2022-10-30T22:39:47-07:00 New Revision: e18c2c5548f6864def4a110239395a18afc195d6 URL: https://github.com/llvm/llvm-project/commit/e18c2c5548f6864def4a110239395a18afc195d6 DIFF: https://github.com/llvm/llvm-project/commit/e18c2c5548f6864def4a110239395a18afc195d6.diff

[clang] 5d086cc - [Clang] perform "maximum TLS alignment" check for template instantiation

Author: Yuanfang Chen Date: 2022-10-30T22:39:47-07:00 New Revision: 5d086cce8b92680a2cdadf1f07d4267cd374122e URL: https://github.com/llvm/llvm-project/commit/5d086cce8b92680a2cdadf1f07d4267cd374122e DIFF: https://github.com/llvm/llvm-project/commit/5d086cce8b92680a2cdadf1f07d4267cd374122e.diff

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

shafik added subscribers: aaron.ballman, shafik. shafik added a comment. CC @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137020/new/ https://reviews.llvm.org/D137020 ___ cfe-commits

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:803 + // Make sure we don't accidentally register the same decl twice. + if (const Decl *VD = Src.dyn_cast(); VD && isa(VD)) { +assert(!P.getGlobal(cast(VD))); Nitpick, I

[PATCH] D136925: [clangd] Index scoped enums for code completion

nridge added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2133 if (const auto *EnumDecl = dyn_cast(ND.getDeclContext())) -return InTopLevelScope(*EnumDecl) && !EnumDecl->isScoped(); tom-anders wrote: > nridge wrote: > > Just to

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

sstwcw added a comment. This patch fixes the regression caused by 2183fe2 while introducing a new regression. But in my opinion the new regression is less of a problem than the old one. Therefore I think it is okay. Take

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

ChuanqiXu added a comment. In D136953#3892578 , @aaron.ballman wrote: > I think the standards wording here is a bit unclear as to what's intended and > I had misunderstood the wording around which part of the path needs to be > checked. Specifically:

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

pcwang-thead added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190 CmdArgs.push_back("-tune-cpu"); -CmdArgs.push_back(A->getValue()); +if (strcmp(A->getValue(), "native") == 0) +

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang updated this revision to Diff 471895. HaoyuZhang added a comment. Remove the prof file uploaded previous for test. No more need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846/new/ https://reviews.llvm.org/D136846 Files:

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Thanks for the comments. The modifications have been finished. PTAL~ Comment at: clang/include/clang/Driver/Options.td:1253 +Flags<[NoXarchOption, CC1Option]>, Group, +HelpText<"Use profi to infer block and edge counts.">; def

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang updated this revision to Diff 471894. HaoyuZhang added a comment. [Driver] Add -fsample-profile-use-profi This patch enable -sample-profile-use-profi in Clang frontend as user-facing feature. By using this patch, we can use the cflag of -fsample-profile-use-profi instead of -mllvm

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190 CmdArgs.push_back("-tune-cpu"); -CmdArgs.push_back(A->getValue()); +if (strcmp(A->getValue(), "native") == 0) +

[PATCH] D137054: [X86][Driver] Remove stale FIXME. NFC

craig.topper created this revision. craig.topper added reviewers: pengfei, RKSimon. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We use

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. Looks good LoongArch-wise but I'm not very familiar with Clang internals to start with. Might be okay to land since this touches little code outside LoongArch and has passed tests.

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe415cb1d61e7: [LoongArch] Support inline asm operand modifier z (authored by SixWeining). Changed prior to commit:

[clang] e415cb1 - [LoongArch] Support inline asm operand modifier 'z'

Author: Weining Lu Date: 2022-10-31T09:56:41+08:00 New Revision: e415cb1d61e798b6d69b5960a90f00518ca5008f URL: https://github.com/llvm/llvm-project/commit/e415cb1d61e798b6d69b5960a90f00518ca5008f DIFF: https://github.com/llvm/llvm-project/commit/e415cb1d61e798b6d69b5960a90f00518ca5008f.diff

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining added a comment. In D136413#3895369 , @xen0n wrote: > Amended the patch summary a little for grammatical fixes and mentioning > `__loongarch64` too. Thanks. BTW, this patch depends on D136146 . Could you

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

xen0n added a comment. Amended the patch summary a little for grammatical fixes and mentioning `__loongarch64` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136413/new/ https://reviews.llvm.org/D136413

[PATCH] D136835: [Clang][LoongArch] Support inline asm constraint 'J'

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0174aacb73: [Clang][LoongArch] Support inline asm constraint J (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136835/new/

[clang] cd0174a - [Clang][LoongArch] Support inline asm constraint 'J'

Author: Weining Lu Date: 2022-10-31T09:13:52+08:00 New Revision: cd0174aacb734904205ed7827fb923acda08f79a URL: https://github.com/llvm/llvm-project/commit/cd0174aacb734904205ed7827fb923acda08f79a DIFF: https://github.com/llvm/llvm-project/commit/cd0174aacb734904205ed7827fb923acda08f79a.diff

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

owenpan added a comment. See D137052 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133647/new/ https://reviews.llvm.org/D133647 ___ cfe-commits mailing list

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan created this revision. owenpan added reviewers: sstwcw, sammccall, HazardyKnusperkeks, MyDeveloperDay, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb);

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 471882. cor3ntin added a comment. Remove extra semi colon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. Note that we should wait end of next week to hear back from the Unicode Technical Committee before merging this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement the proposed UAX Profile "Mathematical notation profile for default identifiers". This implements a not-yet

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

nlopes added a comment. In D134410#3895077 , @nikic wrote: > In D134410#3894995 , @nlopes wrote: > >> We wanted this patch to make us switch uninitialized loads to poison at >> will, since they become UB. In

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

jmciver updated this revision to Diff 471878. jmciver added a comment. Herald added subscribers: kosarev, kerbowa, jvesely. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2) Fix AMD-GPU, ARM, PowerPC, and new

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 updated this revision to Diff 471865. Origami404 added a comment. I'm sorry that my patch can not pass the CI test, but I can not reproduce the CI failure loaclly, including clang-format related problems. On my machine, `ninja check-clang` shows: [0/1] Running the Clang regression

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

tschuett added a comment. Almost all flags are off by default. That's why they are called flags, i.e., `-Weverything`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134410/new/ https://reviews.llvm.org/D134410

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135858/new/ https://reviews.llvm.org/D135858 ___ cfe-commits mailing list

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

tschuett added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:676 +namespace { +void applyNoundefToLoadInst(bool enable, const clang::QualType , +llvm::LoadInst *Load) { Nit: You meant static. Repository: rG LLVM Github

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

nikic added a comment. In D134410#3894995 , @nlopes wrote: > We wanted this patch to make us switch uninitialized loads to poison at will, > since they become UB. In practice, this helps us fixing bugs in SROA and etc > without perf degradation. Can

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

thesamesam added a comment. Thanks for the CC. Yep, I had the same adventure with libedit and was very confused for a moment until we dug into it and realised: https://bugs.gentoo.org/870001. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

inclyc added a comment. > That is OK for glibc system because glibc includes this file manually. But > with other libc (e.g. musl), which does not manually include this, clang will > fail but GCC can get it compiled. FWIW currently we cannot build libedit using clang on

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 created this revision. Herald added a project: All. Origami404 added reviewers: aaron.ballman, erichkeane, mgorny, jyknight, mibintc, clang-language-wg. Origami404 published this revision for review. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. On

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

nlopes added a comment. In D134410#3893918 , @nikic wrote: > I think adding this under a default-disabled flag is fine for evaluation > purposes, but I have doubts that we will ever be able to enable this by > default. There is a lot of code out there

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This implements the 1st heuristic

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

thakis added subscribers: aeubanks, hans. thakis added a comment. Adding @hans @aeubanks since they were involved over there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

thakis added a comment. In D136533#3893032 , @ldionne wrote: > In D136533#3892949 , @ldionne wrote: > >> 2. Shipping this change does mean that anyone building anything with a new >> Clang and a not-yet-updated

[clang-tools-extra] e125e6c - [clang-tools-extra] Use llvm::find (NFC)

Author: Kazu Hirata Date: 2022-10-30T09:41:55-07:00 New Revision: e125e6c429e16741b128b2cab3787cdc57e166c6 URL: https://github.com/llvm/llvm-project/commit/e125e6c429e16741b128b2cab3787cdc57e166c6 DIFF: https://github.com/llvm/llvm-project/commit/e125e6c429e16741b128b2cab3787cdc57e166c6.diff

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan updated this revision to Diff 471838. egorzhdan added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix clangd compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/

[clang] 63a3a06 - Fix the clang Sphinx build

Author: Aaron Ballman Date: 2022-10-30T08:59:33-04:00 New Revision: 63a3a067d0ad5b243dbd9f993c2515dcc630cce2 URL: https://github.com/llvm/llvm-project/commit/63a3a067d0ad5b243dbd9f993c2515dcc630cce2 DIFF: https://github.com/llvm/llvm-project/commit/63a3a067d0ad5b243dbd9f993c2515dcc630cce2.diff

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3edc1210a49d: [clang-format] Adds a formatter for aligning trailing comments over empty lines (authored by yusuke-kadowaki, committed by

[clang] 3edc121 - [clang-format] Adds a formatter for aligning trailing comments over empty lines

Author: Yusuke Kadowaki Date: 2022-10-30T12:22:39Z New Revision: 3edc1210a49d4a666b46ace5c592a00ccb2bb350 URL: https://github.com/llvm/llvm-project/commit/3edc1210a49d4a666b46ace5c592a00ccb2bb350 DIFF: https://github.com/llvm/llvm-project/commit/3edc1210a49d4a666b46ace5c592a00ccb2bb350.diff

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. @mizvekov, thanks for posting a fix. LGTM, but someone else must approve. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 ___

[PATCH] D136925: [clangd] Index scoped enums for code completion

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2133 if (const auto *EnumDecl = dyn_cast(ND.getDeclContext())) -return InTopLevelScope(*EnumDecl) && !EnumDecl->isScoped(); nridge wrote: > Just to make sure I

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

cor3ntin added a comment. I added a few more comments, mostly nitpicks Comment at: clang/lib/AST/ExprConstant.cpp:9952-9953 +const FieldDecl *Field; +if (isa(E)) { + Field = cast(E)->getInitializedFieldInUnion(); +} else if (isa(E)) {

[PATCH] D136956: [clang][Interp] Implement BitXor opcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74fb770de939: [clang][Interp] Implement bitXor opcode (authored by tbaeder). Changed prior to commit:

[clang] 74fb770 - [clang][Interp] Implement bitXor opcode

Author: Timm Bäder Date: 2022-10-30T09:23:33+01:00 New Revision: 74fb770de9399d7258a8eda974c93610cfde698e URL: https://github.com/llvm/llvm-project/commit/74fb770de9399d7258a8eda974c93610cfde698e DIFF: https://github.com/llvm/llvm-project/commit/74fb770de9399d7258a8eda974c93610cfde698e.diff

[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

craig.topper created this revision. craig.topper added reviewers: RKSimon, pengfei. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. craig.topper requested review of this revision. Herald added projects: clang, LLVM. We only really need avx512bw for masking 256 or 512

[PATCH] D136532: [clang][Interp] Implement left and right shifts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d965c94ba58: [clang][Interp] Implement left and right shifts (authored by tbaeder). Changed prior to commit:

[clang] 6d965c9 - [clang][Interp] Implement left and right shifts

Author: Timm Bäder Date: 2022-10-30T08:59:55+01:00 New Revision: 6d965c94ba5806eb18c34cec9a8e9c4cb65c6885 URL: https://github.com/llvm/llvm-project/commit/6d965c94ba5806eb18c34cec9a8e9c4cb65c6885 DIFF: https://github.com/llvm/llvm-project/commit/6d965c94ba5806eb18c34cec9a8e9c4cb65c6885.diff

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

nridge requested review of this revision. nridge added a comment. (I'm going to re-request review since I have an outstanding question about the fix approach.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134827/new/

[PATCH] D136925: [clangd] Index scoped enums for code completion

nridge added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2133 if (const auto *EnumDecl = dyn_cast(ND.getDeclContext())) -return InTopLevelScope(*EnumDecl) && !EnumDecl->isScoped(); Just to make sure I understand: By also

[PATCH] D136528: [clang][Interp] Implement add and sub compound assign operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG881547db03a6: [clang][Interp] Implement add and sub compound assign operators (authored by tbaeder). Changed prior to commit:

[clang] 881547d - [clang][Interp] Implement add and sub compound assign operators

Author: Timm Bäder Date: 2022-10-30T08:11:04+01:00 New Revision: 881547db03a6ea243505a8ccba1547f2f18c05ca URL: https://github.com/llvm/llvm-project/commit/881547db03a6ea243505a8ccba1547f2f18c05ca DIFF: https://github.com/llvm/llvm-project/commit/881547db03a6ea243505a8ccba1547f2f18c05ca.diff

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 471816. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 471814. tbaeder added a comment. Moved the tests to their own file and moved the `isConstantContext()` changes to `InterpState` to their own NFC commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

tbaeder updated this revision to Diff 471813. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136920/new/ https://reviews.llvm.org/D136920 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/arrays.cpp Index: clang/test/AST/Interp/arrays.cpp