[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

MaskRay accepted this revision. MaskRay added a comment. Drop trailing period from subject. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1792 +// RUN: %clang -march=graniterapids -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown-linux \ +// RUN: |

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3916558 , @goldstein.w.n wrote: > In D137181#3916547 , @owenpan wrote: > >> Yes, if there is a header guard. Otherwise, set `PPLevel` to `PPBranchLevel >> + 1`. > > That

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:66 + /// #endifPPLevel still at : 0 + int PPLevel; + goldstein.w.n wrote: > owenpan wrote: > > You need to initialize `PPLevel` in the constructor. FWIW I'd use

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916547 , @owenpan wrote: > In D137181#3916521 , @goldstein.w.n > wrote: > >> I think we can remove the places I set `InitialPPLevel` and `OldPPLevel` but >> anything

[PATCH] D134974: [OpenMP] Add map clause to the LIT test on use_device_addr clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f8e7b43291c: [OpenMP] Add map clause to the LIT test on use_device_addr clause (authored by animeshk-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0f8e7b4 - [OpenMP] Add map clause to the LIT test on use_device_addr clause

Author: Animesh Kumar Date: 2022-11-09T12:23:39+05:30 New Revision: 0f8e7b43291ce5881cde6f3d34041c578390dda4 URL: https://github.com/llvm/llvm-project/commit/0f8e7b43291ce5881cde6f3d34041c578390dda4 DIFF: https://github.com/llvm/llvm-project/commit/0f8e7b43291ce5881cde6f3d34041c578390dda4.diff

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:112 : Line(Line), TokenSource(TokenSource), ResetToken(ResetToken), -PreviousLineLevel(Line.Level), PreviousTokenSource(TokenSource), -Token(nullptr),

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3916521 , @goldstein.w.n wrote: > I think we can remove the places I set `InitialPPLevel` and `OldPPLevel` but > anything else I remove causes at least one test to fail. > > What did you do? Just set `PPLevel =

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916505 , @owenpan wrote: > In D137181#3916488 , @goldstein.w.n > wrote: > >> In D137181#3916474 , @owenpan >> wrote: >> >>>

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mgorny added a comment. I don't have a strong opinion. I'm happy as long as there is *anything* telling me "tests were disabled because ...". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137669/new/ https://reviews.llvm.org/D137669

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,"znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids")

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474155. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. THX fore review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3916488 , @goldstein.w.n wrote: > In D137181#3916474 , @owenpan wrote: > >> You can still simply the changes to UnwrappedLineParser.cpp a lot. In fact, >> instead of

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar added a comment. In D137669#3916493 , @mgorny wrote: > Could you issue a warning though? It's really annoying when targets disappear > like that and you have to guess which of the checks failed. What about just making it an error if

[libunwind] 4db6871 - [libunwind] Check corrupted return address in unwind_phase2 when CET is enabled.

Author: jinge90 Date: 2022-11-09T14:27:07+08:00 New Revision: 4db687155bc12f31b5ed122ba1086c5f04838a24 URL: https://github.com/llvm/llvm-project/commit/4db687155bc12f31b5ed122ba1086c5f04838a24 DIFF: https://github.com/llvm/llvm-project/commit/4db687155bc12f31b5ed122ba1086c5f04838a24.diff LOG:

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

skan added inline comments. Comment at: llvm/lib/Target/X86/X86.td:949 + FeatureAMXINT8, + FeatureAMXBF16, + FeatureBF16];

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mgorny added a comment. Could you issue a warning though? It's really annoying when targets disappear like that and you have to guess which of the checks failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137669/new/

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916474 , @owenpan wrote: > You can still simply the changes to UnwrappedLineParser.cpp a lot. In fact, > instead of adjusting `PPLevel` at various places, you only need to set it > once when `InMacroBody` is

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:92-94 + if (Line.Level >= IndentForLevel.size()) +IndentForLevel.resize(Line.Level + 1, UnknownIndent ? -1 : Indent); +} owenpan wrote: > Please run

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

owenpan added a comment. In D91950#3915777 , @HazardyKnusperkeks wrote: > @MyDeveloperDay @owenpan What shall we do? > > 1. Abandon this > 2. Commit it in our name > 3. Use the email from this commit: >

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. You can still simply the changes to UnwrappedLineParser.cpp a lot. In fact, instead of adjusting `PPLevel` at various places, you only need to set it once when `InMacroBody` is set. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:92-94 + if

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry added a comment. Seems like I have made things too complex :( Should work for C, C++, and other languages now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry updated this revision to Diff 474149. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry updated this revision to Diff 474147. v1nh1shungry added a comment. Support different C++ standards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files:

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474146. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comments. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

pengfei added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,"znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids")

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf updated this revision to Diff 474142. qiucf marked an inline comment as done. qiucf added a reviewer: michele.scandale. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137618/new/ https://reviews.llvm.org/D137618 Files:

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474140. FreddyYe added a comment. Added ZHAOXIN_FAM7H. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added a comment. gcc has landed related patch: Sierraforest , Graniterapids and Grandrdige

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1528 +ProcessorFeatures.TRMTuning>; +def : ProcModel<"grandridge", SLMModel, ProcessorFeatures.GRRFeatures, +ProcessorFeatures.TRMTuning>; RKSimon wrote: >

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474138. FreddyYe added a comment. Rebase and add missing supports in cpu_model.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files:

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. @aaron.ballman does this seem OK? (this was based on my suggestion in the related review linked in the description) It probably needs tests in clang too - not sure if there's an opportunity to use a unit test to simplify

[PATCH] D137536: [NFC] Replace use of PPC64 macro into powerpc64 in intrinsic headers

qiucf abandoned this revision. qiucf added a comment. I think rG7aa90b21b453d1ca52fdfccfd7e01e61d9e5b1f1 has already done that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu added a reviewer: bruno. ChuanqiXu added a comment. In D137609#3915632 , @iains wrote: > I think that (if this change is approved) there will be also some > simplifications possible in the driver (since the mode that produces a > wrapper

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474132. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files:

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. @tom-anders Thanks for reviewing and for your suggestions! I think your suggestion is excellent, but for now, it is too complex for me to implement. If this patch is okay, could you please help me commit it? Thanks again! Repository: rG LLVM Github Monorepo

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 474127. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137550/new/ https://reviews.llvm.org/D137550 Files:

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

bnbarham added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:660 /// 'use-external-names': +/// 'root-relative': /// 'overlay-relative': haowei wrote: > bnbarham wrote: > > phosek wrote: > > > Could we make this just a

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry updated this revision to Diff 474117. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added inline comments. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'root-relative': 'yaml-dir', bnbarham wrote: > bnbarham wrote: > > I'd prefer a test without

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 474115. haowei marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry added a comment. @tom-anders Thanks for reviewing and for your suggestions! Comment at: clang-tools-extra/clangd/Hover.cpp:785 + + // TODO: Show string literal's contents + HI.Name = "String Literal"; tom-anders wrote: > Is it really useful to

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Demo: https://gistpreview.github.io/?fec9b77c726cfb3cc7c424b197e3f68c

[PATCH] D137674: [clangd] Make system-include-extractor.test more resilient in the face of paths with special characters

nridge abandoned this revision. nridge added a comment. Great minds :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137674/new/ https://reviews.llvm.org/D137674 ___ cfe-commits mailing list

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

ayzhao added a comment. In D133757#3916040 , @sammccall wrote: > In D133757#3916028 , @nridge wrote: > >> In D133757#3915995 , @ayzhao wrote: >> >>> This change is

[PATCH] D137674: [clangd] Make system-include-extractor.test more resilient in the face of paths with special characters

ayzhao accepted this revision. ayzhao added a comment. Thanks for the quick fix! I patched this in and I can confirm it fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137674/new/ https://reviews.llvm.org/D137674

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

sammccall added a comment. In D133757#3916028 , @nridge wrote: > In D133757#3915995 , @ayzhao wrote: > >> This change is causing system-include-extractor.test >>

[PATCH] D137674: [clangd] Make system-include-extractor.test more resilient in the face of paths with special characters

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, I committed https://github.com/llvm/llvm-project/commit/96d771c4707df9b3153ea5a8451f2bbbe17c8917 but was too lazy to add the comment, feel free to land this or not. Repository:

[clang-tools-extra] 96d771c - [clangd] Avoid escaping issues in system-include-extractor.test

Author: Sam McCall Date: 2022-11-08T23:48:15+01:00 New Revision: 96d771c4707df9b3153ea5a8451f2bbbe17c8917 URL: https://github.com/llvm/llvm-project/commit/96d771c4707df9b3153ea5a8451f2bbbe17c8917 DIFF: https://github.com/llvm/llvm-project/commit/96d771c4707df9b3153ea5a8451f2bbbe17c8917.diff

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added a comment. In D133757#3915995 , @ayzhao wrote: > This change is causing system-include-extractor.test > > to fail on Chrome:

[PATCH] D137674: [clangd] Make system-include-extractor.test more resilient in the face of paths with special characters

nridge created this revision. nridge added a reviewer: ayzhao. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D137659: [Driver] Refactor err_drv_unsupported_option_argument call sites to use llvm::opt::Arg::getSpelling

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c2c62282fca: [Driver] Refactor err_drv_unsupported_option_argument call sites to use llvm… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8c2c622 - [Driver] Refactor err_drv_unsupported_option_argument call sites to use llvm::opt::Arg::getSpelling

Author: Fangrui Song Date: 2022-11-08T14:39:09-08:00 New Revision: 8c2c62282fca2f3dbfa338427aa97f702e67f86b URL: https://github.com/llvm/llvm-project/commit/8c2c62282fca2f3dbfa338427aa97f702e67f86b DIFF: https://github.com/llvm/llvm-project/commit/8c2c62282fca2f3dbfa338427aa97f702e67f86b.diff

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

ayzhao added a comment. This change is causing system-include-extractor.test to fail on Chrome: https://crbug.com/1382508 The test fails on this assertion

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 474080. cor3ntin marked 4 inline comments as done. cor3ntin added a comment. Address Aaron's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files:

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mstorsjo added subscribers: smeenai, mstorsjo. mstorsjo added a comment. This does, somewhat, coincide with what I'm trying to do in D131052 . There, I don't point out the binaries for `FileCheck` and similar, but point out preexisting native `llvm-tblgen`,

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall added a comment. (and sorry, it seems I was sitting on a pile of comments I thought I'd sent, LMK if I should follow up on them) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136723/new/ https://reviews.llvm.org/D136723

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall added a comment. In D136723#3915853 , @maryammo wrote: > This commit causes build failure on > `https://lab.llvm.org/buildbot/#/builders/121/builds/24947` : > I was able to reproduce the failure and by reverting this commit locally it >

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:47 + /// The preprocessor indent level of the \c UnwrappedLine. + int PPLevel; sstwcw wrote: > Please elaborate what preprocessor indent level means. Done. Repository:

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474079. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar created this revision. tstellar added reviewers: phosek, mgorny, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the FileCheck, count, and not tools are not found in

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

maryammo added a comment. This commit causes build failure on `https://lab.llvm.org/buildbot/#/builders/121/builds/24947` : [43/635] Building CXX object tools/clang/tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/Types.cpp.o FAILED:

[PATCH] D137659: [Driver] Refactor err_drv_unsupported_option_argument call sites to use llvm::opt::Arg::getSpelling

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Thanks for doing this cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137659/new/ https://reviews.llvm.org/D137659

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

jcranmer-intel added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:502 + let Types = [AluTypeClass]; + let Args = [ArgFltSemantics]; + let HasGroup = 1; tbaeder wrote: > sepavloff wrote: > > tbaeder wrote: > > > jcranmer-intel wrote: > > > >

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

bnbarham added inline comments. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'root-relative': 'yaml-dir', bnbarham wrote: > I'd prefer a test without `overlay-relative` set to make it

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. More than one year silence. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___ cfe-commits mailing list

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a subscriber: owenpan. HazardyKnusperkeks added a comment. @MyDeveloperDay @owenpan What shall we do? 1. Abandon this 2. Commit it in our name 3. Use the email from this commit: https://github.com/Wandalen/game_chess/commit/a84bba03667643ded0cfe7aff2907c6546a6a192 I'm

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

dexonsmith added a comment. In D137473#3915497 , @bnbarham wrote: > This seems reasonable to me in general. @dexonsmith in case you have any > thoughts. SGTM! (I haven't reviewed in detail but I figure @bnbarham is on it...) Repository: rG LLVM

[PATCH] D137409: [clang-format][NFCish] Alphabetical sort Format.(h|pp)

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23323 "WhitespaceSensitiveMacros: ['FOO', 'BAR']"))); - std::vector NonDefaultWhiteSpaceMacros{"FOO", "BAR"}; + std::vector NonDefaultWhiteSpaceMacros = +

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ben.boeckel added a comment. FWIW, I was able to make CMake's module test suite pass with this patch on top of you MyP1689 branch on your Github fork. I also added some diffs to help clean up output files. I'll try and get it to work with the replacement patches as well, but I just want this

[PATCH] D137206: [clang][modules][deps] Including module maps are affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137206/new/ https://reviews.llvm.org/D137206

[PATCH] D137512: [clang] Add Swift support for MIPS

aschwaighofer added a comment. This looks good to me. Can you rebase your patch so that it applies on top of github.com:apple/llvm-project.git main? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137512/new/ https://reviews.llvm.org/D137512

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:3234-3237 + if (auto *Var = llvm::dyn_cast(this)) +return Var; + if (auto *BD = llvm::dyn_cast(this)) +return llvm::dyn_cast(BD->getDecomposedDecl()); aaron.ballman wrote: > No need

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added a comment. In D137244#3915633 , @aaron.ballman wrote: > Thanks for this! Can you also add a release note for the changes? Thanks for the Review! As mentioned this fixes an unreleased feature, hence why I don't think a release note

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman added a comment. Thanks for this! Can you also add a release note for the changes? Comment at: clang/include/clang/AST/Decl.h:673 +class VarDecl; + This should be moved up to around line 77 or so (and kept in alphabetical order).

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

iains added a comment. I think that (if this change is approved) there will be also some simplifications possible in the driver (since the mode that produces a wrapper header for multiple command-line headers is different from the mode where multiple command line headers would each produce a

[PATCH] D137617: [AArch64] Allow users-facing feature names in clang target attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e6c403c2d3: [AArch64] Allow users-facing feature names in clang target attributes (authored by dmgreen). Herald added a project: clang. Herald

[clang] f0e6c40 - [AArch64] Allow users-facing feature names in clang target attributes

Author: David Green Date: 2022-11-08T19:30:26Z New Revision: f0e6c403c2d399e4fd821aa5a7e4a20534494c71 URL: https://github.com/llvm/llvm-project/commit/f0e6c403c2d399e4fd821aa5a7e4a20534494c71 DIFF: https://github.com/llvm/llvm-project/commit/f0e6c403c2d399e4fd821aa5a7e4a20534494c71.diff LOG:

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e956995db1f: [clang][Headers] Do not define varargs macros for __need___va_list (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9e95699 - [clang][Headers] Do not define varargs macros for __need___va_list

Author: Adhemerval Zanella Date: 2022-11-08T16:29:35-03:00 New Revision: 9e956995db1fc7e792e3dfb3a465a52626195557 URL: https://github.com/llvm/llvm-project/commit/9e956995db1fc7e792e3dfb3a465a52626195557 DIFF:

[PATCH] D137659: [Driver] Refactor err_drv_unsupported_option_argument call sites to use llvm::opt::Arg::getSpelling

MaskRay created this revision. MaskRay added a reviewer: lenary. Herald added subscribers: StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal,

[PATCH] D137198: [clang][modules][deps] Parent module maps are affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137198/new/ https://reviews.llvm.org/D137198

[clang-tools-extra] c333b92 - [include-cleaner] Missing changes from 38cccb906603

Author: Sam McCall Date: 2022-11-08T20:18:10+01:00 New Revision: c333b92b72b40d1f39d89ab94f764baeb8bb0cab URL: https://github.com/llvm/llvm-project/commit/c333b92b72b40d1f39d89ab94f764baeb8bb0cab DIFF: https://github.com/llvm/llvm-project/commit/c333b92b72b40d1f39d89ab94f764baeb8bb0cab.diff

[PATCH] D137644: [include-cleaner] pass through recorded macro refs in walkUsed

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG38cccb906603: [include-cleaner] pass through recorded macro refs in walkUsed (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 38cccb9 - [include-cleaner] pass through recorded macro refs in walkUsed

Author: Sam McCall Date: 2022-11-08T20:10:39+01:00 New Revision: 38cccb90660347939dd7bfdd57ba66760cba39c2 URL: https://github.com/llvm/llvm-project/commit/38cccb90660347939dd7bfdd57ba66760cba39c2 DIFF: https://github.com/llvm/llvm-project/commit/38cccb90660347939dd7bfdd57ba66760cba39c2.diff

[PATCH] D137197: [clang][modules][deps] Transitive module maps are not affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Yeah, I agree with this. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137197/new/ https://reviews.llvm.org/D137197

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman added a comment. Precommit CI looks to have potentially found something interesting here. Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + aaron.ballman wrote:

[PATCH] D137650: [clangd] Implement hover for C++ string literals

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:785 + + // TODO: Show string literal's contents + HI.Name = "String Literal"; Is it really useful to show the contents inside the Hover? You already see the contents of the

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:421-425 +// [Pointer] -> [] +def IncPtr : Opcode { + let HasGroup = 0; +} +// [Pointer] -> [] Don't both of these result in a `Pointer`? And should they have a `Types` field?

[PATCH] D137192: [clang][serialization] NFCI: Avoid re-reading input file info

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm, thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137192/new/ https://reviews.llvm.org/D137192

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

tom-anders accepted this revision. tom-anders added a comment. This revision is now accepted and ready to land. Would be cool if in the future we could instead transform something like using namespace std; int main() { auto t = 5ms; } into using namespace std::chrono_literals;

[clang] 98fa954 - Revert "[Assignment Tracking][7/*] Add assignment tracking functionality to clang"

Author: OCHyams Date: 2022-11-08T18:43:05Z New Revision: 98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e URL: https://github.com/llvm/llvm-project/commit/98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e DIFF: https://github.com/llvm/llvm-project/commit/98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e.diff LOG:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Okay, now I am getting what I believe to be segfaults: #0 0x564383482be4 PrintStackTraceSignalHandler(void*) Signals.cpp:0:0 #1 0x564383480464 SignalHandler(int) Signals.cpp:0:0 #2 0x7f7c275c9420 __restore_rt

[PATCH] D137399: [clang][Interp] Emit negated integers directly as constants

aaron.ballman added a comment. This is missing test coverage (possibly around integer promotion behavior as well). Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1525 +return true; + APSInt V = APSInt(IL->getValue(), /*IsUnsigned=*/false); + return

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

bnbarham added a subscriber: dexonsmith. bnbarham added a comment. This seems reasonable to me in general. @dexonsmith in case you have any thoughts. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, +

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

Bigcheese added a comment. I'm not aware of anyone using this mode, but please wait for responses from Google and Meta people to verify that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

dreachem added subscribers: dhruvachak, dreachem. dreachem added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @jdoerfert @tianshilei1992 @atmnpatel @dhruvachak Is the target to get this merged in for LLVM 16? Does the VGPU implementation provide a way to support

[PATCH] D125860: [clang] Only use major version in resource dir

tstellar added a comment. @tbaeder That CI failure seems unrelated. Maybe just commit early in the day so you have time to deal with the bot failures (if any). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

  1   2   >