[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson added inline comments. Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:442 + + addExternCSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/include")); MaskRay wrote: > I think Fuchsia way of checking `if

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added a comment. test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:442 + + addExternCSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/include")); I think Fuchsia way of checking `if (!D.SysRoot.empty()) {`

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

owenpan added a comment. @gedare thanks for changing `EXPECT_EQ` to `verifyFormat`, but IMO we should do that in another patch so that it would be easier (at least for me) to review the new tests and to make sure no existing tests have been changed by accident. Comment at:

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476018. mhjacobson added a comment. Clarify comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476017. mhjacobson added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp

[clang] 6d07678 - [OpenMP][NFC] Claim thread_limit clause in target directive

Author: Chi Chun Chen Date: 2022-11-17T00:44:44-06:00 New Revision: 6d076780a8c68203e35f3bc5b9d6ec1f285d66b3 URL: https://github.com/llvm/llvm-project/commit/6d076780a8c68203e35f3bc5b9d6ec1f285d66b3 DIFF: https://github.com/llvm/llvm-project/commit/6d076780a8c68203e35f3bc5b9d6ec1f285d66b3.diff

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3926848 , @owenpan wrote: > In D137181#3924002 , @sstwcw wrote: > >> Can you make `TokenAnnotator::printDebugInfo` print `PPLevel`? > > @goldstein.w.n can you add it as

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476013. goldstein.w.n marked 2 inline comments as done. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak added a comment. In D137996#3927947 , @jansvoboda11 wrote: > Mostly looks good. Is this expected to work with Clang modules at all? My use case only has to keep track of textual headers. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476009. mhjacobson added a comment. Herald added a subscriber: ormris. Added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files:

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson created this revision. mhjacobson added a project: clang. Herald added subscribers: fedor.sergeev, krytarowski, emaste. Herald added a project: All. mhjacobson requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This matches OpenBSD, and it supports

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa created this revision. wzssyqa added reviewers: MaskRay, atanasyan. Herald added subscribers: StephenFan, jrtc27, hiraditya, arichardson, sdardis. Herald added a project: All. wzssyqa requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[clang] bbe6bd7 - Trivial fix to failing test on FreeBSD

Author: Matt Jacobson Date: 2022-11-17T00:20:23-05:00 New Revision: bbe6bd724a6335e497c7edaed191d37a828d0390 URL: https://github.com/llvm/llvm-project/commit/bbe6bd724a6335e497c7edaed191d37a828d0390 DIFF: https://github.com/llvm/llvm-project/commit/bbe6bd724a6335e497c7edaed191d37a828d0390.diff

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM but let's wait for others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/ https://reviews.llvm.org/D138094

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ddd5863088b: [clang] Missed rounding mode use in constant evaluation (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D137719?vs=474304=475999#toc Repository: rG LLVM

[clang] 1ddd586 - [clang] Missed rounding mode use in constant evaluation

Author: Serge Pavlov Date: 2022-11-17T12:05:28+07:00 New Revision: 1ddd5863088b56f8614fb5a17abd2968c05790c3 URL: https://github.com/llvm/llvm-project/commit/1ddd5863088b56f8614fb5a17abd2968c05790c3 DIFF: https://github.com/llvm/llvm-project/commit/1ddd5863088b56f8614fb5a17abd2968c05790c3.diff

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff added a comment. Thanks! Comment at: clang/test/AST/const-fpfeatures.c:37 float _Complex C1d = C0; // CHECK: @C1d = {{.*}} { float, float } { float 1.00e+00, float 1.00e+00 } aaron.ballman wrote: > Should we add a test without the

[clang] 925eaeb - Revert "[CMake] Drop libLTO and switch to PIE for Fuchsia toolchain"

Author: Alex Brachet Date: 2022-11-17T03:37:58Z New Revision: 925eaeb3f4867c735f61d4937075b3129ece3e1d URL: https://github.com/llvm/llvm-project/commit/925eaeb3f4867c735f61d4937075b3129ece3e1d DIFF: https://github.com/llvm/llvm-project/commit/925eaeb3f4867c735f61d4937075b3129ece3e1d.diff LOG:

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

jhuber6 added a comment. This might be useful in the context of generating multi-architecture libraries when we start writing `libc` and `libc++` functionality. Although I can't name any use-cases for certain right now. However, shouldn't we just be able to define these in `clang` along

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin updated this revision to Diff 475987. gonglingqin added a comment. Address @SixWeining's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/ https://reviews.llvm.org/D138094 Files:

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:603 case Intrinsic::loongarch_dbar: { -SDValue Op0 = Op.getOperand(0); -SDValue Op2 = Op.getOperand(2); -if (!isa(Op2)) { -

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak updated this revision to Diff 475984. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.llvm.org/D137996 Files:

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:603 case Intrinsic::loongarch_dbar: { -SDValue Op0 = Op.getOperand(0); -SDValue Op2 = Op.getOperand(2); -if (!isa(Op2)) { - DAG.getContext()->emitError("argument

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3034 RoundingFPMath = false; + FPExceptionBehavior = ""; // If fast-math is set then set the fp-contract mode to fast. zahiraam wrote: > FPExceptionBehavior should

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf updated this revision to Diff 475981. qiucf marked an inline comment as done. qiucf added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137618/new/ https://reviews.llvm.org/D137618 Files:

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj marked an inline comment as done. kawashima-fj added inline comments. Comment at: clang/test/Driver/fp-model.c:162 +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffast-math" +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffinite-math-only" zahiraam wrote: > Shouldn't

[PATCH] D138161: [HLSL] add sin library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG083d949f3800: [HLSL] add sin library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138161/new/

[clang] 083d949 - [HLSL] add sin library function

Author: Joshua Batista Date: 2022-11-16T18:29:50-08:00 New Revision: 083d949f3800978c07260a0b8d6711c353d69e45 URL: https://github.com/llvm/llvm-project/commit/083d949f3800978c07260a0b8d6711c353d69e45 DIFF:

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj updated this revision to Diff 475979. kawashima-fj added a comment. Update a test to include the `ffast-math -ffp-model=fast` pattern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/ https://reviews.llvm.org/D138109 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. In D138117#3931109 , @zahiraam wrote: > It would probably be better to make these changes with the appropriate code > changes you are making for each semantic mode. And may be keep this patch > only for the other changes

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ChuanqiXu added a comment. @dblaikie gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

arphaman added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:69 + if (PA.isGNUAttribute()) +Diag(PA.getLoc(), diag::err_objc_unexpected_attr); + } I think it might be better to still report this error at the location of the `@` token

[clang] 45e57a5 - Suppress warning on unused static data member.

Author: Richard Smith Date: 2022-11-16T17:42:14-08:00 New Revision: 45e57a550f5aa56e934a4fd0f9ed8749a831e445 URL: https://github.com/llvm/llvm-project/commit/45e57a550f5aa56e934a4fd0f9ed8749a831e445 DIFF: https://github.com/llvm/llvm-project/commit/45e57a550f5aa56e934a4fd0f9ed8749a831e445.diff

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

aaronpuchert added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:114-117 +target_link_libraries(clangBasic + PRIVATE + ${LLVM_ATOMIC_LIB} +) Arfrever wrote: > mgorny wrote: > > Is this the right place? Grepping for `std::atomic`, I see

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

This revision was automatically updated to reflect the committed changes. Closed by commit rG84ef72357328: [clang] Fix wrong ABI of AVRTiny. (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138125/new/

[clang] 84ef723 - [clang] Fix wrong ABI of AVRTiny.

Author: Ben Shi Date: 2022-11-17T08:38:44+08:00 New Revision: 84ef7235732896530564289c8db59291a7d5413e URL: https://github.com/llvm/llvm-project/commit/84ef7235732896530564289c8db59291a7d5413e DIFF: https://github.com/llvm/llvm-project/commit/84ef7235732896530564289c8db59291a7d5413e.diff LOG:

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3932369 , @asbirlea wrote: > As far as performance, this looks fine. Not seeing measurable gains. Thank you for checking! Is the evaluation still ongoing, or is this the green light to go ahead? Repository: rG

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

asbirlea added a comment. As far as performance, this looks fine. Not seeing measurable gains. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136806/new/ https://reviews.llvm.org/D136806 ___ cfe-commits

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

arsenm added a comment. Herald added a project: All. Is this still needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978 ___ cfe-commits mailing list

[PATCH] D138161: add sin library function

bob80905 updated this revision to Diff 475952. bob80905 added a comment. [HLSL] add cos library function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138161/new/ https://reviews.llvm.org/D138161 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D138161: add sin library function

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138161 Files:

[PATCH] D135488: [codegen] Display stack layouts in console

arsenm added a comment. In D135488#3929537 , @arsenm wrote: > The kernel resource remarks added in 67357739c6d36a61972c1fc0e829e35cb5375279 > are > probably the current heaviest

[PATCH] D138160: [clang] Use InMemoryModuleCache for readASTFileControlBlock NFC

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a pcm has already been loaded from disk, reuse it from the

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1811 + // clause. + if (getLangOpts().OpenMP >= 52 && ClauseName.str() == "to") { +Diag(Tok, diag::err_omp_declare_target_unexpected_to_clause); Do you really need

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137986/new/ https://reviews.llvm.org/D137986

[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

rnk added a comment. Thanks, I can see the bug here: https://gcc.godbolt.org/z/1xjMYarT9 You can see how storeStrong cleanup uses the catchpad funclet when it should not. Comment at: clang/test/CodeGenObjCXX/arc-exceptions-seh.mm:36 +// CHECK: call +// CHECK:

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/unittests/Annotations.h:30 + struct Position : clangd::Position { +llvm::Optional Payload; tom-anders wrote: > I thought about just using `std::pair llvm::Optional> instead, but that

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

doru1004 created this revision. doru1004 added reviewers: carlo.bertolli, ronl, jdoerfert, gregrodgers, dhruvachak. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: aaron.ballman. Herald added a project: All. doru1004 requested review of this

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

tom-anders updated this revision to Diff 475939. tom-anders added a comment. Fix clangd::Annotations interface, now also has pointWithPayload etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137909/new/ https://reviews.llvm.org/D137909 Files:

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

arsenm resigned from this revision. arsenm added a comment. Herald added a subscriber: kosarev. This is obsolete and can be abandoned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124158/new/ https://reviews.llvm.org/D124158

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added a comment. Can you document the new directory structure with a small example? It would also be good to document in the code that some of these changes were driven by file corruption, and if possible point to a bug on github. Comment at:

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, abrachet, phosek, cryptoad. Herald added a project: All. hctim requested review of this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, MaskRay. Herald added projects:

[PATCH] D128700: [AMDGPU][Clang] Skip adding noundef attribute to AMDGPU HIP device functions

arsenm resigned from this revision. arsenm added a comment. This is now obsolete Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128700/new/ https://reviews.llvm.org/D128700 ___ cfe-commits mailing list

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fcb26c5b648: [clang] Fix __try/__finally blocks in C++ constructors. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0fcb26c - [clang] Fix __try/__finally blocks in C++ constructors.

Author: Eli Friedman Date: 2022-11-16T15:13:33-08:00 New Revision: 0fcb26c5b6487bf9b31670122f8c931ac020bb34 URL: https://github.com/llvm/llvm-project/commit/0fcb26c5b6487bf9b31670122f8c931ac020bb34 DIFF: https://github.com/llvm/llvm-project/commit/0fcb26c5b6487bf9b31670122f8c931ac020bb34.diff

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

delcypher added a comment. In D137024#3931488 , @mgorny wrote: > Well, I'm certainly not opposed to making all the paths configurable. > However, I'm not sure if having CMake file accessible one way or another > wouldn't eventually be a necessity. For

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri updated this revision to Diff 475925. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Herald added a subscriber: pcwang-thead. Adjust full LTO pipeline, for symmetry with non-full LTO pipeline. Looks like there is test coverage shortage. Repository: rG LLVM

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

rsmith closed this revision. rsmith added a comment. Landed in rG9e52db182794d87bb8527dda313afd1ac491ab11 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137751/new/ https://reviews.llvm.org/D137751

[clang-tools-extra] 0e00611 - [clangd] Add heuristic for dropping snippet when completing member function pointer

Author: Tom Praschan Date: 2022-11-17T00:37:16+01:00 New Revision: 0e00611cbc2b2f27e247a58b512cb2cec0624290 URL: https://github.com/llvm/llvm-project/commit/0e00611cbc2b2f27e247a58b512cb2cec0624290 DIFF: https://github.com/llvm/llvm-project/commit/0e00611cbc2b2f27e247a58b512cb2cec0624290.diff

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e00611cbc2b: [clangd] Add heuristic for dropping snippet when completing member function… (authored by tom-anders). Repository: rG LLVM Github

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

rsmith added a comment. In D137751#3930663 , @aaron.ballman wrote: > LGTM! Please add a release note when landing so folks know about the > improvements here. Thanks! Thanks, done and landed. CHANGES SINCE LAST ACTION

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

tom-anders added a comment. In D137909#3930043 , @sammccall wrote: > What do you think about `$name(payload)^` for the general case, with > `$(payload)^`, `$name`, and `^` as abbreviated forms? I don't think the lack > of brackets on **names** hurts a

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mstorsjo added a comment. In D137024#3931488 , @mgorny wrote: > Well, I'm certainly not opposed to making all the paths configurable. > However, I'm not sure if having CMake file accessible one way or another > wouldn't eventually be a necessity. For

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

tom-anders updated this revision to Diff 475922. tom-anders added a comment. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang-tools-extra. Keep name syntax, add optional payload instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3931860 , @spatel wrote: > LGTM based on the timing, results, and alternatives discussed Thank you for the review. > There's some testing in progress according to previous comments, so best to > wait for that to

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

nickdesaulniers added a comment. In D138078#3931843 , @arsenm wrote: > To me it sounds like the kind of issue we deal with in FinalizeISel to hack > around dag limitations I think it would be MUCH better to do this work BEFORE ISEL, otherwise in

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM based on the timing, results, and alternatives discussed There's some testing in progress according to previous comments, so best to wait for that to finish in case it turns up anything

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

arsenm added a comment. To me it sounds like the kind of issue we deal with in FinalizeISel to hack around dag limitations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138078/new/ https://reviews.llvm.org/D138078

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

nickdesaulniers added a comment. In D138078#3931247 , @nickdesaulniers wrote: > It looks like `indirectbr-expand` _is_ enabled at `-O0` and is necessary for > correctness IIUC. Thoughts on moving this there, and maybe renaming the pass > to

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e25ae605edd: [Clang] Correct when Itanium ABI guard variables are set for non-block… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3e25ae6 - [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

Author: Tom Honermann Date: 2022-11-16T16:31:35-05:00 New Revision: 3e25ae605edd88720de3a4407fdd4ea85f758dce URL: https://github.com/llvm/llvm-project/commit/3e25ae605edd88720de3a4407fdd4ea85f758dce DIFF: https://github.com/llvm/llvm-project/commit/3e25ae605edd88720de3a4407fdd4ea85f758dce.diff

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:300 +FPP_Fast, +FPP_None + }; andrew.w.kaylor wrote: > Is FPP_None somehow the same as fexcess-precision=16? If not, what does it > mean? Yes, maybe this is confusing.

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 475902. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/LangOptions.h

[PATCH] D134921: [HLSL] add cos library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG9777e98a610f: [HLSL] add cos library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/

[clang] 9777e98 - [HLSL] add cos library function

Author: Joshua Batista Date: 2022-11-16T12:54:11-08:00 New Revision: 9777e98a610f3128f8a79c13211ca5f05b26f9eb URL: https://github.com/llvm/llvm-project/commit/9777e98a610f3128f8a79c13211ca5f05b26f9eb DIFF:

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli added a comment. @lenary - thank you for the update! I have added a bunch of miso comments, a bit repetitive... by the time I realised they were repetitive it was faster to get to the bottom of it than removing them! In D137838#3931295 ,

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Sounds good to me. I think we just put it in Analysis in an attempt to keep IR small and focused, and particularly to avoid putting more target-specific logic in IR. Repository: rG LLVM Github

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation =

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri updated this revision to Diff 475894. lebedev.ri added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:238 + sys::path::append(path, directory, +outputFileBaseName + ".lto." + baseName); + sys::path::remove_dots(path, true); tejohnson wrote: > MaskRay wrote: > > What if

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475895. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

benlangmuir requested changes to this revision. benlangmuir added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:3374 +def ivfsstatcache : JoinedOrSeparate<["-"], "ivfsstatcache">, Group, Flags<[CC1Option]>, +

[PATCH] D135488: [codegen] Display stack layouts in console

dblaikie added a comment. > This pass prints a TON of (helpful) information...we have a lot of > -Wframe-larger-than= instances triggered in our codebase...I think having > this on by default would blow our logs significantly. That's why it might be > nice to have a Note suggest a flag

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

aaron.ballman added a comment. Thanks for this! You should also add a release note about the new functionality. Comment at: clang/include/clang-c/Index.h:2793-2794 + CXType_BTFTagAttributed = 178, + /* Represents a type that as been substituted for a template type parameter

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9621b1776a1b: [clang] Dont include C++ Standard Library headers when -nostdinc is used (authored by ldionne). Repository: rG LLVM Github Monorepo

[clang] 9621b17 - [clang] Don't include C++ Standard Library headers when -nostdinc is used

Author: Louis Dionne Date: 2022-11-16T15:25:32-05:00 New Revision: 9621b1776a1b3d16735b3c5da31585ad64a018df URL: https://github.com/llvm/llvm-project/commit/9621b1776a1b3d16735b3c5da31585ad64a018df DIFF: https://github.com/llvm/llvm-project/commit/9621b1776a1b3d16735b3c5da31585ad64a018df.diff

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

ldionne added a comment. Thanks! I'll land this and watch for any fallout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138062/new/ https://reviews.llvm.org/D138062 ___ cfe-commits mailing list

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137719/new/ https://reviews.llvm.org/D137719

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

shafik added a comment. In D138091#3930356 , @urnathan wrote: > Thanks, I didn;'t know about ClassifyName, and obviously never hit a need to > adjust it. Thanks for fixing. > > The comment above says we don't resolve member-access non-overload sets in

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

aaron.ballman added a reviewer: jcranmer-intel. aaron.ballman added a subscriber: jcranmer-intel. aaron.ballman added a comment. The changes look correct to me, but adding @jcranmer-intel for floating-point expertise. Comment at: clang/test/AST/const-fpfeatures.c:37 float

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

arsenm added a comment. Herald added a subscriber: Naghasan. Herald added a project: All. Was this addressed already? Today it looks like we have: if (Opts.FastRelaxedMath || Opts.CLUnsafeMath) Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); CHANGES SINCE LAST ACTION

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1 << 1 }; + njames93 wrote: > aaron.ballman wrote: > > I'm not really loving the `F_` prefixes -- the enumerators are

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

tstellar added a comment. In D137024#3931499 , @thetruestblue wrote: > In D137024#3931497 , @tstellar > wrote: > >> @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? > > TBD. > So far this

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475884. haowei marked 2 inline comments as done. haowei added a comment. Fixing Windows test failures. overlay-relative flag will always using native path separator, therefore, it needs a separate base FS and OverlayYAML file setup on Windows. This diff adds

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for your patience. Please wait for @MyDeveloperDay . Comment at: clang/unittests/Format/FormatTest.cpp:7215 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; -

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

thetruestblue added a comment. In D137024#3931497 , @tstellar wrote: > @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? TBD. So far this seems like the only necessary path. But I am working to confirm this. Repository: rG LLVM

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

tstellar added a comment. @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

aaron.ballman added a comment. In D136811#3913759 , @jkorous wrote: > @aaron.ballman We'd like to start making progress on the implementation in > parallel to iterating on the documentation and this is our first patch: > https://reviews.llvm.org/D137346

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Well, I'm certainly not opposed to making all the paths configurable. However, I'm not sure if having CMake file accessible one way or another wouldn't eventually be a necessity. For one thing, I would like to move more common code from standalone build codepaths of

  1   2   3   >