[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969593 , @Michael137 wrote: > In D127284#3969458 , @v.g.vassilev > wrote: > >> In D127284#3969446 , @v.g.vassilev >> wrote:

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 479992. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan needs noundef consistency between interface and implementation. If we call C++ from C we can have noundef on C++

[clang] e92fe7a - [test][msan] Update for noundef on retval

Author: Vitaly Buka Date: 2022-12-04T22:47:56-08:00 New Revision: e92fe7af3f9d7a660e026912852c8ce401331c03 URL: https://github.com/llvm/llvm-project/commit/e92fe7af3f9d7a660e026912852c8ce401331c03 DIFF: https://github.com/llvm/llvm-project/commit/e92fe7af3f9d7a660e026912852c8ce401331c03.diff

[clang] a996cc2 - Remove unused #include "llvm/ADT/Optional.h"

Author: Fangrui Song Date: 2022-12-05T06:31:11Z New Revision: a996cc217cefb9071888de38c6f05e5742d0106f URL: https://github.com/llvm/llvm-project/commit/a996cc217cefb9071888de38c6f05e5742d0106f DIFF: https://github.com/llvm/llvm-project/commit/a996cc217cefb9071888de38c6f05e5742d0106f.diff LOG:

[clang-tools-extra] e280b97 - [iwyu] Add Hashing.h

Author: Fangrui Song Date: 2022-12-05T06:26:26Z New Revision: e280b97fd7e1b555856367da1fac44b2530fd296 URL: https://github.com/llvm/llvm-project/commit/e280b97fd7e1b555856367da1fac44b2530fd296 DIFF: https://github.com/llvm/llvm-project/commit/e280b97fd7e1b555856367da1fac44b2530fd296.diff LOG:

[PATCH] D139281: [clang-format] Fix an assertion failure in block parsing

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. We should rename, remove, or re add the functionality for this function. Or else someone new will come along and be confused. Repository: rG LLVM Github Monorepo

[PATCH] D138489: [tsan] Add tsan support for loongarch64

tangyouling updated this revision to Diff 479980. tangyouling added a comment. Add glibc version comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138489/new/ https://reviews.llvm.org/D138489 Files: clang/lib/Driver/ToolChains/Linux.cpp

[clang] 7760971 - Forward-declare raw_ostream (NFC)

Author: Kazu Hirata Date: 2022-12-04T21:43:10-08:00 New Revision: 77609717410372e8c43aca49a268511378f58297 URL: https://github.com/llvm/llvm-project/commit/77609717410372e8c43aca49a268511378f58297 DIFF: https://github.com/llvm/llvm-project/commit/77609717410372e8c43aca49a268511378f58297.diff

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin added inline comments. Comment at: clang/lib/Headers/larchintrin.h:67-96 #define __break(/*ui15*/ _1) __builtin_loongarch_break((_1)) #define __dbar(/*ui15*/ _1) __builtin_loongarch_dbar((_1)) #define __ibar(/*ui15*/ _1) __builtin_loongarch_ibar((_1))

[PATCH] D138792: [AArch64] Improve TargetParser API

MaskRay added a comment. @bkramer pushed a C++20 fix which was reverted by 8be0d8fb83aa359caf0a7413c4a0fe49aef0dff1 by @tmatheson , but the revert had no message about why. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

SixWeining added inline comments. Comment at: clang/lib/Headers/larchintrin.h:67-96 #define __break(/*ui15*/ _1) __builtin_loongarch_break((_1)) #define __dbar(/*ui15*/ _1) __builtin_loongarch_dbar((_1)) #define __ibar(/*ui15*/ _1) __builtin_loongarch_ibar((_1))

[clang] 22731db - [clang] Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-04T20:31:05-08:00 New Revision: 22731dbd75a9c3dd89ec08e2e86d10343609f58c URL: https://github.com/llvm/llvm-project/commit/22731dbd75a9c3dd89ec08e2e86d10343609f58c DIFF: https://github.com/llvm/llvm-project/commit/22731dbd75a9c3dd89ec08e2e86d10343609f58c.diff

[PATCH] D138792: [AArch64] Improve TargetParser API

saugustine added a comment. We are seeing constexpr failures with this change. They look like this: In file included from llvm-project/llvm/lib/Support/AArch64TargetParser.cpp:14: In file included from llvm-project/llvm/include/llvm/Support/AArch64TargetParser.h:160:

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

owenpan added a comment. @gedare do you need us to commit this patch on your behalf (using "Gedare Bloom ")? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762

[clang] 89fae41 - [IR] llvm::Optional => std::optional

Author: Fangrui Song Date: 2022-12-05T04:13:11Z New Revision: 89fae41ef142892d8d6c20ead28465a34e12172b URL: https://github.com/llvm/llvm-project/commit/89fae41ef142892d8d6c20ead28465a34e12172b DIFF: https://github.com/llvm/llvm-project/commit/89fae41ef142892d8d6c20ead28465a34e12172b.diff LOG:

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin updated this revision to Diff 479967. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139288/new/ https://reviews.llvm.org/D139288 Files:

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin added a comment. In D139288#3969746 , @xen0n wrote: > You'll also need the IOCSR intrinsics too for building Linux. Since they're > very similar to some of the CSR intrinsics you added here, do you plan to add > support for them later here

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM from the LoongArch side but it's better to wait for others. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:270 +#elif

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

xen0n added a comment. You'll also need the IOCSR intrinsics too for building Linux. Since they're very similar to some of the CSR intrinsics you added here, do you plan to add support for them later here or in a separate follow-up change? Comment at:

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:155 +// CHECK-MAKE: [[PREFIX]]/impl_part.o: +// CHECK-MAKE: [[PREFIX]]/impl_part.cppm ben.boeckel wrote: > ChuanqiXu wrote: > > ben.boeckel wrote: > > > For scanning, this

[PATCH] D139177: [LoongArch] Specify registers used for exception handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG47edc7086692: [LoongArch] Specify registers used for exception handling (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139177/new/

[clang] 47edc70 - [LoongArch] Specify registers used for exception handling

Author: Weining Lu Date: 2022-12-05T11:42:41+08:00 New Revision: 47edc70866920693d99e5b31014ba761a796d181 URL: https://github.com/llvm/llvm-project/commit/47edc70866920693d99e5b31014ba761a796d181 DIFF: https://github.com/llvm/llvm-project/commit/47edc70866920693d99e5b31014ba761a796d181.diff

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:155 +// CHECK-MAKE: [[PREFIX]]/impl_part.o: +// CHECK-MAKE: [[PREFIX]]/impl_part.cppm ChuanqiXu wrote: > ben.boeckel wrote: > > For scanning, this cannot be the object file.

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:228 +namespace jit { +bool checkBitcodeImage(__tgt_device_image *Image, std::string Triple) { + TimeTraceScope TimeScope("Check bitcode image");

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:685 + auto TgtImageOrErr = jit::compile(TgtImage, Triple, Arch, +/* OptLevel */ 3, PostProcessing); +

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:879 "Cannot embed bitcode with multiple files."); -OutputFiles.push_back(static_cast(BitcodeOutput.front())); +

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ggeorgakoudis, jhuber6. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1.

[clang] 9e87878 - [test][CodeGen] Check noundef for omited return

Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: 9e8787821f62bc7856d9a4cdf439aadbaf43ed64 URL: https://github.com/llvm/llvm-project/commit/9e8787821f62bc7856d9a4cdf439aadbaf43ed64 DIFF: https://github.com/llvm/llvm-project/commit/9e8787821f62bc7856d9a4cdf439aadbaf43ed64.diff

[clang] 262d6d4 - [test][CodeGen] Check noundef for return value

Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: 262d6d495c692678c100fc4565a519b4ed070f28 URL: https://github.com/llvm/llvm-project/commit/262d6d495c692678c100fc4565a519b4ed070f28 DIFF: https://github.com/llvm/llvm-project/commit/262d6d495c692678c100fc4565a519b4ed070f28.diff

[clang] 487edfa - [NFC][CodeGen] Add const to a method

Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: 487edfa4327446d884709263006d3b9108181fce URL: https://github.com/llvm/llvm-project/commit/487edfa4327446d884709263006d3b9108181fce DIFF: https://github.com/llvm/llvm-project/commit/487edfa4327446d884709263006d3b9108181fce.diff

[clang] a3b48e0 - [NFC][CodeGen] Extract HasStrictReturn

Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: a3b48e094525ebbce95e7a9da77612adf04ae314 URL: https://github.com/llvm/llvm-project/commit/a3b48e094525ebbce95e7a9da77612adf04ae314 DIFF: https://github.com/llvm/llvm-project/commit/a3b48e094525ebbce95e7a9da77612adf04ae314.diff

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

tentzen added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * lebedev.ri wrote: > This test broke once we always started adding (outermost) UB scope for >

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:155 +// CHECK-MAKE: [[PREFIX]]/impl_part.o: +// CHECK-MAKE: [[PREFIX]]/impl_part.cppm ben.boeckel wrote: > For scanning, this cannot be the object file. The output needs to be

[clang-tools-extra] 7c2b773 - [clang-tools-extra] Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-04T17:40:28-08:00 New Revision: 7c2b77368f006f7d4a92b0786adc3f38969d9e2d URL: https://github.com/llvm/llvm-project/commit/7c2b77368f006f7d4a92b0786adc3f38969d9e2d DIFF: https://github.com/llvm/llvm-project/commit/7c2b77368f006f7d4a92b0786adc3f38969d9e2d.diff

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969458 , @v.g.vassilev wrote: > In D127284#3969446 , @v.g.vassilev > wrote: > >>> UPDATE: fails with clean build too >>> >>> Might be best to revert it for now while we

[clang] 35b4fbb - [clang] Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-04T15:57:24-08:00 New Revision: 35b4fbb559d909a7edf64412c665e99748398ac4 URL: https://github.com/llvm/llvm-project/commit/35b4fbb559d909a7edf64412c665e99748398ac4 DIFF: https://github.com/llvm/llvm-project/commit/35b4fbb559d909a7edf64412c665e99748398ac4.diff

[PATCH] D139281: [clang-format] Fix an assertion failure in block parsing

owenpan created this revision. owenpan added reviewers: sstwcw, HazardyKnusperkeks, MyDeveloperDay, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D123450: [clang-format] Parse Verilog if statements

owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:1572 + bool isBlockBegin(const FormatToken , const FormatStyle ) const { +return Style.isVerilog() ? isVerilogBegin(Tok) : Tok.is(tok::l_brace); + } HazardyKnusperkeks wrote: >

[PATCH] D123450: [clang-format] Parse Verilog if statements

owenpan added a comment. In D123450#3465024 , @MyDeveloperDay wrote: > ``if (Keywords.isBlockBegin(*FormatTok, Style)) {`` > > I'm not a massive fan of handling l_brace and begin and end as the same > thing, I might be tempted to handle them

[PATCH] D139276: [SanitizerBinaryMetadata] Use weak __start_/__stop_ instead of dummy empty section

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeecb22d8e1fe: [SanitizerBinaryMetadata] Use weak __start_/__stop_ instead of dummy empty… (authored by MaskRay). Repository: rG LLVM Github

[clang] eecb22d - [SanitizerBinaryMetadata] Use weak __start_/__stop_ instead of dummy empty section

Author: Fangrui Song Date: 2022-12-04T15:06:34-08:00 New Revision: eecb22d8e1fe5ac6cc35ace63ae517c33ff40d85 URL: https://github.com/llvm/llvm-project/commit/eecb22d8e1fe5ac6cc35ace63ae517c33ff40d85 DIFF: https://github.com/llvm/llvm-project/commit/eecb22d8e1fe5ac6cc35ace63ae517c33ff40d85.diff

[PATCH] D139276: [SanitizerBinaryMetadata] Use weak __start_/__stop_ instead of dummy empty section

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. Thanks - yes this looks better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139276/new/ https://reviews.llvm.org/D139276

[clang] 86d8f2c - [clang] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-04T13:52:44-08:00 New Revision: 86d8f2ce97c36a57da55220b1f0eecf999e78a3d URL: https://github.com/llvm/llvm-project/commit/86d8f2ce97c36a57da55220b1f0eecf999e78a3d DIFF: https://github.com/llvm/llvm-project/commit/86d8f2ce97c36a57da55220b1f0eecf999e78a3d.diff

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:154-160 +// Create ArchInfo structs named +#define AARCH64_ARCH(MAJOR, MINOR, PROFILE, NAME, ID, ARCH_FEATURE, \ + ARCH_BASE_EXT)

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. Yes I will look into it and address the other comments when I have more time tomorrow or later this week. However I'm starting to think that the comparison by address is too easy to subtly break, and not immediately obvious to debug, and is therefore not worth it in

[PATCH] D138792: [AArch64] Improve TargetParser API

Hahnfeld added a comment. What about @bkramer's suggestion to move the definitions out of the header? Based on what you write (comparison by address), this should also solve the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138792/new/

[clang] 4e62072 - [Passes] llvm::Optional => std::optional

Author: Fangrui Song Date: 2022-12-04T20:44:52Z New Revision: 4e62072ca1ee4ecb7584ba9a69464ba617eaae61 URL: https://github.com/llvm/llvm-project/commit/4e62072ca1ee4ecb7584ba9a69464ba617eaae61 DIFF: https://github.com/llvm/llvm-project/commit/4e62072ca1ee4ecb7584ba9a69464ba617eaae61.diff LOG:

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. @Hahnfeld, @mgorny I was able to reproduce the failures with LLVM_LINK_LLVM_DYLIB, and they are failing because the comparison is failing because copies are being created. I don't fully understand how but presumably we are still ending up with one object per shared

[PATCH] D138792: [AArch64] Improve TargetParser API

Hahnfeld added a comment. In D138792#3969310 , @mgorny wrote: > In D138792#3966920 , @Hahnfeld > wrote: > >> Hi, I bisected this change to lead to a couple of test failures when >> building with

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969446 , @v.g.vassilev wrote: >> UPDATE: fails with clean build too >> >> Might be best to revert it for now while we figure out what's wrong > > I fail to reproduce it, can you give me access to some node where

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe33243c950ac: [clang-format] Link the braces of a block in UnwrappedLineParser (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] e33243c - [clang-format] Link the braces of a block in UnwrappedLineParser

Author: Owen Pan Date: 2022-12-04T12:01:26-08:00 New Revision: e33243c950ac40d027ad8facbf7ccf0624604a16 URL: https://github.com/llvm/llvm-project/commit/e33243c950ac40d027ad8facbf7ccf0624604a16 DIFF: https://github.com/llvm/llvm-project/commit/e33243c950ac40d027ad8facbf7ccf0624604a16.diff

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. > UPDATE: fails with clean build too > > Might be best to revert it for now while we figure out what's wrong I fail to reproduce it, can you give me access to some node where I can debug? I suspect that should be something easy to fix. Repository: rG LLVM

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969398 , @Michael137 wrote: > In D127284#3969308 , @v.g.vassilev > wrote: > >> In D127284#3969249 , @v.g.vassilev >> wrote:

[clang] 8956852 - Undo a bit of fcf4e360ba6b that confuses MSVC

Author: Benjamin Kramer Date: 2022-12-04T20:33:25+01:00 New Revision: 89568521943b79fe27c6f3c19799a575318b1882 URL: https://github.com/llvm/llvm-project/commit/89568521943b79fe27c6f3c19799a575318b1882 DIFF:

[PATCH] D139038: [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template

royjacobson created this revision. Herald added a project: All. royjacobson updated this revision to Diff 479935. royjacobson added a comment. royjacobson retitled this revision from "Draft fix for 59206" to "[Clang] Don't consider default constructors ineligible if the more constrained

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tschuett added a comment. I am bit afraid about release builds: if (!Initializer) return; Is this semantically incorrect? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 ___ cfe-commits

[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

ehntoo created this revision. ehntoo added reviewers: kadircet, nridge. ehntoo added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. ehntoo requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Rework the cache key

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969308 , @v.g.vassilev wrote: > In D127284#3969249 , @v.g.vassilev > wrote: > >> In D127284#3969225 , @Michael137 >> wrote: >>

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:177-178 + case tok::kw___attribute: + case tok::kw_const: + case tok::kw_volatile: + case tok::star: aaron.ballman wrote: > What about other qualifiers? `_Nullable` and `restrict` and

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added a comment. When committing changes to address Coverity reported issues, I think it would be useful to include the Coverity analysis in the commit message. A textual representation can be obtained using `cov-format-errors --emacs-style` from the command line with access to the

[PATCH] D136078: Use-after-return sanitizer binary metadata

MaskRay added a comment. In D136078#3969091 , @melver wrote: > In D136078#3969061 , @MaskRay wrote: > >> ` SanitizerBinaryMetadata::createZeroSizedObjectInSection` creates >> `__dummy_*`, but why is it needed?

[PATCH] D139276: [SanitizerBinaryMetadata] Use weak __start_/__stop_ instead of dummy empty section

MaskRay created this revision. MaskRay added reviewers: melver, dvyukov. Herald added subscribers: Enna1, StephenFan, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. D130887

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante added a comment. Thanks for the patch! Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Is `__cplusplus-0`

[clang] 0ca43d4 - DebugInfoMetadata: convert Optional to std::optional

Author: Krzysztof Parzyszek Date: 2022-12-04T11:52:02-06:00 New Revision: 0ca43d4485d6caf7636db91fe810e822263c URL: https://github.com/llvm/llvm-project/commit/0ca43d4485d6caf7636db91fe810e822263c DIFF:

[clang] fcf4e36 - Iterate over StringMaps using structured bindings. NFCI.

Author: Benjamin Kramer Date: 2022-12-04T18:36:41+01:00 New Revision: fcf4e360ba6b5f005d2c478ca79112be7a61dacb URL: https://github.com/llvm/llvm-project/commit/fcf4e360ba6b5f005d2c478ca79112be7a61dacb DIFF:

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille created this revision. serge-sans-paille added reviewers: thakis, aaron.ballman, nikic. Herald added a subscriber: hiraditya. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald

[PATCH] D138792: [AArch64] Improve TargetParser API

mgorny added a comment. In D138792#3966920 , @Hahnfeld wrote: > Hi, I bisected this change to lead to a couple of test failures when building > with `LLVM_LINK_LLVM_DYLIB`. In the past, this had to do with global variable > initialization order, but

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969249 , @v.g.vassilev wrote: > In D127284#3969225 , @Michael137 > wrote: > >> FYI, looks like this broke the LLDB incremental buildbot. Following tests >> started

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. pin~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] ee13633 - [NFC][clang] Strengthen checks in avx512fp16-builtins.c

Author: John McIver Date: 2022-12-04T14:57:43Z New Revision: ee13633c46cda3826d384d60c85057085025eebb URL: https://github.com/llvm/llvm-project/commit/ee13633c46cda3826d384d60c85057085025eebb DIFF: https://github.com/llvm/llvm-project/commit/ee13633c46cda3826d384d60c85057085025eebb.diff LOG:

[clang] 2389488 - [NFC][clang] Strengthen checks in avx512f-builtins.c

Author: John McIver Date: 2022-12-04T14:55:41Z New Revision: 23894884377372d2ea048b452bf9a68de3e8515a URL: https://github.com/llvm/llvm-project/commit/23894884377372d2ea048b452bf9a68de3e8515a DIFF: https://github.com/llvm/llvm-project/commit/23894884377372d2ea048b452bf9a68de3e8515a.diff LOG:

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

lebedev.ri added reviewers: wsmoses, jdoerfert. lebedev.ri added a comment. Certainly needs tests. I'm not sure if anyone actually knows this area of LLVM, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139267/new/

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

cor3ntin added a comment. In D139212#3969179 , @h-vetinari wrote: > I've had a small nit/suggestion post-merge of > https://reviews.llvm.org/D138901; in case you feel it's worth picking up if > you're touching that file already. Nice simplification,

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

cor3ntin updated this revision to Diff 479919. cor3ntin added a comment. Apply changes suggested in D138901 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139212/new/ https://reviews.llvm.org/D139212 Files:

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969225 , @Michael137 wrote: > FYI, looks like this broke the LLDB incremental buildbot. Following tests > started failing: > > >

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. FYI, looks like this broke the LLDB incremental buildbot. Following tests started failing: lldb-api.commands/expression/argument_passing_restrictions.TestArgumentPassingRestrictions.py

[PATCH] D138792: [AArch64] Improve TargetParser API

Hahnfeld added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:154-160 +// Create ArchInfo structs named +#define AARCH64_ARCH(MAJOR, MINOR, PROFILE, NAME, ID, ARCH_FEATURE, \ + ARCH_BASE_EXT)

[PATCH] D138792: [AArch64] Improve TargetParser API

bkramer added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:115-118 + ArchInfo(const ArchInfo &) = delete; + ArchInfo(const ArchInfo &&) = delete; + ArchInfo =(const ArchInfo ) = delete; + ArchInfo &=(const ArchInfo &) = delete;

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

h-vetinari added a comment. I've had a small nit/suggestion post-merge of https://reviews.llvm.org/D138901; in case you feel it's worth picking up if you're touching that file already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139212/new/

[PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479906. rahmanl added a comment. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100808/new/ https://reviews.llvm.org/D100808 Files: llvm/include/llvm/CodeGen/BasicBlockSectionsProfileReader.h

[PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479905. rahmanl added a comment. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, hanchung, kadircet, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, steakhal, mtrofin, Enna1, bzcheeseman,

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver added a comment. In D136078#3969061 , @MaskRay wrote: > ` SanitizerBinaryMetadata::createZeroSizedObjectInSection` creates > `__dummy_*`, but why is it needed? (There is no comment.) " // Create a 0-sized object in a section, so that the

[clang] 5f5b942 - Correct typo introduced in f607884a04b0ca06951227a01d00bc59b948d337

Author: serge-sans-paille Date: 2022-12-04T09:32:00+01:00 New Revision: 5f5b942823474e98e43a27d515a87ce140396c53 URL: https://github.com/llvm/llvm-project/commit/5f5b942823474e98e43a27d515a87ce140396c53 DIFF: