[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5573-5576 + SDLoc SL(Op); + return DAG.getNode( + ISD::FP_EXTEND, SL, MVT::f32, + DAG.getNode(ISD::BITCAST, SL, MVT::f16, Op->getOperand(0))); arsenm wrote: > arsen

[clang-tools-extra] 4ce6dfb - [include-cleaner] Add a unique_ptr-style member expr test in WalkASTTest.

Author: Haojian Wu Date: 2022-12-12T09:58:54+01:00 New Revision: 4ce6dfbcd6f0cbe8e03ecf6f99b306f6826bf239 URL: https://github.com/llvm/llvm-project/commit/4ce6dfbcd6f0cbe8e03ecf6f99b306f6826bf239 DIFF: https://github.com/llvm/llvm-project/commit/4ce6dfbcd6f0cbe8e03ecf6f99b306f6826bf239.diff LO

[PATCH] D139696: [include-cleaner] Add a unique_ptr-style member expr test in WalkASTTest.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG4ce6dfbcd6f0: [include-cleaner] Add a unique_ptr-style member expr test in WalkASTTest. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein added a comment. thanks, looks mostly good, I think we can simplify the unittest further. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:51 Type = Type->getPointeeType(); +if (const TemplateSpecializationType *TST = +Type->getAs()) {

[clang] 9853c02 - [LoongArch] Test CodeGen/LoongArch/intrinsic-la32.c with -O2. NFC.

Author: gonglingqin Date: 2022-12-12T17:22:07+08:00 New Revision: 9853c0263efc71c6b392ab4f0af5b7ab117ab76e URL: https://github.com/llvm/llvm-project/commit/9853c0263efc71c6b392ab4f0af5b7ab117ab76e DIFF: https://github.com/llvm/llvm-project/commit/9853c0263efc71c6b392ab4f0af5b7ab117ab76e.diff L

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

clementval added a comment. Herald added a subscriber: jdoerfert. I have the `Driver/fast_math.f90` failing on my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138675/new/ https://reviews.llvm.org/D138675

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

nridge added a comment. While we're waiting for Sam to weigh in on the modifier question, a couple of comments about the details of the patch: - Does the implementation handle explicit operator calls, e.g. `a.operator+(b)`? If so, it would be nice to add some test coverage. - I see the patch ha

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

hokein added a comment. The implementation looks good. Some comments around the test. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:161 +TEST_F(FindHeadersTest, TargetIsArgumentExpandedFromMacroInHeader) { + llvm::Annotations MainFile(R"cpp( ---

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

nridge resigned from this revision. nridge added a comment. In D138546#3980350 , @cpsauer wrote: > @nridge, I took a shot at amending the test. Thanks for the pointer! Please > me know if that looks good to you! The test changes look good, thanks. I'm

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3986227 , @manojgupta wrote: > The removal is also breaking ChromeOS builds which use -Xpattern in some > cases. Do you have a justifying example showing which `-Xpattern` is used? It needs to do useful work, instea

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. > This change is breaking internal builds. We use the -Xfoo pattern but can now > no longer manage whether we allow an unused -Xfoo option to pass as a warning > or promote it to an error. Which `-Xfoo` is used? Do your internal builds reserve `-Xfoo` as a placeholder

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

MaskRay added a comment. > I think newr AVR projects should use clang common style options instead of > older avr-gcc style. Does GCC prefer `-mcpu=` as well? If not, raise a PR there? This seems like a decision we should not unilaterally make on llvm-project side: it's certainly something GCC

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

michaelplatings created this revision. michaelplatings added reviewers: abidh, jroelofs. michaelplatings added a project: clang. Herald added subscribers: dberris, ki.stfu. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 482051. cor3ntin added a comment. When a CXXDefaultInitExpr calls a Constructor, make sure that the fields default initialized by that constructor are also marked odr used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] bb48aa2 - [Clang][NFC] Prevent lit tests from matching substrings in current path

Author: Sameer Sahasrabuddhe Date: 2022-12-12T16:32:58+05:30 New Revision: bb48aa20e761e26226c6f909a07246781d68ba41 URL: https://github.com/llvm/llvm-project/commit/bb48aa20e761e26226c6f909a07246781d68ba41 DIFF: https://github.com/llvm/llvm-project/commit/bb48aa20e761e26226c6f909a07246781d68ba4

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 482055. ckandeler added a comment. Added more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh added a comment. In D139608#3982494 , @jcranmer-intel wrote: > I don't normally handle name mangling, so I can't comment too much here, but > I will note that Itanium ABI is planning on using DF16b for > `std::bfloat16_t`: https://github.com/

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3987852 , @nridge wrote: > - Does the implementation handle explicit operator calls, e.g. > `a.operator+(b)`? If so, it would be nice to add some test coverage. It does now. Repository: rG LLVM Github Monorepo

[clang] a888825 - [UpdateTestChecks] Match define for labels

Author: Sebastian Neubauer Date: 2022-12-12T12:29:54+01:00 New Revision: a25aeef8d6592c6cf5f4e5854cc39af49633 URL: https://github.com/llvm/llvm-project/commit/a25aeef8d6592c6cf5f4e5854cc39af49633 DIFF: https://github.com/llvm/llvm-project/commit/a25aeef8d6592c6cf5f4e5854cc39af49633.

[PATCH] D139006: [UpdateTestChecks] Match define for labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGa25aeef8: [UpdateTestChecks] Match define for labels (authored by sebastian-ne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139006/new/ https://revie

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3987836 , @clementval wrote: > I have the `Driver/fast_math.f90` failing on my side. > > llvm-project/flang/test/Driver/fast_math.f90:63:14: error: CHECK-CRT: > expected string not found in input > ! CHECK-CRT: crtb

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

Backl1ght updated this revision to Diff 482062. Backl1ght retitled this revision from "[clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine" to "[clang-format] AllowShortRequiresExpressionOnASingleLine". Backl1ght edited the summary of this revi

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

Backl1ght updated this revision to Diff 482066. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139786/new/ https://reviews.llvm.org/D139786 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineF

[PATCH] D139006: [UpdateTestChecks] Match define for labels

mkazantsev added a comment. So now every single test needs to be regenerated? It'll create straw diff from nowhere... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139006/new/ https://reviews.llvm.org/D139006 _

[clang-tools-extra] 5af4408 - [clangd] Remove a gest-internal header, NFC

Author: Haojian Wu Date: 2022-12-12T13:16:18+01:00 New Revision: 5af440868c1a1ea880bcbfa3c04b3336af1932c2 URL: https://github.com/llvm/llvm-project/commit/5af440868c1a1ea880bcbfa3c04b3336af1932c2 DIFF: https://github.com/llvm/llvm-project/commit/5af440868c1a1ea880bcbfa3c04b3336af1932c2.diff LO

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the explanation! It makes sense. And given this motivation I don't think inverting to "builtin" is a good idea. The impact is a bit limited because it's not a standard modifier

[PATCH] D139006: [UpdateTestChecks] Match define for labels

sebastian-ne added a comment. In D139006#3988215 , @mkazantsev wrote: > So now every single test needs to be regenerated? It'll create straw diff > from nowhere... We don’t need to regenerate every test. Similar to how we don’t reformat all of LLVM aft

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, rymiel. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format brace wrapp

[clang-tools-extra] 843be73 - [clangd] Fix a typo "Features.h" => "Feature.h" in IWYU pragma.

Author: Haojian Wu Date: 2022-12-12T13:46:19+01:00 New Revision: 843be73065617a4b55a542aff7d0b286c1e9b888 URL: https://github.com/llvm/llvm-project/commit/843be73065617a4b55a542aff7d0b286c1e9b888 DIFF: https://github.com/llvm/llvm-project/commit/843be73065617a4b55a542aff7d0b286c1e9b888.diff LO

[PATCH] D139835: [include-cleaner] Include the reference type when printing the SymbolReference.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This information is useful when printing the reference for debugging purposes. Repository: rG LLVM Github Monorepo

[PATCH] D139113: [clang-tidy] Fix a couple additional cases in misc-use-anonymous-namespace

vingeldal accepted this revision. vingeldal added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/use-anonymous-namespace.cpp:46-48 +// OK +static const int v8{123}; +static constexpr int v9{123};

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

clementval added a comment. In D138675#3988110 , @tblah wrote: > In D138675#3987836 , @clementval > wrote: > >> I have the `Driver/fast_math.f90` failing on my side. >> >> llvm-project/flang/test/Driver/fast_ma

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane, rsmith. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. e

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 482088. ychen added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/AST/DeclCXX.h

[PATCH] D139835: [include-cleaner] Include the reference type when printing the SymbolReference.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/Types.cpp:49 // isn't completely useless (and distinguishes SymbolReference from Symbol). - return OS << R.Targe

[clang] c9e9a7f - Revert "[Clang][NFC] Prevent lit tests from matching substrings in current path"

Author: Nikita Popov Date: 2022-12-12T14:44:10+01:00 New Revision: c9e9a7f2fd4b41a842c74ce2a4bbaccf8a4559e5 URL: https://github.com/llvm/llvm-project/commit/c9e9a7f2fd4b41a842c74ce2a4bbaccf8a4559e5 DIFF: https://github.com/llvm/llvm-project/commit/c9e9a7f2fd4b41a842c74ce2a4bbaccf8a4559e5.diff

[clang] 5f84369 - [Clang] Convert CXX tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2022-12-12T14:49:32+01:00 New Revision: 5f843693a461696a00f2e349b51e4cc9282a1a7b URL: https://github.com/llvm/llvm-project/commit/5f843693a461696a00f2e349b51e4cc9282a1a7b DIFF: https://github.com/llvm/llvm-project/commit/5f843693a461696a00f2e349b51e4cc9282a1a7b.diff

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser requested changes to this revision. jamieschmeiser added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:54 +auto TargetCPUName = llvm::StringSwitch(CPUName) + .Cas

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. Last(?) ping of the year? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. Last(?) ping of the year? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D139835: [include-cleaner] Include the reference type when printing the SymbolReference.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG6c0c280b8ddc: [include-cleaner] Include the reference type when printing the SymbolReference. (authored by h

[clang-tools-extra] 6c0c280 - [include-cleaner] Include the reference type when printing the SymbolReference.

Author: Haojian Wu Date: 2022-12-12T14:52:31+01:00 New Revision: 6c0c280b8ddcede2b78afe948c764cb04503f980 URL: https://github.com/llvm/llvm-project/commit/6c0c280b8ddcede2b78afe948c764cb04503f980 DIFF: https://github.com/llvm/llvm-project/commit/6c0c280b8ddcede2b78afe948c764cb04503f980.diff LO

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

hans added a comment. Chromium is seeing a formatting regression after this: https://github.com/llvm/llvm-project/issues/59473 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136100/new/ https://reviews.llvm.org/D136100

[clang-tools-extra] d3c3de6 - [clang-tidy][NFC] Simply match processing in misc-use-anonymous-namespace

Author: Carlos Galvez Date: 2022-12-12T14:05:19Z New Revision: d3c3de63ce8416ab2dee7f784e54b00a2aa8ed85 URL: https://github.com/llvm/llvm-project/commit/d3c3de63ce8416ab2dee7f784e54b00a2aa8ed85 DIFF: https://github.com/llvm/llvm-project/commit/d3c3de63ce8416ab2dee7f784e54b00a2aa8ed85.diff LOG:

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

jhuber6 added a comment. In D136100#3988424 , @hans wrote: > Chromium is seeing a formatting regression after this: > https://github.com/llvm/llvm-project/issues/59473 My guess is from this line, we could be more specific on the type of pragma. if (S

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

Backl1ght added a comment. I just find out I miss one case like below template concept c = requires(T x) { { x + 1 } -> std::same_as; }; Since I split AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine into two pathes, I can not fix this until AllowSho

[clang-tools-extra] e864749 - [include-cleaner] Add a newline at end of the file, NFC

Author: Haojian Wu Date: 2022-12-12T15:29:27+01:00 New Revision: e864749d4dbe57fd4b0874a9ea189f87285ac473 URL: https://github.com/llvm/llvm-project/commit/e864749d4dbe57fd4b0874a9ea189f87285ac473 DIFF: https://github.com/llvm/llvm-project/commit/e864749d4dbe57fd4b0874a9ea189f87285ac473.diff LO

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 482102. fahadnayyar added a comment. Added forward declare for CheckImplicitConversion to make the diff look clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:54 +auto TargetCPUName = llvm::StringSwitch(CPUName) + .Case("common", "generic") + .Case("440fp", "440") jamieschme

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler updated this revision to Diff 482103. ckandeler added a comment. Renamed modifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ https://reviews.llvm.org/D136594 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D139113: [clang-tidy] Fix a couple additional cases in misc-use-anonymous-namespace

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/use-anonymous-namespace.cpp:46-48 +// OK +static const int v8{123}; +static constexpr int v9{123}; vingeldal wrote: > Is it really the best behavior to allow these?

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

MyDeveloperDay added a comment. In D136100#3988424 , @hans wrote: > Chromium is seeing a formatting regression after this: > https://github.com/llvm/llvm-project/issues/59473 Can we get more specific about what Chromium is seeing? Repository: rG LLV

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

MyDeveloperDay added a comment. I guess in principle this looks ok, but lets see what the others think @owenpan , @HazardyKnusperkeks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139801/new/ https://reviews.llvm.org/D139801 _

[clang-tools-extra] dabda23 - [clang-tidy][NFC] Fix compiler warning in GlobListTest.cpp

Author: Carlos Galvez Date: 2022-12-12T14:49:09Z New Revision: dabda23f1991f7c4e5a840ee6cf1290e18fa2e88 URL: https://github.com/llvm/llvm-project/commit/dabda23f1991f7c4e5a840ee6cf1290e18fa2e88 DIFF: https://github.com/llvm/llvm-project/commit/dabda23f1991f7c4e5a840ee6cf1290e18fa2e88.diff LOG:

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Feels like this would only show if someone did namespace A { };; Which seems odd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. I suppose we could temporarily add a test that does ; REQUIRES: target={{.*}}-zos ; RUN: %python -c 'import platform; print(platform.system())' && false and see what gets printed. Searching the buildbot console page for 'zos' turns up nothing; 's390' turns up cla

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2999 -// Munch the semicolon after a namespace. This is more common than one would -// think. Putting the semicolon into its own line is very ugly. This comment

[PATCH] D137649: [Clang][OpenMP] Warn and discard write to host for const variable

jplehr planned changes to this revision. jplehr added a comment. We had another clarifying example on the github issue, which currently is not correctly covered by this patch. I'm currently reworking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @aeubanks I just completed a compilation of all of chrome including tests. let me know if you want to run more tests on your side and thanks again for reporting these issues. I think we are getting there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 822c274 - [clang-cl] Ignore #pragma managed/unmanaged

Author: Sylvain Audi Date: 2022-12-12T10:01:24-05:00 New Revision: 822c274477ea2f194b4e3f2a38fdb3d3ba8ea611 URL: https://github.com/llvm/llvm-project/commit/822c274477ea2f194b4e3f2a38fdb3d3ba8ea611 DIFF: https://github.com/llvm/llvm-project/commit/822c274477ea2f194b4e3f2a38fdb3d3ba8ea611.diff

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG822c274477ea: [clang-cl] Ignore #pragma managed/unmanaged (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

thakis added a comment. > Can we get more specific about what Chromium is seeing? https://github.com/llvm/llvm-project/issues/59473 has a standalone repro. What else would you like to see? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136100/new/

[clang] 58c9467 - Use std::optional in Tooling/Inclusions.

Author: Haojian Wu Date: 2022-12-12T16:01:56+01:00 New Revision: 58c9467f58a3ec77bae4675becfa7f3bc8470230 URL: https://github.com/llvm/llvm-project/commit/58c9467f58a3ec77bae4675becfa7f3bc8470230 DIFF: https://github.com/llvm/llvm-project/commit/58c9467f58a3ec77bae4675becfa7f3bc8470230.diff LO

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139822/new/ https://reviews.llvm.org/D139822 ___

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

jamieschmeiser added a subscriber: hubert.reinterpretcast. jamieschmeiser added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:54 +auto TargetCPUName = llvm::StringSwitch(CPUName) + .Case("common", "generic") +

[clang-tools-extra] 647d314 - [clangd] Add support for semantic token type "operator"

Author: Christian Kandeler Date: 2022-12-12T16:17:43+01:00 New Revision: 647d314eb059b6d2e7c00d7eefe6a7afc37dff25 URL: https://github.com/llvm/llvm-project/commit/647d314eb059b6d2e7c00d7eefe6a7afc37dff25 DIFF: https://github.com/llvm/llvm-project/commit/647d314eb059b6d2e7c00d7eefe6a7afc37dff25.

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

This revision was automatically updated to reflect the committed changes. Closed by commit rG647d314eb059: [clangd] Add support for semantic token type "operator" (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136594/new/ htt

[clang] 8cdb1aa - [Clang] Convert PCH tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2022-12-12T16:20:49+01:00 New Revision: 8cdb1aa1ec2ba15f5ec8641f5ece23758bf15a06 URL: https://github.com/llvm/llvm-project/commit/8cdb1aa1ec2ba15f5ec8641f5ece23758bf15a06 DIFF: https://github.com/llvm/llvm-project/commit/8cdb1aa1ec2ba15f5ec8641f5ece23758bf15a06.diff

[clang-tools-extra] 35d9f87 - [clang-tidy] Fix a couple additional cases in misc-use-anonymous-namespace only

Author: Carlos Galvez Date: 2022-12-12T15:26:14Z New Revision: 35d9f873e3f21846de1b8f07271feedbbe8518ed URL: https://github.com/llvm/llvm-project/commit/35d9f873e3f21846de1b8f07271feedbbe8518ed DIFF: https://github.com/llvm/llvm-project/commit/35d9f873e3f21846de1b8f07271feedbbe8518ed.diff LOG:

[PATCH] D139113: [clang-tidy] Fix a couple additional cases in misc-use-anonymous-namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG35d9f873e3f2: [clang-tidy] Fix a couple additional cases in misc-use-anonymous-namespace only (authored by carlosgalvezp). Changed prior to commit: https://reviews.llvm.org/D139113?vs=481257&id=482119#t

[clang] 6271805 - [Clang] Update Profile tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2022-12-12T16:28:03+01:00 New Revision: 627180562911b93a523fea000511311ed0d381e4 URL: https://github.com/llvm/llvm-project/commit/627180562911b93a523fea000511311ed0d381e4 DIFF: https://github.com/llvm/llvm-project/commit/627180562911b93a523fea000511311ed0d381e4.diff

[clang] 1f8fecf - [OpenMP][OMPIRBuilder] Migrate code to emit target region functions from clang to OMPIRBuilder

Author: Jan Sjodin Date: 2022-12-12T10:28:58-05:00 New Revision: 1f8fecf26b35cef2713252fb020ff66cee248d99 URL: https://github.com/llvm/llvm-project/commit/1f8fecf26b35cef2713252fb020ff66cee248d99 DIFF: https://github.com/llvm/llvm-project/commit/1f8fecf26b35cef2713252fb020ff66cee248d99.diff LO

[PATCH] D139634: [OpenMP][OMPIRBuilder] Migrate code to emit target region functions from clang to OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8fecf26b35: [OpenMP][OMPIRBuilder] Migrate code to emit target region functions from clang… (authored by jsjodin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[clang] 620d2bf - [clang] Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

Author: Michael Platings Date: 2022-12-12T15:36:06Z New Revision: 620d2bfdadeb7f4936775422a0e965e7fcdcd204 URL: https://github.com/llvm/llvm-project/commit/620d2bfdadeb7f4936775422a0e965e7fcdcd204 DIFF: https://github.com/llvm/llvm-project/commit/620d2bfdadeb7f4936775422a0e965e7fcdcd204.diff L

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

This revision was automatically updated to reflect the committed changes. Closed by commit rG620d2bfdadeb: [clang] Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR… (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

protze.joachim added a comment. Why do we need __kmpc_omp_taskwait_51 ? Taskwait nowait only makes sense with dependencies. It should only result in additional nodes/edges in the task dependency graph without any code to execute. There is not taskwait (aka task barrier) in this case. The taskw

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added a comment. The build failed again, but it looks like the cause is unrelated to these changes. I restarted the build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 ___ cfe-commits

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

HazardyKnusperkeks added a comment. Please mark comments as done. Comment at: clang/lib/Format/Format.cpp:1270 LLVMStyle.AllowShortLoopsOnASingleLine = false; + LLVMStyle.AllowShortRequiresExpressionOnASingleLine = true; LLVMStyle.AlwaysBreakAfterReturnType = FormatStyle

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

HazardyKnusperkeks added a comment. See the comments on D139786 . And you can base your commits on each other, and then add a child rsp. parent revision here in phabricator, that will prevent merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

nikic added inline comments. Comment at: clang/test/OpenMP/taskwait_depend_nowait_codegen.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -verify -triple x86_64-apple-darwin10 -fopenmp -fopenmp-version=51 -x c++ -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -no-opaque-poin

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

HazardyKnusperkeks added a comment. I think you need to parse the first paren as whole and do not indent it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136100/new/ https://reviews.llvm.org/D136100 ___

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

doru1004 updated this revision to Diff 482133. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D139723 Files: clang/lib/Headers/CMakeLists.tx

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

doru1004 added a comment. @arsenm I have factored out the abs/labs/llabs functions in a separate __clang_hip_stdlib.h file which could be included by C sources. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D13

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

jdoerfert added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:685 + auto TgtImageOrErr = jit::compile(TgtImage, Triple, Arch, +/* OptLevel */ 3, PostProcessing); + if

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

HazardyKnusperkeks added a comment. I'm normally way more lenient than the most to add features, but here I have to ask do you want it so that you can get `friend` always as first, or do you really want to be able to put `friend` anywhere in the sequence? If only the first, I'd say we do that w

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 updated this revision to Diff 482137. qiongsiwu1 added a comment. Updating to revert back to `const char *` in the big `StringSwitch`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 Files: c

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 482140. massberg added a comment. Additionally check for ODR use and remove inlcude added by accident. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:77 + .Default(CPUName); +return TargetCPUName.str(); } jamieschmeiser wrote: > qiongsiwu1 wrote:

[clang] f32f293 - [CodeGen] Fix a warning

Author: Kazu Hirata Date: 2022-12-12T08:27:12-08:00 New Revision: f32f29385c90b7be05dc19a137d3b25d3c614a50 URL: https://github.com/llvm/llvm-project/commit/f32f29385c90b7be05dc19a137d3b25d3c614a50 DIFF: https://github.com/llvm/llvm-project/commit/f32f29385c90b7be05dc19a137d3b25d3c614a50.diff L

[PATCH] D139847: Also allow __is_unsigned to be used as an identifier

sberg created this revision. sberg added reviewers: doug.gregor, aaron.ballman. Herald added a project: All. sberg requested review of this revision. Herald added a project: clang. ...similar to 068730992cf08d7d7e82e7bb147d85f429fc3ddd "libstdc++ 4.4 uses __is_signed as an identifier [...]" Star

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:11 +#include // massberg #include "TreeTransform.h" shafik wrote: > Please remove. Ups, thanks! Comment at: clang/lib/Sem

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. We use -Xcompiler and -Xlinker which are passed in programs and they raise error now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 _

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

benlangmuir added a comment. libclang changes LGTM, thanks! I'll let the other reviewers who have domain expertise speak for the rest of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139115/new/ https://reviews.llvm.org/D139115 __

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks good. I'm accepting the change despite one remaining issue that was neither introduced nor addressed by this patch; the diagnostic caret will still be in the wrong locatio

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann added a comment. @cor3ntin, I suspect the answer is no, but do your changes perhaps address this assertion failure? https://godbolt.org/z/1bPcPcWzv int \u1{234}; Stack dump: clang++: /root/llvm-project/clang/lib/Lex/LiteralSupport.cpp:382: void clang::expandUCNs(llvm::SmallVec

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 482158. tianshilei1992 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/cmake/OpenMPTesting.cmake openmp/libomptarge

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added a comment. This LG, but not accepting as I believe libc++ is still broken if built with modules, right? I have run `check-cxx` locally and it seems to work, but I suspect that's not using modules by default. I have clicked through the links in phrabricator and the errors see

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added a comment. Since the errors only shows up in modular builds, I would look closely for bugs inside `ASTReader`/`ASTWriter`. Also, it seems that `ArrayFiller` is not taken in to account in `computeDependence` and maybe it should be. This assumption is wrong if `ArrayFiller` i

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 482168. tianshilei1992 added a comment. add env for opt level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/cmake/OpenMPTesting.cmake openm

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done and an inline comment as not done. tianshilei1992 added inline comments. Comment at: openmp/cmake/OpenMPTesting.cmake:6 function(find_standalone_test_dependencies) - include(FindPythonInterp) + find_package(Python3 COMPONENTS In

  1   2   3   >