[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan planned changes to this revision. owenpan added a comment. Will extend this option to support C#, Java, and JavaScript using the underscore character `_` as the separator. Comment at: clang/unittests/Format/FormatTest.cpp:25124 +TEST_F(FormatTest,

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel planned changes to this revision. rymiel added a comment. Going to try to make the indentation of the cases following the controlling expression not continuations, since that results in weird results such as: #define LIMIT_MAX(T) \ _Generic(

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68a888012b12: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 68a8880 - [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

Author: Freddy Ye Date: 2022-12-23T14:54:53+08:00 New Revision: 68a888012b12f9846131baae2533927617a58584 URL: https://github.com/llvm/llvm-project/commit/68a888012b12f9846131baae2533927617a58584 DIFF: https://github.com/llvm/llvm-project/commit/68a888012b12f9846131baae2533927617a58584.diff

[PATCH] D140462: [clangd] Add schema for `.clangd` config

nridge added a comment. In D140462#4012996 , @sammccall wrote: > This has been discussed before, unfortunately while I *thought* it was on a > bug, it was actually in a PR: https://github.com/clangd/vscode-clangd/pull/140 > > I don't think it's a good

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke marked 6 inline comments as done. Sockke added a comment. Mark comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

skan accepted this revision. skan added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:115 + +char test_mm_reduce_mul_epi8(__m128i __W){ +// CHECK-LABEL: @test_mm_reduce_mul_epi8( FreddyYe wrote: > skan wrote: > > skan wrote: > > >

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a comment. > My GCC patch names it -fdepfile-output= instead of --p1689-targeted-output, > gets --p1689-targeted-file-name from the regular command line (it looks like > a preprocessor command overall) and the --p1689-makeformat-output flag is > handled by the normal -MT and

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu updated this revision to Diff 485022. ChuanqiXu added a comment. Address comments: fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 Files: clang/include/clang/Tooling/CompilationDatabase.h

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:115 + +char test_mm_reduce_mul_epi8(__m128i __W){ +// CHECK-LABEL: @test_mm_reduce_mul_epi8( skan wrote: > skan wrote: > > char has different meaning on different

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 485018. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files:

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei updated this revision to Diff 485016. pengfei added a comment. Add fmul, fmin and fmax cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140467/new/ https://reviews.llvm.org/D140467 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ben.boeckel added a comment. In D137534#4014571 , @ChuanqiXu wrote: >> Why is it necessary to add new command-line flags for this? Can't the input >> and output be inherited from the specified Clang command line? Would such >> command line make sense?

[PATCH] D135171: FreeBSD: enable __float128 on x86

pkubaj requested changes to this revision. pkubaj added a comment. This revision now requires changes to proceed. Could you modify it appropriately to also enable ppc, ppc64 and ppc64le? I checked whether it works on FreeBSD 13.1-RELEASE and it builds and works fine. Repository: rG LLVM

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a comment. > Why is it necessary to add new command-line flags for this? Can't the input > and output be inherited from the specified Clang command line? Would such > command line make sense? CMake wants to query the dependency information for a single file from time to time

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. Currently in `Sema::getDestructorName` we call `SS.getScopeRep()->getPrefix()` but `SS.getScopeRep()` can return `nullptr` because

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

skan added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:115 + +char test_mm_reduce_mul_epi8(__m128i __W){ +// CHECK-LABEL: @test_mm_reduce_mul_epi8( skan wrote: > char has different meaning on different platforms. Should we use

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484998. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files:

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

shafik added a comment. Thank you for the fix, can you explain the failure case in more detail and why checking that `RD` is defined is the correct fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140587/new/ https://reviews.llvm.org/D140587

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#4013217 , @aykevl wrote: > I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't > think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is > inherently specific to that particular

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz marked an inline comment as done. shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:582 } else if (LO.C11) { -LangTag = llvm::dwarf::DW_LANG_C11; +if (CGO.DebugStrictDwarf && CGO.DwarfVersion < 5) + LangTag =

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz updated this revision to Diff 484994. shchenz added a comment. address @dblaikie comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140544/new/ https://reviews.llvm.org/D140544 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

skan added inline comments. Comment at: clang/lib/Headers/avx512vlbwintrin.h:2997 + +static __inline__ char __DEFAULT_FN_ATTRS128 +_mm_reduce_or_epi8(__m128i __W) { Should we update here too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. In D136554#4013463 , @rupprecht wrote: > Glad the test case made sense to you, it was convoluted to me :) > > Still seeing one more error, and it's not modules-related so I might be able > to get it reduced today. Generally,

[PATCH] D140330: [clang-format] Set requires expression params as not an expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ebed862d821: [clang-format] Set requires expression params as not an expression (authored by rymiel). Repository: rG LLVM Github Monorepo

[clang] 0ebed86 - [clang-format] Set requires expression params as not an expression

Author: Emilia Dreamer Date: 2022-12-23T02:22:48+02:00 New Revision: 0ebed862d82134e7a8e42d8dc7944afe765445ba URL: https://github.com/llvm/llvm-project/commit/0ebed862d82134e7a8e42d8dc7944afe765445ba DIFF:

[PATCH] D138441: [clang-format][docs] Fix invalid CSS syntax in versionbadge

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4caec64fec: [clang-format][docs] Fix invalid CSS syntax in versionbadge (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138441/new/

[clang] ba4caec - [clang-format][docs] Fix invalid CSS syntax in versionbadge

Author: Emilia Dreamer Date: 2022-12-23T02:15:48+02:00 New Revision: ba4caec64fec457b4ab20876a809b45162b048f4 URL: https://github.com/llvm/llvm-project/commit/ba4caec64fec457b4ab20876a809b45162b048f4 DIFF:

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel updated this revision to Diff 484985. rymiel added a comment. Adapt description of parseConstraintExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140339/new/ https://reviews.llvm.org/D140339 Files:

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm updated this revision to Diff 484980. arsenm added a comment. Rebase. Use _w32/_w64 suffixes since some other wave specific builtins seem to have gone with that convention CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 Files:

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014256 , @MaskRay wrote: > In D140224#4014243 , @rsundahl > wrote: > >>> I'll reject [-\Xparser for a while as well. This is a valid amendment to >>> D139717

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014246 , @davide wrote: > In D140224#4014245 , @MaskRay wrote: > >> In D140224#4014234 , @davide wrote: >> >>> In D140224#4014230

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014243 , @rsundahl wrote: >> I'll reject [-\Xparser for a while as well. This is a valid amendment to >> D139717 , so I don't think it needs more >> approval. > > We have projects

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014245 , @MaskRay wrote: > In D140224#4014234 , @davide wrote: > >> In D140224#4014230 , @MaskRay >> wrote: >> >>> In D140224#4014203

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014234 , @davide wrote: > In D140224#4014230 , @MaskRay wrote: > >> In D140224#4014203 , @davide wrote: >> >>> @MaskRay Roy hasn't

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

rsundahl added a comment. > I'll reject [-\Xparser for a while as well. This is a valid amendment to > D139717 , so I don't think it needs more > approval. We have projects that are failing because of -Xlinker and I'm not too excited about walking through

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014230 , @MaskRay wrote: > In D140224#4014203 , @davide wrote: > >> @MaskRay Roy hasn't replied. We found other spellings that break (e.g. >> `-Xcctests` or something). Revert

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014203 , @davide wrote: > @MaskRay Roy hasn't replied. We found other spellings that break (e.g. > `-Xcctests` or something). Revert this patch until we find an agreement. D139717

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012854 , @ilinpv wrote: > I don't think `std::equal` is underlying cause here. We have > featuresStrs_size() comparison before calling it: > > if (CurClones && NewClones && >

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide reopened this revision. davide added a comment. This revision is now accepted and ready to land. @MaskRay Roy hasn't replied. We found other spellings that break (e.g. `-Xcctests` or something). Revert this patch until we find an agreement. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This crash is a combination of recovery-expr + new SemaInit.cpp code introduced by by https://reviews.llvm.org/D129531.

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

MaskRay added a comment. In D140363#4014131 , @joaomoreira wrote: > FWIIW, agreed on removing this until we figure out how to make it work > properly. Thanks for the patch @MaskRay. Thanks for accepting the removal:) Repository: rG LLVM Github

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

joaomoreira added a comment. Given https://reviews.llvm.org/D140363, this patch is being abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140035/new/ https://reviews.llvm.org/D140035 ___

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

joaomoreira added a comment. FWIIW, agreed on removing this until we figure out how to make it work properly. Thanks for the patch @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140363/new/ https://reviews.llvm.org/D140363

[clang] 9b050e5 - [clang] Remove redundant initialization of std::optional (NFC)

Author: Kazu Hirata Date: 2022-12-22T13:46:26-08:00 New Revision: 9b050e5011e92be1b953cc1cc1406cfbcb43fb90 URL: https://github.com/llvm/llvm-project/commit/9b050e5011e92be1b953cc1cc1406cfbcb43fb90 DIFF: https://github.com/llvm/llvm-project/commit/9b050e5011e92be1b953cc1cc1406cfbcb43fb90.diff

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

Amir accepted this revision. Amir added a comment. This revision is now accepted and ready to land. LGTM for BOLT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108265/new/ https://reviews.llvm.org/D108265

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:25124 +TEST_F(FormatTest, IntegerLiteralSeparator) { + FormatStyle Style = getLLVMStyle();

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. Created D140585 to update `llvm/docs/CodingStandards.rst`. Changed the summary to mention https://discourse.llvm.org/t/top-level-clang-tidy-options-and-variablename-suggestion-on-codingstandards/58783 Repository: rG LLVM Github

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay updated this revision to Diff 484955. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a reviewer: bollu. Herald added subscribers: yota9, ayermolo, StephenFan. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer:

[PATCH] D137838: [Support] Move TargetParsers to new component

paulkirth added a comment. Sorry for the noise, I missed that that bot is setting a CMake flag that affects LLVM_EXPORTS. Please disregard my earlier message. I just need to update the CMake invocation to fix this, so I don't think there is anything required on your end. Repository: rG

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan added a comment. In D140315#4011440 , @yaxunl wrote: > files under > clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem > not used. removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan updated this revision to Diff 484945. scchan added a comment. Remove unused bitcode files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void created this revision. void added reviewers: aaron.ballman, rjmccall, rsmith, dblaikie. Herald added subscribers: arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

This revision was automatically updated to reflect the committed changes. Closed by commit rG46cd3127fe54: [Driver] Revert D139717 and add -Xparser/-Xcompiler instead (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D140224?vs=483565=484938#toc Repository: rG LLVM

[clang] 46cd312 - [Driver] Revert D139717 and add -Xparser/-Xcompiler instead

Author: Fangrui Song Date: 2022-12-22T12:51:20-08:00 New Revision: 46cd3127fe54ab51f813492017c5acdbeb1baf26 URL: https://github.com/llvm/llvm-project/commit/46cd3127fe54ab51f813492017c5acdbeb1baf26 DIFF: https://github.com/llvm/llvm-project/commit/46cd3127fe54ab51f813492017c5acdbeb1baf26.diff

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I'll reject [-\Xparser for a while as well. This is a valid amendment to D139717 , so I don't think it needs more approval. Repository: rG LLVM Github

[clang] 69243cd - Remove incorrectly implemented -mibt-seal

Author: Fangrui Song Date: 2022-12-22T12:32:59-08:00 New Revision: 69243cdb926b1057c54522df305ffc195b2863ec URL: https://github.com/llvm/llvm-project/commit/69243cdb926b1057c54522df305ffc195b2863ec DIFF: https://github.com/llvm/llvm-project/commit/69243cdb926b1057c54522df305ffc195b2863ec.diff

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

This revision was automatically updated to reflect the committed changes. Closed by commit rG69243cdb926b: Remove incorrectly implemented -mibt-seal (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140363/new/

[PATCH] D104931: [AArch64] Wire up ILP32 ABI support in Clang

nickdesaulniers added a comment. Herald added a project: All. The linux kernel uses a build time invocation of the compiler for feature detection of the `-mabi=lp64` command line flag, which clang-16 currently doesn't support. Looking at https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html,

[PATCH] D137838: [Support] Move TargetParsers to new component

paulkirth added a comment. Hi, we're seeing some build failures after this change. Seems like the TargetParser isn't getting added to LLVMExports correctly. Can you take a look and address these? Failing bot

[clang] c348abc - Revert D138179 "MIPS: fix build from IR files, nan2008 and FpAbi"

Author: Fangrui Song Date: 2022-12-22T11:48:55-08:00 New Revision: c348abce68ac422bf3842de3943ca7463e3a814f URL: https://github.com/llvm/llvm-project/commit/c348abce68ac422bf3842de3943ca7463e3a814f DIFF: https://github.com/llvm/llvm-project/commit/c348abce68ac422bf3842de3943ca7463e3a814f.diff

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ben.boeckel added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:9 +// +// Check the seperated dependency format. +// RUN: clang-scan-deps -format=p1689 --p1689-targeted-file-name=%t/M.cppm --p1689-targeted-output=%t/M.o \ jansvoboda11 wrote:

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

njames93 added a comment. In D138655#4012557 , @Sockke wrote: > Improved the test file. Just a general workflow comment, can you please mark comments as done when they are addressed, or, if you feel the comment in unjustified, explain why. CHANGES

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. I agree, it's probably best to temporarily revert this until Joao has time to address the issues you mentioned. The Linux kernel doesn't use `-mibt-seal` yet, so dropping the

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

jansvoboda11 added a comment. Why is it necessary to add new command-line flags for this? Can't the input and output be inherited from the specified Clang command line? Would such command line make sense? Comment at: clang/test/ClangScanDeps/P1689.cppm:9 +// +// Check the

[PATCH] D140565: [Clang][CMake] Set up distribution target for Clang-BOLT

Amir created this revision. Amir added a reviewer: phosek. Herald added a subscriber: wenlei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provide a way to install usable BOLT-optimized Clang (clang +

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 484882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/AST/Type.h clang/include/clang/Basic/FPOptions.def

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Glad the test case made sense to you, it was convoluted to me :) Still seeing one more error, and it's not modules-related so I might be able to get it reduced today. Generally, it looks like this: struct Inner { Foo& foo; const std::unique_ptr<...> x =

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske added a comment. This crash is produced if the test is run without the fix: [ RUN ] ParameterizedTests/ASTImporterOptionSpecificTestBase.ImportInjectedClassNameType/0 ASTTests: llvm-project/clang/lib/AST/ASTContext.cpp:4678: clang::QualType

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added inline comments. Comment at: clang/test/CodeGen/builtins-x86-reduce.c:8 +} + +// CHECK: fadd pengfei wrote: > arsenm wrote: > > Should test the builtins from both sets > Do you mean this? Almost. You added the guard to 4 switch cases, so I would

[clang] 63aa57d - Small fixes to creduce-clang-crash.py script.

Author: Amy Huang Date: 2022-12-22T16:33:28Z New Revision: 63aa57dc57e1d47479025f65a89a5a9da974800f URL: https://github.com/llvm/llvm-project/commit/63aa57dc57e1d47479025f65a89a5a9da974800f DIFF: https://github.com/llvm/llvm-project/commit/63aa57dc57e1d47479025f65a89a5a9da974800f.diff LOG:

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

shafik added a comment. I am not sure if this is moving in the right direction or not, I will wait for @cor3ntin to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:582 } else if (LO.C11) { -LangTag = llvm::dwarf::DW_LANG_C11; +if (CGO.DebugStrictDwarf && CGO.DwarfVersion < 5) + LangTag = llvm::dwarf::DW_LANG_C; Generally, I think,

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:2395 + /// >0: Insert separators between digits, starting from the rightmost digit. + struct IntegerLiteralSeparatorStyle { +/// \code

[PATCH] D140547: Perform access checking to private members in simple requirement.

shafik added a comment. Thank you for the fix, can you elaborate on the motivation for this change, it looks like setting `setNamingClass` allows for improved diagnostics but I would like it explained better in the PR description. Comment at:

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 484841. owenpan added a comment. Fixed another bug and added some unit tests. Also updated ReleaseNotes.rst and addressed some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 Files:

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

aykevl added a comment. I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is inherently specific to that particular chip anyway so compatibility is not an issue. In fact, having two flags may even

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139881/new/ https://reviews.llvm.org/D139881 ___ cfe-commits mailing list

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei added inline comments. Comment at: clang/test/CodeGen/builtins-x86-reduce.c:8 +} + +// CHECK: fadd arsenm wrote: > Should test the builtins from both sets Do you mean this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei updated this revision to Diff 484838. pengfei marked 2 inline comments as done. pengfei added a comment. Address review comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140467/new/ https://reviews.llvm.org/D140467 Files:

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

ymandel updated this revision to Diff 484830. ymandel added a comment. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Reviving this patch, addressing some of the earlier concerns. However, I may have a better solution which makes this patch irrelevant. So, still WIP.

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added a comment. In D140467#4013107 , @pengfei wrote: > Add test case to check FastMathFlagGuard works. > > Not to mention above cases. So it doesn't sound feasible to me. Testing is always feasible. You could even just generate all the

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei updated this revision to Diff 484826. pengfei added a comment. Add test case to check FastMathFlagGuard works. > Tests don't exist for users, they exist for compiler developers... > I agree with @arsenm. At least for clang irgen, we should have good test > coverage. You are right.

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime created this revision. lime added reviewers: cor3ntin, shafik, erichkeane, aaron.ballman, clang-language-wg. lime added a project: clang. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. During template instantiation, the

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito added a comment. A 2022-12-22 10:51, Nuno Lopes via Phabricator escreveu: > nlopes accepted this revision. > nlopes added a comment. > > LGTM, thank you! > > Repository: > > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > > https://reviews.llvm.org/D140538/new/ > >

[PATCH] D140551: [include-cleaner] Don't count references to operators as uses

sammccall added a comment. Yeah, I think this makes sense. I think this sort of thing should ideally be captured in the include-cleaner design doc if there was one. (Doesn't make sense to create one just for this issue, but it seems like a doc that should exist). Comment at:

[PATCH] D140430: [clang][dataflow] Fix bug in handling of `return` statements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38404df9d879: [clang][dataflow] Fix bug in handling of `return` statements. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 38404df - [clang][dataflow] Fix bug in handling of `return` statements.

Author: Yitzhak Mandelbaum Date: 2022-12-22T14:42:17Z New Revision: 38404df9d879483784a7024b2b4a366388d6d476 URL: https://github.com/llvm/llvm-project/commit/38404df9d879483784a7024b2b4a366388d6d476 DIFF: https://github.com/llvm/llvm-project/commit/38404df9d879483784a7024b2b4a366388d6d476.diff

[PATCH] D140501: [clang][dataflow] Account for global variables in constructor initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3700bdb7f00: [clang][dataflow] Account for global variables in constructor initializers. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f3700bd - [clang][dataflow] Account for global variables in constructor initializers.

Author: Yitzhak Mandelbaum Date: 2022-12-22T14:20:50Z New Revision: f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59 URL: https://github.com/llvm/llvm-project/commit/f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59 DIFF: https://github.com/llvm/llvm-project/commit/f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59.diff

[PATCH] D140551: [include-cleaner] Don't count references to operators as uses

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Fixes https://github.com/llvm/llvm-project/issues/59655 Repository: rG LLVM

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D140506: [clang][dataflow] Simplify handling of nullopt-optionals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e8d4a6df959: [clang][dataflow] Simplify handling of nullopt-optionals. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0e8d4a6 - [clang][dataflow] Simplify handling of nullopt-optionals.

Author: Yitzhak Mandelbaum Date: 2022-12-22T14:19:49Z New Revision: 0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb URL: https://github.com/llvm/llvm-project/commit/0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb DIFF: https://github.com/llvm/llvm-project/commit/0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb.diff

[PATCH] D140462: [clangd] Add schema for `.clangd` config

sammccall added a comment. In D140462#4012451 , @nridge wrote: > Thanks, this is pretty neat! > > cc @sammccall as a heads up, just to make sure you're cool with having this > in-tree This has been discussed before, unfortunately while I *thought* it

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2395 + /// >0: Insert separators between digits, starting from the rightmost digit. + struct IntegerLiteralSeparatorStyle { +/// \code Also add Octal?

[clang] 9e03115 - clang/HIP: Fix missing test for __frsqrt_rn

Author: Matt Arsenault Date: 2022-12-22T08:43:15-05:00 New Revision: 9e0311561c8ed4df2d67a5a1fba16a148683c3c9 URL: https://github.com/llvm/llvm-project/commit/9e0311561c8ed4df2d67a5a1fba16a148683c3c9 DIFF:

  1   2   >