[PATCH] D140462: [clangd] Add schema for `.clangd` config

nridge added a comment. In D140462#4017240 , @nridge wrote: > Is there a command-line tool that can perform JSON schema validation (well, more specifically that can validate YAML files against a JSON schema) Repository: rG LLVM Github Monorepo

[PATCH] D140462: [clangd] Add schema for `.clangd` config

nridge added a comment. In D140462#4017237 , @hyperupcall wrote: > If you would like me to add tests to verify the schema (for now or later?), > is there a utility within LLVM to help do so? I saw TableGen was mentioned, > but it sounds like the

[PATCH] D140462: [clangd] Add schema for `.clangd` config

hyperupcall added a comment. Thank you for the suggestions - I applied all of the fixes! As someone who helps maintain a lot of the schemas on schemastore, it's nice when schemas are in-tree with their respective project, but I totally understand

[PATCH] D140462: [clangd] Add schema for `.clangd` config

hyperupcall updated this revision to Diff 485352. hyperupcall added a comment. Apply `clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140462/new/ https://reviews.llvm.org/D140462 Files: clang-tools-extra/clangd/schema/config.json

[PATCH] D140462: [clangd] Add schema for `.clangd` config

hyperupcall updated this revision to Diff 485351. hyperupcall added a comment. Improve schema correctness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140462/new/ https://reviews.llvm.org/D140462 Files:

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

lime added a comment. There should be a more general solution. This patch does not solve the issue here . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140614/new/ https://reviews.llvm.org/D140614 ___

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling updated this revision to Diff 485349. tangyouling added a comment. rebase code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 Files: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

This revision was automatically updated to reflect the committed changes. Closed by commit rG1deb6bce8931: [NFC][Clang][RISCV] Rename data member DefaultPolicy to PolicyAttrs (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1deb6bc - [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

Author: eopXD Date: 2022-12-26T22:31:05-08:00 New Revision: 1deb6bce8931543bc3649ba5b0e32ae7e044d243 URL: https://github.com/llvm/llvm-project/commit/1deb6bce8931543bc3649ba5b0e32ae7e044d243 DIFF: https://github.com/llvm/llvm-project/commit/1deb6bce8931543bc3649ba5b0e32ae7e044d243.diff LOG:

[PATCH] D139686: [lsan] Add lsan support for loongarch64

XiaodongLoong added a comment. Please rebase code for test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 ___ cfe-commits mailing list

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter added a comment. After this patch the semantics of getExtValue changed and thus broke clang. @pcc Would you mind take a look if the modification works for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter updated this revision to Diff 485328. Peter added a comment. change base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/ADT/APSInt.h

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter updated this revision to Diff 485327. Peter added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059

[PATCH] D140678: [RISCV][WIP] Use SmallVector::append to replace some for loops in intrinsic creation. NFC

craig.topper created this revision. craig.topper added a reviewer: eopXD. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:862 + Value *VLOperand = Ops[PtrOperandIdx + 1]; + Operands.append(NF, PassThruOperand); + Operands.push_back(PtrOperand); This doesn't look right to me.

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 485312. eopXD added a comment. Recover mis-deleted lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 485311. eopXD added a comment. Change: Recover mis-deleted lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 485310. eopXD added a comment. Rebae to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 485307. sepavloff added a comment. Update patch - Rebase, - Add test that checks inlining. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 Files:

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:847 + + // Intrinsic is in the form of below, + // Masked: (Vector0, ..., Vector{NF - 1}, Ptr, Mask, VL, Policy) After remove the builtins comment I don't have idea

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I still have this mixed up with the

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

lime updated this revision to Diff 485276. lime retitled this revision from "[C++20] Check the dependency of declaration contexts before pumping diagnostics" to "[C++20] Mark lambdas in lambda specifiers as dependent if necessary". lime edited the summary of this revision. CHANGES SINCE LAST

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny closed this revision. mgorny added a comment. I've pushed a fix in dab67c66932b9149842f7c8431e951f952125fc0 , based on @jhuber6's fix from the other diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] dab67c6 - [clang] [OpenMP] Test amdgcn_openmp_device_math_c.c test on 32-bit platforms

Author: Michał Górny Date: 2022-12-26T10:38:40+01:00 New Revision: dab67c66932b9149842f7c8431e951f952125fc0 URL: https://github.com/llvm/llvm-project/commit/dab67c66932b9149842f7c8431e951f952125fc0 DIFF: https://github.com/llvm/llvm-project/commit/dab67c66932b9149842f7c8431e951f952125fc0.diff

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

mgorny closed this revision. mgorny added a comment. Thank you. I'm going to try if the same solution helps with D139723 too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140155/new/

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

nridge added a comment. Linking to potentially relevant issue on file: https://github.com/clangd/clangd/issues/1254 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140619/new/ https://reviews.llvm.org/D140619

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

sameerds added a comment. And note that the change description is written in a first-person train of thought. Please do rewrite it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 ___ cfe-commits

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

sameerds accepted this revision. sameerds added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:353 + if (HaveWave32 && HaveWave64) { +Diags.Report(diag::err_invalid_feature_combination) +<<

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 485271. tbaeder added a comment. Add missing inline descriptor handling to local variables created in the EvalEmitter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: