[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added inline comments. Comment at: llvm/test/CodeGen/Mips/abiflags-2008-fp64.ll:1 +; RUN: llc %s -o - | FileCheck %s + Add `;; ` file-level comment what this test does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 83cec14 - [clang] Change CodeGenOptions::RelaxELFRelocations/assembler defaults to match MC default

Author: Fangrui Song Date: 2022-12-31T22:24:37-08:00 New Revision: 83cec143c76f4c76fe8ae28d6d836e8f7bd67891 URL: https://github.com/llvm/llvm-project/commit/83cec143c76f4c76fe8ae28d6d836e8f7bd67891 DIFF: https://github.com/llvm/llvm-project/commit/83cec143c76f4c76fe8ae28d6d836e8f7bd67891.diff

[PATCH] D140814: [clangd] show underlying type in type hint for `decltype(expr)`

v1nh1shungry created this revision. v1nh1shungry added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ex

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. @nathanchance can you have a try this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 485793. wzssyqa retitled this revision from "MIPS: emit .module and .nan directives only for first function" to "MIPS: fix build from IR files, nan2008 and FpAbi". wzssyqa edited the summary of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89aad1e6a397: Reland [clang-format] Add an option to format integer literal separators (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 89aad1e - Reland [clang-format] Add an option to format integer literal separators

Author: Owen Pan Date: 2022-12-31T17:57:33-08:00 New Revision: 89aad1e6a397447f9574bb088f4de1d9044b5812 URL: https://github.com/llvm/llvm-project/commit/89aad1e6a397447f9574bb088f4de1d9044b5812 DIFF: https://github.com/llvm/llvm-project/commit/89aad1e6a397447f9574bb088f4de1d9044b5812.diff LOG:

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new (Allocator.Al

[PATCH] D140767: [clang-format] Require space before noexcept qualifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. But please wait for at least one of the others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140767/new/ https://review

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485783. ccotter added a comment. - Does not offer fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/Avoid

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

ccotter updated this revision to Diff 485782. ccotter added a comment. - run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidRefe

[PATCH] D140808: [clang][Interp] Handle record initialization via CastExpr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In particular, via a `CXXFunctionalCastExpr`. Rep

[clang] 7a8cb6c - [clang][NFC] Fix warning due to initializing a pointer with `false`

Author: Markus Böck Date: 2022-12-31T18:07:03+01:00 New Revision: 7a8cb6cd4e3ff8aaadebff2b9d3ee9e2a326d444 URL: https://github.com/llvm/llvm-project/commit/7a8cb6cd4e3ff8aaadebff2b9d3ee9e2a326d444 DIFF: https://github.com/llvm/llvm-project/commit/7a8cb6cd4e3ff8aaadebff2b9d3ee9e2a326d444.diff L

[PATCH] D140807: [clang][Interp] Skip calling simple destructors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Calling them isn't needed if I understand correctly

[PATCH] D140805: [clang][Interp] Add ArrayElemPtr{,Pop} opcode

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We usually access array elements in the same patt

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely added a comment. In D91000#3862210 , @whisperity wrote: > In D91000#3861942 , @aaron.ballman > wrote: > >> My concern with that approach was that we pay the full expense of doing the >> matches only ge

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 485774. futogergely marked 5 inline comments as done. futogergely removed a reviewer: ktomi996. futogergely added a comment. Addressing review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Fi

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

tbaeder updated this revision to Diff 485769. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140668/new/ https://reviews.llvm.org/D140668 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp clang/test/AST/Interp

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders added a comment. Thanks both of you for reviewing! I added documentation to the website here: https://github.com/llvm/clangd-www/pull/77 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137894/new/ https://reviews.llvm.org/D137894 __

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. I think it would be better to have a meeting to discuss this further instead of posting in this review. I propose to do it after everybody's back from their holidays. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille created this revision. serge-sans-paille added a reviewer: nikic. Herald added subscribers: pmatos, asb, jhenderson, ormris, mstorsjo, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov. Herald

[PATCH] D140775: [clangd] Hover: show CalleeArgInfo for literals

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:779 -HoverInfo getStringLiteralContents(const StringLiteral *SL, - const PrintingPolicy &PP) { - HoverInfo HI; - +void addStringLiteralContents(const StringLitera

[PATCH] D140775: [clangd] Hover: show CalleeArgInfo for literals

tom-anders updated this revision to Diff 485761. tom-anders marked 4 inline comments as done. tom-anders added a comment. Refactor getHoverContents to add CalleeArgInfo for all kinds of expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140775

[PATCH] D140775: [clangd] Hover: show CalleeArgInfo for literals

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:779 -HoverInfo getStringLiteralContents(const StringLiteral *SL, - const PrintingPolicy &PP) { - HoverInfo HI; - +void addStringLiteralContents(const StringLiteral *S

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

clementval requested changes to this revision. clementval added a comment. This revision now requires changes to proceed. You need to update the driver-help tests. Comment at: flang/include/flang/Tools/CLOptions.inc:194 #if !defined(FLANG_EXCLUDE_CODEGEN) -inline void createDe

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM, and it looks like Sam's comments have been substantially addressed as well, so I'm going to go ahead and approve this, hope that's cool. Repository: rG LLVM Github Monorepo CHANGES S