[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

2023-01-01 Thread Vincent Hong via Phabricator via cfe-commits
v1nh1shungry created this revision. v1nh1shungry added reviewers: aaron.ballman, shafik. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Relevant issue: https://github.com/llvm/llvm-project/issues/5

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

2023-01-01 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. This does not show any issues with any of the MIPS configurations that I build in the Linux kernel, thanks for fixing the problems I reported! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

2023-01-01 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Account for an r

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

2023-01-01 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron added a comment. In D118743#3965423 , @Lounarok wrote: > I tried this patch and it's really helpful! You're welcome! > According to this , "A > `constexpr` specifier used in a function or `s

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

2023-01-01 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 485827. ccotter added a comment. - oops - bad arc diff / bad change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguid

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

2023-01-01 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 485824. ccotter added a comment. - Cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140793/new/ https://reviews.llvm.org/D140793 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCor

[clang] ed4afd1 - [clang-format][docs] Fix indentation for the Sphinx build

2023-01-01 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-01T15:13:36-08:00 New Revision: ed4afd1bba8347e1d7ea943c242fccabf606489c URL: https://github.com/llvm/llvm-project/commit/ed4afd1bba8347e1d7ea943c242fccabf606489c DIFF: https://github.com/llvm/llvm-project/commit/ed4afd1bba8347e1d7ea943c242fccabf606489c.diff LOG:

[clang] b027cdc - [clang-format][NFC] Clean up IntegerLiteralSeparatorFixer::process

2023-01-01 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-01-01T14:49:12-08:00 New Revision: b027cdc5b99f56fdfe6c6dbb05188675b94a1aa5 URL: https://github.com/llvm/llvm-project/commit/b027cdc5b99f56fdfe6c6dbb05188675b94a1aa5 DIFF: https://github.com/llvm/llvm-project/commit/b027cdc5b99f56fdfe6c6dbb05188675b94a1aa5.diff LOG:

[PATCH] D140800: Precompute OptTable prefixes union table through tablegen

2023-01-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. I'd only use it in clang tbh. Clang uses many orders of magnitudes more opts than all other tools, and even there it's not a _huge_ win. (2% on empty file is very nice! But most of the time, people don't compile empty files, and I'm guessing on non-empty files this is a

[PATCH] D140800: Precompute OptTable prefixes union table through tablegen

2023-01-01 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D140800#4021228 , @thakis wrote: > Could we make this an optional opt-in maybe? I imagine for the majority of > the tools, this has no measurable effect, but it currently makes the Opt > library harder to use for ev

[PATCH] D140800: Precompute OptTable prefixes union table through tablegen

2023-01-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Could we make this an optional opt-in maybe? I imagine for the majority of the tools, this has no measurable effect, but it currently makes the Opt library harder to use for every client. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

2023-01-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3168-3171 + Separator format of integer literals of different bases. + <0: Remove separators. + 0: Leave the literal as is. + >0: Insert separators between digits, starting from the right

[PATCH] D133574: [C2x] reject type definitions in offsetof

2023-01-01 Thread Yingchi Long via Phabricator via cfe-commits
inclyc added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

2023-01-01 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCoroutineParametersCheck.cpp:31 +const MatchFinder::MatchResult &Result) { + const auto *Param = Result.Nodes.getNodeAs("param"); + Check for nullp

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

2023-01-01 Thread Tom Praschan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd408c34d1f58: [clangd] Add extension for adding context (enclosing function or class) in… (authored by tom-anders). Repository: rG LLVM Github Mon

[clang-tools-extra] d408c34 - [clangd] Add extension for adding context (enclosing function or class) in references results

2023-01-01 Thread Tom Praschan via cfe-commits
Author: Tom Praschan Date: 2023-01-01T15:25:18+01:00 New Revision: d408c34d1f588e518b0ee15c00b55db131944cfb URL: https://github.com/llvm/llvm-project/commit/d408c34d1f588e518b0ee15c00b55db131944cfb DIFF: https://github.com/llvm/llvm-project/commit/d408c34d1f588e518b0ee15c00b55db131944cfb.diff

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

2023-01-01 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added reviewers: MaskRay, mgorny, krytarowski. brad added a project: clang. Herald added subscribers: StephenFan, ormris, arichardson, emaste. Herald added a project: All. brad requested review of this revision. This matches OpenBSD and FreeBSD. Repository: rG